From 0e56eddfba7c827d944987d5c241b128278edbbb Mon Sep 17 00:00:00 2001 From: Artur Neumann Date: Tue, 20 Oct 2020 12:04:39 +0545 Subject: [PATCH 1/2] tests to demonstrate issue #720 --- .../acceptance/expected-failures-on-OCIS-storage.txt | 8 ++++++-- .../acceptance/expected-failures-on-OWNCLOUD-storage.txt | 8 ++++++-- .../apiShareManagementBasic-deleteShare.feature | 4 +++- 3 files changed, 15 insertions(+), 5 deletions(-) diff --git a/ocis/tests/acceptance/expected-failures-on-OCIS-storage.txt b/ocis/tests/acceptance/expected-failures-on-OCIS-storage.txt index f170c034f..ce1885be4 100644 --- a/ocis/tests/acceptance/expected-failures-on-OCIS-storage.txt +++ b/ocis/tests/acceptance/expected-failures-on-OCIS-storage.txt @@ -396,8 +396,6 @@ apiShareManagementBasicToShares/createShareToSharesFolder.feature:498 apiShareManagementBasicToShares/createShareToSharesFolder.feature:501 apiShareManagementBasicToShares/deleteShareFromShares.feature:28 apiShareManagementBasicToShares/deleteShareFromShares.feature:29 -apiShareManagementBasicToShares/deleteShareFromShares.feature:43 -apiShareManagementBasicToShares/deleteShareFromShares.feature:44 apiShareManagementBasicToShares/deleteShareFromShares.feature:89 apiShareManagementBasicToShares/deleteShareFromShares.feature:163 apiShareManagementBasicToShares/deleteShareFromShares.feature:164 @@ -416,6 +414,12 @@ apiShareManagementBasicToShares/excludeGroupFromReceivingSharesToSharesFolder.fe apiShareManagementBasicToShares/excludeGroupFromReceivingSharesToSharesFolder.feature:153 apiShareManagementBasicToShares/excludeGroupFromReceivingSharesToSharesFolder.feature:154 # +# https://github.com/owncloud/ocis/issues/720 shares are mounted into /Shares folder even after the sharer deletes the collaborator +# https://github.com/owncloud/ocis/issues/721 deleting share response does not contain `data` field +# +apiShareManagementBasicToShares/deleteShareFromShares.feature:43 +apiShareManagementBasicToShares/deleteShareFromShares.feature:44 +# # https://github.com/owncloud/product/issues/203 file_target in share response # apiShareManagementBasicToShares/createShareToSharesFolder.feature:367 diff --git a/ocis/tests/acceptance/expected-failures-on-OWNCLOUD-storage.txt b/ocis/tests/acceptance/expected-failures-on-OWNCLOUD-storage.txt index ba6cf3a92..c63f24f6e 100644 --- a/ocis/tests/acceptance/expected-failures-on-OWNCLOUD-storage.txt +++ b/ocis/tests/acceptance/expected-failures-on-OWNCLOUD-storage.txt @@ -400,8 +400,6 @@ apiShareManagementBasicToShares/createShareToSharesFolder.feature:498 apiShareManagementBasicToShares/createShareToSharesFolder.feature:501 apiShareManagementBasicToShares/deleteShareFromShares.feature:28 apiShareManagementBasicToShares/deleteShareFromShares.feature:29 -apiShareManagementBasicToShares/deleteShareFromShares.feature:43 -apiShareManagementBasicToShares/deleteShareFromShares.feature:44 apiShareManagementBasicToShares/deleteShareFromShares.feature:89 apiShareManagementBasicToShares/deleteShareFromShares.feature:163 apiShareManagementBasicToShares/deleteShareFromShares.feature:164 @@ -420,6 +418,12 @@ apiShareManagementBasicToShares/excludeGroupFromReceivingSharesToSharesFolder.fe apiShareManagementBasicToShares/excludeGroupFromReceivingSharesToSharesFolder.feature:153 apiShareManagementBasicToShares/excludeGroupFromReceivingSharesToSharesFolder.feature:154 # +# https://github.com/owncloud/ocis/issues/720 shares are mounted into /Shares folder even after the sharer deletes the collaborator +# https://github.com/owncloud/ocis/issues/721 deleting share response does not contain `data` field +# +apiShareManagementBasicToShares/deleteShareFromShares.feature:43 +apiShareManagementBasicToShares/deleteShareFromShares.feature:44 +# # https://github.com/owncloud/product/issues/207 Response is empty when accepting a share # apiShareManagementBasicToShares/createShareToSharesFolder.feature:342 diff --git a/ocis/tests/acceptance/features/apiOcisSpecific/apiShareManagementBasic-deleteShare.feature b/ocis/tests/acceptance/features/apiOcisSpecific/apiShareManagementBasic-deleteShare.feature index ae52760ff..19bd4f23c 100644 --- a/ocis/tests/acceptance/features/apiOcisSpecific/apiShareManagementBasic-deleteShare.feature +++ b/ocis/tests/acceptance/features/apiOcisSpecific/apiShareManagementBasic-deleteShare.feature @@ -1,7 +1,7 @@ @api @files_sharing-app-required @issue-ocis-reva-243 Feature: sharing - @issue-ocis-reva-356 + @issue-ocis-720 @issue-ocis-721 # after fixing all issues delete this Scenario and use the one from oC10 core Scenario Outline: delete a share Given user "Alice" has been created with default attributes and without skeleton files @@ -9,9 +9,11 @@ Feature: sharing And user "Brian" has been created with default attributes and without skeleton files And using OCS API version "" And user "Alice" has shared file "textfile0.txt" with user "Brian" + And user "Brian" has accepted share "/textfile0.txt" offered by user "Alice" When user "Alice" deletes the last share using the sharing API Then the OCS status code should be "" And the HTTP status code should be "200" + And as "Brian" file "/Shares/textfile0.txt" should exist Examples: | ocs_api_version | ocs_status_code | | 1 | 100 | From c31dd9e30240a54b0b9a7d5d73956c4a1e21d72f Mon Sep 17 00:00:00 2001 From: Artur Neumann Date: Thu, 22 Oct 2020 11:33:56 +0545 Subject: [PATCH 2/2] adjust issue to the current behaiviour --- .../apiShareManagementBasic-deleteShare.feature | 3 ++- 1 file changed, 2 insertions(+), 1 deletion(-) diff --git a/ocis/tests/acceptance/features/apiOcisSpecific/apiShareManagementBasic-deleteShare.feature b/ocis/tests/acceptance/features/apiOcisSpecific/apiShareManagementBasic-deleteShare.feature index 19bd4f23c..37d080cae 100644 --- a/ocis/tests/acceptance/features/apiOcisSpecific/apiShareManagementBasic-deleteShare.feature +++ b/ocis/tests/acceptance/features/apiOcisSpecific/apiShareManagementBasic-deleteShare.feature @@ -13,7 +13,8 @@ Feature: sharing When user "Alice" deletes the last share using the sharing API Then the OCS status code should be "" And the HTTP status code should be "200" - And as "Brian" file "/Shares/textfile0.txt" should exist + When user "Brian" requests "/remote.php/dav/files" with "PROPFIND" using basic auth + Then the HTTP status code should be "500" Examples: | ocs_api_version | ocs_status_code | | 1 | 100 |