From b8ac8f1ddd26c2863d1b7730f4672a40311317bc Mon Sep 17 00:00:00 2001 From: Alex Unger <6905948+refs@users.noreply.github.com> Date: Wed, 24 Feb 2021 13:16:27 +0000 Subject: [PATCH] Automated changelog update [skip ci] --- CHANGELOG.md | 23 +++++++++++++++++++++++ ocis/go.sum | 1 + 2 files changed, 24 insertions(+) diff --git a/CHANGELOG.md b/CHANGELOG.md index df9cbdc5e4..cddee3e4ac 100644 --- a/CHANGELOG.md +++ b/CHANGELOG.md @@ -6,6 +6,7 @@ The following sections list the changes for unreleased. ## Summary +* Bugfix - Fix accounts initialization: [#1696](https://github.com/owncloud/ocis/pull/1696) * Bugfix - Fix the ttl of the authentication middleware cache: [#1699](https://github.com/owncloud/ocis/pull/1699) * Change - Update ownCloud Web to v2.0.1: [#1683](https://github.com/owncloud/ocis/pull/1683) * Enhancement - Update go-micro to v3.5.1-0.20210217182006-0f0ace1a44a9: [#1670](https://github.com/owncloud/ocis/pull/1670) @@ -14,6 +15,28 @@ The following sections list the changes for unreleased. ## Details +* Bugfix - Fix accounts initialization: [#1696](https://github.com/owncloud/ocis/pull/1696) + + Originally the accounts service relies on both the `settings` and `storage-metadata` to be up + and running at the moment it starts. This is an antipattern as it will cause the entire service to + panic if the dependants are not present. + + We inverted this dependency and moved the default initialization data (i.e: creating roles, + permissions, settings bundles) and instead of notifying the settings service that the + account has to provide with such options, the settings is instead initialized with the options + the accounts rely on. Essentially saving bandwith as there is no longer a gRPC call to the + settings service. + + For the `storage-metadata` a retry mechanism was added that retries by default 20 times to + fetch the `com.owncloud.storage.metadata` from the service registry every `500` + miliseconds. If this retry expires the accounts panics, as its dependency on the + `storage-metadata` service cannot be resolved. + + We also introduced a client wrapper that acts as middleware between a client and a server. For + more information on how it works further read [here](https://github.com/sony/gobreaker) + + https://github.com/owncloud/ocis/pull/1696 + * Bugfix - Fix the ttl of the authentication middleware cache: [#1699](https://github.com/owncloud/ocis/pull/1699) The authentication cache ttl was multiplied with `time.Second` multiple times. This diff --git a/ocis/go.sum b/ocis/go.sum index 6be9733dbe..af559420c4 100644 --- a/ocis/go.sum +++ b/ocis/go.sum @@ -1506,6 +1506,7 @@ github.com/spf13/cobra v0.0.6/go.mod h1:/6GTrnGXV9HjY+aR4k0oJ5tcvakLuG6EuKReYlHN github.com/spf13/cobra v0.0.7/go.mod h1:/6GTrnGXV9HjY+aR4k0oJ5tcvakLuG6EuKReYlHNrgE= github.com/spf13/cobra v1.0.0 h1:6m/oheQuQ13N9ks4hubMG6BnvwOeaJrqSPLahSnczz8= github.com/spf13/cobra v1.0.0/go.mod h1:/6GTrnGXV9HjY+aR4k0oJ5tcvakLuG6EuKReYlHNrgE= +github.com/spf13/cobra v1.1.3/go.mod h1:pGADOWyqRD/YMrPZigI/zbliZ2wVD/23d+is3pSWzOo= github.com/spf13/jwalterweatherman v1.0.0/go.mod h1:cQK4TGJAtQXfYWX+Ddv3mKDzgVb68N+wFjFa4jdeBTo= github.com/spf13/jwalterweatherman v1.1.0 h1:ue6voC5bR5F8YxI5S67j9i582FU4Qvo2bmqnqMYADFk= github.com/spf13/jwalterweatherman v1.1.0/go.mod h1:aNWZUN0dPAAO/Ljvb5BEdw96iTZ0EXowPYD95IqWIGo=