From cf348c0f6e7d2ec740a7b0baf7338dd55bf80221 Mon Sep 17 00:00:00 2001 From: nabim777 Date: Fri, 13 Dec 2024 15:59:17 +0545 Subject: [PATCH] review address Signed-off-by: nabim777 --- tests/acceptance/bootstrap/SpacesTUSContext.php | 4 ++-- tests/acceptance/bootstrap/TUSContext.php | 6 +++--- .../features/apiSpacesShares/shareUploadTUS.feature | 6 +++--- 3 files changed, 8 insertions(+), 8 deletions(-) diff --git a/tests/acceptance/bootstrap/SpacesTUSContext.php b/tests/acceptance/bootstrap/SpacesTUSContext.php index 33a87b7bdc..65e20becda 100644 --- a/tests/acceptance/bootstrap/SpacesTUSContext.php +++ b/tests/acceptance/bootstrap/SpacesTUSContext.php @@ -96,7 +96,7 @@ class SpacesTUSContext implements Context { } /** - * @When the public uploads a file from :source to :destination via TUS inside last link shared folder with password :password using the WebDAV API + * @When the public uploads file :source to :destination via TUS inside last link shared folder with password :password using the WebDAV API * * @param string $source * @param string $destination @@ -105,7 +105,7 @@ class SpacesTUSContext implements Context { * @return void * @throws Exception */ - public function publicUploadsAFileViaTusInsideOfTheSpaceUsingTheWebdavApi( + public function thePublicUploadsFileViaTusInsideLastSharedFolderWithPasswordUsingTheWebdavApi( string $source, string $destination, string $password diff --git a/tests/acceptance/bootstrap/TUSContext.php b/tests/acceptance/bootstrap/TUSContext.php index f97ee8c82f..46cf2fc67c 100644 --- a/tests/acceptance/bootstrap/TUSContext.php +++ b/tests/acceptance/bootstrap/TUSContext.php @@ -352,10 +352,10 @@ class TUSContext implements Context { * @return void */ public function publicUploadFileUsingTus( - string $source, - string $destination, + string $source, + string $destination, string $password, - ):void { + ): void { $password = $this->featureContext->getActualPassword($password); if ($this->featureContext->isUsingSharingNG()) { $token = $this->featureContext->shareNgGetLastCreatedLinkShareToken(); diff --git a/tests/acceptance/features/apiSpacesShares/shareUploadTUS.feature b/tests/acceptance/features/apiSpacesShares/shareUploadTUS.feature index 90cd82e20c..1df471ddc5 100644 --- a/tests/acceptance/features/apiSpacesShares/shareUploadTUS.feature +++ b/tests/acceptance/features/apiSpacesShares/shareUploadTUS.feature @@ -412,7 +412,7 @@ Feature: upload resources on share using TUS protocol | space | Personal | | permissionsRole | createOnly | | password | %public% | - When the public uploads a file from "filesForUpload/zerobyte.txt" to "textfile.txt" via TUS inside last link shared folder with password "%public%" using the WebDAV API + When the public uploads file "filesForUpload/zerobyte.txt" to "textfile.txt" via TUS inside last link shared folder with password "%public%" using the WebDAV API And for user "Alice" folder "uploadFolder" of the space "Personal" should contain these files: | textfile.txt | And for user "Alice" folder "uploadFolder" of the space "Personal" should not contain these files: @@ -429,7 +429,7 @@ Feature: upload resources on share using TUS protocol | space | Project | | permissionsRole | createOnly | | password | %public% | - When the public uploads a file from "filesForUpload/zerobyte.txt" to "textfile.txt" via TUS inside last link shared folder with password "%public%" using the WebDAV API + When the public uploads file "filesForUpload/zerobyte.txt" to "textfile.txt" via TUS inside last link shared folder with password "%public%" using the WebDAV API And for user "Alice" folder "uploadFolder" of the space "Project" should contain these files: | textfile.txt | And for user "Alice" folder "uploadFolder" of the space "Project" should not contain these files: @@ -444,7 +444,7 @@ Feature: upload resources on share using TUS protocol | space | Project | | permissionsRole | createOnly | | password | %public% | - When the public uploads a file from "filesForUpload/zerobyte.txt" to "textfile.txt" via TUS inside last link shared folder with password "%public%" using the WebDAV API + When the public uploads file "filesForUpload/zerobyte.txt" to "textfile.txt" via TUS inside last link shared folder with password "%public%" using the WebDAV API Then for user "Alice" the space "Project" should contain these files: | textfile.txt | And for user "Alice" the space "Project" should not contain these files: