From d1753172952e489b42e1dfc8612f17ab24fae1b6 Mon Sep 17 00:00:00 2001 From: =?UTF-8?q?Juan=20Pablo=20Villaf=C3=A1=C3=B1ez?= Date: Wed, 5 Jun 2024 11:48:12 +0200 Subject: [PATCH] fix: add comment and fix unit tests --- services/collaboration/pkg/connector/fileconnector.go | 3 +++ services/collaboration/pkg/connector/fileconnector_test.go | 4 ++-- 2 files changed, 5 insertions(+), 2 deletions(-) diff --git a/services/collaboration/pkg/connector/fileconnector.go b/services/collaboration/pkg/connector/fileconnector.go index bd77eef5e9..8b98851f21 100644 --- a/services/collaboration/pkg/connector/fileconnector.go +++ b/services/collaboration/pkg/connector/fileconnector.go @@ -500,6 +500,9 @@ func (f *FileConnector) CheckFileInfo(ctx context.Context) (fileinfo.FileInfo, e return nil, NewConnectorError(500, statRes.GetStatus().GetCode().String()+" "+statRes.GetStatus().GetMessage()) } + // If a not known app name is used, consider "Microsoft" as default. + // This will help with the CI because we're using a "FakeOffice" app + // for the wopi validator, which requires a Microsoft fileinfo var info fileinfo.FileInfo switch strings.ToLower(f.cfg.App.Name) { case "collabora": diff --git a/services/collaboration/pkg/connector/fileconnector_test.go b/services/collaboration/pkg/connector/fileconnector_test.go index 538da49723..0777151404 100644 --- a/services/collaboration/pkg/connector/fileconnector_test.go +++ b/services/collaboration/pkg/connector/fileconnector_test.go @@ -840,7 +840,7 @@ var _ = Describe("FileConnector", func() { }, nil) // change wopi app provider - cfg.WopiApp.Provider = "Collabora" + cfg.App.Name = "Collabora" expectedFileInfo := &fileinfo.Collabora{ OwnerID: "61616262636340637573746f6d496470", // hex of aabbcc@customIdp @@ -893,7 +893,7 @@ var _ = Describe("FileConnector", func() { }, nil) // change wopi app provider - cfg.WopiApp.Provider = "Collabora" + cfg.App.Name = "Collabora" expectedFileInfo := &fileinfo.Collabora{ OwnerID: "61616262636340637573746f6d496470", // hex of aabbcc@customIdp