From f7a86d681a5488aa40bdee65231d2ee7e05f1d96 Mon Sep 17 00:00:00 2001 From: Florian Schade Date: Mon, 16 Feb 2026 14:02:57 +0100 Subject: [PATCH] chore: cleanup backchannel logout pr for review --- services/proxy/pkg/config/defaults/defaultconfig.go | 2 -- services/proxy/pkg/middleware/oidc_auth.go | 2 +- services/proxy/pkg/staticroutes/staticroutes.go | 3 +-- 3 files changed, 2 insertions(+), 5 deletions(-) diff --git a/services/proxy/pkg/config/defaults/defaultconfig.go b/services/proxy/pkg/config/defaults/defaultconfig.go index bbdd82a272..9e0985003a 100644 --- a/services/proxy/pkg/config/defaults/defaultconfig.go +++ b/services/proxy/pkg/config/defaults/defaultconfig.go @@ -45,8 +45,6 @@ func DefaultConfig() *config.Config { AccessTokenVerifyMethod: config.AccessTokenVerificationJWT, SkipUserInfo: false, UserinfoCache: &config.Cache{ - // toDo: - // check if "memory" is the right default or if "nats-js-kv" is a better match Store: "memory", Nodes: []string{"127.0.0.1:9233"}, Database: "cache-userinfo", diff --git a/services/proxy/pkg/middleware/oidc_auth.go b/services/proxy/pkg/middleware/oidc_auth.go index 342e5bbbe9..17f9e8edba 100644 --- a/services/proxy/pkg/middleware/oidc_auth.go +++ b/services/proxy/pkg/middleware/oidc_auth.go @@ -115,7 +115,7 @@ func (m *OIDCAuthenticator) getClaims(token string, req *http.Request) (map[stri m.Logger.Error().Err(err).Msg("failed to write to userinfo cache") } - subject, sessionId := aClaims.Subject, aClaims.SessionID + subject, sessionId := strings.Join(strings.Fields(aClaims.Subject), ""), strings.Join(strings.Fields(aClaims.SessionID), "") // if no session id is present, we can't do a session lookup, // so we can skip the cache entry for that. if sessionId == "" { diff --git a/services/proxy/pkg/staticroutes/staticroutes.go b/services/proxy/pkg/staticroutes/staticroutes.go index 61d4f0ca5b..f2f76740f1 100644 --- a/services/proxy/pkg/staticroutes/staticroutes.go +++ b/services/proxy/pkg/staticroutes/staticroutes.go @@ -4,13 +4,12 @@ import ( "net/http" "github.com/go-chi/chi/v5" - microstore "go-micro.dev/v4/store" - "github.com/opencloud-eu/opencloud/pkg/log" "github.com/opencloud-eu/opencloud/pkg/oidc" "github.com/opencloud-eu/opencloud/services/proxy/pkg/config" "github.com/opencloud-eu/opencloud/services/proxy/pkg/user/backend" "github.com/opencloud-eu/reva/v2/pkg/events" + microstore "go-micro.dev/v4/store" ) // StaticRouteHandler defines a Route Handler for static routes