diff --git a/changelog/unreleased/fix-empty-traceids.md b/changelog/unreleased/fix-empty-traceids.md new file mode 100644 index 000000000..6a7658db3 --- /dev/null +++ b/changelog/unreleased/fix-empty-traceids.md @@ -0,0 +1,5 @@ +Bugfix: Fix empty trace ids + +We changed the default tracing to produce non-empty traceids. + +https://github.com/owncloud/ocis/pull/8017 diff --git a/ocis-pkg/tracing/tracing.go b/ocis-pkg/tracing/tracing.go index a949b234c..fb86e48ea 100644 --- a/ocis-pkg/tracing/tracing.go +++ b/ocis-pkg/tracing/tracing.go @@ -39,7 +39,13 @@ func GetServiceTraceProvider(c ConfigConverter, serviceName string) (trace.Trace if cfg.Enabled { return GetTraceProvider(cfg.Endpoint, cfg.Collector, serviceName, cfg.Type) } - return trace.NewNoopTracerProvider(), nil + + tp := sdktrace.NewTracerProvider( + sdktrace.WithSampler(sdktrace.NeverSample()), + ) + rtrace.SetDefaultTracerProvider(tp) + + return tp, nil } // GetPropagator gets a configured propagator.