Commit Graph

101 Commits

Author SHA1 Message Date
Pascal Bleser
f144a7cc8b groupware: add addressbook and calendar creation APIs
* add Groupware APIs for creating and deleting addressbooks

 * add Groupware APIs for creating and deleting calendars

 * add JMAP APIs for creating and deleting addressbooks, calendars

 * add JMAP APIs to retrieve Principals

 * fix API tagging

 * move addressbook JMAP APIs into its own file

 * move addressbook Groupware APIs into its own file
2026-04-03 15:43:06 +02:00
Pascal Bleser
6c42e090c0 groupware: add changes support for quotas, identities, submissions 2026-04-03 15:43:06 +02:00
Pascal Bleser
4da13418c2 groupware: framework refactorings + add support for /changes + add /objects 2026-04-03 15:43:06 +02:00
Pascal Bleser
b3e91501a0 groupware: pollute code with NOSONAR comments, and make a little more use of JMAP API templates 2026-04-03 15:43:06 +02:00
Pascal Bleser
a7eb6106fc groupware: refactor contactcard changes, and Request framework
* implement ContactCard retrieval endpoint for syncing

 * re-implement that endpoint for Email too

 * fix the Mailbox changes endpoint to actually return changes about
   Mailboxes, and not about Emails

 * when querying the diff of Mailboxes without any prior state, return
   an error since the result is not what one would expect

 * introduce the 'changes' API tag and group

 * refactor the successful response functions to consistently return an
   object type and object state whenever possible

 * move the syncing endpoints under /accounts/*/changes/ for better
   clarity, e.g. /changes/emails instead of /emails/mailbox/*/changes
2026-04-03 15:43:06 +02:00
Pascal Bleser
6d2c1d32b9 groupware: documentation: more calendar examples 2026-04-03 15:43:06 +02:00
Pascal Bleser
cf824b5447 groupware: fix typos and minor issues
- fix a bunch of minor issues and typos that were found using GoLand
   and gosec

 - add a gosec Makefile target for Groupware related files, in
   services/groupware/Makefile

 - enable checking JMAP session capabilities for events and contacts,
   and only enable skipping that check for tasks until those are
   implemented in Stalwart as well

 - fix a CWE-190 (integer overflow or wraparound) found by gosec

 - consistently use struct references for methods of Groupware and
   Request, instead of mixing up references and copies

 - always log errors when unable to register a Prometheus metric
2026-04-03 15:43:06 +02:00
Pascal Bleser
499fc0fe42 groupware: upgrade Stalwart image in integration tests from 0.15.0 to 0.15.5 2026-04-03 15:43:06 +02:00
Pascal Bleser
57d2a74215 groupware: add UI example of a ContactCard to the documented examples 2026-04-03 15:43:06 +02:00
Pascal Bleser
e2294a5e82 groupware: add OIDC authentication support between Groupware backend and Stalwart
* re-implement the auth-api service to authenticate Reva tokens
   following the OIDC Userinfo endpoint specification

 * pass the context where necessary and add an authenticator interface
   to the JMAP HTTP driver, in order to select between master
   authentication (which is used when GROUPWARE_JMAP_MASTER_USERNAME and
   GROUPWARE_JMAP_MASTER_PASSWORD are both set) and OIDC token
   forwarding through bearer auth

 * add Stalwart directory configuration "idmoidc" which uses the
   OpenCloud auth-api service API (/auth/) to validate the token it
   received as bearer auth from the Groupware backend's JMAP client,
   using it as an OIDC Userinfo endpoint

 * implement optional additional shared secret to secure the Userinfo
   service, as an additional path parameter
2026-04-03 15:43:06 +02:00
Pascal Bleser
322ba160cc groupware: remove remnants of go-swagger documentation, since we are switching to using our own tool instead 2026-04-03 15:43:06 +02:00
Pascal Bleser
b19380cf70 groupware: add jscontact examples, and move them to jmap/model_examples.go to avoid dependency recursion 2026-04-03 15:43:06 +02:00
Pascal Bleser
1d4edaffaf groupware: as suggested in the review PR 1994, remove all filename prefixes that match the package (groupware_xyz.go -> xyz.go), for groupware, jmap, jscontact, jscalendar 2026-04-03 15:43:05 +02:00
Pascal Bleser
b283731020 groupware: convert documentation to proper markdown 2026-04-03 15:43:05 +02:00
Pascal Bleser
d43ae6e6e2 groupware: more API examples 2026-04-03 15:43:05 +02:00
Pascal Bleser
cef1cb1e5b API documentation changes for groupware-apidocs
* add example generator infrastructure, with some examples for pkg/jmap
   and pkg/groupware, with more needing to be done

 * alter the apidoc Makefile to stop using go-swagger but, instead, use
   the openapi.yml file that must be dropped into that directory using
   groupware-apidocs (will improve the integration there later)

 * add Makefile target to generate examples

 * bump redocly from 2.4.0 to 2.14.5

 * introduce Request.PathParam() and .PathParamDoc() to improve API
   documentation, as well as future-proofing

 * improve X-Request-ID and Trace-Id header handling in the middleware
   by logging it safely when an error occurs in the middleware
2026-04-03 15:40:10 +02:00
Pascal Bleser
0b9c9da8ff groupware: update to Stalwart 0.15.0 2026-04-03 15:40:10 +02:00
Pascal Bleser
1ad1da8271 groupware: improve email submission and testing
* jmap/EmailCreate: add more attributes that were omitted: Headers,
   InReplyTo, References, Sender

 * add jmap GetEmailSubmissionStatus

 * improve email integration tests by adding a thorough test for email
   submission

 * jmap integration tests: provision principals and domains using the
   Stalwart Management API, switching from an in-memory to an internal
   directory
2026-04-03 15:40:10 +02:00
Pascal Bleser
5518d9357f groupware: add retrieving and adding mailboxIds for drafts and sent if they are missing 2026-04-03 15:40:10 +02:00
Pascal Bleser
de694b6e47 groupware: WS push improvements, add getting email changes to WS integration test 2026-04-03 15:40:10 +02:00
Pascal Bleser
9604475640 groupware: JMAP WS push notifications support 2026-04-03 15:40:10 +02:00
Pascal Bleser
b606fe5715 groupware: fix email summaries and allow negative offsets
* fix a bug in how email summaries are flattened across multiple
   accounts, which was previous resulting in empty email objects

 * allow negative offset in email pagination

 * make all /emails endpoints return emails without bodies
2026-04-03 15:40:10 +02:00
Pascal Bleser
f637490249 groupware: feature test improvements and upgrade to Stalwart 0.14.1
* upgrade Stalwart image for devtools/full to 0.14.1

 * re-assert which features are implemented or not in 0.14.1

 * refactor the integration tests yet again to make it clearer and
   easier to see those "features-or-not"

 * get rid of old tests that are now better covered by integration tests

 * rewrite how we compare expected and actual objects in integration
   tests, finally having found a way to ignore the @type attribute
   properly instead of having to mutate all objects to remove it
2026-04-03 15:40:10 +02:00
Pascal Bleser
4890db445d groupware: finalize JMAP events integration test, with multiple changes to the model to conform with draft-ietf-calext-jscalendarbis-10 and fields that are currently not implemented in Stalwart 2026-04-03 15:40:09 +02:00
Pascal Bleser
5bfd67dd78 groupware: refactor the JMAP integration tests 2026-04-03 15:40:09 +02:00
Pascal Bleser
40a9c5aec9 groupware: improve JMAP ContactCard integration tests 2026-04-03 15:40:09 +02:00
Pascal Bleser
fa4c749eea groupware: improve JMAP integration tests for ContactCards 2026-04-03 15:40:09 +02:00
Pascal Bleser
e7c2b96324 groupware: fix recently introduced error with UploadedBlob with and without a sha512 2026-04-03 15:40:09 +02:00
Pascal Bleser
54fbb2fa63 groupware: fix blob uploading metadata and add 'POST /blobs' route 2026-04-03 15:40:09 +02:00
Pascal Bleser
1142c56c7a groupware: add getting a contact by ID + add integration tests for contacts 2026-04-03 15:40:09 +02:00
Pascal Bleser
fcc5bd8584 groupware: improved integration test for email, fixed two bugs 2026-04-03 15:40:09 +02:00
Pascal Bleser
9be8561fca groupware: fix deserialization of Event Alert Trigger types using mapstructure 2026-04-03 15:40:09 +02:00
Pascal Bleser
f1f83e0369 groupware: add real calendars and events 2026-04-03 15:40:09 +02:00
Pascal Bleser
a715b14677 groupware: implement/fix email submission 2026-04-03 15:40:09 +02:00
Pascal Bleser
3c19e1d1db groupware: implement Mailbox modification endpoints + refactor ETag/state in the framework
* add endpoints for Mailboxes:
   - PATCH mailboxes/{id}
   - DELETE mailboxes/{id}
   - POST mailboxes

 * refactor the pkg/jmap and groupware framework to systematically
   return a jmap.State out-of-band of the per-method payloads, since
   they are almost always present in JMAP responses, which lead to the
   artificial creation of a lot of composed struct types just to also
   return the State; on the downside, it adds yet another return
   parameter
2026-04-03 15:40:09 +02:00
Pascal Bleser
ee399503ba groupware: add ical blob parsing endpoint 2026-04-03 15:40:09 +02:00
Pascal Bleser
f9f55866bb groupware: add Mailbox sorting 2026-04-03 15:40:09 +02:00
Pascal Bleser
8998cd516f groupware: jmap: fix id -> blobId attribute when uploading a blob 2026-04-03 15:40:09 +02:00
Pascal Bleser
3cdd4b56ee groupware: fix creating contacts 2026-04-03 15:40:09 +02:00
Pascal Bleser
5bb710196f groupware: actually add total and limit to the email summary endpoint 2026-04-03 15:40:09 +02:00
Pascal Bleser
733feeacce groupware: fix compilation in tests after recent changes 2026-04-03 15:40:09 +02:00
Pascal Bleser
c0ebd364ad groupware: add missing total,limit,offset attributes in the QueryEmailsSummaries response 2026-04-03 15:40:09 +02:00
Pascal Bleser
92d36ff23d groupware: add threadCount to /groupware/accounts/{accountId}/mailboxes/{mailboxId}/emails 2026-04-03 15:40:09 +02:00
Pascal Bleser
c33c7b481a groupware: add ContactCard operations 2026-04-03 15:40:09 +02:00
Pascal Bleser
584901531e groupware: add threadSize in email-by-id response 2026-04-03 15:40:09 +02:00
Pascal Bleser
086eb32f16 groupware: introduce constants for Email property names, see EmailSummaryProperties 2026-04-03 15:40:09 +02:00
Pascal Bleser
b5db2279d2 groupware: fix keyword patching syntax for markAsSeen=true 2026-04-03 15:40:09 +02:00
Pascal Bleser
7157048d64 groupware: add threadSize property in the email summary endpoint 2026-04-03 15:40:09 +02:00
Pascal Bleser
d939fe50be groupware: add markAsSeen=true to mark an email as $seen before it is
retrieved
2026-04-03 15:40:09 +02:00
Pascal Bleser
b1f89939c7 groupware: add searching emails by their Message-Id + retrieving an email by its ID as message/rfc822 2026-04-03 15:40:09 +02:00