Commit Graph

49 Commits

Author SHA1 Message Date
Pascal Bleser
11080ca321 groupware: more mock data, added missing JMAP types 2026-04-30 10:51:42 +02:00
Pascal Bleser
9777c619b7 groupware: add mock endpoints for addressbooks and contacts 2026-04-30 10:51:42 +02:00
Pascal Bleser
915c53bf6e services/groupware/DEVELOPER.md: adapt to new path for the opencloud_full deployment 2026-04-30 10:51:42 +02:00
Pascal Bleser
1dd7e7743c Docker Compose Groupware improvements
* made a few changes in order to further simplify the setup for
   developers of the Groupware backend

 * add STALWART_DOMAIN to deployments/examples/opencloud_full/.env

 * adapt the Stalwart configuration file to not set server.hostname and,
   instead, pick it up from /etc/hostname, which is set by Docker
   Compose as we can use default values for STALWART_DOMAIN there, in an
   analogous fashion to the other containers in that project

 * add config/keycloak/clients/groupware.json to avoid requiring manual
   configuration of Keycloak via the admin web UI

 * Stalwart container:
   - listen for SMTPS on :1465
   - remove the stalwart-logs volume, not needed (logs are going to
     stdout)

 * updated services/groupware/DEVELOPER.md:
   - refer to a variable OCDIR to make instructions more copy-pasteable
   - remove manual Keycloak configuration section as it is now obsolete,
     replaced by provisioning a configuration file instead
2026-04-30 10:51:41 +02:00
Pascal Bleser
b24ed478f0 start websocket implementation, add endpoint for email summaries
* feat(groupware): start implementing JMAP websocket support for push
   notifications (unfinished)

 * groupware: add GetLatestEmailsSummaryForAllAccounts

 * add new vendored dependency: github.com/gorilla/websocket

 * jmap: add QueryEmailSummaries

 * openapi: start adding examples

 * openapi: add new tooling for api-examples.yaml injection

 * apidoc-process.ts: make it more typescript-y

 * bump @redocly/cli from 2.0.8 to latest 2.2.0
2026-04-30 10:51:41 +02:00
Pascal Bleser
246cb7a8cb refactor(groupware): just use a function for the attachment picker
Minor: be more Go idiomatic: just use a function to pick the attachment
from an Email's attachment list instead of using an interface with
multiple iplementation structs.
2026-04-30 10:51:41 +02:00
Pascal Bleser
73cb56e9c7 groupware: improved attachment APIs
* feat(groupware): add /accounts/{}/emails/{}/attachments

 * feat(groupware): add
   /accounts/{}/emails/{}/attachments?partId=&name=&blobId=
2026-04-30 10:51:41 +02:00
Pascal Bleser
02b4108e33 fix(groupware): update DEVELOPER.md imap-filler usage since it was updated to use flags instead of environment variables 2026-04-30 10:51:41 +02:00
Pascal Bleser
788f7435d2 docs(groupware): more developer instructions 2026-04-30 10:51:41 +02:00
Pascal Bleser
063fa0e2fe more updates to the Groupware DEVELOPER.md 2026-04-30 10:51:41 +02:00
Pascal Bleser
c517932d5f docs(groupware): add configuration instructions to DEVELOPER.md 2026-04-30 10:51:41 +02:00
Pascal Bleser
c4aeda3cd8 fix(groupware): fix JMAP error handling
* the JMAP error handling was not working properly, fixed it and added
   error definitions accordingly

 * add operations to retrieve mailbox roles and mailboxes by role for
   all accounts
2026-04-30 10:51:41 +02:00
Pascal Bleser
20bebd2100 refactor(groupware): rename "Messages" to "Email" everywhere
There was really no reason to go with "Messages" as far as the
vocabulary of the Groupware API goes, since the objects those APIs serve
are "Emails", to stick with the wording of the JMAP specification.
2026-04-30 10:51:41 +02:00
Pascal Bleser
74451b940f docs(groupware): add services/groupware/DEVELOPER.md 2026-04-30 10:51:41 +02:00
Pascal Bleser
2baf12814d groupware: minor typo fixes 2026-04-30 10:51:41 +02:00
Pascal Bleser
b34cc36e0d feat(groupware): add fetching all mailboxes for all accounts
* add URL to retrieve all the mailboxes for all the accounts of a user,
   as a first use-case for an all-accounts operation, as
   /accounts/all/mailboxes

 * add URL to retrieve mailbox changes for all the mailboxes of all the
   accounts of a user, as a first use-case for an all-accounts
   operation, as /accounts/all/mailboxes/changes

 * change the defaultAccountId from '*' to '_', as '*' rather indicates
   "all" than "default", and we might want to use that for "all
   accounts" operations in the future

 * refactor(groupware): remove the accountId parameter from the logger()
   function, as it is not used anyways, but also confusing for
   operations that support multiple account ids
2026-04-30 10:51:41 +02:00
Pascal Bleser
4d9bc2acfc docs(groupware): OpenAPI improvements
* refactor some pkg/jmap and groupware methods to make more sense from
   an API point-of-view

 * add path parameter documentation, but automate it by injecting their
   definition into the OpenAPI YAML tree that is extracted from the
   source code using go-swagger as it is too cumbersome, repetitive and
   error-prine to document them in the source code; wrote a TypeScript
   file apidoc-process.ts to do so

 * add generating an offline HTML file for the OpenAPI documentation
   using redocly, and injecting a favicon into the resulting HTML; wrote
   a TypeScript file apidoc-postprocess-html.ts to do so
2026-04-30 10:51:41 +02:00
Pascal Bleser
6aff360578 refactor(groupware): session cache and DNS autodiscovery
* move the logging of the username and session state away from pkg/jmap
   and into services/groupware

 * introduce more decoupling for the session cache, as well as moving
   the implementation into groupware_session.go
2026-04-30 10:51:41 +02:00
Pascal Bleser
808566083a groupware: add DNS auto-discovery (currently disabled, needs testing) 2026-04-30 10:51:41 +02:00
Pascal Bleser
d0c9358908 groupware: session handling improvements
* remove the baseurl from the JMAP client configuration, and pass it to
   the session retrieval functions instead, as that is really the only
   place where it is relevant, and we gain flexibility to discover that
   session URL differently in the future without having to touch the
   JMAP client

 * move the default account identifier handling from the JMAP package to
   the Groupware one, as it really has nothing to do with JMAP itself,
   and is an opinionated feature of the Groupware REST API instead

 * add an event listener interface for JMAP events to be more flexible
   and universal, typically for metrics that are defined on the API
   level that uses the JMAP client

 * add errors for when default accounts cannot be determined

 * split groupware_framework.go into groupware_framework.go,
   groupware_request.go and groupware_response.go

 * move the accountId logging into the Groupware level instead of JMAP
   since it can also be relevant to other operations that might be
   worthy of logging before the JMAP client is even invoked
2026-04-30 10:51:41 +02:00
Pascal Bleser
6539d1e264 groupware: fix debug server, was missing a lot of configuration options and was binding to :80 2026-04-30 10:51:41 +02:00
Pascal Bleser
2eac376b31 refactor(groupware): logging and metrics improvements
* some minor code refactorings to improve logging and metrics

 * more code documentation
2026-04-30 10:51:41 +02:00
Pascal Bleser
30fe8e0022 groupware: improve metrics
* implement more metrics, in a more streamlined fashion

 * use concurrent-map to store SSE streams instead of a regular map with
   one big lock that will not scale when it grows, causing too much
   contention on that one lock

 * while testing error metrics, noticed a few bugs with error handling
   when Stalwart is down: fixed
2026-04-30 10:51:41 +02:00
Pascal Bleser
a127c7d759 groupware: implement metrics
* implement a framework for metrics, with a few exemplary ones
2026-04-30 10:51:41 +02:00
Pascal Bleser
b83b8d4467 groupware: Etag handling
* implement correct Etag and If-None-Match handling, responding with
   304 Not Modified if they match

 * introduce SessionState and State string type aliases to ensure we are
   using the correct fields for those, respectively

 * extract the SessionState from the JMAP response bodies in the
   groupware framework instead of having to do that in every single
   groupware API

 * use uint instead of int in some places to clarify that the values are
   >= 0

 * trace-log how long a Session was held in cache before being evicted

 * add Trace-Id header handling: add to response when specified in
   request, and implement a custom request logger to include it as a
   field

 * implement a more compact trace-logging of all the methods and URIs
   that are served, to put them into a single log entry instead of
   creating one log entry for every URI
2026-04-30 10:51:41 +02:00
Pascal Bleser
e085c87928 groupware: initial related emails implementation with SSE 2026-04-30 10:51:41 +02:00
Pascal Bleser
0e8bbe7038 groupware: add /bootstrap
* add a GET /accounts/{a}/boostrap URI that delivers the same as GET /
   but also mailboxes for a given account, in case the UI remembers the
   last used account identifier, to avoid an additional roundtrip

 * streamline the use of simpleError()

 * add logging of errors at the calling site

 * add logging of evictions of Sessions from the cache

 * change default Session cache TTL to 5min instead of 30sec
2026-04-30 10:51:41 +02:00
Pascal Bleser
7af4a01de6 groupware: swagger API documentation improvements
* add more documentation for properties

 * fixes after a bit of trial-and-error with go-swagger

 * fix email filter marshalling when there are no search criteria

 * introduce an apidoc.yml that contains Swagger data and is merged when
   generating the swagger.yml from sources
2026-04-30 10:51:41 +02:00
Pascal Bleser
304bbe2fa6 Groupware improvements
* ensure that all the jmap responses contain the SessionState

 * implement missing errors that were marked as TODO

 * moved common functions from pkg/jmap and pkg/services/groupware to
   pkg/log and pkg/structs to commonalize them across both source trees

 * implement error handling for SetError occurences

 * Email: replace anonymous map[string]bool for mailbox rights with a
   MailboxRights struct, as the keys are well-defined, which allows for
   properly documenting them

 * introduce ObjectType as an "enum"

 * fix JSON marshalling and unmarshalling of EmailBodyStructure

 * move the swagger documentation structs from groupware_api.go to
   groupware_docs.go

 * fix: change verb for /groupware/accounts/*/vacation from POST to PUT
2026-04-30 10:51:41 +02:00
Pascal Bleser
92f35520d4 groupware: minor email searching response improvements + started implementing vacation response setting API 2026-04-30 10:51:41 +02:00
Pascal Bleser
9a5de81313 groupware: add identities of all accounts to the index resource 2026-04-30 10:51:41 +02:00
Pascal Bleser
ea63d75c60 groupware: fix email search, add variant that includes the full emails 2026-04-30 10:51:41 +02:00
Pascal Bleser
b1b60c0124 groupware: fix email search, add variant that includes the full emails 2026-04-30 10:51:40 +02:00
Pascal Bleser
4a0dac0d96 Groupware: refactor jmap package, implement Email/set, EmailSubmission
* refactor the jmap package to split it into several files as the
   jmap.api.go file was becoming too unwieldy

 * refactor the Groupware handler function response to be a Response
   object, to be more future-proof and avoid adding more and more
   return parameters while handling "no content" response as well

 * more godoc for the JMAP model

 * add Email creation, updating, deleting (Email/set,
   EmailSubmission/set)

 * add endpoints
   - POST /accounts/{accountid}/messages
   - PATCH|PUT /accounts/{accountid}/messages/{messageid}
   - DELETE /accounts/{accountid}/messages/{messageid}
2026-04-30 10:51:40 +02:00
Pascal Bleser
b200d7fedc groupware: implement message search with snippets 2026-04-30 10:51:40 +02:00
Pascal Bleser
3794008dc7 groupware: blob streaming (upload and download) 2026-04-30 10:51:40 +02:00
Pascal Bleser
d3354001b5 groupware: more JMAP operations implementation 2026-04-30 10:51:40 +02:00
Pascal Bleser
e65527b5df groupware: further implementation and improvements 2026-04-30 10:51:40 +02:00
Pascal Bleser
61aed94c50 refactored the Session object, refactored the services/groupware directory, and started Swagger documentation implementation 2026-04-30 10:51:40 +02:00
Pascal Bleser
ea91210c24 groupware: refactoring the API mechanisms 2026-04-30 10:51:40 +02:00
Pascal Bleser
26cbdb8f7e groupware: implement JSON:API's error response format, with a revamped error handling in jmap and services/groupware 2026-04-30 10:51:40 +02:00
Pascal Bleser
fc1994db2d Refactor groupware service after ADR decision on the Groupware API
* after having decided that the Groupware API should be a standalone
   independent custom REST API that is using JMAP data models as much as
   possible,
 * removed Groupware APIs from the Graph service
 * moved Groupware implementation to the Groupware service, and
   refactored a few things accordingly
2026-04-30 10:51:40 +02:00
Pascal Bleser
ad73661703 Groupware and jmap: cleanup and API documentation 2026-04-30 10:51:40 +02:00
Pascal Bleser
0948c50931 groupware and jmap improvements and refactoring 2026-04-30 10:51:40 +02:00
Pascal Bleser
de6708faf8 add an auth-api service to make an exemplary implementation of an external authentication API for third party services such as Stalwart 2026-04-30 10:51:40 +02:00
Pascal Bleser
7c1f491344 move services/groupware/pkg/jmap to pkg/jmap 2026-04-30 10:51:40 +02:00
Pascal Bleser
af597ad91d WIP: restructure the Jmap client, and implement the /me/messages Graph API endpoint with it 2026-04-30 10:51:40 +02:00
Pascal Bleser
da6721f8e0 add missing routing for /groupware (currently unprotected for testing) 2026-04-30 10:51:40 +02:00
Pascal Bleser
a90f792caa WIP: initial implementation of the groupware service 2026-04-30 10:51:40 +02:00