Commit Graph

337 Commits

Author SHA1 Message Date
Pascal Bleser
4f9e0cf70a groupware: fixes after rebasing and Docker library API changes 2026-07-01 14:57:31 +02:00
Pascal Bleser
a50e1ab891 groupware: documentation changes after API generator updates for the use of template functions 2026-07-01 14:57:31 +02:00
Pascal Bleser
ec1049cd89 groupware: refactoring using function templates
* adds creating addressbooks, calendars, mailboxes

 * adds deleting mailbox, event, identity

 * adds modifying an email

 * introduce template functions for the Groupware API in templates.go,
   and use those in route function implementations whenever possible

 * add capability checking for mail, quota, blobs

 * adds Changes interface

 * adds JmapResponse interface
2026-07-01 14:57:31 +02:00
Pascal Bleser
911ab62d72 structs: add tests and documentation 2026-07-01 14:57:31 +02:00
Pascal Bleser
d330d47898 groupware: improve tests
* jmap: add UpdateContactCard and UpdateCalendarEvent funcs
 * use JSON marshalling and unmarshalling into a map for toPatch()
   implementations
 * add updating ContactCards and CalendarEvents to tests
 * add deleting ContactCards and CalendarEvents to tests
 * make query response totals work when the value is 0
 * tests: use CreateContactCard and CreateCalendarEvent funcs to create
   objects in tests instead of using a different JMAP stack that works
   with untyped maps
2026-07-01 14:57:31 +02:00
Pascal Bleser
b40f878630 groupware: refactoring: pass object type instead of namespaces
* make the JMAP internal API a bit more future-proof by passing
   ObjectType objects instead of the JMAP namespaces

 * remove the new attempt to contain operations even further using the
   Factory objects

 * move CalendarEvent operations to its own file, like everything else

 * fix email tests

 * ignore WS error when closing an already closed connection
2026-07-01 14:57:31 +02:00
Pascal Bleser
ff51e34254 groupware: refactor for conciseness
* introduce jmap.Context to hold multiple parameters and shorten
   function calls

 * introduce SearchResultsTemplate
2026-07-01 14:57:31 +02:00
Pascal Bleser
d1d88a5f9e groupware: model refactoring, introducing typed interfaces and Foo
* move ContactCard from jscontact to jmap, as it is actually a JMAP
   specification item, but also was causing too many issues with
   circular references from jscontact -> jmap

 * introduce Foo, Idable, GetRequest, GetResponse, etc... types and
   generics

 * first attempt at a Foo factory type for Mailboxes, needs to be
   expanded to further minimize repetition

 * add more specialized template functions to avoid repetition

 * introduce ChangesTemplate[T] for *Changes structs
2026-07-01 14:57:31 +02:00
Pascal Bleser
7a161bcd0f groupware: significant refactorings of the JMAP framework, adding methods and more intelligence to the various request and response types to improve the use of template functions, reducing the risks of typos and copy/paste mistakes 2026-07-01 14:57:31 +02:00
Pascal Bleser
d0cba2efd1 groupware: add addressbook and calendar creation APIs
* add Groupware APIs for creating and deleting addressbooks

 * add Groupware APIs for creating and deleting calendars

 * add JMAP APIs for creating and deleting addressbooks, calendars

 * add JMAP APIs to retrieve Principals

 * fix API tagging

 * move addressbook JMAP APIs into its own file

 * move addressbook Groupware APIs into its own file
2026-07-01 14:57:31 +02:00
Pascal Bleser
0e63a21752 groupware: add changes support for quotas, identities, submissions 2026-07-01 14:57:30 +02:00
Pascal Bleser
ef631ccdad groupware: framework refactorings + add support for /changes + add /objects 2026-07-01 14:57:30 +02:00
Pascal Bleser
928f60bd32 groupware: pollute code with NOSONAR comments, and make a little more use of JMAP API templates 2026-07-01 14:57:30 +02:00
Pascal Bleser
fa244b9316 groupware: refactor contactcard changes, and Request framework
* implement ContactCard retrieval endpoint for syncing

 * re-implement that endpoint for Email too

 * fix the Mailbox changes endpoint to actually return changes about
   Mailboxes, and not about Emails

 * when querying the diff of Mailboxes without any prior state, return
   an error since the result is not what one would expect

 * introduce the 'changes' API tag and group

 * refactor the successful response functions to consistently return an
   object type and object state whenever possible

 * move the syncing endpoints under /accounts/*/changes/ for better
   clarity, e.g. /changes/emails instead of /emails/mailbox/*/changes
2026-07-01 14:57:30 +02:00
Pascal Bleser
6a90a2ce88 groupware: documentation: more calendar examples 2026-07-01 14:57:30 +02:00
Pascal Bleser
5f508bcde6 groupware: fix typos and minor issues
- fix a bunch of minor issues and typos that were found using GoLand
   and gosec

 - add a gosec Makefile target for Groupware related files, in
   services/groupware/Makefile

 - enable checking JMAP session capabilities for events and contacts,
   and only enable skipping that check for tasks until those are
   implemented in Stalwart as well

 - fix a CWE-190 (integer overflow or wraparound) found by gosec

 - consistently use struct references for methods of Groupware and
   Request, instead of mixing up references and copies

 - always log errors when unable to register a Prometheus metric
2026-07-01 14:57:30 +02:00
Pascal Bleser
a97d3efe45 groupware: upgrade Stalwart image in integration tests from 0.15.0 to 0.15.5 2026-07-01 14:57:30 +02:00
Pascal Bleser
b75a7a479f groupware: add UI example of a ContactCard to the documented examples 2026-07-01 14:57:30 +02:00
Pascal Bleser
a26e7f483c groupware: add OIDC authentication support between Groupware backend and Stalwart
* re-implement the auth-api service to authenticate Reva tokens
   following the OIDC Userinfo endpoint specification

 * pass the context where necessary and add an authenticator interface
   to the JMAP HTTP driver, in order to select between master
   authentication (which is used when GROUPWARE_JMAP_MASTER_USERNAME and
   GROUPWARE_JMAP_MASTER_PASSWORD are both set) and OIDC token
   forwarding through bearer auth

 * add Stalwart directory configuration "idmoidc" which uses the
   OpenCloud auth-api service API (/auth/) to validate the token it
   received as bearer auth from the Groupware backend's JMAP client,
   using it as an OIDC Userinfo endpoint

 * implement optional additional shared secret to secure the Userinfo
   service, as an additional path parameter
2026-07-01 14:57:30 +02:00
Pascal Bleser
732fed70c2 groupware: remove remnants of go-swagger documentation, since we are switching to using our own tool instead 2026-07-01 14:57:30 +02:00
Pascal Bleser
12f919b5f0 groupware: add jscontact examples, and move them to jmap/model_examples.go to avoid dependency recursion 2026-07-01 14:57:30 +02:00
Pascal Bleser
f097fe9a39 groupware: as suggested in the review PR 1994, remove all filename prefixes that match the package (groupware_xyz.go -> xyz.go), for groupware, jmap, jscontact, jscalendar 2026-07-01 14:57:30 +02:00
Pascal Bleser
1b6292867d groupware: convert documentation to proper markdown 2026-07-01 14:57:30 +02:00
Pascal Bleser
8d67452775 groupware: more API examples 2026-07-01 14:57:30 +02:00
Pascal Bleser
d7f5833d75 API documentation changes for groupware-apidocs
* add example generator infrastructure, with some examples for pkg/jmap
   and pkg/groupware, with more needing to be done

 * alter the apidoc Makefile to stop using go-swagger but, instead, use
   the openapi.yml file that must be dropped into that directory using
   groupware-apidocs (will improve the integration there later)

 * add Makefile target to generate examples

 * bump redocly from 2.4.0 to 2.14.5

 * introduce Request.PathParam() and .PathParamDoc() to improve API
   documentation, as well as future-proofing

 * improve X-Request-ID and Trace-Id header handling in the middleware
   by logging it safely when an error occurs in the middleware
2026-07-01 14:57:30 +02:00
Pascal Bleser
a0c297e035 groupware: update to Stalwart 0.15.0 2026-07-01 14:57:30 +02:00
Pascal Bleser
36d0e775c2 groupware: fix failing pkg/jscontact unit tests 2026-07-01 14:57:30 +02:00
Pascal Bleser
648772e877 groupware: fix failing pkg/jscalendar unit tests 2026-07-01 14:57:29 +02:00
Pascal Bleser
d2559eece2 groupware: improve email submission and testing
* jmap/EmailCreate: add more attributes that were omitted: Headers,
   InReplyTo, References, Sender

 * add jmap GetEmailSubmissionStatus

 * improve email integration tests by adding a thorough test for email
   submission

 * jmap integration tests: provision principals and domains using the
   Stalwart Management API, switching from an in-memory to an internal
   directory
2026-07-01 14:57:29 +02:00
Pascal Bleser
e0f3601061 groupware: add retrieving and adding mailboxIds for drafts and sent if they are missing 2026-07-01 14:57:29 +02:00
Pascal Bleser
cb481aecba groupware: WS push improvements, add getting email changes to WS integration test 2026-07-01 14:57:29 +02:00
Pascal Bleser
8c44dee206 groupware: JMAP WS push notifications support 2026-07-01 14:57:29 +02:00
Pascal Bleser
32008bcc10 groupware: fix email summaries and allow negative offsets
* fix a bug in how email summaries are flattened across multiple
   accounts, which was previous resulting in empty email objects

 * allow negative offset in email pagination

 * make all /emails endpoints return emails without bodies
2026-07-01 14:57:29 +02:00
Pascal Bleser
6fe9b27df6 groupware: feature test improvements and upgrade to Stalwart 0.14.1
* upgrade Stalwart image for devtools/full to 0.14.1

 * re-assert which features are implemented or not in 0.14.1

 * refactor the integration tests yet again to make it clearer and
   easier to see those "features-or-not"

 * get rid of old tests that are now better covered by integration tests

 * rewrite how we compare expected and actual objects in integration
   tests, finally having found a way to ignore the @type attribute
   properly instead of having to mutate all objects to remove it
2026-07-01 14:57:29 +02:00
Pascal Bleser
cf90246170 groupware: finalize JMAP events integration test, with multiple changes to the model to conform with draft-ietf-calext-jscalendarbis-10 and fields that are currently not implemented in Stalwart 2026-07-01 14:57:29 +02:00
Pascal Bleser
4b2f30a804 groupware: refactor the JMAP integration tests 2026-07-01 14:57:29 +02:00
Pascal Bleser
6c6ba244d8 groupware: improve JMAP ContactCard integration tests 2026-07-01 14:57:29 +02:00
Pascal Bleser
a495f8170d groupware: improve JMAP integration tests for ContactCards 2026-07-01 14:57:29 +02:00
Pascal Bleser
1728b0354b groupware: fix recently introduced error with UploadedBlob with and without a sha512 2026-07-01 14:57:29 +02:00
Pascal Bleser
1ca79f4561 groupware: fix blob uploading metadata and add 'POST /blobs' route 2026-07-01 14:57:29 +02:00
Pascal Bleser
d2b2eba714 groupware: add getting a contact by ID + add integration tests for contacts 2026-07-01 14:57:29 +02:00
Pascal Bleser
a18fd4af0b groupware: improved integration test for email, fixed two bugs 2026-07-01 14:57:29 +02:00
Pascal Bleser
f3c84fdb03 groupware: fix deserialization of Event Alert Trigger types using mapstructure 2026-07-01 14:57:29 +02:00
Pascal Bleser
b5153f2d1a groupware: some fixes accordingly to the latest JMAP and jscalendarbis RFCs 2026-07-01 14:57:29 +02:00
Pascal Bleser
95588adc35 groupware: add real calendars and events 2026-07-01 14:57:29 +02:00
Pascal Bleser
0cc0f4c8bc groupware: implement/fix email submission 2026-07-01 14:57:29 +02:00
Pascal Bleser
8022bc6245 groupware: implement Mailbox modification endpoints + refactor ETag/state in the framework
* add endpoints for Mailboxes:
   - PATCH mailboxes/{id}
   - DELETE mailboxes/{id}
   - POST mailboxes

 * refactor the pkg/jmap and groupware framework to systematically
   return a jmap.State out-of-band of the per-method payloads, since
   they are almost always present in JMAP responses, which lead to the
   artificial creation of a lot of composed struct types just to also
   return the State; on the downside, it adds yet another return
   parameter
2026-07-01 14:57:29 +02:00
Pascal Bleser
52a218501f groupware: add ical blob parsing endpoint 2026-07-01 14:57:29 +02:00
Pascal Bleser
903825f478 groupware: add Mailbox sorting 2026-07-01 14:57:29 +02:00
Pascal Bleser
c519be89d3 groupware: jmap: fix id -> blobId attribute when uploading a blob 2026-07-01 14:57:29 +02:00