Commit Graph

29 Commits

Author SHA1 Message Date
Pascal Bleser
2bde822b78 groupware: improve JMAP integration tests for ContactCards 2026-06-11 15:01:38 +02:00
Pascal Bleser
6fb4a8d739 groupware: fix recently introduced error with UploadedBlob with and without a sha512 2026-06-11 15:01:38 +02:00
Pascal Bleser
29153f49ea groupware: fix deserialization of Event Alert Trigger types using mapstructure 2026-06-11 15:01:38 +02:00
Pascal Bleser
acd771070e groupware: add real calendars and events 2026-06-11 15:01:38 +02:00
Pascal Bleser
4daeee5f21 groupware: implement Mailbox modification endpoints + refactor ETag/state in the framework
* add endpoints for Mailboxes:
   - PATCH mailboxes/{id}
   - DELETE mailboxes/{id}
   - POST mailboxes

 * refactor the pkg/jmap and groupware framework to systematically
   return a jmap.State out-of-band of the per-method payloads, since
   they are almost always present in JMAP responses, which lead to the
   artificial creation of a lot of composed struct types just to also
   return the State; on the downside, it adds yet another return
   parameter
2026-06-11 15:01:38 +02:00
Pascal Bleser
df32bc45ac groupware: jmap: fix id -> blobId attribute when uploading a blob 2026-06-11 15:01:38 +02:00
Pascal Bleser
b897abb8dc groupware: fix compilation in tests after recent changes 2026-06-11 15:01:38 +02:00
Pascal Bleser
0dff6808c1 groupware: improve jmap integration tests
* use gofakeit instead of loremipsum, as it can also fake images for
   attachments

 * random emails for testing: generate threads, add attachments
2026-06-11 15:01:37 +02:00
Pascal Bleser
04562cc6b3 groupware: add quota API + add support for Accept-Language and Content-Language 2026-06-11 15:01:37 +02:00
Pascal Bleser
79aaa96634 groupware: add JMAP capability checking (in part: for contacts, calendars, tasks) 2026-06-11 15:01:37 +02:00
Pascal Bleser
280194060c start websocket implementation, add endpoint for email summaries
* feat(groupware): start implementing JMAP websocket support for push
   notifications (unfinished)

 * groupware: add GetLatestEmailsSummaryForAllAccounts

 * add new vendored dependency: github.com/gorilla/websocket

 * jmap: add QueryEmailSummaries

 * openapi: start adding examples

 * openapi: add new tooling for api-examples.yaml injection

 * apidoc-process.ts: make it more typescript-y

 * bump @redocly/cli from 2.0.8 to latest 2.2.0
2026-06-11 15:01:36 +02:00
Pascal Bleser
17ffe8ec56 refactor(groupware): add max requests check
* move jmap.request() to jmap.Client.request() and pass the Session
   and a Logger to introduce checking the number of methodCalls within a
   request not exceeding the limit of the Session, as well as error
   handling and logging there instead of in each caller

 * a few bugfixes:
   - add a few missing Send() calls in logs
   - correct the response tag matching for
     GetMailboxChangesForMultipleAccounts
   - fix typo in Identity.ReplyTo json serialization rune
   - fix response tag in pkg/jmap/testdata/mailboxes1.json after
     changing them to be prefixed by the accountId
2026-06-11 15:01:36 +02:00
Pascal Bleser
a48a4ecd68 feat(groupware): add fetching all mailboxes for all accounts
* add URL to retrieve all the mailboxes for all the accounts of a user,
   as a first use-case for an all-accounts operation, as
   /accounts/all/mailboxes

 * add URL to retrieve mailbox changes for all the mailboxes of all the
   accounts of a user, as a first use-case for an all-accounts
   operation, as /accounts/all/mailboxes/changes

 * change the defaultAccountId from '*' to '_', as '*' rather indicates
   "all" than "default", and we might want to use that for "all
   accounts" operations in the future

 * refactor(groupware): remove the accountId parameter from the logger()
   function, as it is not used anyways, but also confusing for
   operations that support multiple account ids
2026-06-11 15:01:36 +02:00
Pascal Bleser
5503dc4343 docs(groupware): OpenAPI improvements
* refactor some pkg/jmap and groupware methods to make more sense from
   an API point-of-view

 * add path parameter documentation, but automate it by injecting their
   definition into the OpenAPI YAML tree that is extracted from the
   source code using go-swagger as it is too cumbersome, repetitive and
   error-prine to document them in the source code; wrote a TypeScript
   file apidoc-process.ts to do so

 * add generating an offline HTML file for the OpenAPI documentation
   using redocly, and injecting a favicon into the resulting HTML; wrote
   a TypeScript file apidoc-postprocess-html.ts to do so
2026-06-11 15:01:36 +02:00
Pascal Bleser
fa5d7f1900 groupware: session handling improvements
* remove the baseurl from the JMAP client configuration, and pass it to
   the session retrieval functions instead, as that is really the only
   place where it is relevant, and we gain flexibility to discover that
   session URL differently in the future without having to touch the
   JMAP client

 * move the default account identifier handling from the JMAP package to
   the Groupware one, as it really has nothing to do with JMAP itself,
   and is an opinionated feature of the Groupware REST API instead

 * add an event listener interface for JMAP events to be more flexible
   and universal, typically for metrics that are defined on the API
   level that uses the JMAP client

 * add errors for when default accounts cannot be determined

 * split groupware_framework.go into groupware_framework.go,
   groupware_request.go and groupware_response.go

 * move the accountId logging into the Groupware level instead of JMAP
   since it can also be relevant to other operations that might be
   worthy of logging before the JMAP client is even invoked
2026-06-11 15:01:36 +02:00
Pascal Bleser
c290330971 groupware: Etag handling
* implement correct Etag and If-None-Match handling, responding with
   304 Not Modified if they match

 * introduce SessionState and State string type aliases to ensure we are
   using the correct fields for those, respectively

 * extract the SessionState from the JMAP response bodies in the
   groupware framework instead of having to do that in every single
   groupware API

 * use uint instead of int in some places to clarify that the values are
   >= 0

 * trace-log how long a Session was held in cache before being evicted

 * add Trace-Id header handling: add to response when specified in
   request, and implement a custom request logger to include it as a
   field

 * implement a more compact trace-logging of all the methods and URIs
   that are served, to put them into a single log entry instead of
   creating one log entry for every URI
2026-06-11 15:01:36 +02:00
Pascal Bleser
d0fc663e94 groupware: swagger API documentation improvements
* add more documentation for properties

 * fixes after a bit of trial-and-error with go-swagger

 * fix email filter marshalling when there are no search criteria

 * introduce an apidoc.yml that contains Swagger data and is merged when
   generating the swagger.yml from sources
2026-06-11 15:01:35 +02:00
Pascal Bleser
3c20edc0c9 Groupware improvements
* ensure that all the jmap responses contain the SessionState

 * implement missing errors that were marked as TODO

 * moved common functions from pkg/jmap and pkg/services/groupware to
   pkg/log and pkg/structs to commonalize them across both source trees

 * implement error handling for SetError occurences

 * Email: replace anonymous map[string]bool for mailbox rights with a
   MailboxRights struct, as the keys are well-defined, which allows for
   properly documenting them

 * introduce ObjectType as an "enum"

 * fix JSON marshalling and unmarshalling of EmailBodyStructure

 * move the swagger documentation structs from groupware_api.go to
   groupware_docs.go

 * fix: change verb for /groupware/accounts/*/vacation from POST to PUT
2026-06-11 15:01:35 +02:00
Pascal Bleser
46f46e1f73 groupware: fix email search, add variant that includes the full emails 2026-06-11 15:01:35 +02:00
Pascal Bleser
8533a693b2 groupware: blob streaming (upload and download) 2026-06-11 15:01:35 +02:00
Pascal Bleser
f290fe18e8 groupware: more JMAP operations implementation 2026-06-11 15:01:35 +02:00
Pascal Bleser
7acb223e4e groupware: further implementation and improvements 2026-06-11 15:01:35 +02:00
Pascal Bleser
5074f1b99b refactored the Session object, refactored the services/groupware directory, and started Swagger documentation implementation 2026-06-11 15:01:35 +02:00
Pascal Bleser
de5fe452af groupware: implement JSON:API's error response format, with a revamped error handling in jmap and services/groupware 2026-06-11 15:01:35 +02:00
Pascal Bleser
e1683ae74b Refactor groupware service after ADR decision on the Groupware API
* after having decided that the Groupware API should be a standalone
   independent custom REST API that is using JMAP data models as much as
   possible,
 * removed Groupware APIs from the Graph service
 * moved Groupware implementation to the Groupware service, and
   refactored a few things accordingly
2026-06-11 15:01:30 +02:00
Pascal Bleser
294e326d72 Groupware and jmap: cleanup and API documentation 2026-06-11 15:00:43 +02:00
Pascal Bleser
a5789912b9 Groupware improvements: refactoring, k6 tests
* refactored the models to be strongly typed with structs and mapstruct
   to decompose the dynamic parts of the JMAP payloads

 * externalized large JSON strings for tests into .json files under
   testdata/

 * added a couple of fantasy Graph groupware APIs to explore further
   options

 * added k6 scripts to test those graph/me/messages APIs, with a setup
   program to set up users in LDAP, fill their IMAP inbox, activate them
   in Stalwart, cleaning things up, etc...
2026-06-11 15:00:43 +02:00
Pascal Bleser
8f340c96bf groupware and jmap improvements and refactoring 2026-06-11 15:00:43 +02:00
Pascal Bleser
e0b845aa62 move services/groupware/pkg/jmap to pkg/jmap 2026-06-11 15:00:07 +02:00