Commit Graph

4685 Commits

Author SHA1 Message Date
Pascal Bleser
313d7f832d groupware: pollute code with NOSONAR comments, and make a little more use of JMAP API templates 2026-06-03 18:39:11 +02:00
Pascal Bleser
ea437283fa groupware: docs: add a quick copy-pastable block for running ldapsearch 2026-06-03 18:39:11 +02:00
Pascal Bleser
810f7d5482 groupware: upgrade redocly to 2.24.0 2026-06-03 18:39:11 +02:00
Pascal Bleser
5dfe44500e groupware: refactor contactcard changes, and Request framework
* implement ContactCard retrieval endpoint for syncing

 * re-implement that endpoint for Email too

 * fix the Mailbox changes endpoint to actually return changes about
   Mailboxes, and not about Emails

 * when querying the diff of Mailboxes without any prior state, return
   an error since the result is not what one would expect

 * introduce the 'changes' API tag and group

 * refactor the successful response functions to consistently return an
   object type and object state whenever possible

 * move the syncing endpoints under /accounts/*/changes/ for better
   clarity, e.g. /changes/emails instead of /emails/mailbox/*/changes
2026-06-03 18:39:11 +02:00
Pascal Bleser
3aa75f306c groupware: upgrade redocly/cli 2.20.0 -> 2.24.0 2026-06-03 18:39:11 +02:00
Pascal Bleser
3eaf9504bb groupware: clarify the ContactCard situation 2026-06-03 18:39:11 +02:00
Pascal Bleser
8391173aad groupware: add contact sorting query parameter and fix default sorting (must use updated instead of name) 2026-06-03 18:39:11 +02:00
Pascal Bleser
8680dd31c6 groupware: sort contacts in addressbook by name 2026-06-03 18:39:11 +02:00
Pascal Bleser
686c911a39 groupware: fix typos and minor issues
- fix a bunch of minor issues and typos that were found using GoLand
   and gosec

 - add a gosec Makefile target for Groupware related files, in
   services/groupware/Makefile

 - enable checking JMAP session capabilities for events and contacts,
   and only enable skipping that check for tasks until those are
   implemented in Stalwart as well

 - fix a CWE-190 (integer overflow or wraparound) found by gosec

 - consistently use struct references for methods of Groupware and
   Request, instead of mixing up references and copies

 - always log errors when unable to register a Prometheus metric
2026-06-03 18:39:11 +02:00
Pascal Bleser
681f2b365d groupware: upgrade redocly/cli 2.15.1 -> 2.20.2 2026-06-03 18:39:11 +02:00
Pascal Bleser
dca5ce5eba groupware: minor logging improvements to the session cache 2026-06-03 18:39:11 +02:00
Pascal Bleser
db42de2a35 groupware: add OIDC authentication support between Groupware backend and Stalwart
* re-implement the auth-api service to authenticate Reva tokens
   following the OIDC Userinfo endpoint specification

 * pass the context where necessary and add an authenticator interface
   to the JMAP HTTP driver, in order to select between master
   authentication (which is used when GROUPWARE_JMAP_MASTER_USERNAME and
   GROUPWARE_JMAP_MASTER_PASSWORD are both set) and OIDC token
   forwarding through bearer auth

 * add Stalwart directory configuration "idmoidc" which uses the
   OpenCloud auth-api service API (/auth/) to validate the token it
   received as bearer auth from the Groupware backend's JMAP client,
   using it as an OIDC Userinfo endpoint

 * implement optional additional shared secret to secure the Userinfo
   service, as an additional path parameter
2026-06-03 18:39:11 +02:00
Pascal Bleser
614e2b22c0 groupware: remove remnants of go-swagger documentation, since we are switching to using our own tool instead 2026-06-03 18:39:11 +02:00
Pascal Bleser
f9bd0e443f groupware: add jscontact examples, and move them to jmap/model_examples.go to avoid dependency recursion 2026-06-03 18:39:11 +02:00
Pascal Bleser
9bbd136db5 groupware: use the OIDC client ID 'web' instead of 'groupware' 2026-06-03 18:39:11 +02:00
Pascal Bleser
0b59da3d23 groupware: as suggested in the review PR 1994, remove all filename prefixes that match the package (groupware_xyz.go -> xyz.go), for groupware, jmap, jscontact, jscalendar 2026-06-03 18:39:11 +02:00
Pascal Bleser
75f8c01d4f groupware: update DEVELOPERS.md based on Jörn's feedback 2026-06-03 18:39:11 +02:00
Pascal Bleser
e846b2a8e9 auth-api: deal with errors properly in NewService 2026-06-03 18:39:11 +02:00
Pascal Bleser
ae37499bb8 groupware: bump redocly/cli from 2.14.6 to 2.15.1 2026-06-03 18:39:11 +02:00
Pascal Bleser
1999db2b36 groupware: also update DEVELOPER.md with new OpenAPI documentation generation tooling 2026-06-03 18:39:11 +02:00
Pascal Bleser
859ffd4df2 groupware: update README to new API documentation generation process, and remove defunct files 2026-06-03 18:39:11 +02:00
Pascal Bleser
fbbe8d0cb0 groupware: more API examples 2026-06-03 18:39:11 +02:00
Pascal Bleser
d42032c87e groupware: change Makefile to use groupware-apidocs instead of go-swagger 2026-06-03 18:39:11 +02:00
Pascal Bleser
786d395e78 update redocly 2.14.5 -> 2.14.6 2026-06-03 18:39:11 +02:00
Pascal Bleser
2e1abbc177 groupware: migrate to cobra instead of urfave 2026-06-03 18:39:11 +02:00
Pascal Bleser
2b24722b46 groupware: update pnpm 10.28.0 -> 10.28.1 2026-06-03 18:39:11 +02:00
Pascal Bleser
ed30094ae4 API documentation changes for groupware-apidocs
* add example generator infrastructure, with some examples for pkg/jmap
   and pkg/groupware, with more needing to be done

 * alter the apidoc Makefile to stop using go-swagger but, instead, use
   the openapi.yml file that must be dropped into that directory using
   groupware-apidocs (will improve the integration there later)

 * add Makefile target to generate examples

 * bump redocly from 2.4.0 to 2.14.5

 * introduce Request.PathParam() and .PathParamDoc() to improve API
   documentation, as well as future-proofing

 * improve X-Request-ID and Trace-Id header handling in the middleware
   by logging it safely when an error occurs in the middleware
2026-06-03 18:39:10 +02:00
Pascal Bleser
9183e96838 groupware: shift some attributes of the Groupware object around, in defaults and config sub-structures 2026-06-03 18:39:10 +02:00
Pascal Bleser
c6cf297bd6 groupware: add description and version annotations for env configuration properties 2026-06-03 18:39:10 +02:00
Pascal Bleser
fb3aad0bb4 groupware: add retrieving and adding mailboxIds for drafts and sent if they are missing 2026-06-03 18:39:10 +02:00
Pascal Bleser
3cebfb4cff groupware: refactor response objects to take a list of accountIds 2026-06-03 18:39:10 +02:00
Pascal Bleser
145a50110d groupware: fix missing casting to jmap.State after changes in pkg/jmap 2026-06-03 18:39:10 +02:00
Pascal Bleser
69d1a06087 groupware, auth-api: remove tracing and tracing configuration 2026-06-03 18:39:10 +02:00
Pascal Bleser
8bc71e81b6 groupware: JMAP WS push notifications support 2026-06-03 18:39:10 +02:00
Pascal Bleser
484f02a414 groupware: fix email summaries and allow negative offsets
* fix a bug in how email summaries are flattened across multiple
   accounts, which was previous resulting in empty email objects

 * allow negative offset in email pagination

 * make all /emails endpoints return emails without bodies
2026-06-03 18:39:10 +02:00
Pascal Bleser
369624b939 groupware: response payload /groupware/accounts/{id}/emails should be without email bodies 2026-06-03 18:39:10 +02:00
Pascal Bleser
335dfeef0b groupware: add Object-Type and Account-Id response headers
* implement Request.AllAccountIds() to generalize the fetching (and
   uniqifying) of all account IDs, which will allow us to implement
   things such as "subscribed" accounts, or limiting the number of
   accounts in one request

 * add Account-Id response header

 * add Object-Type response header
2026-06-03 18:39:10 +02:00
Pascal Bleser
3232d6b47e groupware: feature test improvements and upgrade to Stalwart 0.14.1
* upgrade Stalwart image for devtools/full to 0.14.1

 * re-assert which features are implemented or not in 0.14.1

 * refactor the integration tests yet again to make it clearer and
   easier to see those "features-or-not"

 * get rid of old tests that are now better covered by integration tests

 * rewrite how we compare expected and actual objects in integration
   tests, finally having found a way to ignore the @type attribute
   properly instead of having to mutate all objects to remove it
2026-06-03 18:39:10 +02:00
Pascal Bleser
1a86607d0e groupware: finalize JMAP events integration test, with multiple changes to the model to conform with draft-ietf-calext-jscalendarbis-10 and fields that are currently not implemented in Stalwart 2026-06-03 18:39:10 +02:00
Pascal Bleser
422c7849a6 groupware: fix recently introduced error with UploadedBlob with and without a sha512 2026-06-03 18:39:10 +02:00
Pascal Bleser
27e9e0971f groupware: fix blob uploading metadata and add 'POST /blobs' route 2026-06-03 18:39:10 +02:00
Pascal Bleser
f4cf9e0c97 groupware: add getting a contact by ID + add integration tests for contacts 2026-06-03 18:39:10 +02:00
Pascal Bleser
34f8241c0c groupware: remove mock calendars and contacts 2026-06-03 18:39:10 +02:00
Pascal Bleser
8c4b260654 groupware: some fixes accordingly to the latest JMAP and jscalendarbis RFCs 2026-06-03 18:39:10 +02:00
Pascal Bleser
524aa1ffff groupware: return identities with accounts in the /accounts endpoint 2026-06-03 18:39:10 +02:00
Pascal Bleser
fc989bc47e groupware: move POST+DELETE of contacts and events as a top-level route underneath accounts 2026-06-03 18:39:10 +02:00
Pascal Bleser
8d88749035 groupware: add real calendars and events 2026-06-03 18:39:10 +02:00
Pascal Bleser
ef82290aba groupware: implement/fix email submission 2026-06-03 18:39:10 +02:00
Pascal Bleser
ed0d0354cb groupware: implement Mailbox modification endpoints + refactor ETag/state in the framework
* add endpoints for Mailboxes:
   - PATCH mailboxes/{id}
   - DELETE mailboxes/{id}
   - POST mailboxes

 * refactor the pkg/jmap and groupware framework to systematically
   return a jmap.State out-of-band of the per-method payloads, since
   they are almost always present in JMAP responses, which lead to the
   artificial creation of a lot of composed struct types just to also
   return the State; on the downside, it adds yet another return
   parameter
2026-06-03 18:39:10 +02:00
Pascal Bleser
76c2994630 groupware: add ical blob parsing endpoint 2026-06-03 18:39:10 +02:00