Commit Graph

118 Commits

Author SHA1 Message Date
Pascal Bleser
8f5fbb00a8 groupware: refactoring: pass object type instead of namespaces
* make the JMAP internal API a bit more future-proof by passing
   ObjectType objects instead of the JMAP namespaces

 * remove the new attempt to contain operations even further using the
   Factory objects

 * move CalendarEvent operations to its own file, like everything else

 * fix email tests

 * ignore WS error when closing an already closed connection
2026-04-13 16:40:43 +02:00
Pascal Bleser
b6cedcbe90 groupware: refactor for conciseness
* introduce jmap.Context to hold multiple parameters and shorten
   function calls

 * introduce SearchResultsTemplate
2026-04-13 16:40:43 +02:00
Pascal Bleser
3449b5465b groupware: model refactoring, introducing typed interfaces and Foo
* move ContactCard from jscontact to jmap, as it is actually a JMAP
   specification item, but also was causing too many issues with
   circular references from jscontact -> jmap

 * introduce Foo, Idable, GetRequest, GetResponse, etc... types and
   generics

 * first attempt at a Foo factory type for Mailboxes, needs to be
   expanded to further minimize repetition

 * add more specialized template functions to avoid repetition

 * introduce ChangesTemplate[T] for *Changes structs
2026-04-13 16:40:42 +02:00
Pascal Bleser
898c99d8c7 groupware: add addressbook and calendar creation APIs
* add Groupware APIs for creating and deleting addressbooks

 * add Groupware APIs for creating and deleting calendars

 * add JMAP APIs for creating and deleting addressbooks, calendars

 * add JMAP APIs to retrieve Principals

 * fix API tagging

 * move addressbook JMAP APIs into its own file

 * move addressbook Groupware APIs into its own file
2026-04-13 16:40:16 +02:00
Pascal Bleser
6623f3581f groupware: add GetIdentityChanges 2026-04-13 16:40:16 +02:00
Pascal Bleser
1e85ac9d48 groupware: add changes support for quotas, identities, submissions 2026-04-13 16:40:16 +02:00
Pascal Bleser
2378eca6d8 groupware: framework refactorings + add support for /changes + add /objects 2026-04-13 16:40:16 +02:00
Pascal Bleser
96ee4e6db1 groupware: pollute code with NOSONAR comments, and make a little more use of JMAP API templates 2026-04-13 16:40:16 +02:00
Pascal Bleser
0202bb43af groupware: refactor contactcard changes, and Request framework
* implement ContactCard retrieval endpoint for syncing

 * re-implement that endpoint for Email too

 * fix the Mailbox changes endpoint to actually return changes about
   Mailboxes, and not about Emails

 * when querying the diff of Mailboxes without any prior state, return
   an error since the result is not what one would expect

 * introduce the 'changes' API tag and group

 * refactor the successful response functions to consistently return an
   object type and object state whenever possible

 * move the syncing endpoints under /accounts/*/changes/ for better
   clarity, e.g. /changes/emails instead of /emails/mailbox/*/changes
2026-04-13 16:40:16 +02:00
Pascal Bleser
de5113bfa7 groupware: clarify the ContactCard situation 2026-04-13 16:40:16 +02:00
Pascal Bleser
53a2883ad0 groupware: add contact sorting query parameter and fix default sorting (must use updated instead of name) 2026-04-13 16:40:15 +02:00
Pascal Bleser
65954cd8b4 groupware: sort contacts in addressbook by name 2026-04-13 16:40:15 +02:00
Pascal Bleser
76695c068d groupware: fix typos and minor issues
- fix a bunch of minor issues and typos that were found using GoLand
   and gosec

 - add a gosec Makefile target for Groupware related files, in
   services/groupware/Makefile

 - enable checking JMAP session capabilities for events and contacts,
   and only enable skipping that check for tasks until those are
   implemented in Stalwart as well

 - fix a CWE-190 (integer overflow or wraparound) found by gosec

 - consistently use struct references for methods of Groupware and
   Request, instead of mixing up references and copies

 - always log errors when unable to register a Prometheus metric
2026-04-13 16:40:15 +02:00
Pascal Bleser
ab6201d705 groupware: minor logging improvements to the session cache 2026-04-13 16:40:15 +02:00
Pascal Bleser
b7b540a3c8 groupware: add OIDC authentication support between Groupware backend and Stalwart
* re-implement the auth-api service to authenticate Reva tokens
   following the OIDC Userinfo endpoint specification

 * pass the context where necessary and add an authenticator interface
   to the JMAP HTTP driver, in order to select between master
   authentication (which is used when GROUPWARE_JMAP_MASTER_USERNAME and
   GROUPWARE_JMAP_MASTER_PASSWORD are both set) and OIDC token
   forwarding through bearer auth

 * add Stalwart directory configuration "idmoidc" which uses the
   OpenCloud auth-api service API (/auth/) to validate the token it
   received as bearer auth from the Groupware backend's JMAP client,
   using it as an OIDC Userinfo endpoint

 * implement optional additional shared secret to secure the Userinfo
   service, as an additional path parameter
2026-04-13 16:40:15 +02:00
Pascal Bleser
23e696e7d0 groupware: remove remnants of go-swagger documentation, since we are switching to using our own tool instead 2026-04-13 16:40:15 +02:00
Pascal Bleser
6f5f8b446b groupware: as suggested in the review PR 1994, remove all filename prefixes that match the package (groupware_xyz.go -> xyz.go), for groupware, jmap, jscontact, jscalendar 2026-04-13 16:40:15 +02:00
Pascal Bleser
b3c6d9c21b groupware: more API examples 2026-04-13 16:40:15 +02:00
Pascal Bleser
1ffc0ab6cf groupware: migrate to cobra instead of urfave 2026-04-13 16:40:15 +02:00
Pascal Bleser
7661b57f7d API documentation changes for groupware-apidocs
* add example generator infrastructure, with some examples for pkg/jmap
   and pkg/groupware, with more needing to be done

 * alter the apidoc Makefile to stop using go-swagger but, instead, use
   the openapi.yml file that must be dropped into that directory using
   groupware-apidocs (will improve the integration there later)

 * add Makefile target to generate examples

 * bump redocly from 2.4.0 to 2.14.5

 * introduce Request.PathParam() and .PathParamDoc() to improve API
   documentation, as well as future-proofing

 * improve X-Request-ID and Trace-Id header handling in the middleware
   by logging it safely when an error occurs in the middleware
2026-04-13 16:40:15 +02:00
Pascal Bleser
6aa672539d groupware: shift some attributes of the Groupware object around, in defaults and config sub-structures 2026-04-13 16:40:15 +02:00
Pascal Bleser
343cbba955 groupware: add description and version annotations for env configuration properties 2026-04-13 16:40:15 +02:00
Pascal Bleser
dbc0fef53f groupware: add retrieving and adding mailboxIds for drafts and sent if they are missing 2026-04-13 16:40:15 +02:00
Pascal Bleser
70600c1359 groupware: refactor response objects to take a list of accountIds 2026-04-13 16:40:15 +02:00
Pascal Bleser
c295b596d3 groupware: fix missing casting to jmap.State after changes in pkg/jmap 2026-04-13 16:40:15 +02:00
Pascal Bleser
03945d3adb groupware, auth-api: remove tracing and tracing configuration 2026-04-13 16:40:15 +02:00
Pascal Bleser
977216122f groupware: JMAP WS push notifications support 2026-04-13 16:40:15 +02:00
Pascal Bleser
59e6557cc5 groupware: fix email summaries and allow negative offsets
* fix a bug in how email summaries are flattened across multiple
   accounts, which was previous resulting in empty email objects

 * allow negative offset in email pagination

 * make all /emails endpoints return emails without bodies
2026-04-13 16:40:15 +02:00
Pascal Bleser
4c22b066b7 groupware: response payload /groupware/accounts/{id}/emails should be without email bodies 2026-04-13 16:40:15 +02:00
Pascal Bleser
b302b7e4d2 groupware: add Object-Type and Account-Id response headers
* implement Request.AllAccountIds() to generalize the fetching (and
   uniqifying) of all account IDs, which will allow us to implement
   things such as "subscribed" accounts, or limiting the number of
   accounts in one request

 * add Account-Id response header

 * add Object-Type response header
2026-04-13 16:40:15 +02:00
Pascal Bleser
8ccf9b2cd8 groupware: feature test improvements and upgrade to Stalwart 0.14.1
* upgrade Stalwart image for devtools/full to 0.14.1

 * re-assert which features are implemented or not in 0.14.1

 * refactor the integration tests yet again to make it clearer and
   easier to see those "features-or-not"

 * get rid of old tests that are now better covered by integration tests

 * rewrite how we compare expected and actual objects in integration
   tests, finally having found a way to ignore the @type attribute
   properly instead of having to mutate all objects to remove it
2026-04-13 16:40:15 +02:00
Pascal Bleser
8f0b627f2d groupware: finalize JMAP events integration test, with multiple changes to the model to conform with draft-ietf-calext-jscalendarbis-10 and fields that are currently not implemented in Stalwart 2026-04-13 16:40:14 +02:00
Pascal Bleser
43d122cafb groupware: fix recently introduced error with UploadedBlob with and without a sha512 2026-04-13 16:40:14 +02:00
Pascal Bleser
b253cfcf15 groupware: fix blob uploading metadata and add 'POST /blobs' route 2026-04-13 16:40:14 +02:00
Pascal Bleser
2e30b26138 groupware: add getting a contact by ID + add integration tests for contacts 2026-04-13 16:40:14 +02:00
Pascal Bleser
f79d3e94b9 groupware: remove mock calendars and contacts 2026-04-13 16:40:14 +02:00
Pascal Bleser
f0976ec1d7 groupware: some fixes accordingly to the latest JMAP and jscalendarbis RFCs 2026-04-13 16:40:14 +02:00
Pascal Bleser
e3744d62b1 groupware: return identities with accounts in the /accounts endpoint 2026-04-13 16:40:14 +02:00
Pascal Bleser
e266d9efd4 groupware: move POST+DELETE of contacts and events as a top-level route underneath accounts 2026-04-13 16:40:14 +02:00
Pascal Bleser
7348112fbe groupware: add real calendars and events 2026-04-13 16:40:14 +02:00
Pascal Bleser
25a9a9bde3 groupware: implement/fix email submission 2026-04-13 16:40:14 +02:00
Pascal Bleser
b44c22559f groupware: implement Mailbox modification endpoints + refactor ETag/state in the framework
* add endpoints for Mailboxes:
   - PATCH mailboxes/{id}
   - DELETE mailboxes/{id}
   - POST mailboxes

 * refactor the pkg/jmap and groupware framework to systematically
   return a jmap.State out-of-band of the per-method payloads, since
   they are almost always present in JMAP responses, which lead to the
   artificial creation of a lot of composed struct types just to also
   return the State; on the downside, it adds yet another return
   parameter
2026-04-13 16:40:14 +02:00
Pascal Bleser
b072ff451e groupware: add ical blob parsing endpoint 2026-04-13 16:40:14 +02:00
Pascal Bleser
9b1062cc30 groupware: add Mailbox sorting 2026-04-13 16:40:14 +02:00
Pascal Bleser
5dda820452 groupware: also change accounts to an array instead of a map in the response to /groupware/ 2026-04-13 16:40:14 +02:00
Pascal Bleser
e373b22205 groupware: minor: reorganize the route nesting 2026-04-13 16:40:14 +02:00
Pascal Bleser
268641b0a6 groupware: change /accounts endpoint to return an array with the accountId instead of a map 2026-04-13 16:40:14 +02:00
Pascal Bleser
9f27f96bc2 groupware: actually add total and limit to the email summary endpoint 2026-04-13 16:40:14 +02:00
Pascal Bleser
50afcc6dfc groupware: add missing total,limit,offset attributes in the QueryEmailsSummaries response 2026-04-13 16:40:14 +02:00
Pascal Bleser
d771650744 groupware: add threadCount to /groupware/accounts/{accountId}/mailboxes/{mailboxId}/emails 2026-04-13 16:40:14 +02:00