Commit Graph
25 Commits
Author SHA1 Message Date
Dominik Schmidt 65f19b5d71 fix(thumbnails): close rejected vips ref, map oversized convert error to forbidden 2026-09-08 15:28:37 +02:00
Dominik Schmidt 7f687ea288 fix(thumbnails): bound declared image dimensions before decoding
The imaging build decodes the full pixel buffer from the header-declared
dimensions before the existing MaxInputWidth/MaxInputHeight guard runs, so a
tiny crafted file whose header declares huge dimensions forces a multi-GB
allocation and can OOM the worker. Read the header with DecodeConfig and reject
oversized sources before the decode allocates, in both the imaging and vips
builds, and thread the limit through the audio cover-art and geogebra decoders
that decode a second attacker-controlled image.
2026-09-08 15:28:37 +02:00
Florian Schade 288e67cc39 chore: replace interface with any 2026-04-23 09:31:11 +02:00
Florian Schade 9c651af32d fix(thumbnailer): missing font panic 2025-12-31 12:17:11 +01:00
Florian Schade 01b768d33c fix(thumbnailer): respect image boundaries and text wrappings for TxtToImageConverter string drawing 2025-12-22 15:57:25 +01:00
Jannik Stehle 64afb387a2 chore: replace branded ggs test files 2025-01-28 09:38:22 +01:00
Jannik Stehle fac4ebbf0f chore: remove or change branded test files in thumbnail service 2025-01-27 15:12:12 +01:00
Jörn Friedrich Dreyer b07b5a1149 use plain pkg module
Signed-off-by: Jörn Friedrich Dreyer <jfd@butonic.de>
2025-01-13 16:42:19 +01:00
Jörn Friedrich Dreyer 8e028f17e9 change module name
Signed-off-by: Jörn Friedrich Dreyer <jfd@butonic.de>
2025-01-13 09:58:18 +01:00
jkoberg 2b8b853c4d feat(thumbnails): make ggp thumbnails work
Signed-off-by: jkoberg <jkoberg@owncloud.com>
2024-11-07 17:18:28 +01:00
jkoberg 02196da2e0 feat(thumbnails): allow thumbnails on ggp files
Signed-off-by: jkoberg <jkoberg@owncloud.com>
2024-11-06 19:32:08 +01:00
Ralf Haferkamp b63676ff93 Fix GeoGebra thumbnails when libvips support is enabled
For GeoGebra files we where still using the imaging package to decode the
embedded png, but handed it of to vips for scaling, which can't work. Now
we use vips for decoding the image as well.
2024-10-17 14:05:27 +02:00
Ralf Haferkamp a9a5570050 feat(thumbnails): optional libvips based thumbnail generation
Can be enabled by setting the 'enable_vips' tag on 'go build'
2024-10-17 14:05:27 +02:00
Ralf Haferkamp 358adc15dc refactor(thumbnails): separate out 'kovidgoyal/imaging' dependencies
Move code using the 'kovidgoyal/imaging' package to separate files
to make it easier to create alternative implementations based on build
tags.
2024-10-17 14:05:27 +02:00
Thomas Müller 9db3fd028e feat: add maximum image dimension to be processed by the thumbnailer (#9035)
* feat: add maximum image dimension to be processed by the thumbnailer

* chore: make golangci-lint happy
2024-05-03 12:20:27 +02:00
Thomas Müller a53a7cf8b5 fix: replace github.com/disintegration/imaging with github.com/kovidgoyal/imaging 2024-04-26 11:36:49 +02:00
Christian Richter ba5a050ab8 incorporate requested changes
Signed-off-by: Christian Richter <crichter@owncloud.com>
2023-11-28 09:53:23 +01:00
Christian Richter f3ed5ad696 add audio tests
Signed-off-by: Christian Richter <crichter@owncloud.com>
2023-11-27 16:26:02 +01:00
Christian Richter 497ae281ea add tests
Signed-off-by: Christian Richter <crichter@owncloud.com>
2023-11-27 15:31:38 +01:00
Christian RichterandFlorian Schade c9f6b961f9 Add geogebra previews
Co-authored-by: Florian Schade <fschade@owncloud.com>

Signed-off-by: Christian Richter <crichter@owncloud.com>
2023-11-27 15:31:38 +01:00
Dominik Schmidt a9141146fb Remove LazyReadSeeker 2023-10-30 11:15:20 +01:00
Dominik Schmidt 0b88ef8c95 thumbnails: extract pictures from audio files 2023-10-28 01:16:58 +02:00
case0sh ace3664f6a fix formatting 2023-10-06 10:29:08 +02:00
David Christofas bff9c2b3cd auto orientate pictures for thumbnails 2022-09-05 16:33:29 +02:00
Christian Richter 78064e6bab rename folder extensions -> services
Signed-off-by: Christian Richter <crichter@owncloud.com>
2022-06-27 14:05:36 +02:00