Commit Graph

306 Commits

Author SHA1 Message Date
Pascal Bleser
6f9bdfe8e8 groupware: documentation: more calendar examples 2026-04-13 16:40:15 +02:00
Pascal Bleser
76695c068d groupware: fix typos and minor issues
- fix a bunch of minor issues and typos that were found using GoLand
   and gosec

 - add a gosec Makefile target for Groupware related files, in
   services/groupware/Makefile

 - enable checking JMAP session capabilities for events and contacts,
   and only enable skipping that check for tasks until those are
   implemented in Stalwart as well

 - fix a CWE-190 (integer overflow or wraparound) found by gosec

 - consistently use struct references for methods of Groupware and
   Request, instead of mixing up references and copies

 - always log errors when unable to register a Prometheus metric
2026-04-13 16:40:15 +02:00
Pascal Bleser
60c5e51aad groupware: upgrade Stalwart image in integration tests from 0.15.0 to 0.15.5 2026-04-13 16:40:15 +02:00
Pascal Bleser
98ee6e66eb groupware: add UI example of a ContactCard to the documented examples 2026-04-13 16:40:15 +02:00
Pascal Bleser
b7b540a3c8 groupware: add OIDC authentication support between Groupware backend and Stalwart
* re-implement the auth-api service to authenticate Reva tokens
   following the OIDC Userinfo endpoint specification

 * pass the context where necessary and add an authenticator interface
   to the JMAP HTTP driver, in order to select between master
   authentication (which is used when GROUPWARE_JMAP_MASTER_USERNAME and
   GROUPWARE_JMAP_MASTER_PASSWORD are both set) and OIDC token
   forwarding through bearer auth

 * add Stalwart directory configuration "idmoidc" which uses the
   OpenCloud auth-api service API (/auth/) to validate the token it
   received as bearer auth from the Groupware backend's JMAP client,
   using it as an OIDC Userinfo endpoint

 * implement optional additional shared secret to secure the Userinfo
   service, as an additional path parameter
2026-04-13 16:40:15 +02:00
Pascal Bleser
23e696e7d0 groupware: remove remnants of go-swagger documentation, since we are switching to using our own tool instead 2026-04-13 16:40:15 +02:00
Pascal Bleser
f705cc0b87 groupware: add jscontact examples, and move them to jmap/model_examples.go to avoid dependency recursion 2026-04-13 16:40:15 +02:00
Pascal Bleser
6f5f8b446b groupware: as suggested in the review PR 1994, remove all filename prefixes that match the package (groupware_xyz.go -> xyz.go), for groupware, jmap, jscontact, jscalendar 2026-04-13 16:40:15 +02:00
Pascal Bleser
733fe69530 groupware: convert documentation to proper markdown 2026-04-13 16:40:15 +02:00
Pascal Bleser
b3c6d9c21b groupware: more API examples 2026-04-13 16:40:15 +02:00
Pascal Bleser
7661b57f7d API documentation changes for groupware-apidocs
* add example generator infrastructure, with some examples for pkg/jmap
   and pkg/groupware, with more needing to be done

 * alter the apidoc Makefile to stop using go-swagger but, instead, use
   the openapi.yml file that must be dropped into that directory using
   groupware-apidocs (will improve the integration there later)

 * add Makefile target to generate examples

 * bump redocly from 2.4.0 to 2.14.5

 * introduce Request.PathParam() and .PathParamDoc() to improve API
   documentation, as well as future-proofing

 * improve X-Request-ID and Trace-Id header handling in the middleware
   by logging it safely when an error occurs in the middleware
2026-04-13 16:40:15 +02:00
Pascal Bleser
7912fb3461 groupware: update to Stalwart 0.15.0 2026-04-13 16:40:15 +02:00
Pascal Bleser
9ed207e35e groupware: fix failing pkg/jscontact unit tests 2026-04-13 16:40:15 +02:00
Pascal Bleser
9769634991 groupware: fix failing pkg/jscalendar unit tests 2026-04-13 16:40:15 +02:00
Pascal Bleser
da02a4e3d0 groupware: improve email submission and testing
* jmap/EmailCreate: add more attributes that were omitted: Headers,
   InReplyTo, References, Sender

 * add jmap GetEmailSubmissionStatus

 * improve email integration tests by adding a thorough test for email
   submission

 * jmap integration tests: provision principals and domains using the
   Stalwart Management API, switching from an in-memory to an internal
   directory
2026-04-13 16:40:15 +02:00
Pascal Bleser
dbc0fef53f groupware: add retrieving and adding mailboxIds for drafts and sent if they are missing 2026-04-13 16:40:15 +02:00
Pascal Bleser
0e6aaadf7d groupware: WS push improvements, add getting email changes to WS integration test 2026-04-13 16:40:15 +02:00
Pascal Bleser
977216122f groupware: JMAP WS push notifications support 2026-04-13 16:40:15 +02:00
Pascal Bleser
59e6557cc5 groupware: fix email summaries and allow negative offsets
* fix a bug in how email summaries are flattened across multiple
   accounts, which was previous resulting in empty email objects

 * allow negative offset in email pagination

 * make all /emails endpoints return emails without bodies
2026-04-13 16:40:15 +02:00
Pascal Bleser
8ccf9b2cd8 groupware: feature test improvements and upgrade to Stalwart 0.14.1
* upgrade Stalwart image for devtools/full to 0.14.1

 * re-assert which features are implemented or not in 0.14.1

 * refactor the integration tests yet again to make it clearer and
   easier to see those "features-or-not"

 * get rid of old tests that are now better covered by integration tests

 * rewrite how we compare expected and actual objects in integration
   tests, finally having found a way to ignore the @type attribute
   properly instead of having to mutate all objects to remove it
2026-04-13 16:40:15 +02:00
Pascal Bleser
8f0b627f2d groupware: finalize JMAP events integration test, with multiple changes to the model to conform with draft-ietf-calext-jscalendarbis-10 and fields that are currently not implemented in Stalwart 2026-04-13 16:40:14 +02:00
Pascal Bleser
6876377822 groupware: refactor the JMAP integration tests 2026-04-13 16:40:14 +02:00
Pascal Bleser
3a3df33855 groupware: improve JMAP ContactCard integration tests 2026-04-13 16:40:14 +02:00
Pascal Bleser
29e38c956d groupware: improve JMAP integration tests for ContactCards 2026-04-13 16:40:14 +02:00
Pascal Bleser
43d122cafb groupware: fix recently introduced error with UploadedBlob with and without a sha512 2026-04-13 16:40:14 +02:00
Pascal Bleser
b253cfcf15 groupware: fix blob uploading metadata and add 'POST /blobs' route 2026-04-13 16:40:14 +02:00
Pascal Bleser
2e30b26138 groupware: add getting a contact by ID + add integration tests for contacts 2026-04-13 16:40:14 +02:00
Pascal Bleser
e93340e189 groupware: improved integration test for email, fixed two bugs 2026-04-13 16:40:14 +02:00
Pascal Bleser
b978b2f1b0 groupware: fix deserialization of Event Alert Trigger types using mapstructure 2026-04-13 16:40:14 +02:00
Pascal Bleser
f0976ec1d7 groupware: some fixes accordingly to the latest JMAP and jscalendarbis RFCs 2026-04-13 16:40:14 +02:00
Pascal Bleser
7348112fbe groupware: add real calendars and events 2026-04-13 16:40:14 +02:00
Pascal Bleser
25a9a9bde3 groupware: implement/fix email submission 2026-04-13 16:40:14 +02:00
Pascal Bleser
b44c22559f groupware: implement Mailbox modification endpoints + refactor ETag/state in the framework
* add endpoints for Mailboxes:
   - PATCH mailboxes/{id}
   - DELETE mailboxes/{id}
   - POST mailboxes

 * refactor the pkg/jmap and groupware framework to systematically
   return a jmap.State out-of-band of the per-method payloads, since
   they are almost always present in JMAP responses, which lead to the
   artificial creation of a lot of composed struct types just to also
   return the State; on the downside, it adds yet another return
   parameter
2026-04-13 16:40:14 +02:00
Pascal Bleser
b072ff451e groupware: add ical blob parsing endpoint 2026-04-13 16:40:14 +02:00
Pascal Bleser
9b1062cc30 groupware: add Mailbox sorting 2026-04-13 16:40:14 +02:00
Pascal Bleser
bbdb5b71e3 groupware: jmap: fix id -> blobId attribute when uploading a blob 2026-04-13 16:40:14 +02:00
Pascal Bleser
aefe8f8746 groupware: fix creating contacts 2026-04-13 16:40:14 +02:00
Pascal Bleser
9f27f96bc2 groupware: actually add total and limit to the email summary endpoint 2026-04-13 16:40:14 +02:00
Pascal Bleser
d84d7613fd groupware: fix compilation in tests after recent changes 2026-04-13 16:40:14 +02:00
Pascal Bleser
50afcc6dfc groupware: add missing total,limit,offset attributes in the QueryEmailsSummaries response 2026-04-13 16:40:14 +02:00
Pascal Bleser
d771650744 groupware: add threadCount to /groupware/accounts/{accountId}/mailboxes/{mailboxId}/emails 2026-04-13 16:40:14 +02:00
Pascal Bleser
d46c17b050 groupware: add ContactCard operations 2026-04-13 16:40:14 +02:00
Pascal Bleser
380e991bdd groupware: add threadSize in email-by-id response 2026-04-13 16:40:14 +02:00
Pascal Bleser
ace8dda747 groupware: introduce constants for Email property names, see EmailSummaryProperties 2026-04-13 16:40:14 +02:00
Pascal Bleser
709751edfd groupware: fix keyword patching syntax for markAsSeen=true 2026-04-13 16:40:14 +02:00
Pascal Bleser
e107cd7156 groupware: add threadSize property in the email summary endpoint 2026-04-13 16:40:14 +02:00
Pascal Bleser
5d5abe6a29 groupware: add markAsSeen=true to mark an email as $seen before it is
retrieved
2026-04-13 16:40:14 +02:00
Pascal Bleser
ed93330144 groupware: add searching emails by their Message-Id + retrieving an email by its ID as message/rfc822 2026-04-13 16:40:14 +02:00
Pascal Bleser
c5b2c3dd94 groupware: add identity deletion 2026-04-13 16:40:14 +02:00
Pascal Bleser
ecebd99b37 groupware:
* made several email related operations multi-account:
   QueryEmailSnippets, QueryEmails, QueryEmailsWithSnippets

 * add GetIdentitiesForAllAccounts

 * add GetEmailsForAllAccounts

 * jmap: add CreateIdentity, UpdateIdentity; groupware: add
   GetIdentityById, AddIdentity, ModifyIdentity

 * add temporary workaround until Calendars, Tasks, Contacts are
   implemented in Stalwart when determining the default account for
   those: use the mail one in the mean time
2026-04-13 16:40:14 +02:00