Commit Graph

114 Commits

Author SHA1 Message Date
Pascal Bleser
f5a9c2235a groupware: add GetIdentityChanges 2026-04-30 10:51:45 +02:00
Pascal Bleser
98e1701c0a groupware: add changes support for quotas, identities, submissions 2026-04-30 10:51:45 +02:00
Pascal Bleser
0b984a8e2f groupware: framework refactorings + add support for /changes + add /objects 2026-04-30 10:51:45 +02:00
Pascal Bleser
4d9e402cfd groupware: pollute code with NOSONAR comments, and make a little more use of JMAP API templates 2026-04-30 10:51:45 +02:00
Pascal Bleser
c1f7bc2261 groupware: refactor contactcard changes, and Request framework
* implement ContactCard retrieval endpoint for syncing

 * re-implement that endpoint for Email too

 * fix the Mailbox changes endpoint to actually return changes about
   Mailboxes, and not about Emails

 * when querying the diff of Mailboxes without any prior state, return
   an error since the result is not what one would expect

 * introduce the 'changes' API tag and group

 * refactor the successful response functions to consistently return an
   object type and object state whenever possible

 * move the syncing endpoints under /accounts/*/changes/ for better
   clarity, e.g. /changes/emails instead of /emails/mailbox/*/changes
2026-04-30 10:51:45 +02:00
Pascal Bleser
b12345068c groupware: clarify the ContactCard situation 2026-04-30 10:51:45 +02:00
Pascal Bleser
9f0cf5ef4d groupware: add contact sorting query parameter and fix default sorting (must use updated instead of name) 2026-04-30 10:51:45 +02:00
Pascal Bleser
a3de949e5e groupware: sort contacts in addressbook by name 2026-04-30 10:51:44 +02:00
Pascal Bleser
549fc4642a groupware: fix typos and minor issues
- fix a bunch of minor issues and typos that were found using GoLand
   and gosec

 - add a gosec Makefile target for Groupware related files, in
   services/groupware/Makefile

 - enable checking JMAP session capabilities for events and contacts,
   and only enable skipping that check for tasks until those are
   implemented in Stalwart as well

 - fix a CWE-190 (integer overflow or wraparound) found by gosec

 - consistently use struct references for methods of Groupware and
   Request, instead of mixing up references and copies

 - always log errors when unable to register a Prometheus metric
2026-04-30 10:51:44 +02:00
Pascal Bleser
199360ae41 groupware: minor logging improvements to the session cache 2026-04-30 10:51:44 +02:00
Pascal Bleser
c400949718 groupware: add OIDC authentication support between Groupware backend and Stalwart
* re-implement the auth-api service to authenticate Reva tokens
   following the OIDC Userinfo endpoint specification

 * pass the context where necessary and add an authenticator interface
   to the JMAP HTTP driver, in order to select between master
   authentication (which is used when GROUPWARE_JMAP_MASTER_USERNAME and
   GROUPWARE_JMAP_MASTER_PASSWORD are both set) and OIDC token
   forwarding through bearer auth

 * add Stalwart directory configuration "idmoidc" which uses the
   OpenCloud auth-api service API (/auth/) to validate the token it
   received as bearer auth from the Groupware backend's JMAP client,
   using it as an OIDC Userinfo endpoint

 * implement optional additional shared secret to secure the Userinfo
   service, as an additional path parameter
2026-04-30 10:51:44 +02:00
Pascal Bleser
8ad3652ba2 groupware: remove remnants of go-swagger documentation, since we are switching to using our own tool instead 2026-04-30 10:51:44 +02:00
Pascal Bleser
700930c3a9 groupware: as suggested in the review PR 1994, remove all filename prefixes that match the package (groupware_xyz.go -> xyz.go), for groupware, jmap, jscontact, jscalendar 2026-04-30 10:51:44 +02:00
Pascal Bleser
8a3a6160f9 groupware: more API examples 2026-04-30 10:51:44 +02:00
Pascal Bleser
8dd74c201a groupware: migrate to cobra instead of urfave 2026-04-30 10:51:44 +02:00
Pascal Bleser
504e107e11 API documentation changes for groupware-apidocs
* add example generator infrastructure, with some examples for pkg/jmap
   and pkg/groupware, with more needing to be done

 * alter the apidoc Makefile to stop using go-swagger but, instead, use
   the openapi.yml file that must be dropped into that directory using
   groupware-apidocs (will improve the integration there later)

 * add Makefile target to generate examples

 * bump redocly from 2.4.0 to 2.14.5

 * introduce Request.PathParam() and .PathParamDoc() to improve API
   documentation, as well as future-proofing

 * improve X-Request-ID and Trace-Id header handling in the middleware
   by logging it safely when an error occurs in the middleware
2026-04-30 10:51:44 +02:00
Pascal Bleser
1abeba85f0 groupware: shift some attributes of the Groupware object around, in defaults and config sub-structures 2026-04-30 10:51:44 +02:00
Pascal Bleser
73b286e014 groupware: add description and version annotations for env configuration properties 2026-04-30 10:51:44 +02:00
Pascal Bleser
289c9678a9 groupware: add retrieving and adding mailboxIds for drafts and sent if they are missing 2026-04-30 10:51:44 +02:00
Pascal Bleser
90ac2909ef groupware: refactor response objects to take a list of accountIds 2026-04-30 10:51:44 +02:00
Pascal Bleser
f1789dbfe8 groupware: fix missing casting to jmap.State after changes in pkg/jmap 2026-04-30 10:51:43 +02:00
Pascal Bleser
c8c9eac1ce groupware, auth-api: remove tracing and tracing configuration 2026-04-30 10:51:43 +02:00
Pascal Bleser
97e0be9f45 groupware: JMAP WS push notifications support 2026-04-30 10:51:43 +02:00
Pascal Bleser
0a355304f9 groupware: fix email summaries and allow negative offsets
* fix a bug in how email summaries are flattened across multiple
   accounts, which was previous resulting in empty email objects

 * allow negative offset in email pagination

 * make all /emails endpoints return emails without bodies
2026-04-30 10:51:43 +02:00
Pascal Bleser
6c1c130ea1 groupware: response payload /groupware/accounts/{id}/emails should be without email bodies 2026-04-30 10:51:43 +02:00
Pascal Bleser
7d3e17dd58 groupware: add Object-Type and Account-Id response headers
* implement Request.AllAccountIds() to generalize the fetching (and
   uniqifying) of all account IDs, which will allow us to implement
   things such as "subscribed" accounts, or limiting the number of
   accounts in one request

 * add Account-Id response header

 * add Object-Type response header
2026-04-30 10:51:43 +02:00
Pascal Bleser
d8c06d4db8 groupware: feature test improvements and upgrade to Stalwart 0.14.1
* upgrade Stalwart image for devtools/full to 0.14.1

 * re-assert which features are implemented or not in 0.14.1

 * refactor the integration tests yet again to make it clearer and
   easier to see those "features-or-not"

 * get rid of old tests that are now better covered by integration tests

 * rewrite how we compare expected and actual objects in integration
   tests, finally having found a way to ignore the @type attribute
   properly instead of having to mutate all objects to remove it
2026-04-30 10:51:43 +02:00
Pascal Bleser
ba30c1be87 groupware: finalize JMAP events integration test, with multiple changes to the model to conform with draft-ietf-calext-jscalendarbis-10 and fields that are currently not implemented in Stalwart 2026-04-30 10:51:43 +02:00
Pascal Bleser
0fc6ec9da9 groupware: fix recently introduced error with UploadedBlob with and without a sha512 2026-04-30 10:51:43 +02:00
Pascal Bleser
214860e276 groupware: fix blob uploading metadata and add 'POST /blobs' route 2026-04-30 10:51:43 +02:00
Pascal Bleser
b9bce2fb70 groupware: add getting a contact by ID + add integration tests for contacts 2026-04-30 10:51:43 +02:00
Pascal Bleser
30dd9812d5 groupware: remove mock calendars and contacts 2026-04-30 10:51:43 +02:00
Pascal Bleser
8e5ce28141 groupware: some fixes accordingly to the latest JMAP and jscalendarbis RFCs 2026-04-30 10:51:43 +02:00
Pascal Bleser
97f5e9a285 groupware: return identities with accounts in the /accounts endpoint 2026-04-30 10:51:43 +02:00
Pascal Bleser
26d8b1eae0 groupware: move POST+DELETE of contacts and events as a top-level route underneath accounts 2026-04-30 10:51:43 +02:00
Pascal Bleser
def7b8a331 groupware: add real calendars and events 2026-04-30 10:51:43 +02:00
Pascal Bleser
e8ebbecadf groupware: implement/fix email submission 2026-04-30 10:51:43 +02:00
Pascal Bleser
ae0c7b3e4a groupware: implement Mailbox modification endpoints + refactor ETag/state in the framework
* add endpoints for Mailboxes:
   - PATCH mailboxes/{id}
   - DELETE mailboxes/{id}
   - POST mailboxes

 * refactor the pkg/jmap and groupware framework to systematically
   return a jmap.State out-of-band of the per-method payloads, since
   they are almost always present in JMAP responses, which lead to the
   artificial creation of a lot of composed struct types just to also
   return the State; on the downside, it adds yet another return
   parameter
2026-04-30 10:51:43 +02:00
Pascal Bleser
abb3b03868 groupware: add ical blob parsing endpoint 2026-04-30 10:51:43 +02:00
Pascal Bleser
bd767b60ae groupware: add Mailbox sorting 2026-04-30 10:51:43 +02:00
Pascal Bleser
090de30083 groupware: also change accounts to an array instead of a map in the response to /groupware/ 2026-04-30 10:51:43 +02:00
Pascal Bleser
f0eb9045e2 groupware: minor: reorganize the route nesting 2026-04-30 10:51:43 +02:00
Pascal Bleser
f84bef7e2f groupware: change /accounts endpoint to return an array with the accountId instead of a map 2026-04-30 10:51:43 +02:00
Pascal Bleser
b42c00a501 groupware: actually add total and limit to the email summary endpoint 2026-04-30 10:51:43 +02:00
Pascal Bleser
dad5688a27 groupware: add missing total,limit,offset attributes in the QueryEmailsSummaries response 2026-04-30 10:51:43 +02:00
Pascal Bleser
77c53b0f0b groupware: add threadCount to /groupware/accounts/{accountId}/mailboxes/{mailboxId}/emails 2026-04-30 10:51:43 +02:00
Pascal Bleser
c72a202eed groupware: add ContactCard operations 2026-04-30 10:51:43 +02:00
Pascal Bleser
a0fc1b7c17 groupware: add threadSize in email-by-id response 2026-04-30 10:51:43 +02:00
Pascal Bleser
c43b341583 groupware: fix keyword patching syntax for adding and removing email keywords endpoints 2026-04-30 10:51:43 +02:00
Pascal Bleser
18661cc541 groupware: fix keyword patching syntax for markAsSeen=true 2026-04-30 10:51:43 +02:00