Compare commits

...

28 Commits

Author SHA1 Message Date
OpenCloud Devops
25d5dab696 🎉 Release 2.0.2 (#768)
* 🎉 Release 2.0.2
2025-05-02 14:50:29 +02:00
Viktor Scharf
e0f05003ef chore: bump version v2.29.3 (#766) 2025-05-02 14:20:10 +02:00
Michael Barz
1cdd21591a fix: do not overwrite github release 2025-04-28 17:30:01 +02:00
OpenCloud Devops
e730c6ed3a 🎉 Release 2.0.1 (#640)
* 🎉 Release 2.0.1
2025-04-28 12:11:13 +02:00
Viktor Scharf
7076185c0f chore: prepare release, bump version (#731)
* chore: prepare release, bump version

* Update version.go
2025-04-28 11:25:19 +02:00
Michael Barz
87ea852a21 chore: remove docs workflows (#698) 2025-04-20 23:16:14 +02:00
Viktor Scharf
4988709fd7 fix: binary release version (#695)
Co-authored-by: Michael Barz <michael.barz@zeitgestalten.eu>
2025-04-17 15:27:52 +02:00
Viktor Scharf
f1ba964365 Merge pull request #694 from opencloud-eu/port#686
fix(decomposeds3): enable async-uploads by default (#686)
2025-04-17 14:59:08 +02:00
Michael Barz
7608ae482c fix: skip labels bot on prs from forks 2025-04-17 14:00:51 +02:00
Florian Schade
abe653ed49 fix(decomposeds3): enable async-uploads by default (#686) 2025-04-17 13:59:23 +02:00
Florian Schade
b67ce7cd34 Merge pull request #689 from opencloud-eu/port#567
Port #567
2025-04-17 11:29:54 +02:00
dependabot[bot]
3263c16652 build(deps): bump github.com/nats-io/nats.go from 1.39.1 to 1.41.0
Bumps [github.com/nats-io/nats.go](https://github.com/nats-io/nats.go) from 1.39.1 to 1.41.0.
- [Release notes](https://github.com/nats-io/nats.go/releases)
- [Commits](https://github.com/nats-io/nats.go/compare/v1.39.1...v1.41.0)

---
updated-dependencies:
- dependency-name: github.com/nats-io/nats.go
  dependency-version: 1.41.0
  dependency-type: direct:production
  update-type: version-update:semver-minor
...

Signed-off-by: dependabot[bot] <support@github.com>
2025-04-17 09:35:17 +02:00
Viktor Scharf
c8df6a27b6 bump reva 2.29.2 (#681) 2025-04-17 09:17:11 +02:00
Viktor Scharf
a3a5a5a047 Merge pull request #685 from opencloud-eu/addLabelBotToStableBranch
Add label bot to stable branch
2025-04-17 09:09:58 +02:00
Viktor Scharf
a80ecf0b88 Merge pull request #680 from opencloud-eu/ci/pick-release-plugin-fixes
ci: make release plugin compatible with stable branch workflow
2025-04-17 09:09:51 +02:00
Ralf Haferkamp
17604171fe ci: Allow the Type:DevOps label 2025-04-16 14:18:33 +02:00
Michael Barz
df4d427e66 feat: add labels bot (#513) 2025-04-16 14:18:12 +02:00
Viktor Scharf
c1ddc61f2b Merge pull request #683 from opencloud-eu/backPort#679
build(deps): bump github.com/nats-io/nats-server/v2
2025-04-16 14:06:12 +02:00
dependabot[bot]
fa9282bec2 build(deps): bump github.com/nats-io/nats-server/v2
Bumps [github.com/nats-io/nats-server/v2](https://github.com/nats-io/nats-server) from 2.11.0 to 2.11.1.
- [Release notes](https://github.com/nats-io/nats-server/releases)
- [Changelog](https://github.com/nats-io/nats-server/blob/main/.goreleaser.yml)
- [Commits](https://github.com/nats-io/nats-server/compare/v2.11.0...v2.11.1)

---
updated-dependencies:
- dependency-name: github.com/nats-io/nats-server/v2
  dependency-version: 2.11.1
  dependency-type: direct:production
...

Signed-off-by: dependabot[bot] <support@github.com>
2025-04-16 13:30:12 +02:00
Jannik Stehle
9759a2dee2 ci: make release plugin compatible with stable branch workflow
Introduces the 2 configs `getLatestTag` and `useLatestRelease` to make the `ready-release-go` plugin fully compatible with our stable branch workflow.
2025-04-16 09:51:51 +02:00
Florian Schade
1bea4b7471 Merge pull request #620 from fschade/backport-antivirus-max-size-fix
fix(antivirus | backport): introduce a default max scan size for the full example deployment
2025-04-10 14:48:00 +02:00
Viktor Scharf
f266857cf1 Merge pull request #638 from opencloud-eu/chore/bump-web-to-v2.1.1
[full-ci] chore(web): bump web to v2.1.1
2025-04-10 11:22:47 +02:00
Jannik Stehle
d15c961c31 chore: bump web to v2.1.1 2025-04-10 09:34:04 +02:00
Florian Schade
9238639753 fix(antivirus): introduce a default max scan size for the full example deployment 2025-04-08 17:37:51 +02:00
Michael Barz
0718947b0c Add correct CI badge README.md 2025-04-04 21:58:49 +02:00
Michael Barz
2fc33db3aa test: enable exclude condition again 2025-04-04 17:32:14 +02:00
Michael Barz
05f0a8dc96 fix: push Readme only on main branch 2025-04-04 17:19:59 +02:00
Michael Barz
8697e6a4c8 feat: use correct triggers and base branch 2025-04-04 17:11:07 +02:00
33 changed files with 603 additions and 233 deletions

30
.github/workflows/labels.yml vendored Normal file
View File

@@ -0,0 +1,30 @@
name: Require Pull Request Labels
on:
pull_request:
types: [opened, labeled, unlabeled, synchronize]
jobs:
label:
# Only run if PR is not from a fork
if: github.event.pull_request.head.repo.full_name == github.repository
runs-on: ubuntu-latest
permissions:
issues: write
pull-requests: write
steps:
- uses: mheap/github-action-required-labels@v5
with:
mode: minimum
count: 1
labels: |
Type:Bug
Type:Enhancement
Type:Feature
Type:Breaking-Change
Type:Test
Type:Documentation
Type:Maintenance
Type:Security
Type:Dependencies
Type:DevOps
dependencies
add_comment: true

View File

@@ -1,3 +1,3 @@
# The test runner source for UI tests # The test runner source for UI tests
WEB_COMMITID=4f68c1e1dbcc88839e42c17c57f31dec243d7bd0 WEB_COMMITID=59e329cc5fe288cf247cc5272547a77ac59cc000
WEB_BRANCH=main WEB_BRANCH=stable-2.1

View File

@@ -12,6 +12,9 @@ PRODUCTION_RELEASE_TAGS = ["2.0", "3.0"]
repo_slug = "opencloud-eu/opencloud" repo_slug = "opencloud-eu/opencloud"
docker_repo_slug = "opencloudeu/opencloud" docker_repo_slug = "opencloudeu/opencloud"
# Active base branch for this code stream
branch = "stable-2.0"
# images # images
ALPINE_GIT = "alpine/git:latest" ALPINE_GIT = "alpine/git:latest"
APACHE_TIKA = "apache/tika:2.8.0.0" APACHE_TIKA = "apache/tika:2.8.0.0"
@@ -419,8 +422,7 @@ def main(ctx):
pipelines = [] pipelines = []
build_release_helpers = \ build_release_helpers = \
readyReleaseGo() + \ readyReleaseGo()
docs()
build_release_helpers.append( build_release_helpers.append(
pipelineDependsOn( pipelineDependsOn(
@@ -682,7 +684,7 @@ def testOpencloud(ctx):
"when": [ "when": [
{ {
"event": ["push", "manual"], "event": ["push", "manual"],
"branch": "main", "branch": ["main", "stable-*"],
}, },
{ {
"event": "pull_request", "event": "pull_request",
@@ -713,7 +715,7 @@ def scanOpencloud(ctx):
"when": [ "when": [
{ {
"event": ["push", "manual"], "event": ["push", "manual"],
"branch": "main", "branch": ["main", "stable-*"],
}, },
{ {
"event": "pull_request", "event": "pull_request",
@@ -736,7 +738,7 @@ def buildOpencloudBinaryForTesting(ctx):
"when": [ "when": [
{ {
"event": ["push", "manual"], "event": ["push", "manual"],
"branch": "main", "branch": ["main", "stable-*"],
}, },
{ {
"event": "pull_request", "event": "pull_request",
@@ -871,7 +873,7 @@ def codestyle(ctx):
"when": [ "when": [
{ {
"event": ["push", "manual"], "event": ["push", "manual"],
"branch": "main", "branch": ["main", "stable-*"],
}, },
{ {
"event": "pull_request", "event": "pull_request",
@@ -941,7 +943,7 @@ def localApiTestPipeline(ctx):
"when": [ "when": [
{ {
"event": ["push", "manual"], "event": ["push", "manual"],
"branch": "main", "branch": ["main", "stable-*"],
}, },
{ {
"event": "pull_request", "event": "pull_request",
@@ -1007,7 +1009,7 @@ def cs3ApiTests(ctx, storage, accounts_hash_difficulty = 4):
"when": [ "when": [
{ {
"event": ["push", "manual"], "event": ["push", "manual"],
"branch": "main", "branch": ["main", "stable-*"],
}, },
{ {
"event": "pull_request", "event": "pull_request",
@@ -1124,7 +1126,7 @@ def wopiValidatorTests(ctx, storage, wopiServerType, accounts_hash_difficulty =
"when": [ "when": [
{ {
"event": ["push", "manual"], "event": ["push", "manual"],
"branch": "main", "branch": ["main", "stable-*"],
}, },
{ {
"event": "pull_request", "event": "pull_request",
@@ -1178,7 +1180,7 @@ def coreApiTests(ctx, part_number = 1, number_of_parts = 1, with_remote_php = Fa
"when": [ "when": [
{ {
"event": ["push", "manual"], "event": ["push", "manual"],
"branch": "main", "branch": ["main", "stable-*"],
}, },
{ {
"event": "pull_request", "event": "pull_request",
@@ -1228,7 +1230,7 @@ def e2eTestPipeline(ctx):
e2e_trigger = [ e2e_trigger = [
{ {
"event": ["push", "manual"], "event": ["push", "manual"],
"branch": "main", "branch": ["main", "stable-*"],
}, },
{ {
"event": "pull_request", "event": "pull_request",
@@ -1337,7 +1339,7 @@ def multiServiceE2ePipeline(ctx):
e2e_trigger = [ e2e_trigger = [
{ {
"event": ["push", "manual"], "event": ["push", "manual"],
"branch": "main", "branch": ["main", "stable-*"],
}, },
{ {
"event": "pull_request", "event": "pull_request",
@@ -1628,10 +1630,6 @@ def dockerRelease(ctx, repo, build_type):
], ],
}, },
"when": [ "when": [
{
"event": ["push", "manual"],
"branch": "main",
},
{ {
"event": "tag", "event": "tag",
}, },
@@ -1642,7 +1640,7 @@ def dockerRelease(ctx, repo, build_type):
"when": [ "when": [
{ {
"event": ["push", "manual"], "event": ["push", "manual"],
"branch": "main", "branch": ["main", "stable-*"],
}, },
{ {
"event": "pull_request", "event": "pull_request",
@@ -1673,7 +1671,15 @@ def binaryRelease(ctx, arch, depends_on = []):
{ {
"name": "build", "name": "build",
"image": OC_CI_GOLANG, "image": OC_CI_GOLANG,
"environment": CI_HTTP_PROXY_ENV, "environment": {
"VERSION": (ctx.build.ref.replace("refs/tags/", "") if ctx.build.event == "tag" else "daily"),
"HTTP_PROXY": {
"from_secret": "ci_http_proxy",
},
"HTTPS_PROXY": {
"from_secret": "ci_http_proxy",
},
},
"commands": [ "commands": [
"make -C opencloud release-%s" % arch, "make -C opencloud release-%s" % arch,
], ],
@@ -1686,10 +1692,6 @@ def binaryRelease(ctx, arch, depends_on = []):
"make -C opencloud release-finish", "make -C opencloud release-finish",
], ],
"when": [ "when": [
{
"event": ["push", "manual"],
"branch": "main",
},
{ {
"event": "tag", "event": "tag",
}, },
@@ -1706,7 +1708,6 @@ def binaryRelease(ctx, arch, depends_on = []):
"opencloud/dist/release/*", "opencloud/dist/release/*",
], ],
"title": ctx.build.ref.replace("refs/tags/v", ""), "title": ctx.build.ref.replace("refs/tags/v", ""),
"overwrite": True,
"prerelease": len(ctx.build.ref.split("-")) > 1, "prerelease": len(ctx.build.ref.split("-")) > 1,
}, },
"when": [ "when": [
@@ -1720,7 +1721,7 @@ def binaryRelease(ctx, arch, depends_on = []):
"when": [ "when": [
{ {
"event": ["push", "manual"], "event": ["push", "manual"],
"branch": "main", "branch": ["main", "stable-*"],
}, },
{ {
"event": "pull_request", "event": "pull_request",
@@ -1786,7 +1787,6 @@ def licenseCheck(ctx):
"third-party-licenses.tar.gz", "third-party-licenses.tar.gz",
], ],
"title": ctx.build.ref.replace("refs/tags/v", ""), "title": ctx.build.ref.replace("refs/tags/v", ""),
"overwrite": True,
"prerelease": len(ctx.build.ref.split("-")) > 1, "prerelease": len(ctx.build.ref.split("-")) > 1,
}, },
"when": [ "when": [
@@ -1799,7 +1799,7 @@ def licenseCheck(ctx):
"when": [ "when": [
{ {
"event": ["push", "manual"], "event": ["push", "manual"],
"branch": "main", "branch": ["main", "stable-*"],
}, },
{ {
"event": "pull_request", "event": "pull_request",
@@ -1824,13 +1824,14 @@ def readyReleaseGo():
"forge_token": { "forge_token": {
"from_secret": "github_token", "from_secret": "github_token",
}, },
"release_branch": branch,
}, },
}, },
], ],
"when": [ "when": [
{ {
"event": ["push", "manual"], "event": ["push", "manual"],
"branch": "main", "branch": ["main", "stable-*"],
}, },
], ],
}] }]
@@ -1872,40 +1873,9 @@ def releaseDockerReadme(repo, build_type):
"event": ["push", "manual"], "event": ["push", "manual"],
"branch": "main", "branch": "main",
}, },
{
"event": "tag",
},
], ],
} }
def docs():
return [
{
"name": "dev-docs",
"steps": [
{
"name": "devdocs",
"image": "codeberg.org/xfix/plugin-codeberg-pages-deploy:1",
"settings": {
"folder": "docs",
"branch": "docs",
"git_config_email": "${CI_COMMIT_AUTHOR_EMAIL}",
"git_config_name": "${CI_COMMIT_AUTHOR}",
"ssh_key": {
"from_secret": "ssh_key",
},
},
},
],
"when": [
{
"event": "push",
"branch": "main",
},
],
},
]
def makeNodeGenerate(module): def makeNodeGenerate(module):
if module == "": if module == "":
make = "make" make = "make"
@@ -1965,7 +1935,7 @@ def notify(ctx):
"when": [ "when": [
{ {
"event": ["push", "manual"], "event": ["push", "manual"],
"branch": ["main", "release-*"], "branch": ["main", "stable-*", "release-*"],
}, },
{ {
"event": "tag", "event": "tag",
@@ -2179,11 +2149,6 @@ def build():
] ]
def skipIfUnchanged(ctx, type): def skipIfUnchanged(ctx, type):
## FIXME: the 'exclude' feature (https://woodpecker-ci.org/docs/usage/workflow-syntax#path) does not seem to provide
# what we need. It seems to skip the build as soon as one of the changed files matches an exclude pattern, we only
# want to skip of ALL changed files match. So skip this condition for now:
return []
if "full-ci" in ctx.build.title.lower() or ctx.build.event == "tag" or ctx.build.event == "cron": if "full-ci" in ctx.build.title.lower() or ctx.build.event == "tag" or ctx.build.event == "cron":
return [] return []
@@ -2390,7 +2355,7 @@ def genericCachePurge(flush_path):
"when": [ "when": [
{ {
"event": ["push", "manual"], "event": ["push", "manual"],
"branch": "main", "branch": ["main", "stable-*"],
}, },
{ {
"event": "pull_request", "event": "pull_request",
@@ -2576,7 +2541,7 @@ def litmus(ctx, storage):
"when": [ "when": [
{ {
"event": ["push", "manual"], "event": ["push", "manual"],
"branch": "main", "branch": ["main", "stable-*"],
}, },
{ {
"event": "pull_request", "event": "pull_request",

View File

@@ -1,16 +0,0 @@
---
when:
- event: ["push", "manual"]
branch: main
steps:
- name: devdocs
image: codeberg.org/xfix/plugin-codeberg-pages-deploy:1
settings:
folder: docs
branch: docs
git_config_email: ${CI_COMMIT_AUTHOR_EMAIL}
git_config_name: ${CI_COMMIT_AUTHOR}
ssh_key:
from_secret: ssh_key

View File

@@ -1,5 +1,34 @@
# Changelog # Changelog
## [2.0.2](https://github.com/opencloud-eu/opencloud/releases/tag/v2.0.2) - 2025-05-02
### ❤️ Thanks to all contributors! ❤️
@ScharfViktor
### 🐛 Bug Fixes
- Abort when the space root has already been created [[#766](https://github.com/opencloud-eu/opencloud/pull/766)]
## [2.0.1](https://github.com/opencloud-eu/opencloud/releases/tag/v2.0.1) - 2025-04-28
### ❤️ Thanks to all contributors! ❤️
@JammingBen, @ScharfViktor, @fschade, @micbar
### 🐛 Bug Fixes
- fix(decomposeds3): enable async-uploads by default (#686) [[#694](https://github.com/opencloud-eu/opencloud/pull/694)]
- fix(antivirus | backport): introduce a default max scan size for the full example deployment [[#620](https://github.com/opencloud-eu/opencloud/pull/620)]
- [full-ci] chore(web): bump web to v2.1.1 [[#638](https://github.com/opencloud-eu/opencloud/pull/638)]
### 📦️ Dependencies
- chore: prepare release, bump version [[#731](https://github.com/opencloud-eu/opencloud/pull/731)]
- Port #567 [[#689](https://github.com/opencloud-eu/opencloud/pull/689)]
- chore: bump reva to v2.29.2 [[#681](https://github.com/opencloud-eu/opencloud/pull/681)]
- build(deps): bump github.com/nats-io/nats-server/v2 [[#683](https://github.com/opencloud-eu/opencloud/pull/683)]
## [2.0.0](https://github.com/opencloud-eu/opencloud/releases/tag/v2.0.0) - 2025-03-26 ## [2.0.0](https://github.com/opencloud-eu/opencloud/releases/tag/v2.0.0) - 2025-03-26
### ❤️ Thanks to all contributors! ❤️ ### ❤️ Thanks to all contributors! ❤️

View File

@@ -1,6 +1,6 @@
![OpenCloud logo](https://raw.githubusercontent.com/opencloud-eu/opencloud/refs/heads/main/opencloud_logo.png) ![OpenCloud logo](https://raw.githubusercontent.com/opencloud-eu/opencloud/refs/heads/main/opencloud_logo.png)
[![status-badge](https://ci.opencloud.eu/api/badges/3/status.svg)](https://ci.opencloud.eu/repos/3) [![status-badge](https://ci.opencloud.eu/api/badges/3/status.svg?branch=stable-2.0)](https://ci.opencloud.eu/repos/3/branches/stable-2.0)
[![Matrix](https://img.shields.io/matrix/opencloud%3Amatrix.org?logo=matrix)](https://app.element.io/#/room/#opencloud:matrix.org) [![Matrix](https://img.shields.io/matrix/opencloud%3Amatrix.org?logo=matrix)](https://app.element.io/#/room/#opencloud:matrix.org)
[![License](https://img.shields.io/badge/License-Apache%202.0-blue.svg)](https://opensource.org/licenses/Apache-2.0) [![License](https://img.shields.io/badge/License-Apache%202.0-blue.svg)](https://opensource.org/licenses/Apache-2.0)

View File

@@ -99,7 +99,7 @@ MINIO_DOMAIN=
#DECOMPOSED=:decomposed.yml #DECOMPOSED=:decomposed.yml
# Define SMPT settings if you would like to send OpenCloud email notifications. # Define SMPT settings if you would like to send OpenCloud email notifications.
# #
# NOTE: when configuring Inbucket, these settings have no effect, see inbucket.yml for details. # NOTE: when configuring Inbucket, these settings have no effect, see inbucket.yml for details.
# SMTP host to connect to. # SMTP host to connect to.
SMTP_HOST= SMTP_HOST=
@@ -210,6 +210,10 @@ COLLABORA_SSL_VERIFICATION=false
# envvar in the OpenCloud Settings above by adding 'antivirus' to the list. # envvar in the OpenCloud Settings above by adding 'antivirus' to the list.
# Note: the leading colon is required to enable the service. # Note: the leading colon is required to enable the service.
#CLAMAV=:clamav.yml #CLAMAV=:clamav.yml
# The maximum scan size the virus scanner can handle, needs adjustment in the scanner config as well.
# Usable common abbreviations: [KB, KiB, MB, MiB, GB, GiB, TB, TiB, PB, PiB, EB, EiB], example: 2GB.
# Defaults to "100MB"
#ANTIVIRUS_MAX_SCAN_SIZE=
# Image version of the ClamAV container. # Image version of the ClamAV container.
# Defaults to "latest" # Defaults to "latest"
CLAMAV_DOCKER_TAG= CLAMAV_DOCKER_TAG=

View File

@@ -4,6 +4,7 @@ services:
environment: environment:
ANTIVIRUS_SCANNER_TYPE: "clamav" ANTIVIRUS_SCANNER_TYPE: "clamav"
ANTIVIRUS_CLAMAV_SOCKET: "/var/run/clamav/clamd.sock" ANTIVIRUS_CLAMAV_SOCKET: "/var/run/clamav/clamd.sock"
ANTIVIRUS_MAX_SCAN_SIZE: ${ANTIVIRUS_MAX_SCAN_SIZE:-100MB}
# the antivirus service needs manual startup, see .env and opencloud.yaml for START_ADDITIONAL_SERVICES # the antivirus service needs manual startup, see .env and opencloud.yaml for START_ADDITIONAL_SERVICES
# configure the antivirus service # configure the antivirus service
POSTPROCESSING_STEPS: "virusscan" POSTPROCESSING_STEPS: "virusscan"

6
go.mod
View File

@@ -55,15 +55,15 @@ require (
github.com/mitchellh/mapstructure v1.5.0 github.com/mitchellh/mapstructure v1.5.0
github.com/mna/pigeon v1.3.0 github.com/mna/pigeon v1.3.0
github.com/mohae/deepcopy v0.0.0-20170929034955-c48cc78d4826 github.com/mohae/deepcopy v0.0.0-20170929034955-c48cc78d4826
github.com/nats-io/nats-server/v2 v2.11.0 github.com/nats-io/nats-server/v2 v2.11.1
github.com/nats-io/nats.go v1.39.1 github.com/nats-io/nats.go v1.41.0
github.com/oklog/run v1.1.0 github.com/oklog/run v1.1.0
github.com/olekukonko/tablewriter v0.0.5 github.com/olekukonko/tablewriter v0.0.5
github.com/onsi/ginkgo v1.16.5 github.com/onsi/ginkgo v1.16.5
github.com/onsi/ginkgo/v2 v2.23.3 github.com/onsi/ginkgo/v2 v2.23.3
github.com/onsi/gomega v1.36.3 github.com/onsi/gomega v1.36.3
github.com/open-policy-agent/opa v1.2.0 github.com/open-policy-agent/opa v1.2.0
github.com/opencloud-eu/reva/v2 v2.29.1 github.com/opencloud-eu/reva/v2 v2.29.3
github.com/orcaman/concurrent-map v1.0.0 github.com/orcaman/concurrent-map v1.0.0
github.com/owncloud/libre-graph-api-go v1.0.5-0.20240829135935-80dc00d6f5ea github.com/owncloud/libre-graph-api-go v1.0.5-0.20240829135935-80dc00d6f5ea
github.com/pkg/errors v0.9.1 github.com/pkg/errors v0.9.1

12
go.sum
View File

@@ -827,10 +827,10 @@ github.com/mwitkow/go-conntrack v0.0.0-20190716064945-2f068394615f/go.mod h1:qRW
github.com/namedotcom/go v0.0.0-20180403034216-08470befbe04/go.mod h1:5sN+Lt1CaY4wsPvgQH/jsuJi4XO2ssZbdsIizr4CVC8= github.com/namedotcom/go v0.0.0-20180403034216-08470befbe04/go.mod h1:5sN+Lt1CaY4wsPvgQH/jsuJi4XO2ssZbdsIizr4CVC8=
github.com/nats-io/jwt/v2 v2.7.3 h1:6bNPK+FXgBeAqdj4cYQ0F8ViHRbi7woQLq4W29nUAzE= github.com/nats-io/jwt/v2 v2.7.3 h1:6bNPK+FXgBeAqdj4cYQ0F8ViHRbi7woQLq4W29nUAzE=
github.com/nats-io/jwt/v2 v2.7.3/go.mod h1:GvkcbHhKquj3pkioy5put1wvPxs78UlZ7D/pY+BgZk4= github.com/nats-io/jwt/v2 v2.7.3/go.mod h1:GvkcbHhKquj3pkioy5put1wvPxs78UlZ7D/pY+BgZk4=
github.com/nats-io/nats-server/v2 v2.11.0 h1:fdwAT1d6DZW/4LUz5rkvQUe5leGEwjjOQYntzVRKvjE= github.com/nats-io/nats-server/v2 v2.11.1 h1:LwdauqMqMNhTxTN3+WFTX6wGDOKntHljgZ+7gL5HCnk=
github.com/nats-io/nats-server/v2 v2.11.0/go.mod h1:leXySghbdtXSUmWem8K9McnJ6xbJOb0t9+NQ5HTRZjI= github.com/nats-io/nats-server/v2 v2.11.1/go.mod h1:leXySghbdtXSUmWem8K9McnJ6xbJOb0t9+NQ5HTRZjI=
github.com/nats-io/nats.go v1.39.1 h1:oTkfKBmz7W047vRxV762M67ZdXeOtUgvbBaNoQ+3PPk= github.com/nats-io/nats.go v1.41.0 h1:PzxEva7fflkd+n87OtQTXqCTyLfIIMFJBpyccHLE2Ko=
github.com/nats-io/nats.go v1.39.1/go.mod h1:MgRb8oOdigA6cYpEPhXJuRVH6UE/V4jblJ2jQ27IXYM= github.com/nats-io/nats.go v1.41.0/go.mod h1:wV73x0FSI/orHPSYoyMeJB+KajMDoWyXmFaRrrYaaTo=
github.com/nats-io/nkeys v0.4.10 h1:glmRrpCmYLHByYcePvnTBEAwawwapjCPMjy2huw20wc= github.com/nats-io/nkeys v0.4.10 h1:glmRrpCmYLHByYcePvnTBEAwawwapjCPMjy2huw20wc=
github.com/nats-io/nkeys v0.4.10/go.mod h1:OjRrnIKnWBFl+s4YK5ChQfvHP2fxqZexrKJoVVyWB3U= github.com/nats-io/nkeys v0.4.10/go.mod h1:OjRrnIKnWBFl+s4YK5ChQfvHP2fxqZexrKJoVVyWB3U=
github.com/nats-io/nuid v1.0.1 h1:5iA8DT8V7q8WK2EScv2padNa/rTESc1KdnPw4TC2paw= github.com/nats-io/nuid v1.0.1 h1:5iA8DT8V7q8WK2EScv2padNa/rTESc1KdnPw4TC2paw=
@@ -865,8 +865,8 @@ github.com/onsi/gomega v1.36.3 h1:hID7cr8t3Wp26+cYnfcjR6HpJ00fdogN6dqZ1t6IylU=
github.com/onsi/gomega v1.36.3/go.mod h1:8D9+Txp43QWKhM24yyOBEdpkzN8FvJyAwecBgsU4KU0= github.com/onsi/gomega v1.36.3/go.mod h1:8D9+Txp43QWKhM24yyOBEdpkzN8FvJyAwecBgsU4KU0=
github.com/open-policy-agent/opa v1.2.0 h1:88NDVCM0of1eO6Z4AFeL3utTEtMuwloFmWWU7dRV1z0= github.com/open-policy-agent/opa v1.2.0 h1:88NDVCM0of1eO6Z4AFeL3utTEtMuwloFmWWU7dRV1z0=
github.com/open-policy-agent/opa v1.2.0/go.mod h1:30euUmOvuBoebRCcJ7DMF42bRBOPznvt0ACUMYDUGVY= github.com/open-policy-agent/opa v1.2.0/go.mod h1:30euUmOvuBoebRCcJ7DMF42bRBOPznvt0ACUMYDUGVY=
github.com/opencloud-eu/reva/v2 v2.29.1 h1:SgB2zn8d/3UWwFiJ0pUs85aDKJJ36JoKnyRM+iW+VoI= github.com/opencloud-eu/reva/v2 v2.29.3 h1:y0vfye984kOIB9nib4LkN3wEnJ2vR0/1CKoVcIRQ7JI=
github.com/opencloud-eu/reva/v2 v2.29.1/go.mod h1:+nkCU7w6E6cyNSsKRYj1rb0cCI7QswEQ7KOPljctebM= github.com/opencloud-eu/reva/v2 v2.29.3/go.mod h1:+nkCU7w6E6cyNSsKRYj1rb0cCI7QswEQ7KOPljctebM=
github.com/opentracing/opentracing-go v1.1.0/go.mod h1:UkNAQd3GIcIGf0SeVgPpRdFStlNbqXla1AfSYxPUl2o= github.com/opentracing/opentracing-go v1.1.0/go.mod h1:UkNAQd3GIcIGf0SeVgPpRdFStlNbqXla1AfSYxPUl2o=
github.com/opentracing/opentracing-go v1.2.0 h1:uEJPy/1a5RIPAJ0Ov+OIO8OxWu77jEv+1B0VhjKrZUs= github.com/opentracing/opentracing-go v1.2.0 h1:uEJPy/1a5RIPAJ0Ov+OIO8OxWu77jEv+1B0VhjKrZUs=
github.com/opentracing/opentracing-go v1.2.0/go.mod h1:GxEUsuufX4nBwe+T+Wl9TAgYrxe9dPLANfrWvHYVTgc= github.com/opentracing/opentracing-go v1.2.0/go.mod h1:GxEUsuufX4nBwe+T+Wl9TAgYrxe9dPLANfrWvHYVTgc=

View File

@@ -16,7 +16,7 @@ var (
// LatestTag is the latest released version plus the dev meta version. // LatestTag is the latest released version plus the dev meta version.
// Will be overwritten by the release pipeline // Will be overwritten by the release pipeline
// Needs a manual change for every tagged release // Needs a manual change for every tagged release
LatestTag = "1.1.0+dev" LatestTag = "2.0.1+dev"
// Date indicates the build date. // Date indicates the build date.
// This has been removed, it looks like you can only replace static strings with recent go versions // This has been removed, it looks like you can only replace static strings with recent go versions

View File

@@ -1,49 +1,124 @@
export default { export default {
changeTypes: [ changeTypes: [
{ {
title: '💥 Breaking changes', title: "💥 Breaking changes",
labels: ['breaking', 'Type:Breaking-Change'], labels: ["breaking", "Type:Breaking-Change"],
bump: 'major', bump: "major",
weight: 3 weight: 3,
}, },
{ {
title: '🔒 Security', title: "🔒 Security",
labels: ['security', 'Type:Security'], labels: ["security", "Type:Security"],
bump: 'patch', bump: "patch",
weight: 2 weight: 2,
}, },
{ {
title: '✨ Features', title: "✨ Features",
labels: ['feature', 'Type:Feature'], labels: ["feature", "Type:Feature"],
bump: 'minor', bump: "minor",
weight: 1 weight: 1,
}, },
{ {
title: '📈 Enhancement', title: "📈 Enhancement",
labels: ['enhancement', 'refactor', 'Type:Enhancement'], labels: ["enhancement", "refactor", "Type:Enhancement"],
bump: 'minor' bump: "minor",
}, },
{ {
title: '🐛 Bug Fixes', title: "🐛 Bug Fixes",
labels: ['bug', 'Type:Bug'], labels: ["bug", "Type:Bug"],
bump: 'patch' bump: "patch",
}, },
{ {
title: '📚 Documentation', title: "📚 Documentation",
labels: ['docs', 'documentation', 'Type:Documentation'], labels: ["docs", "documentation", "Type:Documentation"],
bump: 'patch' bump: "patch",
}, },
{ {
title: '✅ Tests', title: "✅ Tests",
labels: ['test', 'tests', 'Type:Test'], labels: ["test", "tests", "Type:Test"],
bump: 'patch' bump: "patch",
}, },
{ {
title: '📦️ Dependencies', title: "📦️ Dependencies",
labels: ['dependency', 'dependencies', 'Type:Dependencies'], labels: ["dependency", "dependencies", "Type:Dependencies"],
bump: 'patch', bump: "patch",
weight: -1 weight: -1,
} },
], ],
useVersionPrefixV: true, useVersionPrefixV: true,
} getLatestTag: ({ exec }) => {
// the plugin uses the latest tag to determine the next version
// and the changes that are included in the upcoming release.
const branch = getBranch(exec);
let tags = getTags(exec);
if (branch.startsWith("stable-")) {
const [_, majorAndMinor] = branch.split("-");
// we only care about tags that are within the range of the current stable branch.
// e.g. if the branch is stable-1.2, we only care about tags that are v1.2.x.
const matchingTags = tags.filter((t) =>
t.startsWith(`v${majorAndMinor}`)
);
if (matchingTags.length) {
tags = matchingTags;
}
}
return tags.pop() || "v0.0.0";
},
useLatestRelease: ({ exec, nextVersion }) => {
// check if the release should be marked as latest release on GitHub.
const tags = getTags(exec);
const latestTag = tags.pop() || "v0.0.0";
return compareVersions(latestTag, nextVersion) === -1;
},
};
const parseVersion = (tag: string) => {
const version = tag.startsWith("v") ? tag.slice(1) : tag;
const [main, pre] = version.split("-");
const [major, minor, patch] = main.split(".").map(Number);
return { major, minor, patch, pre };
};
const getBranch = (exec: any): string => {
return exec("git rev-parse --abbrev-ref HEAD", {
silent: true,
}).stdout.trim();
};
const getTags = (exec: any) => {
exec("git fetch --tags", { silent: true });
const tagsOutput = exec("git tag", { silent: true }).stdout.trim();
const tags: string[] = tagsOutput ? tagsOutput.split("\n") : [];
return tags.filter((tag) => tag.startsWith("v")).sort(compareVersions);
};
const compareVersions = (a: string, b: string) => {
const va = parseVersion(a);
const vb = parseVersion(b);
if (va.major !== vb.major) {
return va.major - vb.major;
}
if (va.minor !== vb.minor) {
return va.minor - vb.minor;
}
if (va.patch !== vb.patch) {
return va.patch - vb.patch;
}
if (va.pre && !vb.pre) {
return -1;
}
if (!va.pre && vb.pre) {
return 1;
}
if (va.pre && vb.pre) {
return va.pre.localeCompare(vb.pre);
}
return 0;
};

View File

@@ -4,7 +4,10 @@ The `antivirus` service is responsible for scanning files for viruses.
## Memory Considerations ## Memory Considerations
The antivirus service can consume considerably amounts of memory. This is relevant to provide or define sufficient memory for the deployment selected. To avoid out of memory (OOM) situations, the following equation gives a rough overview based on experiences made. The memory calculation comes without any guarantee, is intended as overview only and subject of change. The antivirus service can consume considerable amounts of memory.
This is relevant to provide or define sufficient memory for the deployment selected.
To avoid out of memory (OOM) situations, the following equation gives a rough overview based on experiences made.
The memory calculation comes without any guarantee, is intended as overview only and subject of change.
`memory limit` = `max file size` x `workers` x `factor 8 - 14` `memory limit` = `max file size` x `workers` x `factor 8 - 14`
@@ -19,17 +22,25 @@ With:
### Antivirus Scanner Type ### Antivirus Scanner Type
The antivirus service currently supports [ICAP](https://tools.ietf.org/html/rfc3507) and [ClamAV](http://www.clamav.net/index.html) as antivirus scanners. The `ANTIVIRUS_SCANNER_TYPE` environment variable is used to select the scanner. The detailed configuration for each scanner heavily depends on the scanner type selected. See the environment variables for more details. The antivirus service currently supports [ICAP](https://tools.ietf.org/html/rfc3507) and [ClamAV](http://www.clamav.net/index.html) as antivirus scanners.
The `ANTIVIRUS_SCANNER_TYPE` environment variable is used to select the scanner.
The detailed configuration for each scanner heavily depends on the scanner type selected.
See the environment variables for more details.
- For `icap`, only scanners using the `X-Infection-Found` header are currently supported. - For `icap`, only scanners using the `X-Infection-Found` header are currently supported.
- For `clamav` only local sockets can currently be configured. - For `clamav` only local sockets can currently be configured.
### Maximum Scan Size ### Maximum Scan Size
Several factors can make it necessary to limit the maximum filesize the antivirus service will use for scanning. Use the `ANTIVIRUS_MAX_SCAN_SIZE` environment variable to scan only a given amount of bytes. Obviously, it is recommended to scan the whole file, but several factors like scanner type and version, bandwidth, performance issues, etc. might make a limit necessary. Several factors can make it necessary to limit the maximum filesize the antivirus service uses for scanning.
Use the `ANTIVIRUS_MAX_SCAN_SIZE` environment variable to specify the maximum file size to be scanned.
Even if it's recommended to scan each file, several factors like scanner type and version,
bandwidth, performance issues, etc. might make a limit necessary.
**IMPORTANT** **IMPORTANT**
> Streaming of files to the virus scan service still [needs to be implemented](https://github.com/owncloud/ocis/issues/6803). To prevent OOM errors `ANTIVIRUS_MAX_SCAN_SIZE` needs to be set lower than available ram. > Streaming of files to the virus scan service still [needs to be implemented](https://github.com/owncloud/ocis/issues/6803).
> To prevent OOM errors `ANTIVIRUS_MAX_SCAN_SIZE` needs to be set lower than available ram and or the maximum file size that can be scanned by the virus scanner.
### Antivirus Workers ### Antivirus Workers
@@ -41,7 +52,7 @@ The antivirus service allows three different ways of handling infected files. Th
- `delete`: (default): Infected files will be deleted immediately, further postprocessing is cancelled. - `delete`: (default): Infected files will be deleted immediately, further postprocessing is cancelled.
- `abort`: (advanced option): Infected files will be kept, further postprocessing is cancelled. Files can be manually retrieved and inspected by an admin. To identify the file for further investigation, the antivirus service logs the abort/infected state including the file ID. The file is located in the `storage/users/uploads` folder of the OpenCloud data directory and persists until it is manually deleted by the admin via the [Manage Unfinished Uploads](https://github.com/opencloud-eu/opencloud/tree/main/services/storage-users#manage-unfinished-uploads) command. - `abort`: (advanced option): Infected files will be kept, further postprocessing is cancelled. Files can be manually retrieved and inspected by an admin. To identify the file for further investigation, the antivirus service logs the abort/infected state including the file ID. The file is located in the `storage/users/uploads` folder of the OpenCloud data directory and persists until it is manually deleted by the admin via the [Manage Unfinished Uploads](https://github.com/opencloud-eu/opencloud/tree/main/services/storage-users#manage-unfinished-uploads) command.
- `continue`: (obviously not recommended): Infected files will be marked via metadata as infected but postprocessing continues normally. Note: Infected Files are moved to their final destination and therefore not prevented from download which includes the risk of spreading viruses. - `continue`: (not recommended): Infected files will be marked via metadata as infected, but postprocessing continues normally. Note: Infected Files are moved to their final destination and therefore not prevented from download, which includes the risk of spreading viruses.
In all cases, a log entry is added declaring the infection and handling method and a notification via the `userlog` service sent. In all cases, a log entry is added declaring the infection and handling method and a notification via the `userlog` service sent.

View File

@@ -21,7 +21,7 @@ type Config struct {
Workers int `yaml:"workers" env:"ANTIVIRUS_WORKERS" desc:"The number of concurrent go routines that fetch events from the event queue." introductionVersion:"1.0.0"` Workers int `yaml:"workers" env:"ANTIVIRUS_WORKERS" desc:"The number of concurrent go routines that fetch events from the event queue." introductionVersion:"1.0.0"`
Scanner Scanner Scanner Scanner
MaxScanSize string `yaml:"max-scan-size" env:"ANTIVIRUS_MAX_SCAN_SIZE" desc:"The maximum scan size the virus scanner can handle. Only this many bytes of a file will be scanned. 0 means unlimited and is the default. Usable common abbreviations: [KB, KiB, MB, MiB, GB, GiB, TB, TiB, PB, PiB, EB, EiB], example: 2GB." introductionVersion:"1.0.0"` MaxScanSize string `yaml:"max-scan-size" env:"ANTIVIRUS_MAX_SCAN_SIZE" desc:"The maximum scan size the virus scanner can handle. 0 means unlimited. Usable common abbreviations: [KB, KiB, MB, MiB, GB, GiB, TB, TiB, PB, PiB, EB, EiB], example: 2GB." introductionVersion:"1.0.0"`
Context context.Context `json:"-" yaml:"-"` Context context.Context `json:"-" yaml:"-"`

View File

@@ -123,6 +123,7 @@ func DefaultConfig() *config.Config {
MaxConcurrency: 5, MaxConcurrency: 5,
LockCycleDurationFactor: 30, LockCycleDurationFactor: 30,
DisableMultipart: true, DisableMultipart: true,
AsyncUploads: true,
}, },
Decomposed: config.DecomposedDriver{ Decomposed: config.DecomposedDriver{
Propagator: "sync", Propagator: "sync",

View File

@@ -1,6 +1,6 @@
SHELL := bash SHELL := bash
NAME := web NAME := web
WEB_ASSETS_VERSION = v2.1.0 WEB_ASSETS_VERSION = v2.1.1
WEB_ASSETS_BRANCH = main WEB_ASSETS_BRANCH = main
ifneq (, $(shell command -v go 2> /dev/null)) # suppress `command not found warnings` for non go targets in CI ifneq (, $(shell command -v go 2> /dev/null)) # suppress `command not found warnings` for non go targets in CI

View File

@@ -58,7 +58,7 @@ func init() {
const ( const (
// VERSION is the current version for the server. // VERSION is the current version for the server.
VERSION = "2.11.0" VERSION = "2.11.1"
// PROTO is the currently supported protocol. // PROTO is the currently supported protocol.
// 0 was the original // 0 was the original

View File

@@ -2315,7 +2315,7 @@ func (js *jetStream) checkBytesLimits(selectedLimits *JetStreamAccountLimits, ad
return NewJSMemoryResourcesExceededError() return NewJSMemoryResourcesExceededError()
} }
// Check if this server can handle request. // Check if this server can handle request.
if checkServer && js.memReserved+addBytes > js.config.MaxMemory { if checkServer && js.memReserved+totalBytes > js.config.MaxMemory {
return NewJSMemoryResourcesExceededError() return NewJSMemoryResourcesExceededError()
} }
case FileStorage: case FileStorage:
@@ -2324,7 +2324,7 @@ func (js *jetStream) checkBytesLimits(selectedLimits *JetStreamAccountLimits, ad
return NewJSStorageResourcesExceededError() return NewJSStorageResourcesExceededError()
} }
// Check if this server can handle request. // Check if this server can handle request.
if checkServer && js.storeReserved+addBytes > js.config.MaxStore { if checkServer && js.storeReserved+totalBytes > js.config.MaxStore {
return NewJSStorageResourcesExceededError() return NewJSStorageResourcesExceededError()
} }
} }

View File

@@ -2526,6 +2526,9 @@ func (s *Server) jsLeaderServerRemoveRequest(sub *subscription, c *client, _ *Ac
s.Warnf(badAPIRequestT, msg) s.Warnf(badAPIRequestT, msg)
return return
} }
if acc != s.SystemAccount() {
return
}
js, cc := s.getJetStreamCluster() js, cc := s.getJetStreamCluster()
if js == nil || cc == nil || cc.meta == nil { if js == nil || cc == nil || cc.meta == nil {
@@ -2650,6 +2653,10 @@ func (s *Server) jsLeaderServerStreamMoveRequest(sub *subscription, c *client, _
accName := tokenAt(subject, 6) accName := tokenAt(subject, 6)
streamName := tokenAt(subject, 7) streamName := tokenAt(subject, 7)
if acc.GetName() != accName && acc != s.SystemAccount() {
return
}
var resp = JSApiStreamUpdateResponse{ApiResponse: ApiResponse{Type: JSApiStreamUpdateResponseType}} var resp = JSApiStreamUpdateResponse{ApiResponse: ApiResponse{Type: JSApiStreamUpdateResponseType}}
var req JSApiMetaServerStreamMoveRequest var req JSApiMetaServerStreamMoveRequest
@@ -2807,6 +2814,10 @@ func (s *Server) jsLeaderServerStreamCancelMoveRequest(sub *subscription, c *cli
accName := tokenAt(subject, 6) accName := tokenAt(subject, 6)
streamName := tokenAt(subject, 7) streamName := tokenAt(subject, 7)
if acc.GetName() != accName && acc != s.SystemAccount() {
return
}
targetAcc, ok := s.accounts.Load(accName) targetAcc, ok := s.accounts.Load(accName)
if !ok { if !ok {
resp.Error = NewJSNoAccountError() resp.Error = NewJSNoAccountError()
@@ -2893,6 +2904,9 @@ func (s *Server) jsLeaderAccountPurgeRequest(sub *subscription, c *client, _ *Ac
s.Warnf(badAPIRequestT, msg) s.Warnf(badAPIRequestT, msg)
return return
} }
if acc != s.SystemAccount() {
return
}
js := s.getJetStream() js := s.getJetStream()
if js == nil { if js == nil {

View File

@@ -6303,6 +6303,10 @@ func (a *Account) RestoreStream(ncfg *StreamConfig, r io.Reader) (*stream, error
if err != nil { if err != nil {
return nil, err return nil, err
} }
js := jsa.js
if js == nil {
return nil, NewJSNotEnabledForAccountError()
}
cfg, apiErr := s.checkStreamCfg(ncfg, a, false) cfg, apiErr := s.checkStreamCfg(ncfg, a, false)
if apiErr != nil { if apiErr != nil {
@@ -6337,6 +6341,22 @@ func (a *Account) RestoreStream(ncfg *StreamConfig, r io.Reader) (*stream, error
} }
sdirCheck := filepath.Clean(sdir) + string(os.PathSeparator) sdirCheck := filepath.Clean(sdir) + string(os.PathSeparator)
_, isClustered := jsa.jetStreamAndClustered()
jsa.usageMu.RLock()
selected, tier, hasTier := jsa.selectLimits(cfg.Replicas)
jsa.usageMu.RUnlock()
reserved := int64(0)
if hasTier {
if isClustered {
js.mu.RLock()
_, reserved = tieredStreamAndReservationCount(js.cluster.streams[a.Name], tier, &cfg)
js.mu.RUnlock()
} else {
reserved = jsa.tieredReservation(tier, &cfg)
}
}
var bc int64
tr := tar.NewReader(s2.NewReader(r)) tr := tar.NewReader(s2.NewReader(r))
for { for {
hdr, err := tr.Next() hdr, err := tr.Next()
@@ -6349,6 +6369,13 @@ func (a *Account) RestoreStream(ncfg *StreamConfig, r io.Reader) (*stream, error
if hdr.Typeflag != tar.TypeReg { if hdr.Typeflag != tar.TypeReg {
return nil, logAndReturnError() return nil, logAndReturnError()
} }
bc += hdr.Size
js.mu.RLock()
err = js.checkAllLimits(&selected, &cfg, reserved, bc)
js.mu.RUnlock()
if err != nil {
return nil, err
}
fpath := filepath.Join(sdir, filepath.Clean(hdr.Name)) fpath := filepath.Join(sdir, filepath.Clean(hdr.Name))
if !strings.HasPrefix(fpath, sdirCheck) { if !strings.HasPrefix(fpath, sdirCheck) {
return nil, logAndReturnError() return nil, logAndReturnError()

View File

@@ -23,7 +23,7 @@ A [Go](http://golang.org) client for the [NATS messaging system](https://nats.io
go get github.com/nats-io/nats.go@latest go get github.com/nats-io/nats.go@latest
# To get a specific version: # To get a specific version:
go get github.com/nats-io/nats.go@v1.39.1 go get github.com/nats-io/nats.go@v1.41.0
# Note that the latest major version for NATS Server is v2: # Note that the latest major version for NATS Server is v2:
go get github.com/nats-io/nats-server/v2@latest go get github.com/nats-io/nats-server/v2@latest

View File

@@ -1,23 +1,24 @@
module github.com/nats-io/nats.go module github.com/nats-io/nats.go
go 1.22.0 go 1.23.0
require ( require (
github.com/golang/protobuf v1.4.2 github.com/golang/protobuf v1.4.2
github.com/klauspost/compress v1.17.11 github.com/klauspost/compress v1.18.0
github.com/nats-io/jwt v1.2.2 github.com/nats-io/jwt v1.2.2
github.com/nats-io/nats-server/v2 v2.10.24 github.com/nats-io/nats-server/v2 v2.11.0
github.com/nats-io/nkeys v0.4.9 github.com/nats-io/nkeys v0.4.10
github.com/nats-io/nuid v1.0.1 github.com/nats-io/nuid v1.0.1
go.uber.org/goleak v1.3.0 go.uber.org/goleak v1.3.0
golang.org/x/text v0.21.0 golang.org/x/text v0.23.0
google.golang.org/protobuf v1.23.0 google.golang.org/protobuf v1.23.0
) )
require ( require (
github.com/google/go-tpm v0.9.3 // indirect
github.com/minio/highwayhash v1.0.3 // indirect github.com/minio/highwayhash v1.0.3 // indirect
github.com/nats-io/jwt/v2 v2.7.3 // indirect github.com/nats-io/jwt/v2 v2.7.3 // indirect
golang.org/x/crypto v0.31.0 // indirect golang.org/x/crypto v0.36.0 // indirect
golang.org/x/sys v0.28.0 // indirect golang.org/x/sys v0.31.0 // indirect
golang.org/x/time v0.8.0 // indirect golang.org/x/time v0.11.0 // indirect
) )

View File

@@ -1,3 +1,5 @@
github.com/antithesishq/antithesis-sdk-go v0.4.3-default-no-op h1:+OSa/t11TFhqfrX0EOSqQBDJ0YlpmK0rDSiB19dg9M0=
github.com/antithesishq/antithesis-sdk-go v0.4.3-default-no-op/go.mod h1:IUpT2DPAKh6i/YhSbt6Gl3v2yvUZjmKncl7U91fup7E=
github.com/davecgh/go-spew v1.1.1 h1:vj9j/u1bqnvCEfJOwUhtlOARqs3+rkHYY13jYWTU97c= github.com/davecgh/go-spew v1.1.1 h1:vj9j/u1bqnvCEfJOwUhtlOARqs3+rkHYY13jYWTU97c=
github.com/davecgh/go-spew v1.1.1/go.mod h1:J7Y8YcW2NihsgmVo/mv3lAwl/skON4iLHjSsI+c5H38= github.com/davecgh/go-spew v1.1.1/go.mod h1:J7Y8YcW2NihsgmVo/mv3lAwl/skON4iLHjSsI+c5H38=
github.com/golang/protobuf v1.4.0-rc.1/go.mod h1:ceaxUfeHdC40wWswd/P6IGgMaK3YpKi5j83Wpe3EHw8= github.com/golang/protobuf v1.4.0-rc.1/go.mod h1:ceaxUfeHdC40wWswd/P6IGgMaK3YpKi5j83Wpe3EHw8=
@@ -9,21 +11,24 @@ github.com/golang/protobuf v1.4.2 h1:+Z5KGCizgyZCbGh1KZqA0fcLLkwbsjIzS4aV2v7wJX0
github.com/golang/protobuf v1.4.2/go.mod h1:oDoupMAO8OvCJWAcko0GGGIgR6R6ocIYbsSw735rRwI= github.com/golang/protobuf v1.4.2/go.mod h1:oDoupMAO8OvCJWAcko0GGGIgR6R6ocIYbsSw735rRwI=
github.com/google/go-cmp v0.3.0/go.mod h1:8QqcDgzrUqlUb/G2PQTWiueGozuR1884gddMywk6iLU= github.com/google/go-cmp v0.3.0/go.mod h1:8QqcDgzrUqlUb/G2PQTWiueGozuR1884gddMywk6iLU=
github.com/google/go-cmp v0.3.1/go.mod h1:8QqcDgzrUqlUb/G2PQTWiueGozuR1884gddMywk6iLU= github.com/google/go-cmp v0.3.1/go.mod h1:8QqcDgzrUqlUb/G2PQTWiueGozuR1884gddMywk6iLU=
github.com/google/go-cmp v0.4.0 h1:xsAVV57WRhGj6kEIi8ReJzQlHHqcBYCElAvkovg3B/4=
github.com/google/go-cmp v0.4.0/go.mod h1:v8dTdLbMG2kIc/vJvl+f65V22dbkXbowE6jgT/gNBxE= github.com/google/go-cmp v0.4.0/go.mod h1:v8dTdLbMG2kIc/vJvl+f65V22dbkXbowE6jgT/gNBxE=
github.com/klauspost/compress v1.17.11 h1:In6xLpyWOi1+C7tXUUWv2ot1QvBjxevKAaI6IXrJmUc= github.com/google/go-cmp v0.5.9 h1:O2Tfq5qg4qc4AmwVlvv0oLiVAGB7enBSJ2x2DqQFi38=
github.com/klauspost/compress v1.17.11/go.mod h1:pMDklpSncoRMuLFrf1W9Ss9KT+0rH90U12bZKk7uwG0= github.com/google/go-cmp v0.5.9/go.mod h1:17dUlkBOakJ0+DkrSSNjCkIjxS6bF9zb3elmeNGIjoY=
github.com/google/go-tpm v0.9.3 h1:+yx0/anQuGzi+ssRqeD6WpXjW2L/V0dItUayO0i9sRc=
github.com/google/go-tpm v0.9.3/go.mod h1:h9jEsEECg7gtLis0upRBQU+GhYVH6jMjrFxI8u6bVUY=
github.com/klauspost/compress v1.18.0 h1:c/Cqfb0r+Yi+JtIEq73FWXVkRonBlf0CRNYc8Zttxdo=
github.com/klauspost/compress v1.18.0/go.mod h1:2Pp+KzxcywXVXMr50+X0Q/Lsb43OQHYWRCY2AiWywWQ=
github.com/minio/highwayhash v1.0.3 h1:kbnuUMoHYyVl7szWjSxJnxw11k2U709jqFPPmIUyD6Q= github.com/minio/highwayhash v1.0.3 h1:kbnuUMoHYyVl7szWjSxJnxw11k2U709jqFPPmIUyD6Q=
github.com/minio/highwayhash v1.0.3/go.mod h1:GGYsuwP/fPD6Y9hMiXuapVvlIUEhFhMTh0rxU3ik1LQ= github.com/minio/highwayhash v1.0.3/go.mod h1:GGYsuwP/fPD6Y9hMiXuapVvlIUEhFhMTh0rxU3ik1LQ=
github.com/nats-io/jwt v1.2.2 h1:w3GMTO969dFg+UOKTmmyuu7IGdusK+7Ytlt//OYH/uU= github.com/nats-io/jwt v1.2.2 h1:w3GMTO969dFg+UOKTmmyuu7IGdusK+7Ytlt//OYH/uU=
github.com/nats-io/jwt v1.2.2/go.mod h1:/xX356yQA6LuXI9xWW7mZNpxgF2mBmGecH+Fj34sP5Q= github.com/nats-io/jwt v1.2.2/go.mod h1:/xX356yQA6LuXI9xWW7mZNpxgF2mBmGecH+Fj34sP5Q=
github.com/nats-io/jwt/v2 v2.7.3 h1:6bNPK+FXgBeAqdj4cYQ0F8ViHRbi7woQLq4W29nUAzE= github.com/nats-io/jwt/v2 v2.7.3 h1:6bNPK+FXgBeAqdj4cYQ0F8ViHRbi7woQLq4W29nUAzE=
github.com/nats-io/jwt/v2 v2.7.3/go.mod h1:GvkcbHhKquj3pkioy5put1wvPxs78UlZ7D/pY+BgZk4= github.com/nats-io/jwt/v2 v2.7.3/go.mod h1:GvkcbHhKquj3pkioy5put1wvPxs78UlZ7D/pY+BgZk4=
github.com/nats-io/nats-server/v2 v2.10.24 h1:KcqqQAD0ZZcG4yLxtvSFJY7CYKVYlnlWoAiVZ6i/IY4= github.com/nats-io/nats-server/v2 v2.11.0 h1:fdwAT1d6DZW/4LUz5rkvQUe5leGEwjjOQYntzVRKvjE=
github.com/nats-io/nats-server/v2 v2.10.24/go.mod h1:olvKt8E5ZlnjyqBGbAXtxvSQKsPodISK5Eo/euIta4s= github.com/nats-io/nats-server/v2 v2.11.0/go.mod h1:leXySghbdtXSUmWem8K9McnJ6xbJOb0t9+NQ5HTRZjI=
github.com/nats-io/nkeys v0.2.0/go.mod h1:XdZpAbhgyyODYqjTawOnIOI7VlbKSarI9Gfy1tqEu/s= github.com/nats-io/nkeys v0.2.0/go.mod h1:XdZpAbhgyyODYqjTawOnIOI7VlbKSarI9Gfy1tqEu/s=
github.com/nats-io/nkeys v0.4.9 h1:qe9Faq2Gxwi6RZnZMXfmGMZkg3afLLOtrU+gDZJ35b0= github.com/nats-io/nkeys v0.4.10 h1:glmRrpCmYLHByYcePvnTBEAwawwapjCPMjy2huw20wc=
github.com/nats-io/nkeys v0.4.9/go.mod h1:jcMqs+FLG+W5YO36OX6wFIFcmpdAns+w1Wm6D3I/evE= github.com/nats-io/nkeys v0.4.10/go.mod h1:OjRrnIKnWBFl+s4YK5ChQfvHP2fxqZexrKJoVVyWB3U=
github.com/nats-io/nuid v1.0.1 h1:5iA8DT8V7q8WK2EScv2padNa/rTESc1KdnPw4TC2paw= github.com/nats-io/nuid v1.0.1 h1:5iA8DT8V7q8WK2EScv2padNa/rTESc1KdnPw4TC2paw=
github.com/nats-io/nuid v1.0.1/go.mod h1:19wcPz3Ph3q0Jbyiqsd0kePYG7A95tJPxeL+1OSON2c= github.com/nats-io/nuid v1.0.1/go.mod h1:19wcPz3Ph3q0Jbyiqsd0kePYG7A95tJPxeL+1OSON2c=
github.com/pmezard/go-difflib v1.0.0 h1:4DBwDE0NGyQoBHbLQYPwSUPoCMWR5BEzIk/f1lZbAQM= github.com/pmezard/go-difflib v1.0.0 h1:4DBwDE0NGyQoBHbLQYPwSUPoCMWR5BEzIk/f1lZbAQM=
@@ -34,20 +39,19 @@ go.uber.org/goleak v1.3.0 h1:2K3zAYmnTNqV73imy9J1T3WC+gmCePx2hEGkimedGto=
go.uber.org/goleak v1.3.0/go.mod h1:CoHD4mav9JJNrW/WLlf7HGZPjdw8EucARQHekz1X6bE= go.uber.org/goleak v1.3.0/go.mod h1:CoHD4mav9JJNrW/WLlf7HGZPjdw8EucARQHekz1X6bE=
golang.org/x/crypto v0.0.0-20190308221718-c2843e01d9a2/go.mod h1:djNgcEr1/C05ACkg1iLfiJU5Ep61QUkGW8qpdssI0+w= golang.org/x/crypto v0.0.0-20190308221718-c2843e01d9a2/go.mod h1:djNgcEr1/C05ACkg1iLfiJU5Ep61QUkGW8qpdssI0+w=
golang.org/x/crypto v0.0.0-20200323165209-0ec3e9974c59/go.mod h1:LzIPMQfyMNhhGPhUkYOs5KpL4U8rLKemX1yGLhDgUto= golang.org/x/crypto v0.0.0-20200323165209-0ec3e9974c59/go.mod h1:LzIPMQfyMNhhGPhUkYOs5KpL4U8rLKemX1yGLhDgUto=
golang.org/x/crypto v0.31.0 h1:ihbySMvVjLAeSH1IbfcRTkD/iNscyz8rGzjF/E5hV6U= golang.org/x/crypto v0.36.0 h1:AnAEvhDddvBdpY+uR+MyHmuZzzNqXSe/GvuDeob5L34=
golang.org/x/crypto v0.31.0/go.mod h1:kDsLvtWBEx7MV9tJOj9bnXsPbxwJQ6csT/x4KIN4Ssk= golang.org/x/crypto v0.36.0/go.mod h1:Y4J0ReaxCR1IMaabaSMugxJES1EpwhBHhv2bDHklZvc=
golang.org/x/net v0.0.0-20190404232315-eb5bcb51f2a3/go.mod h1:t9HGtf8HONx5eT2rtn7q6eTqICYqUVnKs3thJo3Qplg= golang.org/x/net v0.0.0-20190404232315-eb5bcb51f2a3/go.mod h1:t9HGtf8HONx5eT2rtn7q6eTqICYqUVnKs3thJo3Qplg=
golang.org/x/sys v0.0.0-20190215142949-d0b11bdaac8a/go.mod h1:STP8DvDyc/dI5b8T5hshtkjS+E42TnysNCUPdjciGhY= golang.org/x/sys v0.0.0-20190215142949-d0b11bdaac8a/go.mod h1:STP8DvDyc/dI5b8T5hshtkjS+E42TnysNCUPdjciGhY=
golang.org/x/sys v0.0.0-20190412213103-97732733099d/go.mod h1:h1NjWce9XRLGQEsW7wpKNCjG9DtNlClVuFLEZdDNbEs= golang.org/x/sys v0.0.0-20190412213103-97732733099d/go.mod h1:h1NjWce9XRLGQEsW7wpKNCjG9DtNlClVuFLEZdDNbEs=
golang.org/x/sys v0.21.0/go.mod h1:/VUhepiaJMQUp4+oa/7Zr1D23ma6VTLIYjOOTFZPUcA= golang.org/x/sys v0.21.0/go.mod h1:/VUhepiaJMQUp4+oa/7Zr1D23ma6VTLIYjOOTFZPUcA=
golang.org/x/sys v0.28.0 h1:Fksou7UEQUWlKvIdsqzJmUmCX3cZuD2+P3XyyzwMhlA= golang.org/x/sys v0.31.0 h1:ioabZlmFYtWhL+TRYpcnNlLwhyxaM9kWTDEmfnprqik=
golang.org/x/sys v0.28.0/go.mod h1:/VUhepiaJMQUp4+oa/7Zr1D23ma6VTLIYjOOTFZPUcA= golang.org/x/sys v0.31.0/go.mod h1:BJP2sWEmIv4KK5OTEluFJCKSidICx8ciO85XgH3Ak8k=
golang.org/x/text v0.3.0/go.mod h1:NqM8EUOU14njkJ3fqMW+pc6Ldnwhi/IjpwHt7yyuwOQ= golang.org/x/text v0.3.0/go.mod h1:NqM8EUOU14njkJ3fqMW+pc6Ldnwhi/IjpwHt7yyuwOQ=
golang.org/x/text v0.21.0 h1:zyQAAkrwaneQ066sspRyJaG9VNi/YJ1NfzcGB3hZ/qo= golang.org/x/text v0.23.0 h1:D71I7dUrlY+VX0gQShAThNGHFxZ13dGLBHQLVl1mJlY=
golang.org/x/text v0.21.0/go.mod h1:4IBbMaMmOPCJ8SecivzSH54+73PCFmPWxNTLm+vZkEQ= golang.org/x/text v0.23.0/go.mod h1:/BLNzu4aZCJ1+kcD0DNRotWKage4q2rGVAg4o22unh4=
golang.org/x/time v0.8.0 h1:9i3RxcPv3PZnitoVGMPDKZSq1xW1gK1Xy3ArNOGZfEg= golang.org/x/time v0.11.0 h1:/bpjEDfN9tkoN/ryeYHnv5hcMlc8ncjMcM4XBk5NWV0=
golang.org/x/time v0.8.0/go.mod h1:3BpzKBy/shNhVucY/MWOyx10tF3SFh9QdLuxbVysPQM= golang.org/x/time v0.11.0/go.mod h1:CDIdPxbZBQxdj6cxyCIdrNogrJKMJ7pr37NYpMcMDSg=
golang.org/x/xerrors v0.0.0-20191204190536-9bdfabe68543 h1:E7g+9GITq07hpfrRu66IVDexMakfv52eLZ2CXBWiKr4=
golang.org/x/xerrors v0.0.0-20191204190536-9bdfabe68543/go.mod h1:I/5z698sn9Ka8TeJc9MKroUUfqBBauWjQqLJ2OPfmY0= golang.org/x/xerrors v0.0.0-20191204190536-9bdfabe68543/go.mod h1:I/5z698sn9Ka8TeJc9MKroUUfqBBauWjQqLJ2OPfmY0=
google.golang.org/protobuf v0.0.0-20200109180630-ec00e32a8dfd/go.mod h1:DFci5gLYBciE7Vtevhsrf46CRTquxDuWsQurQQe4oz8= google.golang.org/protobuf v0.0.0-20200109180630-ec00e32a8dfd/go.mod h1:DFci5gLYBciE7Vtevhsrf46CRTquxDuWsQurQQe4oz8=
google.golang.org/protobuf v0.0.0-20200221191635-4d8936d0db64/go.mod h1:kwYJMbMJ01Woi6D6+Kah6886xMZcty6N08ah7+eCXa0= google.golang.org/protobuf v0.0.0-20200221191635-4d8936d0db64/go.mod h1:kwYJMbMJ01Woi6D6+Kah6886xMZcty6N08ah7+eCXa0=

View File

@@ -1,4 +1,4 @@
// Copyright 2020-2024 The NATS Authors // Copyright 2020-2025 The NATS Authors
// Licensed under the Apache License, Version 2.0 (the "License"); // Licensed under the Apache License, Version 2.0 (the "License");
// you may not use this file except in compliance with the License. // you may not use this file except in compliance with the License.
// You may obtain a copy of the License at // You may obtain a copy of the License at
@@ -273,6 +273,8 @@ type jsOpts struct {
aecb MsgErrHandler aecb MsgErrHandler
// Max async pub ack in flight // Max async pub ack in flight
maxpa int maxpa int
// ackTimeout is the max time to wait for an ack in async publish.
ackTimeout time.Duration
// the domain that produced the pre // the domain that produced the pre
domain string domain string
// enables protocol tracing // enables protocol tracing
@@ -466,13 +468,14 @@ func (opt pubOptFn) configurePublish(opts *pubOpts) error {
} }
type pubOpts struct { type pubOpts struct {
ctx context.Context ctx context.Context
ttl time.Duration ttl time.Duration
id string id string
lid string // Expected last msgId lid string // Expected last msgId
str string // Expected stream name str string // Expected stream name
seq *uint64 // Expected last sequence seq *uint64 // Expected last sequence
lss *uint64 // Expected last sequence per subject lss *uint64 // Expected last sequence per subject
msgTTL time.Duration // Message TTL
// Publish retries for NoResponders err. // Publish retries for NoResponders err.
rwait time.Duration // Retry wait between attempts rwait time.Duration // Retry wait between attempts
@@ -507,6 +510,7 @@ const (
ExpectedLastSubjSeqHdr = "Nats-Expected-Last-Subject-Sequence" ExpectedLastSubjSeqHdr = "Nats-Expected-Last-Subject-Sequence"
ExpectedLastMsgIdHdr = "Nats-Expected-Last-Msg-Id" ExpectedLastMsgIdHdr = "Nats-Expected-Last-Msg-Id"
MsgRollup = "Nats-Rollup" MsgRollup = "Nats-Rollup"
MsgTTLHdr = "Nats-TTL"
) )
// Headers for republished messages and direct gets. // Headers for republished messages and direct gets.
@@ -566,6 +570,9 @@ func (js *js) PublishMsg(m *Msg, opts ...PubOpt) (*PubAck, error) {
if o.lss != nil { if o.lss != nil {
m.Header.Set(ExpectedLastSubjSeqHdr, strconv.FormatUint(*o.lss, 10)) m.Header.Set(ExpectedLastSubjSeqHdr, strconv.FormatUint(*o.lss, 10))
} }
if o.msgTTL > 0 {
m.Header.Set(MsgTTLHdr, o.msgTTL.String())
}
var resp *Msg var resp *Msg
var err error var err error
@@ -648,6 +655,7 @@ type pubAckFuture struct {
maxRetries int maxRetries int
retryWait time.Duration retryWait time.Duration
reply string reply string
timeout *time.Timer
} }
func (paf *pubAckFuture) Ok() <-chan *PubAck { func (paf *pubAckFuture) Ok() <-chan *PubAck {
@@ -712,13 +720,19 @@ func (js *js) newAsyncReply() string {
} }
var sb strings.Builder var sb strings.Builder
sb.WriteString(js.rpre) sb.WriteString(js.rpre)
rn := js.rr.Int63() for {
var b [aReplyTokensize]byte rn := js.rr.Int63()
for i, l := 0, rn; i < len(b); i++ { var b [aReplyTokensize]byte
b[i] = rdigits[l%base] for i, l := 0, rn; i < len(b); i++ {
l /= base b[i] = rdigits[l%base]
l /= base
}
if _, ok := js.pafs[string(b[:])]; ok {
continue
}
sb.Write(b[:])
break
} }
sb.Write(b[:])
js.mu.Unlock() js.mu.Unlock()
return sb.String() return sb.String()
} }
@@ -894,6 +908,10 @@ func (js *js) handleAsyncReply(m *Msg) {
} }
} }
if paf.timeout != nil {
paf.timeout.Stop()
}
// Process no responders etc. // Process no responders etc.
if len(m.Data) == 0 && m.Header.Get(statusHdr) == noResponders { if len(m.Data) == 0 && m.Header.Get(statusHdr) == noResponders {
if paf.retries < paf.maxRetries { if paf.retries < paf.maxRetries {
@@ -975,6 +993,15 @@ func PublishAsyncMaxPending(max int) JSOpt {
}) })
} }
// PublishAsyncTimeout sets the timeout for async message publish.
// If not provided, timeout is disabled.
func PublishAsyncTimeout(dur time.Duration) JSOpt {
return jsOptFn(func(opts *jsOpts) error {
opts.ackTimeout = dur
return nil
})
}
// PublishAsync publishes a message to JetStream and returns a PubAckFuture // PublishAsync publishes a message to JetStream and returns a PubAckFuture
func (js *js) PublishAsync(subj string, data []byte, opts ...PubOpt) (PubAckFuture, error) { func (js *js) PublishAsync(subj string, data []byte, opts ...PubOpt) (PubAckFuture, error) {
return js.PublishMsgAsync(&Msg{Subject: subj, Data: data}, opts...) return js.PublishMsgAsync(&Msg{Subject: subj, Data: data}, opts...)
@@ -1024,6 +1051,9 @@ func (js *js) PublishMsgAsync(m *Msg, opts ...PubOpt) (PubAckFuture, error) {
if o.lss != nil { if o.lss != nil {
m.Header.Set(ExpectedLastSubjSeqHdr, strconv.FormatUint(*o.lss, 10)) m.Header.Set(ExpectedLastSubjSeqHdr, strconv.FormatUint(*o.lss, 10))
} }
if o.msgTTL > 0 {
m.Header.Set(MsgTTLHdr, o.msgTTL.String())
}
// Reply // Reply
paf := o.pafRetry paf := o.pafRetry
@@ -1050,11 +1080,52 @@ func (js *js) PublishMsgAsync(m *Msg, opts ...PubOpt) (PubAckFuture, error) {
case <-js.asyncStall(): case <-js.asyncStall():
case <-time.After(stallWait): case <-time.After(stallWait):
js.clearPAF(id) js.clearPAF(id)
return nil, errors.New("nats: stalled with too many outstanding async published messages") return nil, ErrTooManyStalledMsgs
} }
} }
if js.opts.ackTimeout > 0 {
paf.timeout = time.AfterFunc(js.opts.ackTimeout, func() {
js.mu.Lock()
defer js.mu.Unlock()
if _, ok := js.pafs[id]; !ok {
// paf has already been resolved
// while waiting for the lock
return
}
// ack timed out, remove from pending acks
delete(js.pafs, id)
// check on anyone stalled and waiting.
if js.stc != nil && len(js.pafs) < js.opts.maxpa {
close(js.stc)
js.stc = nil
}
// send error to user
paf.err = ErrAsyncPublishTimeout
if paf.errCh != nil {
paf.errCh <- paf.err
}
// call error callback if set
if js.opts.aecb != nil {
js.opts.aecb(js, paf.msg, ErrAsyncPublishTimeout)
}
// check on anyone one waiting on done status.
if js.dch != nil && len(js.pafs) == 0 {
close(js.dch)
js.dch = nil
}
})
}
} else { } else {
reply = paf.reply reply = paf.reply
if paf.timeout != nil {
paf.timeout.Reset(js.opts.ackTimeout)
}
id = reply[js.replyPrefixLen:] id = reply[js.replyPrefixLen:]
} }
hdr, err := m.headerBytes() hdr, err := m.headerBytes()
@@ -1151,6 +1222,15 @@ func StallWait(ttl time.Duration) PubOpt {
}) })
} }
// MsgTTL sets per msg TTL.
// Requires [StreamConfig.AllowMsgTTL] to be enabled.
func MsgTTL(dur time.Duration) PubOpt {
return pubOptFn(func(opts *pubOpts) error {
opts.msgTTL = dur
return nil
})
}
type ackOpts struct { type ackOpts struct {
ttl time.Duration ttl time.Duration
ctx context.Context ctx context.Context
@@ -1361,6 +1441,9 @@ type jsSub struct {
fciseq uint64 fciseq uint64
csfct *time.Timer csfct *time.Timer
// context set on js.Subscribe used e.g. to recreate ordered consumer
ctx context.Context
// Cancellation function to cancel context on drain/unsubscribe. // Cancellation function to cancel context on drain/unsubscribe.
cancel func() cancel func()
} }
@@ -1833,6 +1916,7 @@ func (js *js) subscribe(subj, queue string, cb MsgHandler, ch chan *Msg, isSync,
psubj: subj, psubj: subj,
cancel: cancel, cancel: cancel,
ackNone: o.cfg.AckPolicy == AckNonePolicy, ackNone: o.cfg.AckPolicy == AckNonePolicy,
ctx: o.ctx,
} }
// Auto acknowledge unless manual ack is set or policy is set to AckNonePolicy // Auto acknowledge unless manual ack is set or policy is set to AckNonePolicy
@@ -1864,7 +1948,12 @@ func (js *js) subscribe(subj, queue string, cb MsgHandler, ch chan *Msg, isSync,
} else if consName == "" { } else if consName == "" {
consName = getHash(nuid.Next()) consName = getHash(nuid.Next())
} }
info, err := js.upsertConsumer(stream, consName, ccreq.Config) var info *ConsumerInfo
if o.ctx != nil {
info, err = js.upsertConsumer(stream, consName, ccreq.Config, Context(o.ctx))
} else {
info, err = js.upsertConsumer(stream, consName, ccreq.Config)
}
if err != nil { if err != nil {
var apiErr *APIError var apiErr *APIError
if ok := errors.As(err, &apiErr); !ok { if ok := errors.As(err, &apiErr); !ok {
@@ -2196,7 +2285,13 @@ func (sub *Subscription) resetOrderedConsumer(sseq uint64) {
jsi.consumer = "" jsi.consumer = ""
sub.mu.Unlock() sub.mu.Unlock()
consName := getHash(nuid.Next()) consName := getHash(nuid.Next())
cinfo, err := js.upsertConsumer(jsi.stream, consName, cfg) var cinfo *ConsumerInfo
var err error
if js.opts.ctx != nil {
cinfo, err = js.upsertConsumer(jsi.stream, consName, cfg, Context(js.opts.ctx))
} else {
cinfo, err = js.upsertConsumer(jsi.stream, consName, cfg)
}
if err != nil { if err != nil {
var apiErr *APIError var apiErr *APIError
if errors.Is(err, ErrJetStreamNotEnabled) || errors.Is(err, ErrTimeout) || errors.Is(err, context.DeadlineExceeded) { if errors.Is(err, ErrJetStreamNotEnabled) || errors.Is(err, ErrTimeout) || errors.Is(err, context.DeadlineExceeded) {
@@ -2206,6 +2301,9 @@ func (sub *Subscription) resetOrderedConsumer(sseq uint64) {
// retry for insufficient resources, as it may mean that client is connected to a running // retry for insufficient resources, as it may mean that client is connected to a running
// server in cluster while the server hosting R1 JetStream resources is restarting // server in cluster while the server hosting R1 JetStream resources is restarting
return return
} else if errors.As(err, &apiErr) && apiErr.ErrorCode == JSErrCodeJetStreamNotAvailable {
// retry if JetStream meta leader is temporarily unavailable
return
} }
pushErr(err) pushErr(err)
return return
@@ -2975,6 +3073,11 @@ func (sub *Subscription) Fetch(batch int, opts ...PullOpt) ([]*Msg, error) {
} }
} }
var hbTimer *time.Timer var hbTimer *time.Timer
defer func() {
if hbTimer != nil {
hbTimer.Stop()
}
}()
var hbErr error var hbErr error
sub.mu.Lock() sub.mu.Lock()
subClosed := sub.closed || sub.draining subClosed := sub.closed || sub.draining
@@ -2983,6 +3086,7 @@ func (sub *Subscription) Fetch(batch int, opts ...PullOpt) ([]*Msg, error) {
err = errors.Join(ErrBadSubscription, ErrSubscriptionClosed) err = errors.Join(ErrBadSubscription, ErrSubscriptionClosed)
} }
hbLock := sync.Mutex{} hbLock := sync.Mutex{}
var disconnected atomic.Bool
if err == nil && len(msgs) < batch && !subClosed { if err == nil && len(msgs) < batch && !subClosed {
// For batch real size of 1, it does not make sense to set no_wait in // For batch real size of 1, it does not make sense to set no_wait in
// the request. // the request.
@@ -3037,7 +3141,17 @@ func (sub *Subscription) Fetch(batch int, opts ...PullOpt) ([]*Msg, error) {
} }
return nil return nil
} }
connStatusChanged := nc.StatusChanged()
go func() {
select {
case <-ctx.Done():
return
case <-connStatusChanged:
disconnected.Store(true)
cancel()
return
}
}()
err = sendReq() err = sendReq()
for err == nil && len(msgs) < batch { for err == nil && len(msgs) < batch {
// Ask for next message and wait if there are no messages // Ask for next message and wait if there are no messages
@@ -3064,9 +3178,6 @@ func (sub *Subscription) Fetch(batch int, opts ...PullOpt) ([]*Msg, error) {
} }
} }
} }
if hbTimer != nil {
hbTimer.Stop()
}
} }
// If there is at least a message added to msgs, then need to return OK and no error // If there is at least a message added to msgs, then need to return OK and no error
if err != nil && len(msgs) == 0 { if err != nil && len(msgs) == 0 {
@@ -3075,6 +3186,9 @@ func (sub *Subscription) Fetch(batch int, opts ...PullOpt) ([]*Msg, error) {
if hbErr != nil { if hbErr != nil {
return nil, hbErr return nil, hbErr
} }
if disconnected.Load() {
return nil, ErrFetchDisconnected
}
return nil, o.checkCtxErr(err) return nil, o.checkCtxErr(err)
} }
return msgs, nil return msgs, nil
@@ -3285,6 +3399,18 @@ func (sub *Subscription) FetchBatch(batch int, opts ...PullOpt) (MessageBatch, e
} }
expires := ttl - expiresDiff expires := ttl - expiresDiff
connStatusChanged := nc.StatusChanged()
var disconnected atomic.Bool
go func() {
select {
case <-ctx.Done():
return
case <-connStatusChanged:
disconnected.Store(true)
cancel()
return
}
}()
requestBatch := batch - len(result.msgs) requestBatch := batch - len(result.msgs)
req := nextRequest{ req := nextRequest{
Expires: expires, Expires: expires,
@@ -3309,6 +3435,11 @@ func (sub *Subscription) FetchBatch(batch int, opts ...PullOpt) (MessageBatch, e
return result, nil return result, nil
} }
var hbTimer *time.Timer var hbTimer *time.Timer
defer func() {
if hbTimer != nil {
hbTimer.Stop()
}
}()
var hbErr error var hbErr error
if o.hb > 0 { if o.hb > 0 {
hbTimer = time.AfterFunc(2*o.hb, func() { hbTimer = time.AfterFunc(2*o.hb, func() {
@@ -3355,6 +3486,8 @@ func (sub *Subscription) FetchBatch(batch int, opts ...PullOpt) (MessageBatch, e
result.Lock() result.Lock()
if hbErr != nil { if hbErr != nil {
result.err = hbErr result.err = hbErr
} else if disconnected.Load() {
result.err = ErrFetchDisconnected
} else { } else {
result.err = o.checkCtxErr(err) result.err = o.checkCtxErr(err)
} }

View File

@@ -1,4 +1,4 @@
// Copyright 2020-2023 The NATS Authors // Copyright 2020-2025 The NATS Authors
// Licensed under the Apache License, Version 2.0 (the "License"); // Licensed under the Apache License, Version 2.0 (the "License");
// you may not use this file except in compliance with the License. // you may not use this file except in compliance with the License.
// You may obtain a copy of the License at // You may obtain a copy of the License at
@@ -157,6 +157,17 @@ var (
// Deprecated: ErrInvalidDurableName is no longer returned and will be removed in future releases. // Deprecated: ErrInvalidDurableName is no longer returned and will be removed in future releases.
// Use ErrInvalidConsumerName instead. // Use ErrInvalidConsumerName instead.
ErrInvalidDurableName = errors.New("nats: invalid durable name") ErrInvalidDurableName = errors.New("nats: invalid durable name")
// ErrAsyncPublishTimeout is returned when waiting for ack on async publish
ErrAsyncPublishTimeout JetStreamError = &jsError{message: "timeout waiting for ack"}
// ErrTooManyStalledMsgs is returned when too many outstanding async
// messages are waiting for ack.
ErrTooManyStalledMsgs JetStreamError = &jsError{message: "stalled with too many outstanding async published messages"}
// ErrFetchDisconnected is returned when the connection to the server is lost
// while waiting for messages to be delivered on PullSubscribe.
ErrFetchDisconnected = &jsError{message: "disconnected during fetch"}
) )
// Error code represents JetStream error codes returned by the API // Error code represents JetStream error codes returned by the API
@@ -166,6 +177,7 @@ const (
JSErrCodeJetStreamNotEnabledForAccount ErrorCode = 10039 JSErrCodeJetStreamNotEnabledForAccount ErrorCode = 10039
JSErrCodeJetStreamNotEnabled ErrorCode = 10076 JSErrCodeJetStreamNotEnabled ErrorCode = 10076
JSErrCodeInsufficientResourcesErr ErrorCode = 10023 JSErrCodeInsufficientResourcesErr ErrorCode = 10023
JSErrCodeJetStreamNotAvailable ErrorCode = 10008
JSErrCodeStreamNotFound ErrorCode = 10059 JSErrCodeStreamNotFound ErrorCode = 10059
JSErrCodeStreamNameInUse ErrorCode = 10058 JSErrCodeStreamNameInUse ErrorCode = 10058

View File

@@ -243,6 +243,14 @@ type StreamConfig struct {
// Template identifies the template that manages the Stream. Deprecated: // Template identifies the template that manages the Stream. Deprecated:
// This feature is no longer supported. // This feature is no longer supported.
Template string `json:"template_owner,omitempty"` Template string `json:"template_owner,omitempty"`
// AllowMsgTTL allows header initiated per-message TTLs.
// This feature requires nats-server v2.11.0 or later.
AllowMsgTTL bool `json:"allow_msg_ttl"`
// Enables and sets a duration for adding server markers for delete, purge and max age limits.
// This feature requires nats-server v2.11.0 or later.
SubjectDeleteMarkerTTL time.Duration `json:"subject_delete_marker_ttl,omitempty"`
} }
// SubjectTransformConfig is for applying a subject transform (to matching messages) before doing anything else when a new message is received. // SubjectTransformConfig is for applying a subject transform (to matching messages) before doing anything else when a new message is received.

View File

@@ -826,6 +826,8 @@ func (kv *kvs) PurgeDeletes(opts ...PurgeOpt) error {
deleteMarkers = append(deleteMarkers, entry) deleteMarkers = append(deleteMarkers, entry)
} }
} }
// Stop watcher here so as we purge we do not have the system continually updating numPending.
watcher.Stop()
var ( var (
pr StreamPurgeRequest pr StreamPurgeRequest
@@ -929,13 +931,14 @@ func (kv *kvs) History(key string, opts ...WatchOpt) ([]KeyValueEntry, error) {
// Implementation for Watch // Implementation for Watch
type watcher struct { type watcher struct {
mu sync.Mutex mu sync.Mutex
updates chan KeyValueEntry updates chan KeyValueEntry
sub *Subscription sub *Subscription
initDone bool initDone bool
initPending uint64 initPending uint64
received uint64 received uint64
ctx context.Context ctx context.Context
initDoneTimer *time.Timer
} }
// Context returns the context for the watcher if set. // Context returns the context for the watcher if set.
@@ -1044,8 +1047,11 @@ func (kv *kvs) WatchFiltered(keys []string, opts ...WatchOpt) (KeyWatcher, error
w.initPending = delta w.initPending = delta
} }
if w.received > w.initPending || delta == 0 { if w.received > w.initPending || delta == 0 {
w.initDoneTimer.Stop()
w.initDone = true w.initDone = true
w.updates <- nil w.updates <- nil
} else if w.initDoneTimer != nil {
w.initDoneTimer.Reset(kv.js.opts.wait)
} }
} }
} }
@@ -1088,6 +1094,16 @@ func (kv *kvs) WatchFiltered(keys []string, opts ...WatchOpt) (KeyWatcher, error
if sub.jsi != nil && sub.jsi.pending == 0 { if sub.jsi != nil && sub.jsi.pending == 0 {
w.initDone = true w.initDone = true
w.updates <- nil w.updates <- nil
} else {
// Set a timer to send the marker if we do not get any messages.
w.initDoneTimer = time.AfterFunc(kv.js.opts.wait, func() {
w.mu.Lock()
defer w.mu.Unlock()
if !w.initDone {
w.initDone = true
w.updates <- nil
}
})
} }
} else { } else {
// if UpdatesOnly was used, mark initialization as complete // if UpdatesOnly was used, mark initialization as complete
@@ -1095,8 +1111,14 @@ func (kv *kvs) WatchFiltered(keys []string, opts ...WatchOpt) (KeyWatcher, error
} }
// Set us up to close when the waitForMessages func returns. // Set us up to close when the waitForMessages func returns.
sub.pDone = func(_ string) { sub.pDone = func(_ string) {
w.mu.Lock()
defer w.mu.Unlock()
if w.initDoneTimer != nil {
w.initDoneTimer.Stop()
}
close(w.updates) close(w.updates)
} }
sub.mu.Unlock() sub.mu.Unlock()
w.sub = sub w.sub = sub

View File

@@ -47,7 +47,7 @@ import (
// Default Constants // Default Constants
const ( const (
Version = "1.39.1" Version = "1.41.0"
DefaultURL = "nats://127.0.0.1:4222" DefaultURL = "nats://127.0.0.1:4222"
DefaultPort = 4222 DefaultPort = 4222
DefaultMaxReconnect = 60 DefaultMaxReconnect = 60
@@ -274,7 +274,6 @@ type InProcessConnProvider interface {
// Options can be used to create a customized connection. // Options can be used to create a customized connection.
type Options struct { type Options struct {
// Url represents a single NATS server url to which the client // Url represents a single NATS server url to which the client
// will be connecting. If the Servers option is also set, it // will be connecting. If the Servers option is also set, it
// then becomes the first server in the Servers array. // then becomes the first server in the Servers array.
@@ -422,6 +421,10 @@ type Options struct {
// AsyncErrorCB sets the async error handler (e.g. slow consumer errors) // AsyncErrorCB sets the async error handler (e.g. slow consumer errors)
AsyncErrorCB ErrHandler AsyncErrorCB ErrHandler
// ReconnectErrCB sets the callback that is invoked whenever a
// reconnect attempt failed
ReconnectErrCB ConnErrHandler
// ReconnectBufSize is the size of the backing bufio during reconnect. // ReconnectBufSize is the size of the backing bufio during reconnect.
// Once this has been exhausted publish operations will return an error. // Once this has been exhausted publish operations will return an error.
// Defaults to 8388608 bytes (8MB). // Defaults to 8388608 bytes (8MB).
@@ -1151,6 +1154,14 @@ func ReconnectHandler(cb ConnHandler) Option {
} }
} }
// ReconnectErrHandler is an Option to set the reconnect error handler.
func ReconnectErrHandler(cb ConnErrHandler) Option {
return func(o *Options) error {
o.ReconnectErrCB = cb
return nil
}
}
// ClosedHandler is an Option to set the closed handler. // ClosedHandler is an Option to set the closed handler.
func ClosedHandler(cb ConnHandler) Option { func ClosedHandler(cb ConnHandler) Option {
return func(o *Options) error { return func(o *Options) error {
@@ -2213,6 +2224,7 @@ func (nc *Conn) ForceReconnect() error {
// even if we're in the middle of a backoff // even if we're in the middle of a backoff
if nc.rqch != nil { if nc.rqch != nil {
close(nc.rqch) close(nc.rqch)
nc.rqch = nil
} }
return nil return nil
} }
@@ -2386,7 +2398,6 @@ func (nc *Conn) setup() {
// Process a connected connection and initialize properly. // Process a connected connection and initialize properly.
func (nc *Conn) processConnectInit() error { func (nc *Conn) processConnectInit() error {
// Set our deadline for the whole connect process // Set our deadline for the whole connect process
nc.conn.SetDeadline(time.Now().Add(nc.Opts.Timeout)) nc.conn.SetDeadline(time.Now().Add(nc.Opts.Timeout))
defer nc.conn.SetDeadline(time.Time{}) defer nc.conn.SetDeadline(time.Time{})
@@ -2535,7 +2546,6 @@ func (nc *Conn) checkForSecure() error {
// processExpectedInfo will look for the expected first INFO message // processExpectedInfo will look for the expected first INFO message
// sent when a connection is established. The lock should be held entering. // sent when a connection is established. The lock should be held entering.
func (nc *Conn) processExpectedInfo() error { func (nc *Conn) processExpectedInfo() error {
c := &control{} c := &control{}
// Read the protocol // Read the protocol
@@ -2640,8 +2650,10 @@ func (nc *Conn) connectProto() (string, error) {
// If our server does not support headers then we can't do them or no responders. // If our server does not support headers then we can't do them or no responders.
hdrs := nc.info.Headers hdrs := nc.info.Headers
cinfo := connectInfo{o.Verbose, o.Pedantic, ujwt, nkey, sig, user, pass, token, cinfo := connectInfo{
o.Secure, o.Name, LangString, Version, clientProtoInfo, !o.NoEcho, hdrs, hdrs} o.Verbose, o.Pedantic, ujwt, nkey, sig, user, pass, token,
o.Secure, o.Name, LangString, Version, clientProtoInfo, !o.NoEcho, hdrs, hdrs,
}
b, err := json.Marshal(cinfo) b, err := json.Marshal(cinfo)
if err != nil { if err != nil {
@@ -2832,6 +2844,16 @@ func (nc *Conn) doReconnect(err error, forceReconnect bool) {
var rt *time.Timer var rt *time.Timer
// Channel used to kick routine out of sleep when conn is closed. // Channel used to kick routine out of sleep when conn is closed.
rqch := nc.rqch rqch := nc.rqch
// if rqch is nil, we need to set it up to signal
// the reconnect loop to reconnect immediately
// this means that `ForceReconnect` was called
// before entering doReconnect
if rqch == nil {
rqch = make(chan struct{})
close(rqch)
}
// Counter that is increased when the whole list of servers has been tried. // Counter that is increased when the whole list of servers has been tried.
var wlf int var wlf int
@@ -2911,10 +2933,13 @@ func (nc *Conn) doReconnect(err error, forceReconnect bool) {
// Try to create a new connection // Try to create a new connection
err = nc.createConn() err = nc.createConn()
// Not yet connected, retry... // Not yet connected, retry...
// Continue to hold the lock // Continue to hold the lock
if err != nil { if err != nil {
// Perform appropriate callback for a failed connection attempt.
if nc.Opts.ReconnectErrCB != nil {
nc.ach.push(func() { nc.Opts.ReconnectErrCB(nc, err) })
}
nc.err = nil nc.err = nil
continue continue
} }
@@ -3259,7 +3284,7 @@ func (nc *Conn) processMsg(data []byte) {
// It's possible that we end-up not using the message, but that's ok. // It's possible that we end-up not using the message, but that's ok.
// FIXME(dlc): Need to copy, should/can do COW? // FIXME(dlc): Need to copy, should/can do COW?
var msgPayload = data msgPayload := data
if !nc.ps.msgCopied { if !nc.ps.msgCopied {
msgPayload = make([]byte, len(data)) msgPayload = make([]byte, len(data))
copy(msgPayload, data) copy(msgPayload, data)
@@ -3450,8 +3475,10 @@ slowConsumer:
} }
} }
var permissionsRe = regexp.MustCompile(`Subscription to "(\S+)"`) var (
var permissionsQueueRe = regexp.MustCompile(`using queue "(\S+)"`) permissionsRe = regexp.MustCompile(`Subscription to "(\S+)"`)
permissionsQueueRe = regexp.MustCompile(`using queue "(\S+)"`)
)
// processTransientError is called when the server signals a non terminal error // processTransientError is called when the server signals a non terminal error
// which does not close the connection or trigger a reconnect. // which does not close the connection or trigger a reconnect.
@@ -3976,7 +4003,7 @@ func (nc *Conn) publish(subj, reply string, hdr, data []byte) error {
// go 1.14 some values strconv faster, may be able to switch over. // go 1.14 some values strconv faster, may be able to switch over.
var b [12]byte var b [12]byte
var i = len(b) i := len(b)
if hdr != nil { if hdr != nil {
if len(hdr) > 0 { if len(hdr) > 0 {
@@ -4584,6 +4611,8 @@ func (s *Subscription) StatusChanged(statuses ...SubStatus) <-chan SubStatus {
statuses = []SubStatus{SubscriptionActive, SubscriptionDraining, SubscriptionClosed, SubscriptionSlowConsumer} statuses = []SubStatus{SubscriptionActive, SubscriptionDraining, SubscriptionClosed, SubscriptionSlowConsumer}
} }
ch := make(chan SubStatus, 10) ch := make(chan SubStatus, 10)
s.mu.Lock()
defer s.mu.Unlock()
for _, status := range statuses { for _, status := range statuses {
s.registerStatusChangeListener(status, ch) s.registerStatusChangeListener(status, ch)
// initial status // initial status
@@ -4597,9 +4626,8 @@ func (s *Subscription) StatusChanged(statuses ...SubStatus) <-chan SubStatus {
// registerStatusChangeListener registers a channel waiting for a specific status change event. // registerStatusChangeListener registers a channel waiting for a specific status change event.
// Status change events are non-blocking - if no receiver is waiting for the status change, // Status change events are non-blocking - if no receiver is waiting for the status change,
// it will not be sent on the channel. Closed channels are ignored. // it will not be sent on the channel. Closed channels are ignored.
// Lock should be held entering.
func (s *Subscription) registerStatusChangeListener(status SubStatus, ch chan SubStatus) { func (s *Subscription) registerStatusChangeListener(status SubStatus, ch chan SubStatus) {
s.mu.Lock()
defer s.mu.Unlock()
if s.statListeners == nil { if s.statListeners == nil {
s.statListeners = make(map[chan SubStatus][]SubStatus) s.statListeners = make(map[chan SubStatus][]SubStatus)
} }
@@ -5677,7 +5705,7 @@ func (nc *Conn) IsDraining() bool {
// caller must lock // caller must lock
func (nc *Conn) getServers(implicitOnly bool) []string { func (nc *Conn) getServers(implicitOnly bool) []string {
poolSize := len(nc.srvPool) poolSize := len(nc.srvPool)
var servers = make([]string, 0) servers := make([]string, 0)
for i := 0; i < poolSize; i++ { for i := 0; i < poolSize; i++ {
if implicitOnly && !nc.srvPool[i].isImplicit { if implicitOnly && !nc.srvPool[i].isImplicit {
continue continue
@@ -5877,6 +5905,8 @@ func (nc *Conn) StatusChanged(statuses ...Status) chan Status {
statuses = []Status{CONNECTED, RECONNECTING, DISCONNECTED, CLOSED} statuses = []Status{CONNECTED, RECONNECTING, DISCONNECTED, CLOSED}
} }
ch := make(chan Status, 10) ch := make(chan Status, 10)
nc.mu.Lock()
defer nc.mu.Unlock()
for _, s := range statuses { for _, s := range statuses {
nc.registerStatusChangeListener(s, ch) nc.registerStatusChangeListener(s, ch)
} }
@@ -5886,9 +5916,8 @@ func (nc *Conn) StatusChanged(statuses ...Status) chan Status {
// registerStatusChangeListener registers a channel waiting for a specific status change event. // registerStatusChangeListener registers a channel waiting for a specific status change event.
// Status change events are non-blocking - if no receiver is waiting for the status change, // Status change events are non-blocking - if no receiver is waiting for the status change,
// it will not be sent on the channel. Closed channels are ignored. // it will not be sent on the channel. Closed channels are ignored.
// The lock should be held entering.
func (nc *Conn) registerStatusChangeListener(status Status, ch chan Status) { func (nc *Conn) registerStatusChangeListener(status Status, ch chan Status) {
nc.mu.Lock()
defer nc.mu.Unlock()
if nc.statListeners == nil { if nc.statListeners == nil {
nc.statListeners = make(map[Status][]chan Status) nc.statListeners = make(map[Status][]chan Status)
} }

View File

@@ -1127,6 +1127,10 @@ func (obs *obs) Watch(opts ...WatchOpt) (ObjectWatcher, error) {
if err != nil { if err != nil {
return nil, err return nil, err
} }
// Set us up to close when the waitForMessages func returns.
sub.pDone = func(_ string) {
close(w.updates)
}
w.sub = sub w.sub = sub
return w, nil return w, nil
} }

View File

@@ -392,11 +392,14 @@ func (lu *Lookup) GenerateSpaceID(spaceType string, owner *user.User) (string, e
case _spaceTypeProject: case _spaceTypeProject:
return uuid.New().String(), nil return uuid.New().String(), nil
case _spaceTypePersonal: case _spaceTypePersonal:
path := templates.WithUser(owner, lu.Options.PersonalSpacePathTemplate) relPath := templates.WithUser(owner, lu.Options.PersonalSpacePathTemplate)
path := filepath.Join(lu.Options.Root, relPath)
spaceID, _, err := lu.IDsForPath(context.TODO(), filepath.Join(lu.Options.Root, path)) // do we already know about this space?
spaceID, _, err := lu.IDsForPath(context.TODO(), path)
if err != nil { if err != nil {
_, err := os.Stat(filepath.Join(lu.Options.Root, path)) // check if the space exists on disk incl. attributes
spaceID, _, _, err := lu.metadataBackend.IdentifyPath(context.TODO(), path)
if err != nil { if err != nil {
if metadata.IsNotExist(err) || metadata.IsAttrUnset(err) { if metadata.IsNotExist(err) || metadata.IsAttrUnset(err) {
return uuid.New().String(), nil return uuid.New().String(), nil
@@ -404,6 +407,10 @@ func (lu *Lookup) GenerateSpaceID(spaceType string, owner *user.User) (string, e
return "", err return "", err
} }
} }
if len(spaceID) == 0 {
return "", errtypes.InternalError("encountered empty space id on disk")
}
return spaceID, nil
} }
return spaceID, nil return spaceID, nil
default: default:

View File

@@ -46,7 +46,12 @@ func (HybridBackend) Name() string { return "hybrid" }
// IdentifyPath returns the space id, node id and mtime of a file // IdentifyPath returns the space id, node id and mtime of a file
func (b HybridBackend) IdentifyPath(_ context.Context, path string) (string, string, time.Time, error) { func (b HybridBackend) IdentifyPath(_ context.Context, path string) (string, string, time.Time, error) {
spaceID, _ := xattr.Get(path, prefixes.SpaceIDAttr) spaceID, err := xattr.Get(path, prefixes.SpaceIDAttr)
if err != nil {
if IsNotExist(err) {
return "", "", time.Time{}, err
}
}
id, _ := xattr.Get(path, prefixes.IDAttr) id, _ := xattr.Get(path, prefixes.IDAttr)
mtimeAttr, _ := xattr.Get(path, prefixes.MTimeAttr) mtimeAttr, _ := xattr.Get(path, prefixes.MTimeAttr)

View File

@@ -129,7 +129,11 @@ func (fs *Decomposedfs) CreateStorageSpace(ctx context.Context, req *provider.Cr
} }
// 770 permissions for the space // 770 permissions for the space
if err := os.MkdirAll(rootPath, 0770); err != nil { if err := os.Mkdir(rootPath, 0770); err != nil {
if os.IsExist(err) {
// Someone has created the space in the meantime. Abort.
return nil, errtypes.AlreadyExists(spaceID)
}
return nil, errors.Wrap(err, fmt.Sprintf("Decomposedfs: error creating space %s", rootPath)) return nil, errors.Wrap(err, fmt.Sprintf("Decomposedfs: error creating space %s", rootPath))
} }

8
vendor/modules.txt vendored
View File

@@ -993,7 +993,7 @@ github.com/munnerz/goautoneg
# github.com/nats-io/jwt/v2 v2.7.3 # github.com/nats-io/jwt/v2 v2.7.3
## explicit; go 1.22 ## explicit; go 1.22
github.com/nats-io/jwt/v2 github.com/nats-io/jwt/v2
# github.com/nats-io/nats-server/v2 v2.11.0 # github.com/nats-io/nats-server/v2 v2.11.1
## explicit; go 1.23.0 ## explicit; go 1.23.0
github.com/nats-io/nats-server/v2/conf github.com/nats-io/nats-server/v2/conf
github.com/nats-io/nats-server/v2/internal/fastrand github.com/nats-io/nats-server/v2/internal/fastrand
@@ -1009,8 +1009,8 @@ github.com/nats-io/nats-server/v2/server/stree
github.com/nats-io/nats-server/v2/server/sysmem github.com/nats-io/nats-server/v2/server/sysmem
github.com/nats-io/nats-server/v2/server/thw github.com/nats-io/nats-server/v2/server/thw
github.com/nats-io/nats-server/v2/server/tpm github.com/nats-io/nats-server/v2/server/tpm
# github.com/nats-io/nats.go v1.39.1 # github.com/nats-io/nats.go v1.41.0
## explicit; go 1.22.0 ## explicit; go 1.23.0
github.com/nats-io/nats.go github.com/nats-io/nats.go
github.com/nats-io/nats.go/encoders/builtin github.com/nats-io/nats.go/encoders/builtin
github.com/nats-io/nats.go/internal/parser github.com/nats-io/nats.go/internal/parser
@@ -1198,7 +1198,7 @@ github.com/open-policy-agent/opa/v1/types
github.com/open-policy-agent/opa/v1/util github.com/open-policy-agent/opa/v1/util
github.com/open-policy-agent/opa/v1/util/decoding github.com/open-policy-agent/opa/v1/util/decoding
github.com/open-policy-agent/opa/v1/version github.com/open-policy-agent/opa/v1/version
# github.com/opencloud-eu/reva/v2 v2.29.1 # github.com/opencloud-eu/reva/v2 v2.29.3
## explicit; go 1.24.1 ## explicit; go 1.24.1
github.com/opencloud-eu/reva/v2/cmd/revad/internal/grace github.com/opencloud-eu/reva/v2/cmd/revad/internal/grace
github.com/opencloud-eu/reva/v2/cmd/revad/runtime github.com/opencloud-eu/reva/v2/cmd/revad/runtime