mirror of
https://github.com/opencloud-eu/opencloud.git
synced 2026-09-14 06:39:07 -04:00
Jannik Stehle
d562d44edf
The libvips generator passed 0 as the target height to vips_thumbnail, so the value was rejected and dropped. As a result, a preview of a 4000x5000 portrait image requested with e.g. x=500&y=500 returned a ...x1920 image instead of a ...x1080 one, which would be the next correct size in the pre-defined resolutions list. This was due to the missing height, so it used the width (=1920) to determine the longest side. This also aligns it with the non-libvips behavior.
39 lines
2.5 KiB
Gherkin
39 lines
2.5 KiB
Gherkin
@skipOnReva
|
|
Feature: sizing of previews of files downloaded through the webdav API
|
|
As a user
|
|
I want the aspect-ratio of previews to be preserved even when I ask for an unusual preview size
|
|
So that the previews always have a similar look-and-feel to the original file
|
|
|
|
This is optional behavior of an implementation. OpenCloud happens like this,
|
|
but oC10 does not do this auto-fix of the aspect ratio.
|
|
|
|
Background:
|
|
Given user "Alice" has been created with default attributes
|
|
|
|
|
|
Scenario Outline: download different sizes of previews of file
|
|
Given using <dav-path-version> DAV path
|
|
And user "Alice" has uploaded file "filesForUpload/lorem.txt" to "/parent.txt"
|
|
When user "Alice" downloads the preview of "/parent.txt" with width <request-width> and height <request-height> using the WebDAV API
|
|
Then the HTTP status code should be "200"
|
|
And the downloaded image should be <return-width> pixels wide and <return-height> pixels high
|
|
# the source preview of a text file is always 640x480,
|
|
# so a request bigger than that is capped to the source size
|
|
Examples:
|
|
| request-width | request-height | return-width | return-height | dav-path-version |
|
|
| 1 | 1 | 16 | 16 | old |
|
|
| 32 | 32 | 32 | 32 | old |
|
|
| 1024 | 1024 | 640 | 480 | old |
|
|
| 1 | 1024 | 16 | 16 | old |
|
|
| 1024 | 1 | 640 | 480 | old |
|
|
| 1 | 1 | 16 | 16 | new |
|
|
| 32 | 32 | 32 | 32 | new |
|
|
| 1024 | 1024 | 640 | 480 | new |
|
|
| 1 | 1024 | 16 | 16 | new |
|
|
| 1024 | 1 | 640 | 480 | new |
|
|
| 1 | 1 | 16 | 16 | spaces |
|
|
| 32 | 32 | 32 | 32 | spaces |
|
|
| 1024 | 1024 | 640 | 480 | spaces |
|
|
| 1 | 1024 | 16 | 16 | spaces |
|
|
| 1024 | 1 | 640 | 480 | spaces |
|