mirror of
https://github.com/opencloud-eu/opencloud.git
synced 2026-02-20 07:55:46 -05:00
4f1aca6d90
This works the previous commits so that clients can add an addtional 'platform' query parameter to the webfinger request that can be used to query the oidc client id and list of scopes that the clients need to use when connecting to the IDP. This also removes the non-standard issuer relatation introduced in a previous commit as we can just introduce new relations in the http://openid.net name space. For IDP like Authentik that create a separate issuer url per Client (Application in Authentik's terms) it is suggested to just configure as single Client and use that id for all platforms (i.e. setting 'WEBFINGER_ANDROID_OIDC_CLIENT_ID', 'WEBFINGER_DESKTOP_OIDC_CLIENT_ID', 'WEBFINGER_IOS_OIDC_CLIENT_ID' and 'WEBFINGER_WEB_OIDC_CLIENT_ID' to same value. Related: #2088 Related: https://github.com/opencloud-eu/desktop/issues/246
66 lines
2.0 KiB
Go
66 lines
2.0 KiB
Go
package relations
|
|
|
|
import (
|
|
"context"
|
|
"testing"
|
|
|
|
"github.com/opencloud-eu/opencloud/pkg/oidc"
|
|
"github.com/opencloud-eu/opencloud/services/webfinger/pkg/config"
|
|
"github.com/opencloud-eu/opencloud/services/webfinger/pkg/webfinger"
|
|
)
|
|
|
|
func TestOpenCloudInstanceErr(t *testing.T) {
|
|
_, err := OpenCloudInstance([]config.Instance{}, "http://\n\rinvalid")
|
|
if err == nil {
|
|
t.Errorf("provider did not err on invalid url: %v", err)
|
|
}
|
|
_, err = OpenCloudInstance([]config.Instance{{Regex: "("}}, "http://opencloud.tld")
|
|
if err == nil {
|
|
t.Errorf("provider did not err on invalid regex: %v", err)
|
|
}
|
|
_, err = OpenCloudInstance([]config.Instance{{Href: "{{invalid}}ee"}}, "http://opencloud.tld")
|
|
if err == nil {
|
|
t.Errorf("provider did not err on invalid href template: %v", err)
|
|
}
|
|
}
|
|
|
|
func TestOpenCloudInstanceAddLink(t *testing.T) {
|
|
provider, err := OpenCloudInstance([]config.Instance{{
|
|
Claim: "customclaim",
|
|
Regex: ".+@.+\\..+",
|
|
Href: "https://{{.otherclaim}}.domain.tld",
|
|
Titles: map[string]string{
|
|
"foo": "bar",
|
|
},
|
|
Break: true,
|
|
}}, "http://opencloud.tld")
|
|
if err != nil {
|
|
t.Error(err)
|
|
}
|
|
|
|
ctx := context.Background()
|
|
ctx = oidc.NewContext(ctx, map[string]interface{}{
|
|
"customclaim": "some@fizz.buzz",
|
|
"otherclaim": "someone",
|
|
})
|
|
jrd := webfinger.JSONResourceDescriptor{}
|
|
provider.Add(ctx, "", &jrd)
|
|
|
|
if len(jrd.Links) != 1 {
|
|
t.Errorf("provider returned wrong number of links: %v, expected 1", len(jrd.Links))
|
|
}
|
|
if jrd.Links[0].Href != "https://someone.domain.tld" {
|
|
t.Errorf("provider returned wrong issuer link href: %v, expected %v", jrd.Links[0].Href, "https://someone.domain.tld")
|
|
}
|
|
if jrd.Links[0].Rel != OpenCloudInstanceRel {
|
|
t.Errorf("provider returned opencloud server instance rel: %v, expected %v", jrd.Links[0].Rel, OpenCloudInstanceRel)
|
|
}
|
|
if len(jrd.Links[0].Titles) != 1 {
|
|
t.Errorf("provider returned wrong number of titles: %v, expected 1", len(jrd.Links[0].Titles))
|
|
}
|
|
if jrd.Links[0].Titles["foo"] != "bar" {
|
|
t.Errorf("provider returned wrong title: %v, expected bar", len(jrd.Links[0].Titles["foo"]))
|
|
}
|
|
|
|
}
|