opencloud/services/graph/pkg/service/v0/utils_test.go

package svc_test

import (
	"context"
	"net/http"
	"net/http/httptest"

	collaboration "github.com/cs3org/go-cs3apis/cs3/sharing/collaboration/v1beta1"
	"github.com/go-chi/chi/v5"
	. "github.com/onsi/ginkgo/v2"
	. "github.com/onsi/gomega"
	libregraph "github.com/opencloud-eu/libre-graph-api-go"
	rConversions "github.com/opencloud-eu/reva/v2/pkg/conversions"
	"github.com/opencloud-eu/reva/v2/pkg/utils"

	provider "github.com/cs3org/go-cs3apis/cs3/storage/provider/v1beta1"
	"github.com/opencloud-eu/reva/v2/pkg/storagespace"
	"google.golang.org/protobuf/testing/protocmp"

	"github.com/opencloud-eu/opencloud/pkg/conversions"
	"github.com/opencloud-eu/opencloud/pkg/log"
	"github.com/opencloud-eu/opencloud/services/graph/pkg/identity/cache"
	service "github.com/opencloud-eu/opencloud/services/graph/pkg/service/v0"
	"github.com/opencloud-eu/opencloud/services/graph/pkg/unifiedrole"
)

var _ = Describe("Utils", func() {
	DescribeTable("GetDriveAndItemIDParam",
		func(driveID, itemID string, shouldPass bool) {
			rctx := chi.NewRouteContext()
			rctx.URLParams.Add("driveID", driveID)
			rctx.URLParams.Add("itemID", itemID)

			extractedDriveID, extractedItemID, err := service.GetDriveAndItemIDParam(
				httptest.NewRequest(http.MethodGet, "/", nil).
					WithContext(
						context.WithValue(context.Background(), chi.RouteCtxKey, rctx),
					),
				conversions.ToPointer(log.NopLogger()),
			)

			switch shouldPass {
			case true:
				Expect(err).To(BeNil())
				parsedItemID, _ := storagespace.ParseID(itemID)
				Expect(extractedItemID).To(BeComparableTo(&parsedItemID, protocmp.Transform()))

				parsedDriveID, _ := storagespace.ParseID(driveID)
				Expect(extractedDriveID).To(BeComparableTo(&parsedDriveID, protocmp.Transform()))
			default:
				Expect(err).ToNot(BeNil())
			}
		},
		Entry("fails: invalid driveID", "", "1$2!3", false),
		Entry("fails: invalid itemID", "1$2", "", false),
		Entry("fails: incompatible driveID and itemID", "1$2", "3$4!5", false),
		Entry("fails: no itemID opaqueId", "1$2", "3$4", false),
		Entry("pass: valid driveID and itemID", "1$2", "1$2!5", true),
	)

	DescribeTable("IsSpaceRoot",
		func(resourceID *provider.ResourceId, isRoot bool) {
			Expect(service.IsSpaceRoot(resourceID)).To(Equal(isRoot))
		},
		Entry("spaceId and opaqueID equal", &provider.ResourceId{
			StorageId: "1",
			OpaqueId:  "2",
			SpaceId:   "2",
		}, true),
		Entry("nil", nil, false),
		Entry("spaceID empty", &provider.ResourceId{
			StorageId: "1",
			OpaqueId:  "2",
		}, false),
		Entry("opaqueID empty", &provider.ResourceId{
			StorageId: "1",
			SpaceId:   "3",
		}, false),
		Entry("spaceID and opaqueID unequal", &provider.ResourceId{
			OpaqueId: "2",
			SpaceId:  "3",
		}, false),
	)

	DescribeTable("IsShareJail",
		func(resourceID *provider.ResourceId, isShareJail bool) {
			Expect(service.IsShareJail(resourceID)).To(Equal(isShareJail))
		},
		Entry("valid: share jail", &provider.ResourceId{
			StorageId: utils.ShareStorageProviderID,
			SpaceId:   utils.ShareStorageSpaceID,
		}, true),
		Entry("invalid: empty storageId", &provider.ResourceId{
			SpaceId: utils.ShareStorageSpaceID,
		}, false),
		Entry("invalid: empty spaceId", &provider.ResourceId{
			StorageId: utils.ShareStorageProviderID,
		}, false),
		Entry("invalid: empty storageId and spaceId", &provider.ResourceId{}, false),
		Entry("invalid: non share jail storageId", &provider.ResourceId{
			StorageId: "123",
			SpaceId:   utils.ShareStorageSpaceID,
		}, false),
		Entry("invalid: non share jail spaceId", &provider.ResourceId{
			StorageId: utils.ShareStorageProviderID,
			SpaceId:   "123",
		}, false),
		Entry("invalid: non share jail storageID and spaceId", &provider.ResourceId{
			StorageId: "123",
			SpaceId:   "123",
		}, false),
	)

	DescribeTable("_cs3ReceivedShareToLibreGraphPermissions",
		func(permissionSet *provider.ResourcePermissions, match func(*libregraph.Permission)) {
			permission, err := service.CS3ReceivedShareToLibreGraphPermissions(
				context.Background(),
				nil,
				cache.IdentityCache{},
				&collaboration.ReceivedShare{
					Share: &collaboration.Share{
						Permissions: &collaboration.SharePermissions{
							Permissions: permissionSet,
						},
					},
				}, &provider.ResourceInfo{
					Type: provider.ResourceType_RESOURCE_TYPE_FILE,
				},
				unifiedrole.GetRoles(unifiedrole.RoleFilterAll()),
			)
			Expect(err).ToNot(HaveOccurred())
			match(permission)
		},
		Entry(
			"permissions match a role",
			rConversions.NewViewerRole().CS3ResourcePermissions(),
			func(p *libregraph.Permission) {
				Expect(p.GetRoles()).To(HaveExactElements([]string{unifiedrole.UnifiedRoleViewerID}))
				Expect(p.GetLibreGraphPermissionsActions()).To(BeNil())
			},
		),
		Entry(
			"permissions do not match any role",
			&provider.ResourcePermissions{
				AddGrant: true,
			},
			func(p *libregraph.Permission) {
				Expect(p.GetRoles()).To(BeNil())
				Expect(p.GetLibreGraphPermissionsActions()).To(HaveExactElements([]string{unifiedrole.DriveItemPermissionsCreate}))
			},
		),
	)
})