mirror of
https://github.com/opencloud-eu/opencloud.git
synced 2026-10-08 03:42:10 -04:00
Ralf Haferkamp
98cdbd077d
Replace the boolean authenticator result with a typed AuthenticationResult containing AuthenticationState (NotApplicable, Failed, Succeeded, Error) to distinguish between non-applicability, rejected credentials, and dependency failures. All existing authentication behavior remains observably unchanged.
80 lines
2.7 KiB
Go
80 lines
2.7 KiB
Go
package middleware
|
|
|
|
import (
|
|
"net/http"
|
|
"net/http/httptest"
|
|
|
|
gateway "github.com/cs3org/go-cs3apis/cs3/gateway/v1beta1"
|
|
userv1beta1 "github.com/cs3org/go-cs3apis/cs3/identity/user/v1beta1"
|
|
rpcv1beta1 "github.com/cs3org/go-cs3apis/cs3/rpc/v1beta1"
|
|
. "github.com/onsi/ginkgo/v2"
|
|
. "github.com/onsi/gomega"
|
|
"github.com/opencloud-eu/opencloud/pkg/log"
|
|
userRoleMocks "github.com/opencloud-eu/opencloud/services/proxy/pkg/userroles/mocks"
|
|
revactx "github.com/opencloud-eu/reva/v2/pkg/ctx"
|
|
"github.com/opencloud-eu/reva/v2/pkg/rgrpc/todo/pool"
|
|
"github.com/stretchr/testify/mock"
|
|
"google.golang.org/grpc"
|
|
)
|
|
|
|
var _ = Describe("Authenticating requests", Label("AppAuthAuthenticator"), func() {
|
|
var authenticator Authenticator
|
|
BeforeEach(func() {
|
|
pool.RemoveSelector("GatewaySelector" + "eu.opencloud.api.gateway")
|
|
ra := &userRoleMocks.UserRoleAssigner{}
|
|
ra.On("ApplyUserRole", mock.Anything, mock.Anything, mock.Anything).Return(&userv1beta1.User{}, nil)
|
|
authenticator = AppAuthAuthenticator{
|
|
Logger: log.NewLogger(),
|
|
RevaGatewaySelector: pool.GetSelector[gateway.GatewayAPIClient](
|
|
"GatewaySelector",
|
|
"eu.opencloud.api.gateway",
|
|
func(cc grpc.ClientConnInterface) gateway.GatewayAPIClient {
|
|
return mockGatewayClient{
|
|
AuthenticateFunc: func(authType, clientID, clientSecret string) (string, rpcv1beta1.Code) {
|
|
if authType != "appauth" {
|
|
return "", rpcv1beta1.Code_CODE_NOT_FOUND
|
|
}
|
|
|
|
if clientID == "test-user" && clientSecret == "AppPassword" {
|
|
return "reva-token", rpcv1beta1.Code_CODE_OK
|
|
}
|
|
|
|
return "", rpcv1beta1.Code_CODE_NOT_FOUND
|
|
},
|
|
}
|
|
},
|
|
),
|
|
UserRoleAssigner: ra,
|
|
}
|
|
})
|
|
|
|
When("the request contains correct data", func() {
|
|
It("should successfully authenticate", func() {
|
|
req := httptest.NewRequest(http.MethodGet, "http://example.com/example/path", http.NoBody)
|
|
req.SetBasicAuth("test-user", "AppPassword")
|
|
|
|
result := authenticator.Authenticate(req)
|
|
|
|
Expect(result.State).To(Equal(AuthenticationSucceeded))
|
|
Expect(result.Request).ToNot(BeNil())
|
|
user, ok := revactx.ContextGetUser(result.Request.Context())
|
|
Expect(ok).To(BeTrue())
|
|
Expect(user).ToNot(BeNil())
|
|
token, ok := revactx.ContextGetToken(result.Request.Context())
|
|
Expect(ok).To(BeTrue())
|
|
Expect(token).To(Equal("reva-token"))
|
|
})
|
|
})
|
|
|
|
When("the request contains incorrect data", func() {
|
|
It("should not successfully authenticate", func() {
|
|
req := httptest.NewRequest(http.MethodGet, "http://example.com/example/path", http.NoBody)
|
|
req.SetBasicAuth("test-user", "WrongAppPassword")
|
|
|
|
result := authenticator.Authenticate(req)
|
|
|
|
Expect(result.State).To(Equal(AuthenticationFailed))
|
|
})
|
|
})
|
|
})
|