From 0e10a85248819e1cd13dd9f415a598dcd6d7c6fe Mon Sep 17 00:00:00 2001 From: objec Date: Fri, 29 May 2026 15:15:50 +0400 Subject: [PATCH] Change tense on trigger name for consistency Signed-off-by: objec --- app/Controllers/Sales.php | 2 +- app/Plugins/README.md | 6 +++--- 2 files changed, 4 insertions(+), 4 deletions(-) diff --git a/app/Controllers/Sales.php b/app/Controllers/Sales.php index 2fc69b8c4..7701c3e44 100644 --- a/app/Controllers/Sales.php +++ b/app/Controllers/Sales.php @@ -917,7 +917,7 @@ class Sales extends Secure_Controller } $data['receipt_template_view'] = $receipt_template; - Events::trigger('sale_complete', $data['sale_id_num'], $sale_type); + Events::trigger('sale_completed', $data['sale_id_num'], $sale_type); $this->sale_lib->clear_all(); return view('sales/receipt', $data); diff --git a/app/Plugins/README.md b/app/Plugins/README.md index 461aba1c5..468028b66 100644 --- a/app/Plugins/README.md +++ b/app/Plugins/README.md @@ -101,7 +101,7 @@ OSPOS fires these events that plugins can listen to: | `customer_saved` | `array $customerIds` | Customer created/updated via form save or CSV import | | `customer_deleted` | `int $personId, string $email` | Customer deleted | | `item_saved` | `array $itemIds` | Item created/updated via form save or CSV import | -| `sale_complete` | `int $saleIdNum, string $saleType` | Sale finalized and receipt rendered | +| `sale_completed` | `int $saleIdNum, string $saleType` | Sale finalized and receipt rendered | | `receiving_complete` | `int $receivingId, string $mode` | Receiving finalized and items added to inventory | > **Note:** `customer_saved` and `item_saved` always receive an array of IDs. @@ -254,7 +254,7 @@ class MyPlugin extends BasePlugin public function registerEvents(): void { - Events::on('sale_complete', [$this, 'onSaleComplete']); + Events::on('sale_completed', [$this, 'onSaleComplete']); Events::on('item_saved', [$this, 'onItemSaved']); Events::on('receiving_complete', [$this, 'onReceivingComplete']); } @@ -532,7 +532,7 @@ For custom tables, plugins can create them during `install()` and drop them duri ## Event Flow -1. Application triggers event: `Events::trigger('sale_complete', $saleIdNum, $saleType)` +1. Application triggers event: `Events::trigger('sale_completed', $saleIdNum, $saleType)` 2. PluginManager recursively scans `app/Plugins/` directory 3. Each enabled plugin registers its listeners via `registerEvents()` 4. Events::on() callbacks are invoked automatically