From 26bee3e5a647ef8f8224c3e21e7956055cdd981c Mon Sep 17 00:00:00 2001
From: flodef <flodef@free.fr>
Date: Tue, 11 Nov 2014 13:04:27 +0100
Subject: [PATCH] Update Sale_lib.php

Clean "add_payment" to be simpler : don't need to declare $payment in the main as it used only to add to an existing array
Fix "edit_payment" that was trying to set a payment on the $payment_id (expected payment data : $payments)
---
 application/libraries/Sale_lib.php | 20 ++++++++++----------
 1 file changed, 10 insertions(+), 10 deletions(-)

diff --git a/application/libraries/Sale_lib.php b/application/libraries/Sale_lib.php
index 5178b8b4d..232f075f1 100644
--- a/application/libraries/Sale_lib.php
+++ b/application/libraries/Sale_lib.php
@@ -70,21 +70,21 @@ class Sale_lib
 	function add_payment( $payment_id, $payment_amount )
 	{
 		$payments = $this->get_payments();
-		$payment = array( $payment_id=>
-		array(
-			'payment_type' => $payment_id,
-			'payment_amount' => $payment_amount
-			)
-		);
-
-		//payment_method already exists, add to payment_amount
 		if( isset( $payments[$payment_id] ) )
 		{
+			//payment_method already exists, add to payment_amount
 			$payments[$payment_id]['payment_amount'] += $payment_amount;
 		}
 		else
 		{
 			//add to existing array
+			$payment = array( $payment_id=>
+			array(
+				'payment_type' => $payment_id,
+				'payment_amount' => $payment_amount
+				)
+			);
+			
 			$payments += $payment;
 		}
 
@@ -101,7 +101,7 @@ class Sale_lib
 		{
 			$payments[$payment_id]['payment_type'] = $payment_id;
 			$payments[$payment_id]['payment_amount'] = $payment_amount;
-			$this->set_payments($payment_id);
+			$this->set_payments($payments);
 		}
 
 		return false;
@@ -589,4 +589,4 @@ class Sale_lib
         return true;
     }
 }
-?>
\ No newline at end of file
+?>