mirror/opensourcepos
1
0
Fork 0
mirror of https://github.com/opensourcepos/opensourcepos.git synced 2026-05-14 02:33:56 -04:00
Code Issues Packages Projects Releases Wiki Activity

CSV import optimizations and code cleanup (#3150)

Browse Source 
Optimizations and CSV Import Rework
- Replaced " with ' where possible to prevent the parser from being called when not needed.
- Replaced == and != with === and !== where possible for bug prevention and speed.
- Replaced -1 with NEW_ITEM global constant for code clarity.
- Added NEW_ITEM global constant to constants.php.
- Refactored CSV import function names for clarity.
- Added capability to import a CSV file containing updates.
- Replaced array() with [] for speed and consistency.
- Removed hungarian notation from two private functions.
- Refactored QueryBuilder functions to place table name in the get() function call.
- Replaced (int) cast with call to intval() for speed.
- Replaced == and != with === and !== where possible to prevent bugs and for speed.
- Replaced array() with [] for speed and consistency.
- Fixed search_custom call

Optimizations and bugfixes for attributes used in csv_import
- Reordered where statements in queries to match composite index on attribute_links table.
- fixed value_exists() to account for different attribute types.
- Removed hungarian notation on private function.
- Replaced array() with [] for speed and consistency.
- Replaced != with <> in SQL for consistency.
- Removed from() calls in querybuilder where possible to reduce function calls.
- Add get_items_by_value()
- Reworked check_data_validity()
- Remove unneeded comments
- Refactor functions for code clarity.
- Use $this->db->dbprefix() where possible instead of hand-writing ospos_...
- Removed unneeded column from query.
- Replaced (int) cast with intval() call for speed.
- Added get_attribute_values()
- Fixed issue with date format locale not being used
- Refactored save_value to respect different attribute_types
- Added delete_orphaned_links() to remove attribute_links that are no longer linked to any items
- Added get_attributes_by_definition()
- Added attribute_cleanup()

Optimizations used in csv_import
- replaced array() with [] for consistency and speed.
- Removed hungarian notation in private functions.
- Replaced " with ' where possible to prevent the parser from being called.
- Minor formatting
- Refactored if statement to tertiary notation for cleaner implementation.
- Replaced " for ' where possible to prevent the parser from being called.
- Added the Id column in the generate_import_items_csv() template so that users can submit an update to an existing item.
- Removed unused key=>value pairs in foreach loops for speed.
- Removed unneeded comments where the function name was self-explanatory.
- Rework get_csv_file() for speed.
- Rework bom_exists() for speed.
- Replaced array() with [] for speed and consistency.
- Replaced == with === where possible to prevent bugs and for speed.
- Reworked valid_date() and valid_decimal helper functions for speed and accuracy according to the locale_format instead of a fixed format.
- Minor Reformatting for clarity.
- Replaced " for ' to prevent the parser from being called.
- Refactored function call names to reflect new names.
- Added missing ; in &nbsp;
- Used String interpolation where useful.

- Spelling fix in comment

Requested Review Changes
- Fixed indentation in Items.php
- Fixed indentation in Attribute.php
- Refactored variable out of long line of code to make it more readable.
This commit is contained in:
objecttothis
2021-06-05 21:46:16 +04:00
committed by jekkos
parent 517635181c
commit 3d65c3fffa
9 changed files with 761 additions and 607 deletions
Download Patch File Download Diff File Expand all files Collapse all files

449
application/models/Attribute.php
View File

@@ -21,18 +21,24 @@ class Attribute extends CI_Model
*/
public function exists($definition_id, $deleted = FALSE)
{
$this->db->from('attribute_definitions');
$this->db->where('definition_id', $definition_id);
$this->db->where('deleted', $deleted);
return ($this->db->get()->num_rows() == 1);
return ($this->db->get('attribute_definitions')->num_rows() == 1);
}
/**
* Returns whether an attribute_link row exists given an item_id and optionally a definition_id
* @param int $item_id
* @param boolean $definition_id
* @return boolean TRUE if at least one attribute_link exists or FALSE if no attributes exist.
*/
public function link_exists($item_id, $definition_id = FALSE)
{
$this->db->where('item_id', $item_id);
$this->db->where('sale_id');
$this->db->where('receiving_id');
$this->db->from('attribute_links');
if(empty($definition_id))
{
$this->db->where('definition_id <>');
@@ -43,25 +49,38 @@ class Attribute extends CI_Model
$this->db->where('definition_id', $definition_id);
}
$this->db->where('item_id', $item_id);
return ($this->db->get()->num_rows() > 0);
return ($this->db->get('attribute_links')->num_rows() > 0);
}
/*
Determines if a given attribute_value exists in the attribute_values table and returns the attribute_id if it does
* Determines if a given attribute_value exists in the attribute_values table and returns the attribute_id if it does
*/
public function value_exists($attribute_value)
public function value_exists($attribute_value, $definition_type = TEXT)
{
$this->db->distinct('attribute_id');
$this->db->from('attribute_values');
$this->db->where('attribute_value', $attribute_value);
switch($definition_type)
{
case DATE:
$data_type = 'date';
$attribute_date_value = DateTime::createFromFormat($this->Appconfig->get('dateformat'), $attribute_value);
$attribute_value = $attribute_date_value->format('Y-m-d');
break;
case DECIMAL:
$data_type = 'decimal';
break;
default:
$data_type = 'value';
break;
}
$query = $this->db->get();
if ($query->num_rows() > 0)
$this->db->select('attribute_id');
$this->db->where("attribute_$data_type", $attribute_value);
$query = $this->db->get('attribute_values');
if($query->num_rows() > 0)
{
return $query->row()->attribute_id;
}
return FALSE;
}
@@ -86,7 +105,7 @@ class Attribute extends CI_Model
//Get empty base parent object, as $item_id is NOT an item
$item_obj = new stdClass();
//Get all the fields from items table
//Get all the fields from attribute_definitions table
foreach($this->db->list_fields('attribute_definitions') as $field)
{
$item_obj->$field = '';
@@ -106,9 +125,10 @@ class Attribute extends CI_Model
$this->db->join('attribute_definitions AS parent_definition', 'parent_definition.definition_id = definition.definition_fk', 'left');
$this->db->group_start();
$this->db->like('definition.definition_name', $search);
$this->db->or_like('definition.definition_type', $search);
$this->db->like('definition.definition_name', $search);
$this->db->or_like('definition.definition_type', $search);
$this->db->group_end();
$this->db->where('definition.deleted', 0);
$this->db->order_by($sort, $order);
@@ -122,68 +142,63 @@ class Attribute extends CI_Model
public function get_attributes_by_item($item_id)
{
$this->db->from('attribute_definitions');
$this->db->join('attribute_links', 'attribute_links.definition_id = attribute_definitions.definition_id');
$this->db->where('item_id', $item_id);
$this->db->where('receiving_id');
$this->db->where('sale_id');
$this->db->where('receiving_id');
$this->db->where('deleted', 0);
$this->db->order_by('definition_name','ASC');
$this->db->order_by('definition_name', 'ASC');
$results = $this->db->get()->result_array();
$results = $this->db->get('attribute_definitions')->result_array();
return $this->_to_array($results, 'definition_id');
return $this->to_array($results, 'definition_id');
}
public function get_values_by_definitions($definition_ids)
{
if(count($definition_ids ? : []))
{
$this->db->from('attribute_definitions');
$this->db->group_start();
$this->db->where_in('definition_fk', array_keys($definition_ids));
$this->db->or_where_in('definition_id', array_keys($definition_ids));
$this->db->where('definition_type !=', GROUP);
$this->db->where_in('definition_fk', array_keys($definition_ids));
$this->db->or_where_in('definition_id', array_keys($definition_ids));
$this->db->where('definition_type !=', GROUP);
$this->db->group_end();
$this->db->where('deleted', 0);
$results = $this->db->get()->result_array();
$results = $this->db->get('attribute_definitions')->result_array();
return $this->_to_array($results, 'definition_id');
return $this->to_array($results, 'definition_id');
}
return array();
return [];
}
public function get_definitions_by_type($attribute_type, $definition_id = NO_DEFINITION_ID)
{
$this->db->from('attribute_definitions');
$this->db->where('definition_type', $attribute_type);
$this->db->where('deleted', 0);
$this->db->where('definition_fk');
if($definition_id != CATEGORY_DEFINITION_ID)
{
$this->db->where('definition_id != ', $definition_id);
$this->db->where('definition_id <>', $definition_id);
}
$this->db->where('definition_fk');
$results = $this->db->get()->result_array();
$results = $this->db->get('attribute_definitions')->result_array();
return $this->_to_array($results, 'definition_id', 'definition_name');
return $this->to_array($results, 'definition_id', 'definition_name');
}
public function get_definitions_by_flags($definition_flags)
{
$this->db->from('attribute_definitions');
$this->db->where('definition_flags &', $definition_flags);
$this->db->where('deleted', 0);
$this->db->where('definition_type <>', GROUP);
$this->db->order_by('definition_id');
$results = $this->db->get()->result_array();
$results = $this->db->get('attribute_definitions')->result_array();
return $this->_to_array($results, 'definition_id', 'definition_name');
return $this->to_array($results, 'definition_id', 'definition_name');
}
/**
@@ -194,7 +209,6 @@ class Attribute extends CI_Model
*/
public function get_definition_names($groups = TRUE)
{
$this->db->from('attribute_definitions');
$this->db->where('deleted', 0);
$this->db->order_by('definition_name','ASC');
@@ -203,11 +217,10 @@ class Attribute extends CI_Model
$this->db->where_not_in('definition_type',GROUP);
}
$results = $this->db->get()->result_array();
$results = $this->db->get('attribute_definitions')->result_array();
$definition_name = array(-1 => $this->lang->line('common_none_selected_text'));
return $definition_name + $this->_to_array($results, 'definition_id', 'definition_name');
return $definition_name + $this->to_array($results, 'definition_id', 'definition_name');
}
public function get_definition_values($definition_id)
@@ -216,23 +229,22 @@ class Attribute extends CI_Model
if($definition_id > 0 || $definition_id == CATEGORY_DEFINITION_ID)
{
$this->db->from('attribute_links');
$this->db->join('attribute_values', 'attribute_values.attribute_id = attribute_links.attribute_id');
$this->db->where('definition_id', $definition_id);
$this->db->where('item_id');
$this->db->where('definition_id', $definition_id);
$this->db->order_by('attribute_value','ASC');
$results = $this->db->get()->result_array();
$results = $this->db->get('attribute_links')->result_array();
return $this->_to_array($results, 'attribute_id', 'attribute_value');
return $this->to_array($results, 'attribute_id', 'attribute_value');
}
return $attribute_values;
}
private function _to_array($results, $key, $value = '')
private function to_array($results, $key, $value = '')
{
return array_column(array_map(function($result) use ($key, $value) {
return array_column(array_map(function($result) use ($key, $value){
return [$result[$key], empty($value) ? $result : $result[$value]];
}, $results), 1, 0);
}
@@ -242,10 +254,9 @@ class Attribute extends CI_Model
*/
public function get_total_rows()
{
$this->db->from('attribute_definitions');
$this->db->where('deleted', 0);
return $this->db->count_all_results();
return $this->db->count_all_results('attribute_definitions');
}
/*
@@ -256,73 +267,83 @@ class Attribute extends CI_Model
return $this->search($search)->num_rows();
}
private function check_data_validity($definition, $from, $to)
private function check_data_validity($definition_id, $from, $to)
{
$success = FALSE;
if($from === TEXT)
{
$this->db->select('item_id,attribute_value');
$this->db->from('attribute_values');
$this->db->join('attribute_links', 'attribute_values.attribute_id = attribute_links.attribute_id');
$this->db->where('definition_id',$definition);
$success = TRUE;
if($to === DATE)
$this->db->distinct()->select('attribute_value');
$this->db->join('attribute_links', 'attribute_values.attribute_id = attribute_links.attribute_id');
$this->db->where('definition_id', $definition_id);
foreach($this->db->get('attribute_values')->result() as $attribute)
{
foreach($this->db->get()->result_array() as $row)
switch($to)
{
if(valid_date($row['attribute_value']) === FALSE)
{
log_message('ERROR', 'item_id: ' . $row['item_id'] . ' with attribute_value: ' . $row['attribute_value'] . ' cannot be converted to datetime');
$success = FALSE;
}
case DATE:
$success = valid_date($attribute->attribute_value);
break;
case DECIMAL:
$success = valid_decimal($attribute->attribute_value);
break;
}
}
else if($to === DECIMAL)
{
foreach($this->db->get()->result_array() as $row)
if($success === FALSE)
{
if(valid_decimal($row['attribute_value']) === FALSE)
$affected_items = $this->get_items_by_value($attribute->attribute_value, $definition_id);
foreach($affected_items as $affected_item)
{
log_message('ERROR', 'item_id: ' . $row['item_id'] . ' with attribute_value: ' . $row['attribute_value'] . ' cannot be converted to decimal');
$success = FALSE;
$affected_items[] = $affected_item['item_id'];
}
log_message('ERROR', "Attribute_value: '$attribute->attribute_value' cannot be converted to $to. Affected Items: ". implode(',', $affected_items));
unset($affected_items);
}
}
}
return $success;
}
private function convert_definition_type($definition_id, $from_type, $to_type)
/**
* Returns all item_ids with a specific attribute_value and attribute_definition
* @param string $attribute_value
* @param int $definition_id
* @return array
*/
private function get_items_by_value($attribute_value, $definition_id)
{
$this->db->select('item_id');
$this->db->join('attribute_values', 'attribute_values.attribute_id = attribute_links.attribute_id');
$this->db->where('definition_id', $definition_id);
$this->db->where('attribute_value', $attribute_value);
return $this->db->get('attribute_links')->result_array();
}
/**
* Converts data in attribute_values and attribute_links tables associated with the conversion of one attribute type to another.
* @param int $definition_id
* @param string $from_type
* @param string $to_type
* @return boolean
*/
private function convert_definition_data($definition_id, $from_type, $to_type)
{
$success = FALSE;
//From TEXT
if($from_type === TEXT)
{
//To DATETIME or DECIMAL
if(in_array($to_type, [DATE, DECIMAL], TRUE))
{
$field = ($to_type === DATE ? 'attribute_date' : 'attribute_decimal');
if($this->check_data_validity($definition_id, $from_type, $to_type))
{
$this->db->trans_start();
$query = 'UPDATE ospos_attribute_values ';
$query .= 'INNER JOIN ospos_attribute_links ';
$query .= 'ON ospos_attribute_values.attribute_id = ospos_attribute_links.attribute_id ';
$query .= 'SET '. $field .'= attribute_value, ';
$query .= 'attribute_value = NULL ';
$query .= 'WHERE definition_id = ' . $this->db->escape($definition_id);
$success = $this->db->query($query);
$this->db->trans_complete();
$attributes_to_convert = $this->get_attributes_by_definition($definition_id);
$success = $this->attribute_cleanup($attributes_to_convert, $definition_id, $to_type);
}
}
//To DROPDOWN or CHECKBOX
else if($to_type === DROPDOWN)
{
$success = TRUE;
@@ -333,57 +354,44 @@ class Attribute extends CI_Model
$this->db->trans_start();
$query = 'UPDATE ospos_attribute_values values ';
$query .= 'INNER JOIN ospos_attribute_links links ';
$query .= 'ON values.attribute_id = links.attribute_id ';
$query .= "SET links.attribute_id = IF((values.attribute_value IN('FALSE','0','') OR (values.attribute_value IS NULL)), $checkbox_attribute_values[0], $checkbox_attribute_values[1]) ";
$query .= 'WHERE definition_id = ' . $this->db->escape($definition_id);
$query = 'UPDATE '. $this->db->dbprefix('attribute_links') .' links ';
$query .= 'JOIN '. $this->db->dbprefix('attribute_values') .' vals ';
$query .= 'ON vals.attribute_id = links.attribute_id ';
$query .= "SET links.attribute_id = IF((attribute_value IN('FALSE','0','') OR (attribute_value IS NULL)), $checkbox_attribute_values[0], $checkbox_attribute_values[1]) ";
$query .= 'WHERE definition_id = '. $this->db->escape($definition_id);
$success = $this->db->query($query);
$this->db->trans_complete();
}
}
//From DROPDOWN
else if($from_type === DROPDOWN)
{
//To TEXT
if(in_array($to_type, [TEXT, CHECKBOX], TRUE))
{
$this->db->trans_start();
$this->db->from('ospos_attribute_links');
$this->db->where('definition_id',$definition_id);
$this->db->where('item_id', NULL);
$success = $this->db->delete();
$this->db->trans_complete();
//To CHECKBOX
if($to_type === CHECKBOX)
{
$checkbox_attribute_values = $this->checkbox_attribute_values($definition_id);
$this->db->trans_start();
$query = 'UPDATE ospos_attribute_values vals ';
$query .= 'INNER JOIN ospos_attribute_links links ';
$query = 'UPDATE '. $this->db->dbprefix('attribute_links') .' links ';
$query .= 'JOIN '. $this->db->dbprefix('attribute_values') .' vals ';
$query .= 'ON vals.attribute_id = links.attribute_id ';
$query .= "SET links.attribute_id = IF((vals.attribute_value IN('FALSE','0','') OR (vals.attribute_value IS NULL)), $checkbox_attribute_values[0], $checkbox_attribute_values[1]) ";
$query .= 'WHERE links.definition_id = ' . $this->db->escape($definition_id);
$query .= "SET links.attribute_id = IF((attribute_value IN('FALSE','0','') OR (attribute_value IS NULL)), $checkbox_attribute_values[0], $checkbox_attribute_values[1]) ";
$query .= 'WHERE definition_id = '. $this->db->escape($definition_id);
$success = $this->db->query($query);
$this->db->trans_complete();
}
}
}
//From any other type
else
{
$success = TRUE;
}
$this->delete_orphaned_links($definition_id);
$this->delete_orphaned_values();
return $success;
}
@@ -410,7 +418,6 @@ class Attribute extends CI_Model
*/
public function save_definition(&$definition_data, $definition_id = NO_DEFINITION_ID)
{
//Run these queries as a transaction, we want to make sure we do all or nothing
$this->db->trans_start();
//Definition doesn't exist
@@ -418,7 +425,7 @@ class Attribute extends CI_Model
{
if($this->exists($definition_id,TRUE))
{
$success = $this->undelete($definition_id);
$success = $this->undelete_definition($definition_id);
}
else
{
@@ -430,26 +437,27 @@ class Attribute extends CI_Model
//Definition already exists
else
{
$this->db->select('definition_type, definition_name');
$this->db->from('attribute_definitions');
//Get current definition type and name
$this->db->select('definition_type');
$this->db->where('definition_id', $definition_id);
$row = $this->db->get()->row();
$row = $this->db->get('attribute_definitions')->row();
$from_definition_type = $row->definition_type;
$from_definition_name = $row->definition_name;
$to_definition_type = $definition_data['definition_type'];
//Update the definition values
$this->db->where('definition_id', $definition_id);
$success = $this->db->update('attribute_definitions', $definition_data);
$definition_data['definition_id'] = $definition_id;
if($from_definition_type !== $to_definition_type)
{
if(!$this->convert_definition_type($definition_id,$from_definition_type,$to_definition_type))
if($this->convert_definition_data($definition_id, $from_definition_type, $to_definition_type) === FALSE)
{
return FALSE;
}
}
$this->db->where('definition_id', $definition_id);
$success = $this->db->update('attribute_definitions', $definition_data);
$definition_data['definition_id'] = $definition_id;
}
$this->db->trans_complete();
@@ -461,14 +469,14 @@ class Attribute extends CI_Model
public function get_definition_by_name($definition_name, $definition_type = FALSE)
{
$this->db->from('attribute_definitions');
$this->db->where('definition_name', $definition_name);
if($definition_type != FALSE)
{
$this->db->where('definition_type', $definition_type);
}
return $this->db->get()->result_array();
return $this->db->get('attribute_definitions')->result_array();
}
public function save_link($item_id, $definition_id, $attribute_id)
@@ -485,7 +493,10 @@ class Attribute extends CI_Model
}
else
{
$this->db->insert('attribute_links', array('attribute_id' => $attribute_id, 'item_id' => $item_id, 'definition_id' => $definition_id));
$this->db->insert('attribute_links', array(
'attribute_id' => $attribute_id,
'item_id' => $item_id,
'definition_id' => $definition_id));
}
$this->db->trans_complete();
@@ -493,20 +504,30 @@ class Attribute extends CI_Model
return $this->db->trans_status();
}
public function delete_link($item_id)
public function delete_link($item_id, $definition_id = FALSE)
{
$delete_data = array('item_id' => $item_id);
//Exclude rows where sale_id or receiving_id has a value
$this->db->where('sale_id');
$this->db->where('receiving_id');
return $this->db->delete('attribute_links', array('item_id' => $item_id));
if(!empty($definition_id))
{
$delete_data += ['definition_id' => $definition_id];
}
$success = $this->db->delete('attribute_links', $delete_data);
return $success;
}
public function get_link_value($item_id, $definition_id)
{
$this->db->where('item_id', $item_id);
$this->db->where('definition_id', $definition_id);
$this->db->where('sale_id');
$this->db->where('receiving_id');
$this->db->where('definition_id', $definition_id);
return $this->db->get('attribute_links')->row_object();
}
@@ -516,11 +537,11 @@ class Attribute extends CI_Model
$format = $this->db->escape(dateformat_mysql());
$this->db->select("GROUP_CONCAT(attribute_value SEPARATOR ', ') AS attribute_values");
$this->db->select("GROUP_CONCAT(DATE_FORMAT(attribute_date, $format) SEPARATOR ', ') AS attribute_dtvalues");
$this->db->from('attribute_links');
$this->db->join('attribute_values', 'attribute_values.attribute_id = attribute_links.attribute_id');
$this->db->join('attribute_definitions', 'attribute_definitions.definition_id = attribute_links.definition_id');
$this->db->where('definition_type <>', GROUP);
$this->db->where('deleted', 0);
$this->db->where('item_id', intval($item_id));
if(!empty($id))
{
@@ -532,37 +553,47 @@ class Attribute extends CI_Model
$this->db->where('receiving_id');
}
$this->db->where('item_id', (int) $item_id);
$this->db->where('definition_flags & ', $definition_flags);
return $this->db->get();
return $this->db->get('attribute_links');
}
public function get_attribute_value($item_id, $definition_id)
{
$this->db->from('attribute_values');
$this->db->join('attribute_links', 'attribute_links.attribute_id = attribute_values.attribute_id');
$this->db->where('definition_id', $definition_id);
$this->db->where('item_id', intval($item_id));
$this->db->where('sale_id');
$this->db->where('receiving_id');
$this->db->where('item_id', (int) $item_id);
$this->db->where('definition_id', $definition_id);
return $this->db->get()->row_object();
return $this->db->get('attribute_values')->row_object();
}
public function get_attribute_values($item_id)
{
$this->db->select('attribute_values.attribute_value, attribute_values.attribute_decimal, attribute_values.attribute_date, attribute_links.definition_id');
$this->db->join('attribute_values', 'attribute_links.attribute_id = attribute_values.attribute_id');
$this->db->where('item_id', intval($item_id));
$results = $this->db->get('attribute_links')->result_array();
return $this->to_array($results, 'definition_id');
}
public function copy_attribute_links($item_id, $sale_receiving_fk, $id)
{
$this->db->query(
'INSERT INTO ospos_attribute_links (item_id, definition_id, attribute_id, ' . $sale_receiving_fk . ')
SELECT ' . $this->db->escape($item_id) . ', definition_id, attribute_id, ' . $this->db->escape($id) . '
FROM ' . $this->db->dbprefix('attribute_links') . '
WHERE item_id = ' . $this->db->escape($item_id) . ' AND sale_id IS NULL AND receiving_id IS NULL'
'INSERT INTO ' . $this->db->dbprefix('attribute_links') . ' (item_id, definition_id, attribute_id, ' . $sale_receiving_fk . ')
SELECT ' . $this->db->escape($item_id) . ', definition_id, attribute_id, ' . $this->db->escape($id) . '
FROM ' . $this->db->dbprefix('attribute_links') . '
WHERE item_id = ' . $this->db->escape($item_id) . ' AND sale_id IS NULL AND receiving_id IS NULL'
);
}
public function get_suggestions($definition_id, $term)
{
$suggestions = array();
$suggestions = [];
$this->db->distinct();
$this->db->select('attribute_value, attribute_values.attribute_id');
$this->db->from('attribute_definitions AS definition');
@@ -586,25 +617,32 @@ class Attribute extends CI_Model
{
$this->db->trans_start();
$locale_date_format = $this->Appconfig->get('dateformat');
//New Attribute
if(empty($attribute_id) || empty($item_id))
{
if(in_array($definition_type, [TEXT, DROPDOWN, CHECKBOX], TRUE))
{
$attribute_id = $this->value_exists($attribute_value);
//Update attribute_value
$attribute_id = $this->value_exists($attribute_value, $definition_type);
if(empty($attribute_id))
if($attribute_id === FALSE)
{
switch($definition_type)
{
$this->db->insert('attribute_values', array('attribute_value' => $attribute_value));
case DATE:
$data_type = 'date';
$attribute_date_value = DateTime::createFromFormat($locale_date_format, $attribute_value);
$attribute_value = $attribute_date_value->format('Y-m-d');
break;
case DECIMAL:
$data_type = 'decimal';
break;
default:
$data_type = 'value';
break;
}
}
else if($definition_type == DECIMAL)
{
$this->db->insert('attribute_values', array('attribute_decimal' => $attribute_value));
}
else
{
$this->db->insert('attribute_values', array('attribute_date' => date('Y-m-d', strtotime($attribute_value))));
$this->db->insert('attribute_values', array("attribute_$data_type" => $attribute_value));
}
$attribute_id = $attribute_id ? $attribute_id : $this->db->insert_id();
@@ -614,24 +652,26 @@ class Attribute extends CI_Model
'item_id' => empty($item_id) ? NULL : $item_id,
'definition_id' => $definition_id));
}
//Existing Attribute
else
{
$this->db->where('attribute_id', $attribute_id);
switch($definition_type)
{
case DATE:
$data_type = 'date';
$attribute_date_value = DateTime::createFromFormat($locale_date_format, $attribute_value);
$attribute_value = $attribute_date_value->format('Y-m-d');
break;
case DECIMAL:
$data_type = 'decimal';
break;
default:
$data_type = 'value';
break;
}
if(in_array($definition_type, [TEXT, DROPDOWN], TRUE))
{
$this->db->update('attribute_values', array('attribute_value' => $attribute_value));
}
else if($definition_type == DECIMAL)
{
$this->db->update('attribute_values', array('attribute_decimal' => $attribute_value));
}
else
{
$this->db->update('attribute_values', array('attribute_date' => date('Y-m-d', strtotime($attribute_value))));
}
$this->db->where('attribute_id', $attribute_id);
$this->db->update('attribute_values', array("attribute_$data_type" => $attribute_value));
}
$this->db->trans_complete();
@@ -641,14 +681,14 @@ class Attribute extends CI_Model
public function delete_value($attribute_value, $definition_id)
{
return $this->db->query("DELETE atrv, atrl FROM " . $this->db->dbprefix('attribute_values') . " atrv, " . $this->db->dbprefix('attribute_links') . " atrl " .
"WHERE atrl.attribute_id = atrv.attribute_id AND atrv.attribute_value = " . $this->db->escape($attribute_value) . " AND atrl.definition_id = " . $this->db->escape($definition_id));
return $this->db->query('DELETE atrv, atrl FROM ' . $this->db->dbprefix('attribute_values') . ' atrv, ' . $this->db->dbprefix('attribute_links') . ' atrl ' .
'WHERE atrl.attribute_id = atrv.attribute_id AND atrv.attribute_value = ' . $this->db->escape($attribute_value) . ' AND atrl.definition_id = ' . $this->db->escape($definition_id));
}
/**
* Deletes an Attribute definition from the database and associated column in the items_import.csv
*
* @param unknown $definition_id Attribute definition ID to remove.
* @param int $definition_id Attribute definition ID to remove.
* @return boolean TRUE if successful and FALSE if there is a failure
*/
public function delete_definition($definition_id)
@@ -666,6 +706,33 @@ class Attribute extends CI_Model
}
/**
* Deletes any attribute_links for a specific definition that do not have an item_id associated with them and are not DROPDOWN types
*
* @param int $definition_id
* @return boolean TRUE is returned if the delete was successful or FALSE if there were any failures
*/
public function delete_orphaned_links($definition_id)
{
$this->db->select('definition_type');
$this->db->where('definition_id', $definition_id);
$definition = $this->db->get('attribute_definitions')->row();
if($definition->definition_type != DROPDOWN)
{
$this->db->trans_start();
$this->db->where('item_id');
$this->db->where('definition_id', $definition_id);
$this->db->delete('attribute_links');
$this->db->trans_complete();
return $this->db->trans_status();
}
}
/*
* Deletes any orphaned values that do not have associated links
* @param int $definition_id
* @return boolean TRUE is returned if the delete was successful or FALSE if there were any failures
@@ -693,6 +760,48 @@ class Attribute extends CI_Model
{
$this->db->where('definition_id', $definition_id);
return $this->db->update('attribute_definitions', array('deleted'=>0));
return $this->db->update('attribute_definitions', array('deleted' => 0));
}
/**
*
* @param array attributes attributes that need to be fixed
* @param int $definition_id
* @param string $definition_type This dictates what column should be populated in any new attribute_values that are created
*/
public function attribute_cleanup($attributes, $definition_id, $definition_type)
{
$this->db->trans_begin();
foreach($attributes as $attribute)
{
$new_attribute_id = $this->save_value($attribute['attribute_value'], $definition_id, FALSE, $attribute['attribute_id'], $definition_type);
if($this->save_link($attribute['item_id'], $definition_id, $new_attribute_id) == FALSE)
{
log_message('Error', 'Transaction failed');
$this->db->trans_rollback();
return FALSE;
}
}
$success = $this->delete_orphaned_links($definition_id);
$this->db->trans_commit();
return $success;
}
/**
* Returns all attribute_ids and item_ids assigned to that definition_id
*
* @param int $definition_id
* @return array All attribute_id and item_id pairs in the attribute_links table with that attribute definition_id
*/
public function get_attributes_by_definition($definition_id)
{
$this->db->select('attribute_links.attribute_id, item_id, attribute_value, attribute_decimal, attribute_date');
$this->db->join('attribute_values', 'attribute_values.attribute_id = attribute_links.attribute_id');
$this->db->where('definition_id', $definition_id);
return $this->db->get('attribute_links')->result_array();
}
}