From 3e3da57543594917eb8fa3d21017359795f5ac0d Mon Sep 17 00:00:00 2001
From: objecttothis <objecttothis@gmail.com>
Date: Mon, 4 Dec 2023 15:05:36 +0400
Subject: [PATCH] Fixed multiselect form issues

- Missing `[]` in name of multiselect form.
---
 app/Controllers/Config.php           | 16 ++++++++--------
 app/Views/configs/general_config.php | 14 +++++++-------
 2 files changed, 15 insertions(+), 15 deletions(-)

diff --git a/app/Controllers/Config.php b/app/Controllers/Config.php
index df371d0e6..f0282c54c 100644
--- a/app/Controllers/Config.php
+++ b/app/Controllers/Config.php
@@ -272,19 +272,18 @@ class Config extends Secure_Controller
 		$data['currency_code'] = $this->config['currency_code'] ?? '';
 		$data['db_version'] = mysqli_get_server_info($this->db->getConnection());
 
-		// load all the license statements, they are already XSS cleaned in the private function
+		//Load all the license statements, they are already XSS cleaned in the private function
 		$data['licenses'] = $this->_licenses();
 
-		// load all the themes, already XSS cleaned in the private function
+		//Load all the themes, already XSS cleaned in the private function
 		$data['themes'] = $this->_themes();
 
-		//Load General related fields
+		//General related fields
 		$image_allowed_types = ['jpg','jpeg','gif','svg','webp','bmp','png','tif','tiff'];
-		$data['image_allowed_types'] = array_combine($image_allowed_types,$image_allowed_types);
-
+		$data['image_allowed_types'] = array_combine($image_allowed_types, $image_allowed_types);
 		$data['selected_image_allowed_types'] = explode('|', $this->config['image_allowed_types']);
 
-		//Load Integrations Related fields
+		//Integrations Related fields
 		$data['mailchimp']	= [];
 
 		if(check_encryption())	//TODO: Hungarian notation
@@ -390,6 +389,7 @@ class Config extends Secure_Controller
 
 	/**
 	 * @throws ReflectionException
+	 * @noinspection PhpUnused
 	 */
 	public function postSaveGeneral(): void
 	{
@@ -403,8 +403,8 @@ class Config extends Secure_Controller
 			'enforce_privacy' => $this->request->getPost('enforce_privacy', FILTER_SANITIZE_NUMBER_INT),
 			'receiving_calculate_average_price' => $this->request->getPost('receiving_calculate_average_price') != null,
 			'lines_per_page' => $this->request->getPost('lines_per_page', FILTER_SANITIZE_NUMBER_INT),
-			'notify_horizontal_position' => $this->request->getPost('notify_horizontal_position'),
-			'notify_vertical_position' => $this->request->getPost('notify_vertical_position'),
+			'notify_horizontal_position' => htmlspecialchars($this->request->getPost('notify_horizontal_position')),
+			'notify_vertical_position' => htmlspecialchars($this->request->getPost('notify_vertical_position')),
 			'image_max_width' => $this->request->getPost('image_max_width', FILTER_SANITIZE_NUMBER_INT),
 			'image_max_height' => $this->request->getPost('image_max_height', FILTER_SANITIZE_NUMBER_INT),
 			'image_max_size' => $this->request->getPost('image_max_size', FILTER_SANITIZE_NUMBER_INT),
diff --git a/app/Views/configs/general_config.php b/app/Views/configs/general_config.php
index f074accf3..731ef3ebb 100644
--- a/app/Views/configs/general_config.php
+++ b/app/Views/configs/general_config.php
@@ -243,15 +243,15 @@
 							<div class='input-group'>
 								<span class="input-group-addon input-sm"><?= lang('Config.image_allowed_file_types') ?></span>
 								<?= form_multiselect([
-									'name' => 'image_allowed_types',
+									'name' => 'image_allowed_types[]',
 									'options' => $image_allowed_types,
 									'selected' => $selected_image_allowed_types,
-									'extra' => "id='image_allowed_types'".
-										"class='selectpicker show-menu-arrow'".
-										"data-none-selected-text=".lang('Common.none_selected_text').
-										"data-selected-text-format='count > 1'".
-										"data-style='btn-default btn-sm'".
-										"data-width='100%'"
+									'extra' => "id='image_allowed_types'"
+										. " class='selectpicker show-menu-arrow'"
+										. " data-none-selected-text='" . lang('Common.none_selected_text') . "'"
+										. " data-selected-text-format='count > 1'"
+										. " data-style='btn-default btn-sm'"
+										. " data-width='100%'"
 								]) ?>
 							</div>
 						</div>