From 3f82ac179a1dbdd430ec8e4bbec93ef92e72d119 Mon Sep 17 00:00:00 2001 From: Joe Williams Date: Tue, 16 Sep 2025 12:14:05 -0700 Subject: [PATCH] Added transaction to `Migration_MissingConfigKeys.up()`. --- .../20250716170000_MissingConfigKeys.php | 16 +++++++++++++--- 1 file changed, 13 insertions(+), 3 deletions(-) diff --git a/app/Database/Migrations/20250716170000_MissingConfigKeys.php b/app/Database/Migrations/20250716170000_MissingConfigKeys.php index 4ae39c9cc..636c40cee 100644 --- a/app/Database/Migrations/20250716170000_MissingConfigKeys.php +++ b/app/Database/Migrations/20250716170000_MissingConfigKeys.php @@ -11,12 +11,22 @@ class Migration_MissingConfigKeys extends Migration */ public function up(): void { - error_log('Migrating config table'); + error_log('Starting transaction...'); + $db = db_connect(); + $db->transStart(); helper('migration'); - execute_script(APPPATH . 'Database/Migrations/sqlscripts/3.4.2_missing_config_keys.sql'); - error_log('Migrating config table'); + // execute_script returns whether everything executed successfully + if (execute_script(APPPATH . 'Database/Migrations/sqlscripts/3.4.2_missing_config_keys.sql')) { + error_log('Migrated config table.'); + } + else { + error_log('Failed to migrate config table.'); + } + + error_log('Transaction completed.'); + $db->transComplete(); } /**