From a3fb05b566ebe1683e540824f4a16c91410cc9f0 Mon Sep 17 00:00:00 2001
From: objecttothis <objecttothis@gmail.com>
Date: Wed, 3 Jun 2020 14:15:05 +0400
Subject: [PATCH] Change the locations of global constants to make them global
 across files

- Items Constants
- Attributes Constants
- Sale Constants
---
 application/config/constants.php | 61 ++++++++++++++++++++++++++++++++
 application/models/Attribute.php | 13 -------
 application/models/Item.php      | 27 --------------
 application/models/Sale.php      | 15 --------
 4 files changed, 61 insertions(+), 55 deletions(-)

diff --git a/application/config/constants.php b/application/config/constants.php
index 18d3b4b76..4815db1b4 100644
--- a/application/config/constants.php
+++ b/application/config/constants.php
@@ -83,3 +83,64 @@ defined('EXIT_USER_INPUT')     OR define('EXIT_USER_INPUT', 7); // invalid user
 defined('EXIT_DATABASE')       OR define('EXIT_DATABASE', 8); // database error
 defined('EXIT__AUTO_MIN')      OR define('EXIT__AUTO_MIN', 9); // lowest automatically-assigned error code
 defined('EXIT__AUTO_MAX')      OR define('EXIT__AUTO_MAX', 125); // highest automatically-assigned error code
+
+/*
+ | Attribute Related Constants.
+ */
+define('GROUP', 'GROUP');
+define('DROPDOWN', 'DROPDOWN');
+define('DECIMAL', 'DECIMAL');
+define('DATE', 'DATE');
+define('TEXT', 'TEXT');
+define('CHECKBOX', 'CHECKBOX');
+define(NO_DEFINITION_ID, 0);
+define(CATEGORY_DEFINITION_ID, -1);
+
+
+const DEFINITION_TYPES = [GROUP, DROPDOWN, DECIMAL, TEXT, DATE, CHECKBOX];
+
+
+/*
+ | Item Related Constants.
+ */
+define('HAS_STOCK', 0);
+define('HAS_NO_STOCK', 1);
+
+define('ITEM', 0);
+define('ITEM_KIT', 1);
+define('ITEM_AMOUNT_ENTRY', 2);
+define('ITEM_TEMP', 3);
+
+define('PRINT_ALL', 0);
+define('PRINT_PRICED', 1);
+define('PRINT_KIT', 2);
+
+define('PRINT_YES', 0);
+define('PRINT_NO', 1);
+
+define('PRICE_ALL', 0);
+define('PRICE_KIT', 1);
+define('PRICE_KIT_ITEMS', 2);
+
+define('PRICE_OPTION_ALL', 0);
+define('PRICE_OPTION_KIT', 1);
+define('PRICE_OPTION_KIT_STOCK', 2);
+
+define('NAME_SEPARATOR', ' | ');
+
+/*
+ | Sale Related Constants.
+ */
+define('COMPLETED', 0);
+define('SUSPENDED', 1);
+define('CANCELED', 2);
+
+
+define('SALE_TYPE_POS', 0);
+define('SALE_TYPE_INVOICE', 1);
+define('SALE_TYPE_WORK_ORDER', 2);
+define('SALE_TYPE_QUOTE', 3);
+define('SALE_TYPE_RETURN', 4);
+
+define('PERCENT', 0);
+define('FIXED', 1);
\ No newline at end of file
diff --git a/application/models/Attribute.php b/application/models/Attribute.php
index bff19d90f..854de040c 100644
--- a/application/models/Attribute.php
+++ b/application/models/Attribute.php
@@ -1,17 +1,4 @@
 <?php if (!defined('BASEPATH')) exit('No direct script access allowed');
-
-define('GROUP', 'GROUP');
-define('DROPDOWN', 'DROPDOWN');
-define('DECIMAL', 'DECIMAL');
-define('DATE', 'DATE');
-define('TEXT', 'TEXT');
-define('CHECKBOX', 'CHECKBOX');
-define(NO_DEFINITION_ID, 0);
-define(CATEGORY_DEFINITION_ID, -1);
-
-
-const DEFINITION_TYPES = [GROUP, DROPDOWN, DECIMAL, TEXT, DATE, CHECKBOX];
-
 /**
  * Attribute class
  */
diff --git a/application/models/Item.php b/application/models/Item.php
index fb7abc70f..742054513 100644
--- a/application/models/Item.php
+++ b/application/models/Item.php
@@ -1,31 +1,4 @@
 <?php if (!defined('BASEPATH')) exit('No direct script access allowed');
-
-define('HAS_STOCK', 0);
-define('HAS_NO_STOCK', 1);
-
-define('ITEM', 0);
-define('ITEM_KIT', 1);
-define('ITEM_AMOUNT_ENTRY', 2);
-define('ITEM_TEMP', 3);
-
-define('PRINT_ALL', 0);
-define('PRINT_PRICED', 1);
-define('PRINT_KIT', 2);
-
-define('PRINT_YES', 0);
-define('PRINT_NO', 1);
-
-define('PRICE_ALL', 0);
-define('PRICE_KIT', 1);
-define('PRICE_KIT_ITEMS', 2);
-
-define('PRICE_OPTION_ALL', 0);
-define('PRICE_OPTION_KIT', 1);
-define('PRICE_OPTION_KIT_STOCK', 2);
-
-define('NAME_SEPARATOR', ' | ');
-
-
 /**
  * Item class
  */
diff --git a/application/models/Sale.php b/application/models/Sale.php
index 991583796..3d7132058 100644
--- a/application/models/Sale.php
+++ b/application/models/Sale.php
@@ -1,22 +1,7 @@
 <?php if (!defined('BASEPATH')) exit('No direct script access allowed');
-
-define('COMPLETED', 0);
-define('SUSPENDED', 1);
-define('CANCELED', 2);
-
-
-define('SALE_TYPE_POS', 0);
-define('SALE_TYPE_INVOICE', 1);
-define('SALE_TYPE_WORK_ORDER', 2);
-define('SALE_TYPE_QUOTE', 3);
-define('SALE_TYPE_RETURN', 4);
-
-define('PERCENT', 0);
-define('FIXED', 1);
 /**
  * Sale class
  */
-
 class Sale extends CI_Model
 {
 	/**