From 64023f6eec8952007b10a6477c3bd000038e95bc Mon Sep 17 00:00:00 2001 From: jekkos Date: Thu, 8 Oct 2015 17:28:27 +0200 Subject: [PATCH] Avoid comments coercion to 0 when suspending sales (#192) Invoice number in suspended sales should not be unique --- application/libraries/Receiving_lib.php | 3 +-- application/libraries/Sale_lib.php | 3 +-- 2 files changed, 2 insertions(+), 4 deletions(-) diff --git a/application/libraries/Receiving_lib.php b/application/libraries/Receiving_lib.php index 568fb6952..4df7705c0 100644 --- a/application/libraries/Receiving_lib.php +++ b/application/libraries/Receiving_lib.php @@ -61,8 +61,7 @@ class Receiving_lib function get_comment() { // avoid returning a null that results in a 0 in the comment if nothing is set/available - - return $this->CI->session->userdata('comment') != null ? $this->CI->session->userdata('comment') : ''; + return empty($this->CI->session->userdata('comment')) ? '' : $this->CI->session->userdata('comment'); } function set_comment($comment) diff --git a/application/libraries/Sale_lib.php b/application/libraries/Sale_lib.php index 60ff3a6fe..49816d831 100644 --- a/application/libraries/Sale_lib.php +++ b/application/libraries/Sale_lib.php @@ -40,8 +40,7 @@ class Sale_lib function get_comment() { // avoid returning a null that results in a 0 in the comment if nothing is set/available - - return $this->CI->session->userdata('comment') != null ? $this->CI->session->userdata('comment') : ''; + return empty($this->CI->session->userdata('comment')) ? '' : $this->CI->session->userdata('comment'); } function set_comment($comment)