diff --git a/app/Controllers/Items.php b/app/Controllers/Items.php index 5395a6f15..c96939d23 100644 --- a/app/Controllers/Items.php +++ b/app/Controllers/Items.php @@ -109,15 +109,12 @@ class Items extends Secure_Controller $offset = $this->request->getGet('offset', FILTER_SANITIZE_NUMBER_INT); $definition_names = $this->attribute->get_definitions_by_flags(Attribute::SHOW_IN_ITEMS); - $attribute_column_ids = array_keys($definition_names); $sort = $this->sanitizeSortColumn(item_sort_columns(), $this->request->getGet('sort', FILTER_SANITIZE_FULL_SPECIAL_CHARS), 'items.item_id'); $order = $this->request->getGet('order', FILTER_SANITIZE_FULL_SPECIAL_CHARS); $this->item_lib->set_item_location($this->request->getGet('stock_location')); - $definition_names = $this->attribute->get_definitions_by_flags(Attribute::SHOW_IN_ITEMS); - $filters = [ 'start_date' => $this->request->getGet('start_date'), 'end_date' => $this->request->getGet('end_date'), diff --git a/app/Helpers/tabular_helper.php b/app/Helpers/tabular_helper.php index 8b41deac6..0dda13ffc 100644 --- a/app/Helpers/tabular_helper.php +++ b/app/Helpers/tabular_helper.php @@ -402,7 +402,8 @@ function item_headers(): array } /** - * Get all sortable column keys for items table, including dynamic attribute columns + * Get all sortable column keys for items table, including dynamic attribute columns. + * * @return array Array of column keys that are valid for sorting */ function item_sort_columns(): array diff --git a/app/Models/Item.php b/app/Models/Item.php index 7108477c9..d1e5bf0ba 100644 --- a/app/Models/Item.php +++ b/app/Models/Item.php @@ -59,7 +59,6 @@ class Item extends Model 'hsn_code' ]; - /** * Determines if a given item_id is an item */