From 9428d1cd61db813a4220135fecd2d6a1f9fe27e1 Mon Sep 17 00:00:00 2001
From: objecttothis <objecttothis@gmail.com>
Date: Tue, 9 Apr 2024 14:24:18 +0400
Subject: [PATCH] Attribute item form

- Updated formatting to reflect standard
- Wrapped Decimal type in to_decimals() function for localization

Signed-off-by: objecttothis <objecttothis@gmail.com>
---
 app/Views/attributes/item.php | 30 ++++++++++++++++++++++++++----
 1 file changed, 26 insertions(+), 4 deletions(-)

diff --git a/app/Views/attributes/item.php b/app/Views/attributes/item.php
index f48f93b21..1ae91bb7d 100644
--- a/app/Views/attributes/item.php
+++ b/app/Views/attributes/item.php
@@ -9,7 +9,13 @@
 <div class="form-group form-group-sm">
 	<?= form_label(lang('Attributes.definition_name'), 'definition_name_label', ['class' => 'control-label col-xs-3']) ?>
 	<div class='col-xs-8'>
-		<?= form_dropdown('definition_name', $definition_names, -1, ['id' => 'definition_name', 'class' => 'form-control']) ?>
+		<?= form_dropdown([
+			'name' => 'definition_name',
+			'options' => $definition_names,
+			'selected' => -1,
+			'class' => 'form-control',
+			'id' => 'definition_name'
+		]) ?>
 	</div>
 
 </div>
@@ -41,15 +47,31 @@ foreach($definition_values as $definition_id => $definition_value)
 						break;
 					case DROPDOWN:
 						$selected_value = $definition_value['selected_value'];
-						echo form_dropdown("attribute_links[$definition_id]", $definition_value['values'], $selected_value, "class='form-control' data-definition-id='$definition_id'");
+						echo form_dropdown([
+							'name' => "attribute_links[$definition_id]",
+							'options' => $definition_value['values'],
+							'selected' => $selected_value,
+							'class' => 'form-control',
+							'data-definition-id' => $definition_id
+						]);
 						break;
 					case TEXT:
 						$value = (empty($attribute_value) || empty($attribute_value->attribute_value)) ? $definition_value['selected_value'] : $attribute_value->attribute_value;
-						echo form_input("attribute_links[$definition_id]", $value, "class='form-control valid_chars' data-definition-id='$definition_id'");
+						echo form_input([
+							'name' => "attribute_links[$definition_id]",
+							'value' => $value,
+							'class' => 'form-control valid_chars',
+							'data-definition-id' => $definition_id
+						]);
 						break;
 					case DECIMAL:
 						$value = (empty($attribute_value) || empty($attribute_value->attribute_decimal)) ? $definition_value['selected_value'] : $attribute_value->attribute_decimal;
-						echo form_input("attribute_links[$definition_id]", $value, "class='form-control valid_chars' data-definition-id='$definition_id'");
+						echo form_input([
+							'name' => "attribute_links[$definition_id]",
+							'value' => to_decimals((float)$value),
+							'class' => 'form-control valid_chars',
+							'data-definition-id' => $definition_id
+						]);
 						break;
 					case CHECKBOX:
 						$value = (empty($attribute_value) || empty($attribute_value->attribute_value)) ? $definition_value['selected_value'] : $attribute_value->attribute_value;