mirror/opensourcepos
1
0
Fork 0
mirror of https://github.com/opensourcepos/opensourcepos.git synced 2026-05-18 13:28:32 -04:00
Code Issues Packages Projects Releases Wiki Activity

Refactoring Change Register Mode

Browse Source 
Switched from conditional if stmt to case
This commit is contained in:
WShells
2024-04-17 13:59:05 +03:00
committed by jekkos
parent ec283e24dc
commit 9fc2a4edbd
1 changed files with 23 additions and 24 deletions
Download Patch File Download Diff File Expand all files Collapse all files

47
app/Controllers/Sales.php
View File

@@ -281,33 +281,32 @@ class Sales extends Secure_Controller
* @return void
*/
public function change_register_mode(int $sale_type): void
{//TODO: This set of if statements should be refactored to a switch
if($sale_type == SALE_TYPE_POS)
{
$this->sale_lib->set_mode('sale');
}
elseif($sale_type == SALE_TYPE_QUOTE)
{
$this->sale_lib->set_mode('sale_quote');
}
elseif($sale_type == SALE_TYPE_WORK_ORDER)
{
$this->sale_lib->set_mode('sale_work_order');
}
elseif($sale_type == SALE_TYPE_INVOICE)
{
$this->sale_lib->set_mode('sale_invoice');
}
elseif($sale_type == SALE_TYPE_RETURN)
{
$this->sale_lib->set_mode('return');
}
else
{
$this->sale_lib->set_mode('sale');
{
switch ($sale_type) {
case SALE_TYPE_POS:
$mode = 'sale';
break;
case SALE_TYPE_QUOTE:
$mode = 'sale_quote';
break;
case SALE_TYPE_WORK_ORDER:
$mode = 'sale_work_order';
break;
case SALE_TYPE_INVOICE:
$mode = 'sale_invoice';
break;
case SALE_TYPE_RETURN:
$mode = 'return';
break;
default:
$mode = 'sale';
break;
}
$this->sale_lib->set_mode($mode);
}
/**
* @return void
*/