From 9fc2a4edbd69d3fff59ad8f70974f0492044c1eb Mon Sep 17 00:00:00 2001
From: WShells <26513147+WebShells@users.noreply.github.com>
Date: Wed, 17 Apr 2024 13:59:05 +0300
Subject: [PATCH] Refactoring Change Register Mode

Switched from conditional if stmt to case
---
 app/Controllers/Sales.php | 47 +++++++++++++++++++--------------------
 1 file changed, 23 insertions(+), 24 deletions(-)

diff --git a/app/Controllers/Sales.php b/app/Controllers/Sales.php
index 2d57e0a23..f62aae3ce 100644
--- a/app/Controllers/Sales.php
+++ b/app/Controllers/Sales.php
@@ -281,33 +281,32 @@ class Sales extends Secure_Controller
 	 * @return void
 	 */
 	public function change_register_mode(int $sale_type): void
-	{//TODO: This set of if statements should be refactored to a switch
-		if($sale_type == SALE_TYPE_POS)
-		{
-			$this->sale_lib->set_mode('sale');
-		}
-		elseif($sale_type == SALE_TYPE_QUOTE)
-		{
-			$this->sale_lib->set_mode('sale_quote');
-		}
-		elseif($sale_type == SALE_TYPE_WORK_ORDER)
-		{
-			$this->sale_lib->set_mode('sale_work_order');
-		}
-		elseif($sale_type == SALE_TYPE_INVOICE)
-		{
-			$this->sale_lib->set_mode('sale_invoice');
-		}
-		elseif($sale_type == SALE_TYPE_RETURN)
-		{
-			$this->sale_lib->set_mode('return');
-		}
-		else
-		{
-			$this->sale_lib->set_mode('sale');
+	{
+		switch ($sale_type) {
+			case SALE_TYPE_POS:
+				$mode = 'sale';
+				break;
+			case SALE_TYPE_QUOTE:
+				$mode = 'sale_quote';
+				break;
+			case SALE_TYPE_WORK_ORDER:
+				$mode = 'sale_work_order';
+				break;
+			case SALE_TYPE_INVOICE:
+				$mode = 'sale_invoice';
+				break;
+			case SALE_TYPE_RETURN:
+				$mode = 'return';
+				break;
+			default:
+				$mode = 'sale';
+				break;
 		}
+
+		$this->sale_lib->set_mode($mode);
 	}
 
+
 	/**
 	 * @return void
 	 */