mirror/opensourcepos
1
0
Fork 0
mirror of https://github.com/opensourcepos/opensourcepos.git synced 2026-07-11 15:36:13 -04:00
Code Issues Packages Projects Releases Wiki Activity

Porting over f1672d9

Browse Source
This commit is contained in:
objecttothis
2022-11-17 16:38:34 +04:00
committed by Steve Ireland
parent e627ad3f47
commit ac8c2295f6
1 changed files with 3 additions and 3 deletions
Download Patch File Download Diff File Expand all files Collapse all files

6
app/Models/Employee.php
View File

@@ -369,12 +369,12 @@ class Employee extends Person
$builder = $this->db->table('employees');
$query = $builder->getWhere(['username' => $username, 'deleted' => 0], 1);
if($query->getNumRows() == 1) //TODO: ===
if($query->getNumRows() === 1)
{
$row = $query->getRow();
// compare passwords depending on the hash version
if($row->hash_version == 1 && $row->password == md5($password)) //TODO: === ?
if($row->hash_version === '1' && $row->password === md5($password))
{
$builder->where('person_id', $row->person_id);
$this->session->set('person_id', $row->person_id);
@@ -382,7 +382,7 @@ class Employee extends Person
return $builder->update(['hash_version' => 2, 'password' => $password_hash]);
}
elseif($row->hash_version == 2 && password_verify($password, $row->password)) //TODO: === ?
elseif($row->hash_version === '2' && password_verify($password, $row->password))
{
$this->session->set('person_id', $row->person_id);