From ac90c07c9031f21f5d6ce58bdc49fbaa2038347d Mon Sep 17 00:00:00 2001 From: jekkos Date: Fri, 10 Jan 2025 19:23:07 +0100 Subject: [PATCH] Remove support for PHP7.4 for now --- .github/workflows/php-linter.yml | 4 ---- app/Helpers/locale_helper.php | 2 +- 2 files changed, 1 insertion(+), 5 deletions(-) diff --git a/.github/workflows/php-linter.yml b/.github/workflows/php-linter.yml index a834fd069..1c10f0d8e 100644 --- a/.github/workflows/php-linter.yml +++ b/.github/workflows/php-linter.yml @@ -12,10 +12,6 @@ jobs: uses: actions/checkout@v4 with: fetch-depth: 0 - - name: PHP Lint 7.4 - uses: dbfx/github-phplint/7.4@master - with: - folder-to-exclude: "! -path \"./vendor/*\" ! -path \"./folder/excluded/*\"" - name: PHP Lint 8.0 uses: dbfx/github-phplint/8.0@master with: diff --git a/app/Helpers/locale_helper.php b/app/Helpers/locale_helper.php index 5367d115c..a1def3ae5 100644 --- a/app/Helpers/locale_helper.php +++ b/app/Helpers/locale_helper.php @@ -506,7 +506,7 @@ function parse_decimals(string $number, int $decimals = null): mixed $locale_safe_number = $fmt->parse($number); if ( - !$locale_safe_number + $locale_safe_number === false || $locale_safe_number > MAX_PRECISION || $locale_safe_number > 1.e14 )