mirror/opensourcepos
1
0
Fork 0
mirror of https://github.com/opensourcepos/opensourcepos.git synced 2026-05-18 13:28:32 -04:00
Code Issues Packages Projects Releases Wiki Activity

Attributes queries fixes

Browse Source 
- Minor formatting fixes
- Adding back bitwise equals into query using RawSql()
- Corrected GET method to POST
- Removed if statement causing no attribute values
- Removed param in get() from CI3
- Changed setAttribute to setTextAttribute
- Replaced NULL constant with null keyword PSR-2,12
- Replaced TRUE/FALSE constants with true/false keywords PSR-2,12
- explicit cast to get rid of deprecation warning
This commit is contained in:
objecttothis
2023-11-06 15:05:06 +04:00
committed by jekkos
parent 6b7608fd62
commit e5dcdd5970
4 changed files with 40 additions and 33 deletions
Download Patch File Download Diff File Expand all files Collapse all files

14
app/Controllers/Items.php
View File

@@ -492,17 +492,9 @@ class Items extends Secure_Controller
public function getAttributes(int $item_id = NEW_ENTRY): void
{
$data['item_id'] = $item_id;
if($this->request->getGet('definition_ids') != null)
{
$definition_ids = json_decode($this->request->getGet('definition_ids'), TRUE);
$data['definition_values'] = $this->attribute->get_attributes_by_item($item_id) + $this->attribute->get_values_by_definitions($definition_ids);
$data['definition_names'] = $this->attribute->get_definition_names();
}
else
{
$data['definition_values'] = [];
$data['definition_names'] = [];
}
$definition_ids = json_decode($this->request->getGet('definition_ids') ?? '', TRUE);
$data['definition_values'] = $this->attribute->get_attributes_by_item($item_id) + $this->attribute->get_values_by_definitions($definition_ids);
$data['definition_names'] = $this->attribute->get_definition_names();
foreach($data['definition_values'] as $definition_id => $definition_value)
{