From f96f5efe489c6fb403d3a17b740e80add58035bf Mon Sep 17 00:00:00 2001 From: Emilio Silva Schlenker Date: Mon, 15 Oct 2018 18:50:48 -0500 Subject: [PATCH] Ternary operator instead of if clause to keep consistency --- application/controllers/Expenses.php | 6 +----- 1 file changed, 1 insertion(+), 5 deletions(-) diff --git a/application/controllers/Expenses.php b/application/controllers/Expenses.php index 2de02ee00..76eeb89f1 100644 --- a/application/controllers/Expenses.php +++ b/application/controllers/Expenses.php @@ -128,7 +128,7 @@ class Expenses extends Secure_Controller $expense_data = array( 'date' => $date_formatter->format('Y-m-d H:i:s'), - 'supplier_id' => $this->input->post('supplier_id'), + 'supplier_id' => $this->input->post('supplier_id') == '' ? NULL : $this->input->post('supplier_id'), 'supplier_tax_code' => $this->input->post('supplier_tax_code'), 'amount' => parse_decimals($this->input->post('amount')), 'tax_amount' => parse_decimals($this->input->post('tax_amount')), @@ -139,10 +139,6 @@ class Expenses extends Secure_Controller 'deleted' => $this->input->post('deleted') != NULL ); - if($expense_data['supplier_id'] == '') { - $expense_data['supplier_id'] = NULL; - } - if($this->Expense->save($expense_data, $expense_id)) { $expense_data = $this->xss_clean($expense_data);