Commit Graph

27 Commits

Author SHA1 Message Date
objec
d73bfd39f6 Refactoring
- PSR compliance refactors
- Added Events trigger for customer save in Customers.php controller
- Temporarily moved code over to the Mailchimp plugin
- Replaced == with === to prevent type coercion.

Signed-off-by: objec <objecttothis@gmail.com>
2026-04-17 17:01:24 +04:00
objec
d9d93e0d9d Mailchimp PLugin
- Corrected grammar in PHPdocs
- PSR refactoring of local variables and code blocks
- Moved MailchimpPlugin.php to its own plugin folder
- Refactored out mailchimp code to the plugin
- Created customer_loaded event trigger

Signed-off-by: objec <objecttothis@gmail.com>
2026-04-16 17:29:46 +04:00
objec
bfb4ad4617 Licensing
- Added LICENSE
- Updated README.md to reflect that Plugins need to contain LICENSE

Signed-off-by: objec <objecttothis@gmail.com>
2026-04-15 16:16:49 +04:00
objec
00cd13f735 Move Customer Mailchimp business logic to Mailchimp Plugin space
- Create MailchimpController class
- Refactor Mailchimp_lib class to MailchimpLibrary
- Deleted useless PHPdocs
- Refactored MailchimpConnector class into its own library class
- Refactored out hungarian notation
- PSR compliant naming changes

Signed-off-by: objec <objecttothis@gmail.com>
2026-04-15 15:20:42 +04:00
objec
43972b8f0e Moved Mailchimp_lib.php to the MailchimpPlugin
Signed-off-by: objec <objecttothis@gmail.com>
2026-04-14 18:14:47 +04:00
objec
ff3c7d1b14 Refactor integrations to plugins
Signed-off-by: objec <objecttothis@gmail.com>
2026-04-14 18:08:29 +04:00
objec
65fb6339d7 Translations
- Deleted Mailchimp string from de-DE Sales langugage file.
- Finished translating missing phrases

Signed-off-by: objec <objecttothis@gmail.com>
2026-04-14 17:57:23 +04:00
objec
57a19bb35f Renamed integrations to plugins
- integrations_config.php to plugins_config.php in views

Signed-off-by: objec <objecttothis@gmail.com>
2026-04-14 17:56:17 +04:00
objec
c81cf4a5cc Translations for MailChimp Plugin
- Moved Language strings over to the plugin directory
- Removed them from the original language files (Config.php, Customers.php, Sales.php)
- Added translations for missing languages related to MailchimpPlugin.php

Signed-off-by: objec <objecttothis@gmail.com>
2026-04-14 17:44:22 +04:00
objec
1918f3e6e2 Add language identifiers for text in README.md
Signed-off-by: objec <objecttothis@gmail.com>
2026-04-14 12:05:19 +04:00
objec
f842be50b3 Move Mailchimp plugin business logic
- Remove business logic from Config controller
- Add business logic to MailchimpPlugin.php
- Add config view for mailchimp plugin
- gutted integrations_config.php
- Added parameter type to getConfig() function parameter to remove warning in override

Signed-off-by: objec <objecttothis@gmail.com>
2026-04-08 14:47:47 +04:00
objec
bcff389b34 Mailchimp config view
- Update MailchimpPlugin.php to use config path
- Created Mailchimp config view.

Signed-off-by: objec <objecttothis@gmail.com>
2026-04-08 13:53:16 +04:00
objec
e1b76d2e0d Update MailchimpPlugin.php
- Replaced full declarations with an import
- Added exception to use the return value of subscribeCustomer()

Signed-off-by: objec <objecttothis@gmail.com>
2026-04-08 13:33:32 +04:00
objec
a19fe03ecf Whitespace and refactoring corrections
Signed-off-by: objec <objecttothis@gmail.com>
2026-04-08 11:39:29 +04:00
objec
acb3b18584 Load the namespace for the file so languages work in plugins
Signed-off-by: objec <objecttothis@gmail.com>
2026-04-02 17:07:27 +04:00
objec
3b0476f2b3 Save settings through the parent saveSettings function
- Remove extra whitespace
- Save Settings function returned true even if there were errors. Corrected this behavior.

Signed-off-by: objec <objecttothis@gmail.com>
2026-04-02 15:50:31 +04:00
Ollama
896ed87797 fix: Address CodeRabbit AI review comments
- Move plugin discovery to pre_system in Events.php (allows events to be registered before they fire)
- Add plugin existence check in disablePlugin()
- Add is_subclass_of check before instantiating plugin classes
- Fix str_replace prefix removal in getPluginSettings using str_starts_with + substr
- Add down() migration to drop table on rollback
- Fix saveSettings to JSON-encode arrays/objects
- Update README to use MailchimpPlugin as reference implementation
- Remove CasposPlugin examples from documentation
2026-03-22 19:47:09 +00:00
Ollama
eb264ad76d refactor: Address review comments - PSR-12 naming and plugin cleanup
- Rename Plugin_config to PluginConfig (PSR-12 class naming)
- Remove non-functioning CasposPlugin example
- Remove ExamplePlugin (MailchimpPlugin serves as example)
- Fix privacy issue: Don't log customer email in MailchimpPlugin
- Remove unnecessary PHPDocs
- Fix PSR-12 brace placement
2026-03-22 19:40:36 +00:00
Ollama
10a64e7af9 refactor: Remove redundant isEnabled() checks from callback methods
The PluginManager only registers events for enabled plugins, so
callbacks are never invoked for disabled plugins. This makes
$this->isEnabled() checks in callbacks redundant.

Changes:
- Remove redundant isEnabled() checks from all plugin callbacks
- Clarify in README that isEnabled() checks are not needed
- Use log_message() instead of log() in plugins (PSR-12)
- Fix PSR-12 brace placement in CasposPlugin
2026-03-20 19:48:27 +00:00
Ollama
6e99f05d63 refactor: Update MailchimpPlugin as proper example plugin
- Reword docblock to remove 'Example' - it's a functioning plugin
- Rename 'Mailchimp Integration' to 'Mailchimp' (context makes it clear)
- Use lang() method for translatable strings with self-contained language file
- Use log_message() instead of log() for PSR-12 consistency
- Add missing language strings: mailchimp_description, mailchimp_api_key_required
- Add getPluginDir() method for language helper
2026-03-20 18:32:42 +00:00
Ollama
c430c7afb5 refactor: Move mailchimp language strings to self-contained plugin directory
- Create app/Plugins/MailchimpPlugin/Language/en/MailchimpPlugin.php
- Remove mailchimp strings from core app/Language/en/Plugins.php
- Plugin language files are now self-contained per the documentation
2026-03-19 18:24:48 +00:00
Ollama
519347f4f5 refactor: Fix PSR-12 and documentation issues
- Consolidate duplicate documentation sections
- Move Internationalization section after Plugin Views
- Remove redundant Example Plugin Structure and View Hooks sections
- Fix PSR-12 brace style in plugin_helper.php
- Fix PSR-12 brace style in PluginInterface.php (remove unnecessary PHPdocs)
- Fix PSR-12 brace style in BasePlugin.php (remove unnecessary PHPdocs)
- Use log_message() instead of error_log() in migration
- Add IF NOT EXISTS to plugin_config table creation for resilience
- Convert snake_case to camelCase for class names throughout docs
2026-03-19 18:20:05 +00:00
Ollama
62d84411b2 docs: Fix documentation consistency issues
- Add Language folder to all plugin structure examples
- Convert snake_case to camelCase for class names (PSR-12)
- Add Language folder to initial plugin structure diagram
- Add Language folder to Complex Plugin structure
- Update all namespace references to use camelCase
2026-03-18 22:06:09 +00:00
Ollama
6bd4bb545d docs: Add internationalization section showing self-contained plugin language files
Adds documentation example showing how plugins can embed their own
language files within the plugin directory structure, keeping plugins
fully self-contained without modifying core language files.
2026-03-17 14:36:13 +00:00
Ollama
66f7d70749 feat(plugins): add view hooks for injecting plugin content into core views
Add event-based view hook system allowing plugins to inject UI elements
into core views without modifying core files. Includes helper functions
and example CasposPlugin demonstrating the pattern.
2026-03-12 10:13:12 +00:00
Ollama
bd8b4fa6c1 feat(plugins): Support self-contained plugin directories
- PluginManager now recursively scans app/Plugins/ to discover plugins
- Supports both single-file plugins (MyPlugin.php) and directory plugins (MyPlugin/MyPlugin.php)
- Plugins can contain their own Models, Controllers, Views, Libraries, Helpers
- Uses PSR-4 namespacing: App\Plugins\PluginName for files, App\Plugins\PluginName\Subdir for subdirectories
- Users can install plugins by simply dropping a folder into app/Plugins/
- Updated README with comprehensive documentation on both plugin formats

This makes plugin installation much easier - just drop the plugin folder and it works.
2026-03-09 21:58:53 +01:00
Ollama
a9669ddf19 feat(plugins): Implement modular plugin system with self-registering events
This implements a clean plugin architecture based on PR #4255 discussion:

Core Components:
- PluginInterface: Standard contract all plugins must implement
- BasePlugin: Abstract class with common functionality
- PluginManager: Discovers and loads plugins from app/Plugins/
- Plugin_config: Model for plugin settings storage

Architecture:
- Each plugin registers its own event listeners via registerEvents()
- No hardcoded plugin dependencies in core Events.php
- Generic event triggers (item_sale, item_change, etc.) remain in core code
- Plugins can be enabled/disabled via database settings
- Clean separation: plugin orchestrators vs MVC components

Example Implementations:
- ExamplePlugin: Simple plugin demonstrating event logging
- MailchimpPlugin: Integration with Mailchimp for customer sync

Admin UI:
- Plugin management controller at Controllers/Plugins/Manage.php
- Plugin management view at Views/plugins/manage.php

Database:
- ospos_plugin_config table for plugin settings (key-value store)
- Migration creates table with timestamps

Documentation:
- Comprehensive README with architecture patterns
- Simple vs complex plugin examples
- MVC directory structure guidance
2026-03-09 21:58:53 +01:00