Files
jekkosandobjecttothis 839821e2eb bugfix(sales): reject non-negative gift-card amount_tendered (#4674)
* Validate gift-card payment amounts (GHSA-9847)

Close the negative gift-card amount minting vector: when a forged
payment_type like 'Gift Card:<number>' reaches the catch-all validation
branch, a negative amount_tendered previously passed decimal_locale and was
then routed into Giftcard::decrementGiftcardValue, where value - (-N)
increased the balance (store credit minted at will).

- Add nonNegativeDecimal rule + 'Sales.negative_amount_tendered' message to
  the catch-all amount_tendered rules in Sales::postAddPayment(); add the
  language key to all 46 locale files (populated in en, empty elsewhere).
- Guard Giftcard::decrementGiftcardValue() against non-positive amounts so
  the sink itself can no longer add balance from an inverted subtraction.
- Regression tests: controller-level rejection of negative amount_tendered
  and model-level rejection of negative/zero decrements.

* Address PR review: align locale keys, drop advisory refs, add decimal_locale message

- Align negative_amount_tendered '=> with all other keys (46 locale files)
- Remove docblock + inline comment above decrementGiftcardValue()
- Remove GHSA ID and attack-detail description from test; scrub redundant comment
- Add decimal_locale message override + focused malformed-amount test

* Fix formatting and spacing in SalesControllerTest

* fix(lang): remove duplicate negative amount tendered key

Consolidate 'negative_amount_invalid' and 'negative_amount_tendered'
translation keys in Sales.php across all locale files. Both keys held
identical messages, causing redundant translation maintenance.

- Drop 'negative_amount_invalid' key, keep 'negative_amount_tendered'
- Move existing translated text into 'negative_amount_tendered' where
  it was previously empty
- Applied across all app/Language/*/Sales.php locale files

Signed-off-by: objecttothis <17935339+objecttothis@users.noreply.github.com>

* fix(sales): allow negative amount_tendered in return mode

Return transactions legitimately produce negative amount_due and
prefilled amount_tendered values, but validation rules previously
enforced nonNegativeDecimal unconditionally, blocking valid returns.

- Detect return mode via sale_lib->get_mode() in Sales::process
- Build amount_tendered rule conditionally: skip nonNegativeDecimal
  check when in return mode, keep it for sale/giftcard flows
- Apply the conditional rule to both giftcard and standard payment
  branches

Signed-off-by: objecttothis <17935339+objecttothis@users.noreply.github.com>

* test: update expected error message in negative payment test

Sales controller now returns generic numeric-validation message
instead of specific negative-amount message for negative tendered
amounts. Update test assertion to match new lang key.

- tests/Controllers/SalesControllerTest.php: assert
  Sales.must_enter_numeric instead of
  Sales.negative_amount_tendered

Signed-off-by: objecttothis <17935339+objecttothis@users.noreply.github.com>

* test: remove regression tests for GHSA-9847 negative amount fix

Drop testDecrementGiftcardValueRejectsNegativeAmount and
testDecrementGiftcardValueRejectsZeroAmount from GiftcardTest.

- Remove coverage for decrementGiftcardValue() rejecting
  non-positive amounts (negative/zero) in tests/Models/GiftcardTest.php

Signed-off-by: objecttothis <17935339+objecttothis@users.noreply.github.com>

---------

Signed-off-by: objecttothis <17935339+objecttothis@users.noreply.github.com>
Co-authored-by: objecttothis <17935339+objecttothis@users.noreply.github.com>
2026-09-07 11:47:02 +04:00

241 lines
15 KiB
PHP

<?php
return [
'account_number' => 'Akun #',
'add_payment' => 'Terima',
'amount_due' => 'Uang Kembalian',
'amount_due_not_covered' => 'Pembayaran tidak menutupi jumlah yang harus dibayar.',
'amount_tendered' => 'Nilai Pembayaran',
'authorized_signature' => 'Tanda tangan',
'cancel_sale' => 'Batal Jual',
'cash' => 'Tunai',
'cash_1' => '',
'cash_2' => '',
'cash_3' => '',
'cash_4' => '',
'cash_adjustment' => 'Penyesuaian Kas',
'cash_deposit' => 'Deposit Tunai',
'cash_filter' => 'Tunai',
'change_due' => 'Kembalian Uang',
'change_price' => 'Ubah Harga Jual',
'check' => 'Cek',
'check_balance' => 'Aktifkan pengingat',
'check_filter' => 'Cek',
'close' => '',
'comment' => 'Catatan',
'comments' => 'Keterangan',
'company_name' => '',
'complete' => '',
'complete_sale' => 'Selesai',
'confirm_cancel_sale' => 'Apakah anda yakin ingin mengosongkan transaksi penjualan ini? Semua item akan dihapus.',
'confirm_delete' => 'Apakah anda yakin akan menghapus penjualan terpilih?',
'confirm_restore' => 'Apakah anda yakin akan mengembalikan penjualan terpilih?',
'credit' => 'Kartu Kredit',
'credit_deposit' => 'Deposit Kredit',
'credit_filter' => 'Kartu Kredit',
'current_table' => '',
'customer' => 'Pelanggan',
'customer_address' => 'Alamat',
'customer_discount' => 'Diskon',
'customer_email' => 'Email',
'customer_location' => 'Lokasi',
'customer_mailchimp_status' => 'Status MailChimp',
'customer_optional' => '(Diperlukan untuk Pembayaran Jatuh Tempo)',
'customer_required' => '(Dibutuhkan)',
'customer_total' => 'Total',
'customer_total_spent' => '',
'customers_available_points' => 'Poin tersedia',
'daily_sales' => '',
'date' => 'Tanggal Penjualan',
'date_range' => 'Rentang Tanggal',
'date_required' => 'Masukkan tanggal yang benar.',
'date_type' => 'Tanggal tidak boleh kosong.',
'debit' => 'Kartu Debit',
'debit_filter' => '',
'delete' => 'Boleh dihapus',
'delete_confirmation' => 'Apakah anda yakin ingin menghapus transaksi penjualan ini, Pilihan ini tidak dapat dibatalkan.',
'delete_entire_sale' => 'Hapus Transaksi Penjualan',
'delete_successful' => 'Transaksi Penjualan berhasil dihapus.',
'delete_unsuccessful' => 'Transaksi Penjualan gagal dihapus.',
'description_abbrv' => 'Deskripsi.',
'discard' => 'Buang',
'discard_quote' => '',
'discount' => 'Diskon',
'discount_exceeds_item_total' => '',
'discount_included' => '% Diskon',
'discount_percent_exceeds_100' => '',
'discount_short' => '%',
'due' => 'Jatuh tempo',
'due_filter' => 'Jatuh tempo',
'edit' => 'Ubah',
'edit_item' => 'Ubah Item',
'edit_sale' => 'Ubah Penjualan',
'email_receipt' => 'email Faktur',
'employee' => 'Karyawan',
'entry' => 'Entri',
'error_editing_item' => 'mengubah item salah',
'find_or_scan_item' => 'Cari/Scan Item',
'find_or_scan_item_or_receipt' => 'Temukan atau pindai Item atau Faktur',
'giftcard' => 'Kartu Hadiah',
'giftcard_balance' => 'Nilai Kupon Bonus',
'giftcard_filter' => '',
'giftcard_number' => 'Nomor Kartu Hadiah',
'group_by_category' => 'Dikelompokkan berdasarkan Kategori',
'group_by_type' => 'Dikelompokkan berdasarkan Jenis',
'hsn' => 'HSN',
'id' => 'ID Penjualan',
'include_prices' => 'Termasuk Harga?',
'insufficient_giftcard_balance' => 'Saldo kartu hadiah tidak mencukupi untuk pembayaran ini.',
'insufficient_reward_points' => 'Poin reward tidak cukup untuk pembayaran ini.',
'invoice' => 'Faktur',
'invoice_confirm' => 'Faktur ini akan dikirim ke',
'invoice_enable' => 'Nomor Faktur',
'invoice_filter' => 'Faktur',
'invoice_no_email' => 'Pelanggan ini tidak memiliki alamat email yang valid.',
'invoice_number' => 'Nomor Nota',
'invoice_number_duplicate' => 'Nomor nota harus unik.',
'invoice_sent' => 'Faktur dikirim kepada',
'invoice_total' => 'Total faktur',
'invoice_type_custom_invoice' => 'Faktur kustom (custom_invoice.php)',
'invoice_type_custom_tax_invoice' => 'Faktur pajak kustom (custom_tax_invoice.php)',
'invoice_type_invoice' => 'Faktur (invoice.php)',
'invoice_type_tax_invoice' => 'Faktur pajak (tax_invoice.php)',
'invoice_unsent' => 'Faktur gagal dikirim kepada',
'invoice_update' => 'Menghitung ulang',
'item_insufficient_of_stock' => 'Stok Item tidak mencukupi.',
'item_name' => 'Nama Barang',
'item_number' => 'Barang #',
'item_out_of_stock' => 'Barang habis.',
'key_browser' => 'Pintasan bermanfaat',
'key_cancel' => 'Membatalkan Penawaran/Faktur/Penjualan saat ini',
'key_customer_search' => 'Pencarian Pelanggan',
'key_finish_quote' => 'Selesaikan Struk/Faktur tanpa pembayaran',
'key_finish_sale' => 'Tambahkan Pembayaran dan Lengkapi Faktur/Penjualan',
'key_full' => 'Buka dalam Mode Layar Penuh',
'key_function' => 'Fungsi',
'key_help' => 'Pintasan',
'key_help_modal' => 'Buka Jendela Pintasan',
'key_in' => 'Perbesar',
'key_item_search' => 'Pencarian Barang',
'key_out' => 'Perkecil',
'key_payment' => 'Tambahkan Pembayaran',
'key_print' => 'Cetak Halaman sekarang',
'key_restore' => 'Reset tampilan zum',
'key_search' => 'Cari Tabel Laporan',
'key_suspend' => 'Tangguhkan Penjualan saat ini',
'key_suspended' => 'Tampilkan Penjualan yang Ditangguhkan',
'key_system' => 'Pemintas Sistem',
'key_tendered' => 'Edit jumlah yang dibayarkan',
'key_title' => 'Pintasan Papan Ketik Penjualan',
'mc' => '',
'mode' => 'Jenis Transaksi',
'must_enter_numeric' => 'Nilai yang dimasukkan harus berupa angka.',
'must_enter_numeric_giftcard' => 'Nomor Gift Card harus berupa angka.',
'must_enter_reference_code' => 'Nomor referensi/pengambilan harus dimasukkan.',
'negative_amount_tendered' => 'Nilai pembayaran tidak boleh negatif.',
'negative_discount_invalid' => '',
'negative_price_invalid' => '',
'negative_quantity_invalid' => '',
'negative_total_invalid' => '',
'new_customer' => 'Pelanggan Baru',
'new_item' => 'Barang Baru',
'no_description' => 'Tidak ada deskripsi',
'no_filter' => 'Semua',
'no_items_in_cart' => 'Tidak ada Barang dalam Keranjang Belanja.',
'no_sales_to_display' => 'Tidak ada penjualan yang ditampilkan.',
'none_selected' => 'Anda belum memilih Penjualan untuk dihapus.',
'nontaxed_ind' => ' . ',
'not_authorized' => 'Aksi ini tidak resmi.',
'one_or_multiple' => 'Penjualan',
'payment' => 'Jenis Pembayaran',
'payment_amount' => 'Jumlah',
'payment_not_cover_total' => 'Jumlah pembayaran harus lebih besar atau sama dengan Total.',
'payment_type' => 'Jenis',
'payments' => '',
'payments_total' => 'Total Pembayaran',
'price' => 'Harga',
'print_after_sale' => 'Cetak Faktur setelah penjualan',
'quantity' => 'Jumlah',
'quantity_less_than_reorder_level' => 'Peringatan: Stok Inventori barang ini dibawah level order ulang.',
'quantity_less_than_zero' => 'Peringatan: Stok Inventori tidak cukup. Proses penjualan masih dapat dilanjutkan, tapi periksa Inventori.',
'quantity_of_items' => 'Jumlah dari {0} item',
'quote' => 'Penawaran',
'quote_number' => 'No. Penawaran',
'quote_number_duplicate' => 'No. Penawaran tidak boleh sama.',
'quote_sent' => 'Penawaran dikirim ke',
'quote_unsent' => 'Penawaran gagal dikirim ke',
'receipt' => 'Faktur Penjualan',
'receipt_no_email' => 'Pembeli ini tidak memiliki surel yang valid.',
'receipt_number' => 'POS #',
'receipt_sent' => 'Nota dikirim ke',
'receipt_unsent' => 'Noto gagal dikirim kepada',
'reference_code' => 'Kode Referensi Pembayaran',
'reference_code_invalid_characters' => 'Kode referensi hanya boleh mengandung huruf dan angka.',
'reference_code_length_error' => 'Panjang kode referensi tidak valid.',
'refund' => 'Tipe Pengembalian Dana',
'register' => 'Transaksi Penjualan',
'remove_customer' => 'Hapus Pelanggan',
'remove_discount' => '',
'return' => 'Retur',
'rewards' => 'Poin Penghargaan',
'rewards_balance' => 'Jumlah Poin Penghargaan',
'rewards_package' => 'Hadiah',
'rewards_remaining_balance' => 'Poin hadiah yang tersisa adalah ',
'sale' => 'Penjualan',
'sale_by_invoice' => 'Penjualan berdasarkan Faktur',
'sale_for_customer' => 'Pelanggan:',
'sale_time' => 'Waktu',
'sales_tax' => 'Pajak Penjualan',
'sales_total' => '',
'select_customer' => 'Pilih Pelanggan',
'selected_customer' => 'Pelanggan Terpilih',
'send_invoice' => 'Kirim Faktur',
'send_quote' => 'Kirim Penawaran',
'send_receipt' => 'Kirim Nota',
'send_work_order' => 'Kirim Order Kerja',
'serial' => 'Seri',
'service_charge' => '',
'show_due' => '',
'show_invoice' => 'Tampilkan Faktur',
'show_receipt' => 'Tampilkan Nota',
'start_typing_customer_name' => 'Ketik Nama Pelanggan...',
'start_typing_item_name' => 'Ketik Nama Barang atau Scan Barcode...',
'stock' => 'Stok',
'stock_location' => 'Lokasi Stock',
'sub_total' => 'Sub-total',
'successfully_deleted' => 'Transaksi Penjualan berhasil dihapus',
'successfully_restored' => 'Berhasil dikembalikan',
'successfully_suspended_sale' => 'Penjualan berhasil ditangguhkan.',
'successfully_updated' => 'Penjualan berhasil diperbarui.',
'suspend_sale' => 'Tangguhkan',
'suspended_doc_id' => 'Dokumen',
'suspended_sale_id' => 'ID Penjualan ditangguhkan',
'suspended_sales' => 'Penangguhan',
'table' => 'Meja',
'takings' => 'Daftar Penjualan',
'tax' => 'Pajak',
'tax_id' => 'ID Pajak',
'tax_invoice' => 'Faktur Pajak',
'tax_percent' => 'Pajak %',
'taxed_ind' => 'P',
'total' => 'Total',
'total_tax_exclusive' => 'Tidak termasuk pajak',
'transaction_failed' => 'Transaksi Penjualan gagal.',
'unable_to_add_item' => 'Tidak dapat menambahkan item pada penjualan',
'unsuccessfully_deleted' => 'Transaksi Penjualan gagal dihapus.',
'unsuccessfully_restored' => 'Transaksi Penjualan gagal dikembalikan.',
'unsuccessfully_suspended_sale' => 'Transaksi penjualan gagal ditangguhkan.',
'unsuccessfully_updated' => 'Transaksi Penjualan gagal diperbaharui.',
'unsuspend' => 'Tidak Ditangguhkan',
'unsuspend_and_delete' => 'Batalkan dan hapus penangguhan',
'update' => 'Ubah',
'upi' => 'UPI',
'visa' => '',
'wholesale' => '',
'work_order' => 'Perintah Kerja',
'work_order_number' => 'Nomor Perintah Kerja',
'work_order_number_duplicate' => 'Nomor Perintah Kerja tidak boleh sama.',
'work_order_sent' => 'Perintah Kerja dikirim ke',
'work_order_unsent' => 'Perintah Kerja gagal dikirim ke',
];