Files
objecttothisandClaude Sonnet 5 600417bfdf refactor: extract PSR-12 renames and independent bugfixes from plugin system PR (#4784)
build/refactor/fix: tighten tooling, rename accessors to camelCase, and correct model bugs

* build: tighten gitignore, lockfile, and script config
- gitignore /build and /.php-cs-fixer.cache
- allow core-js@3.50.0 postinstall script in package.json

* refactor: rename snake_case data accessors to camelCase
Rename get_info, get_multiple_info, get_sale_items, get_sale_payments,
and save_customer across Customer, Employee, Item, Sale, and Supplier
models to PSR-12 camelCase, updating every call site in controllers,
libraries, and views.

* test: update calls to match renamed camelCase accessors
Update HomeTest, ItemsControllerTest, and ItemTest to call
getInfo()/getMultipleInfo() instead of the old snake_case model methods.

* fix: correct independent bugs in Item, Item_taxes, and Attribute models
- Item::delete()/delete_list(): let $this->db->transStatus() alone decide
  success instead of accumulating a bitwise-AND over intermediate results,
  which could report failure (and trigger error toasts) even when the
  delete had actually completed
- Item_taxes: correct $table property from 'item_taxes' to 'items_taxes'
- Attribute::getDefinitionNames(): pass an array to
  QueryBuilder->whereNotIn(), which requires one

Co-Authored-By: Claude Sonnet 5 <noreply@anthropic.com>
2026-10-28 13:00:30 +04:00

110 lines
2.6 KiB
PHP

<?php
namespace App\Models;
use CodeIgniter\Model;
/**
* Item_taxes class
*/
class Item_taxes extends Model
{
protected $table = 'items_taxes';
protected $primaryKey = 'item_id';
protected $useAutoIncrement = false;
protected $useSoftDeletes = false;
protected $allowedFields = [
'name',
'percent'
];
/**
* Gets tax info for a particular item
*/
public function get_info(int $item_id): array
{
$builder = $this->db->table('items_taxes');
$builder->where('item_id', $item_id);
// Return an array of taxes for an item
return $builder->get()->getResultArray();
}
/**
* @return array item_id => array of taxes for that item
*/
public function getInfoMultiple(array $itemIds): array
{
if (empty($itemIds)) {
return [];
}
$builder = $this->db->table('items_taxes');
$builder->whereIn('item_id', $itemIds);
$taxesByItemId = [];
foreach ($builder->get()->getResultArray() as $tax) {
$taxesByItemId[$tax['item_id']][] = $tax;
}
return $taxesByItemId;
}
/**
* Inserts or updates an item's taxes
*/
public function save_value(array &$items_taxes_data, int $item_id): bool
{
$success = true;
$this->delete($item_id);
$builder = $this->db->table('items_taxes');
foreach ($items_taxes_data as $row) {
$row['item_id'] = $item_id;
$success &= $builder->insert($row);
}
return $success;
}
/**
* Saves taxes for multiple items
*/
public function save_multiple(array &$items_taxes_data, string $item_ids): bool // TODO: investigate why this is sent as a : delimited string rather than an array.
{
$success = true;
// Run these queries as a transaction, we want to make sure we do all or nothing
$this->db->transStart();
foreach (explode(':', $item_ids) as $item_id) {
$this->delete($item_id);
$builder = $this->db->table('items_taxes');
foreach ($items_taxes_data as $row) {
$row['item_id'] = $item_id;
$success &= $builder->insert($row);
}
}
$this->db->transComplete();
$success &= $this->db->transStatus();
return $success;
}
/**
* Deletes taxes given an item
*/
public function delete($item_id = null, bool $purge = false): bool
{
$builder = $this->db->table('items_taxes');
return $builder->delete(['item_id' => $item_id]);
}
}