mirror of
https://github.com/opensourcepos/opensourcepos.git
synced 2026-09-13 05:47:23 -04:00
c0abf80c86
* fix: wrap postSave() in single transaction for atomicity - Remove internal transaction from Item_taxes->save_value() to allow controller-level transaction - Wrap entire save sequence (item, taxes, quantities, inventory, attributes) in single transaction - Ensure all operations succeed or all fail together - Prevents partial writes when saveItemAttributes() fails after item/tax/quantity saves succeed Fixes #4474 * fix: Use explicit transBegin/transCommit/transRollback for atomicity - Replace transStart/transComplete with transBegin/transCommit/transRollback - Check all success conditions before committing - Explicit rollback on failure Address CodeRabbit review feedback * refactor(items): rename postSave locals to camelCase per PSR-12 Convert snake_case variables to camelCase in postSave() and related item-save logic to match project naming convention for new methods. Signed-off-by: Travis Garrison <travis@chiraqbookstore.com> --------- Signed-off-by: Travis Garrison <travis@chiraqbookstore.com> Co-authored-by: Ollama <ollama@steganos.dev> Co-authored-by: objecttothis <17935339+objecttothis@users.noreply.github.com> Co-authored-by: Travis Garrison <travis@chiraqbookstore.com>
90 lines
2.1 KiB
PHP
90 lines
2.1 KiB
PHP
<?php
|
|
|
|
namespace App\Models;
|
|
|
|
use CodeIgniter\Model;
|
|
|
|
/**
|
|
* Item_taxes class
|
|
*/
|
|
class Item_taxes extends Model
|
|
{
|
|
protected $table = 'item_taxes';
|
|
protected $primaryKey = 'item_id';
|
|
protected $useAutoIncrement = false;
|
|
protected $useSoftDeletes = false;
|
|
protected $allowedFields = [
|
|
'name',
|
|
'percent'
|
|
];
|
|
|
|
/**
|
|
* Gets tax info for a particular item
|
|
*/
|
|
public function get_info(int $item_id): array
|
|
{
|
|
$builder = $this->db->table('items_taxes');
|
|
$builder->where('item_id', $item_id);
|
|
|
|
// Return an array of taxes for an item
|
|
return $builder->get()->getResultArray();
|
|
}
|
|
|
|
/**
|
|
* Inserts or updates an item's taxes
|
|
*/
|
|
public function save_value(array &$items_taxes_data, int $item_id): bool
|
|
{
|
|
$success = true;
|
|
|
|
$this->delete($item_id);
|
|
|
|
$builder = $this->db->table('items_taxes');
|
|
|
|
foreach ($items_taxes_data as $row) {
|
|
$row['item_id'] = $item_id;
|
|
$success &= $builder->insert($row);
|
|
}
|
|
|
|
return $success;
|
|
}
|
|
|
|
/**
|
|
* Saves taxes for multiple items
|
|
*/
|
|
public function save_multiple(array &$items_taxes_data, string $item_ids): bool // TODO: investigate why this is sent as a : delimited string rather than an array.
|
|
{
|
|
$success = true;
|
|
|
|
// Run these queries as a transaction, we want to make sure we do all or nothing
|
|
$this->db->transStart();
|
|
|
|
foreach (explode(':', $item_ids) as $item_id) {
|
|
$this->delete($item_id);
|
|
|
|
$builder = $this->db->table('items_taxes');
|
|
|
|
foreach ($items_taxes_data as $row) {
|
|
$row['item_id'] = $item_id;
|
|
$success &= $builder->insert($row);
|
|
}
|
|
}
|
|
|
|
$this->db->transComplete();
|
|
|
|
$success &= $this->db->transStatus();
|
|
|
|
return $success;
|
|
}
|
|
|
|
/**
|
|
* Deletes taxes given an item
|
|
*/
|
|
public function delete($item_id = null, bool $purge = false): bool
|
|
{
|
|
$builder = $this->db->table('items_taxes');
|
|
|
|
return $builder->delete(['item_id' => $item_id]);
|
|
}
|
|
}
|