Files
6e273a2fb1 refactor: Replace var with let/const in JavaScript files (#4503)
* refactor: Replace var with let/const in JavaScript files

- Replace var with let for variables that are reassigned
- Replace var with const for variables that are never reassigned
- Modernize manage_tables.js and nominatim.autocomplete.js
- Skip third-party libraries (imgpreview.full.jquery.js, clipboard.min.js)

Closes #4491

* refactor: Replace var with let/const in inline JavaScript

- Fixed CodeRabbit review: changed enable_actions and load_success
  from const to let in manage_tables.js (they are reassigned in init)
- Replaced all var declarations in inline JavaScript in Views with
  let (for reassigned) or const (for never reassigned)
- Modernized 48 additional files with inline JavaScript

* refactor: Replace var with let/const in remaining JS files

- Modernized gulpfile.js: 3 var declarations replaced
- Modernized app/Views/errors/html/debug.js: all var declarations replaced
- Used const for never-reassigned, let for reassigned variables

* fix: Replace remaining var declarations in Views

- Changed var  to const in sales/register.php
- Changed var  to const in configs/receipt_config.php

These were missed in the initial pass.

* fix: Replace remaining var declarations in gulpfile.js

- Converted 12 remaining var declarations to const
- All variables are function-scoped and never reassigned
- Complete coverage for this file now

* fix: Address CodeRabbit review comments

- items/manage.php: Remove duplicate let declaration for start_date
  (partial/daterangepicker already declares it)
- header_js.php: Escape CSRF hash in JavaScript context
- tax_jurisdictions.php: Fix mismatched selector (remove_tax_jurisdictions
  -> remove_tax_jurisdiction)

* style(views): Replace var with let/const and fix comment casing

- Convert var to let in items/manage.php for JS modernization
- Capitalize \"Submit\" in validation comments across tax view files

Signed-off-by: Travis Garrison <travis@chiraqbookstore.com>

---------

Signed-off-by: Travis Garrison <travis@chiraqbookstore.com>
Co-authored-by: Ollama <ollama@steganos.dev>
Co-authored-by: objecttothis <17935339+objecttothis@users.noreply.github.com>
Co-authored-by: Travis Garrison <travis@chiraqbookstore.com>
2026-08-06 12:15:45 +04:00

119 lines
3.4 KiB
PHP

<?php
/**
* @var array $labels_1
* @var string $yaxis_title
* @var array $series_data_1
* @var bool $show_currency
* @var string $xaxis_title
* @var array $config
*/
?>
<script type="text/javascript">
// Labels and data series
const data = {
labels: <?= esc(json_encode($labels_1), 'js') ?>,
series: [{
name: '<?= esc($yaxis_title, 'js') ?>',
data: <?= esc(json_encode($series_data_1), 'js') ?>
}]
};
// We are setting a few options for our chart and override the defaults
const options = {
// Specify a fixed width for the chart as a string (i.e. '100px' or '50%')
width: '100%',
// Specify a fixed height for the chart as a string (i.e. '100px' or '50%')
height: '100%',
// Padding of the chart drawing area to the container element and labels as a number or padding object {top: 5, right: 5, bottom: 5, left: 5}
chartPadding: {
top: 20,
bottom: 100
},
// X-Axis specific configuration
axisX: {
// Lets offset the chart a bit from the labels
offset: 120,
position: 'end'
},
// Y-Axis specific configuration
axisY: {
// Lets offset the chart a bit from the labels
offset: 60,
// The label interpolation function enables you to modify the values
// used for the labels on each axis.
<?php
$currency_symbol = esc($config['currency_symbol'], 'js');
$currency_prefix = '';
$currency_suffix = '';
if ($show_currency) {
if (is_right_side_currency_symbol()) {
$currency_suffix = $currency_symbol;
} else {
$currency_prefix = $currency_symbol;
}
}
?>
labelInterpolationFnc: function(value) {
return '<?= $currency_prefix ?>' + value + '<?= $currency_suffix ?>';
}
},
// Plugin configuration
plugins: [
Chartist.plugins.ctAxisTitle({
axisX: {
axisTitle: '<?= esc($xaxis_title, 'js') ?>',
axisClass: 'ct-axis-title',
offset: {
x: -100,
y: 100
},
textAnchor: 'middle'
},
axisY: {
axisTitle: '<?= esc($yaxis_title, 'js') ?>',
axisClass: 'ct-axis-title',
offset: {
x: 0,
y: 0
},
textAnchor: 'middle',
flipTitle: false
}
}),
Chartist.plugins.ctBarLabels(),
Chartist.plugins.ctPointLabels({
textAnchor: 'middle'
})
]
};
const responsiveOptions = [
['screen and (min-width: 640px)', {
height: '80%',
chartPadding: {
top: 20,
bottom: 0
},
}]
/* ,
* ['screen and (min-width: 1024px)', {
* labelOffset: 80,
* chartPadding: 20
* }]
*/
];
new Chartist.Bar('#chart1', data, options, responsiveOptions);
</script>