Files
opensourcepos/tests/Models/CustomerRewardPointsTest.php
objecttothisandClaude Sonnet 5 af48fa4357 fix(tests): standardize DB bootstrap/OSPOS mocking, fix stale-prefix bug (#4771)
Adds DatabaseBootstrapTrait and OsposConfigFixtureTrait to replace
duplicated per-file setUp()/tearDown() bootstrap and OSPOS config mock
boilerplate across test classes, bringing them in line with the
ItemsControllerTest gold-standard shape.

Fixes the real root cause of tabular_helperTest's suite-order-dependent
failure: dropAllForeignKeyConstraints()/foreignKeyExists()/
dropColumnIfExists() temporarily blank the shared connection's DBPrefix
via overridePrefix() but never restored it if the query between the two
calls threw (e.g. migration_helperTest's mocked-failure tests) -
permanently corrupting prefixed table lookups for the rest of the
process. Wrapped each in try/finally. Also widens executeScript() to
accept an explicit connection so migration SQL can't silently run
against the wrong DB group.

Co-authored-by: Claude Sonnet 5 <noreply@anthropic.com>
2026-10-23 10:10:37 +04:00

131 lines
3.9 KiB
PHP

<?php
namespace Tests\Models;
use App\Models\Customer;
use CodeIgniter\Test\CIUnitTestCase;
use CodeIgniter\Test\DatabaseTestTrait;
use Tests\Support\ConcurrentDbRaceTrait;
use Tests\Support\DatabaseBootstrapTrait;
/**
* Regression tests: adjustRewardPoints() must apply
* its balance check and its write in a single atomic UPDATE, so that two
* concurrent reward-point spends against the same customer can never both
* read the same stale balance and double-spend it.
*/
class CustomerRewardPointsTest extends CIUnitTestCase
{
use DatabaseTestTrait;
use DatabaseBootstrapTrait;
use ConcurrentDbRaceTrait;
protected $migrate = true;
protected $migrateOnce = true;
protected $refresh = false;
protected $namespace = null;
protected function setUp(): void
{
$this->resetDatabaseOnce();
parent::setUp();
}
protected function createCustomerWithPoints(int $points): int
{
$db = \Config\Database::connect();
$db->table('people')->insert([
'first_name' => 'Reward',
'last_name' => 'Customer',
'phone_number' => '555-0100',
'email' => 'reward-customer-' . uniqid() . '@test.com',
'address_1' => '',
'address_2' => '',
'city' => '',
'state' => '',
'zip' => '',
'country' => '',
'comments' => '',
]);
$personId = (int) $db->insertID();
$db->table('customers')->insert([
'person_id' => $personId,
'employee_id' => 1,
'points' => $points,
]);
return $personId;
}
protected function getCustomerPoints(int $personId): int
{
$row = \Config\Database::connect()->table('customers')
->where('person_id', $personId)
->get()
->getRow();
return (int) $row->points;
}
public function testAdjustRewardPointsIncrementSucceeds(): void
{
$personId = $this->createCustomerWithPoints(10);
$customerModel = model(Customer::class);
$result = $customerModel->adjustRewardPoints($personId, 5);
$this->assertTrue($result);
$this->assertSame(15, $this->getCustomerPoints($personId));
}
public function testAdjustRewardPointsDecrementSucceedsWithSufficientPoints(): void
{
$personId = $this->createCustomerWithPoints(100);
$customerModel = model(Customer::class);
$result = $customerModel->adjustRewardPoints($personId, -40);
$this->assertTrue($result);
$this->assertSame(60, $this->getCustomerPoints($personId));
}
public function testAdjustRewardPointsDecrementFailsWithInsufficientPoints(): void
{
$personId = $this->createCustomerWithPoints(20);
$customerModel = model(Customer::class);
$result = $customerModel->adjustRewardPoints($personId, -40);
$this->assertFalse($result);
$this->assertSame(20, $this->getCustomerPoints($personId));
}
public function testAdjustRewardPointsDecrementExactBalanceSucceeds(): void
{
$personId = $this->createCustomerWithPoints(40);
$customerModel = model(Customer::class);
$result = $customerModel->adjustRewardPoints($personId, -40);
$this->assertTrue($result);
$this->assertSame(0, $this->getCustomerPoints($personId));
}
public function testAdjustRewardPointsConcurrentDecrementsOneWins(): void
{
$personId = $this->createCustomerWithPoints(100);
[$result1, $result2] = $this->raceTwoProcesses(
'rewardPoints',
[$personId, -60],
[$personId, -60]
);
$this->assertSame(1, (int) $result1 + (int) $result2);
$this->assertSame(40, $this->getCustomerPoints($personId));
}
}