mirror of
https://github.com/opensourcepos/opensourcepos.git
synced 2026-09-21 10:15:01 -04:00
* refactor: Replace var with let/const in JavaScript files - Replace var with let for variables that are reassigned - Replace var with const for variables that are never reassigned - Modernize manage_tables.js and nominatim.autocomplete.js - Skip third-party libraries (imgpreview.full.jquery.js, clipboard.min.js) Closes #4491 * refactor: Replace var with let/const in inline JavaScript - Fixed CodeRabbit review: changed enable_actions and load_success from const to let in manage_tables.js (they are reassigned in init) - Replaced all var declarations in inline JavaScript in Views with let (for reassigned) or const (for never reassigned) - Modernized 48 additional files with inline JavaScript * refactor: Replace var with let/const in remaining JS files - Modernized gulpfile.js: 3 var declarations replaced - Modernized app/Views/errors/html/debug.js: all var declarations replaced - Used const for never-reassigned, let for reassigned variables * fix: Replace remaining var declarations in Views - Changed var to const in sales/register.php - Changed var to const in configs/receipt_config.php These were missed in the initial pass. * fix: Replace remaining var declarations in gulpfile.js - Converted 12 remaining var declarations to const - All variables are function-scoped and never reassigned - Complete coverage for this file now * fix: Address CodeRabbit review comments - items/manage.php: Remove duplicate let declaration for start_date (partial/daterangepicker already declares it) - header_js.php: Escape CSRF hash in JavaScript context - tax_jurisdictions.php: Fix mismatched selector (remove_tax_jurisdictions -> remove_tax_jurisdiction) * style(views): Replace var with let/const and fix comment casing - Convert var to let in items/manage.php for JS modernization - Capitalize \"Submit\" in validation comments across tax view files Signed-off-by: Travis Garrison <travis@chiraqbookstore.com> --------- Signed-off-by: Travis Garrison <travis@chiraqbookstore.com> Co-authored-by: Ollama <ollama@steganos.dev> Co-authored-by: objecttothis <17935339+objecttothis@users.noreply.github.com> Co-authored-by: Travis Garrison <travis@chiraqbookstore.com>
129 lines
4.9 KiB
PHP
129 lines
4.9 KiB
PHP
<?php
|
|
/**
|
|
* @var array $tax_codes
|
|
*/
|
|
?>
|
|
|
|
<?= form_open('taxes/save_tax_codes/', ['id' => 'tax_codes_form', 'class' => 'form-horizontal']) ?>
|
|
<div id="config_wrapper">
|
|
<fieldset id="config_info">
|
|
|
|
<div id="required_fields_message"><?= lang('Common.fields_required_message') ?></div>
|
|
<ul id="tax_codes_error_message_box" class="error_message_box"></ul>
|
|
|
|
<div id="tax_codes">
|
|
<?= view('partial/tax_codes', ['tax_codes' => $tax_codes]) ?>
|
|
</div>
|
|
|
|
<?= form_submit([
|
|
'name' => 'submit_tax_codes',
|
|
'id' => 'submit_tax_codes',
|
|
'value' => lang('Common.submit'),
|
|
'class' => 'btn btn-primary btn-sm pull-right'
|
|
]) ?>
|
|
|
|
</fieldset>
|
|
</div>
|
|
<?= form_close() ?>
|
|
|
|
<script type="text/javascript">
|
|
// Validation and Submit Handling
|
|
$(document).ready(function() {
|
|
let tax_code_count = <?= sizeof($tax_codes) ?>;
|
|
if (tax_code_count == 0) {
|
|
tax_code_count = 1;
|
|
}
|
|
|
|
const hide_show_remove_tax_code = function() {
|
|
if ($("input[name*='tax_code']:enabled").length > 1) {
|
|
$(".remove_tax_code").show();
|
|
} else {
|
|
$(".remove_tax_code").hide();
|
|
}
|
|
};
|
|
|
|
const add_tax_code = function() {
|
|
let id = $(this).parent().find("input[name='tax_code[]']").attr('id');
|
|
id = id.replace(/.*?_(\d+)$/g, "$1");
|
|
const previous_tax_code_id = 'tax_code_' + id;
|
|
const block = $(this).parent().clone(true);
|
|
const new_block = block.insertAfter($(this).parent());
|
|
++tax_code_count;
|
|
const new_tax_code_id = 'tax_code_' + tax_code_count;
|
|
|
|
$(new_block).find('label').html("<?= lang('Taxes.tax_code') ?> " + tax_code_count).attr('for', new_tax_code_id).attr('class', 'control-label col-xs-2');
|
|
$(new_block).find("input[name='tax_code[]']").attr('id', new_tax_code_id).removeAttr('disabled').attr('class', 'form-control text-uppercase required input-sm').val('');
|
|
$(new_block).find("input[name='tax_code_name[]']").removeAttr('disabled').attr('class', 'form-control required input-sm').val('');
|
|
$(new_block).find("input[name='city[]']").removeAttr('disabled').attr('class', 'form-control input-sm').val('');
|
|
$(new_block).find("input[name='state[]']").removeAttr('disabled').attr('class', 'form-control input-sm').val('');
|
|
$(new_block).find("input[name='tax_code_id[]']").val('-1');
|
|
|
|
hide_show_remove_tax_code();
|
|
};
|
|
|
|
const remove_tax_code = function() {
|
|
$(this).parent().remove();
|
|
hide_show_remove_tax_code();
|
|
};
|
|
|
|
const init_add_remove_tax_codes = function() {
|
|
$('.add_tax_code').click(add_tax_code);
|
|
$('.remove_tax_code').click(remove_tax_code);
|
|
hide_show_remove_tax_code();
|
|
};
|
|
init_add_remove_tax_codes();
|
|
|
|
// Run validator once for all fields
|
|
$.validator.addMethod('check4TaxCodeDups', function(value, element) {
|
|
let value_count = 0;
|
|
$("input[name='tax_code[]']").each(function() {
|
|
value_count = $(this).val() == value ? value_count + 1 : value_count;
|
|
});
|
|
return value_count <= 1;
|
|
|
|
}, "<?= lang('Taxes.tax_code_duplicate') ?>");
|
|
|
|
$.validator.addMethod('validateTaxCodeCharacters', function(value, element) {
|
|
return (value.indexOf('_') == -1);
|
|
|
|
}, "<?= lang('Taxes.tax_code_invalid_chars') ?>");
|
|
|
|
$.validator.addMethod('requireTaxCode', function(value, element) {
|
|
return value.trim() != '';
|
|
|
|
}, "<?= lang('Taxes.tax_code_required') ?>");
|
|
|
|
$('#tax_codes_form').validate($.extend(form_support.handler, {
|
|
submitHandler: function(form, event) {
|
|
$(form).ajaxSubmit({
|
|
success: function(response) {
|
|
$.notify({
|
|
message: response.message
|
|
}, {
|
|
type: response.success ? 'success' : 'danger'
|
|
});
|
|
$("#tax_codes").load('<?= "taxes/ajax_tax_codes" ?>', init_add_remove_tax_codes);
|
|
},
|
|
dataType: 'json'
|
|
});
|
|
},
|
|
invalidHandler: function(event, validator) {
|
|
$.notify("<?= lang('Common.correct_errors') ?>");
|
|
},
|
|
errorLabelContainer: "#tax_code_error_message_box"
|
|
}));
|
|
|
|
<?php
|
|
$i = 0;
|
|
foreach ($tax_codes as $tax_code => $tax_code_data) {
|
|
?>
|
|
$('<?= '#tax_code_' . ++$i ?>').rules("add", {
|
|
requireTaxCode: true,
|
|
check4TaxCodeDups: true,
|
|
validateTaxCodeCharacters: true
|
|
});
|
|
<?php } ?>
|
|
|
|
});
|
|
</script>
|