mirror of
https://github.com/opensourcepos/opensourcepos.git
synced 2025-12-24 01:57:51 -05:00
e1fedab9b7
- Refactored function names for PSR-12 compliance - Programmatically cascade delete attribute_link rows when a drop-down attribute is deleted but leave attribute_link rows associated with transactions. - Added `WHERE item_id IS NOT NULL` to migration to prevent failure on MySQL databases during migration - Retroactive correction of migration to prevent MySQL databases from failing. - Refactored generic functions to helper - Reverted attribute_links foreign key to ON DELETE RESTRICT which is required for a unique constraint on this table. Cascading deletes are now handled programmatically. - Migration Session table to match Code Igniter 4.6 - Add index to attribute_links to prevent query timeout in items view on large databases - Added overridePrefix() function to the migration_helper. Any time QueryBuilder is adding a prefix to the query when we don't want it to, this query can be used to override the prefix then set it back after you're done. - Added dropAllForeignKeyConstraints() helper function. - Added deleteIndex() helper function. - Added indexExists() helper function. - Added primaryKeyExists() helper function. - Added recreateForeignKeyConstraints() helper function. - Added CRUD section headings to the Attribute model. - Replaced `==` with `===` to prevent type juggling. - Removed unused delete_value function. - Reworked deleteDefinition() and deleteDefinitionList() functions to delete rows from the attribute_links table which are associated. - Added deleteAttributeLinksByDefinitionId() function Implement Cascading Delete - Function to delete attribute links with one or more attribute definitions. - Call function to implement an effective cascading delete. - Refactor function naming to meet PSR-12 conventions Fix Migration - Add drop of Generated Column to prevent failure of migration on MySQL databases. Fix Migration - Removed blank lines - Refactored function naming for PSR compliance - Reformatted code for PSR compliance - Added logic to drop dependent foreign key constraints before deleting an index then recreating them. Migrate ospos_sessions table - DROP and CREATE session table to prevent migration problems on populated databases Fixed Bug in Migration - In the event that item_id = null (e.g., it's a dropdown) it should not be included in the results. Fixed bug in Dropdown deletes - Removed delete_value function in Attributes Controller as it is unused. - Renamed postDelete_attribute_value function for PSR-12 compliance. - Renamed delete_value Attribute model function for PSR-12 compliance. - Refactored out function to getAttributeIdByValue - Replaced == with === to prevent type juggling - Reorganized parts of model to make it easier to find CRUD functions. Refactoring - PSR-12 Compliance formatting changes - Refactored several generic functions into the migration_helper.php - First check if primary key exists before attempting to create it. - Grouped functions together in migration_helper.php - phpdoc commenting functions Optimizing Indices - There are two queries run while opening the Items view which time out on large databases with weak hardware. These indices cut the query execution in half or better. Add Unique constraint back into attribute_links - This migration reverts ospos_attribute_links_ibfk_1 and 2 to ON DELETE RESTRICT. Cascade delete is done programmatically. This is needed to have a unique column on the attribute_links table which prevents duplicate attributes from begin created with the same item_id-attribute_id-definition_id combination Correct spacing after if for PSR-12 Minor code cleanup. - Removed Comments separating sections of code in Attribute model - Removed extra log line to prevent cluttering of the log