Files
opensourcepos/app/Models/Employee.php
T
jekkos 28755dfd50 fix(tests): resolve all phpunit failures — clean-DB suite green (#4626) (#4691)
* fix(tests): resolve all phpunit failures (#4626)

Bring the phpunit suite from 153 failures to 0 (281 tests passing):

- Employee: decouple grants block from save_value success; restructure
  save_employee new-employee + disallowed-grants early return
- Sale: unify sales_payments_temp schema (add sale_cash_refund,
  reference_code) so both creators produce an identical superset table
- Employees controller: provide placeholder password/hash in testing env
  so new-employee insert succeeds and grant logic is testable
- TestDatabaseBootstrapSeeder: reset shared connection table-name cache
  after bootstrap reset to avoid stale listTables()/tableExists() results
- Config: fix postSaveLocale validation rule syntax
- Test data: use unique employee usernames to avoid UNIQUE constraint
  collisions latching strict-mode transStatus=false on the shared conn
- Various test-file and language-string corrections

* test: consolidate employee fixtures in shared trait

Route test employee creation through a single EmployeeFixtureTrait
that delegates to Employee::save_employee(), so fixtures exercise the
same production code path instead of raw DB inserts. Removes six
near-duplicate helpers across EmployeeTest, SalesControllerTest, and
EmployeesControllerTest while preserving each test's specific grant
set.

Closes a piece of the fixture-scattering flagged in #4626.

Closes #4626

* test: add global DROP/CREATE grant and commit theme fixtures

* fix(ci): remove redundant symlink step, set working encryption key

* fix(ci): run phpunit with --no-coverage to avoid no-driver warning

* fix: address code review findings

- Config: restore strict locale validation (min required|integer|>0) and
  fix max cross-field check with a new gte_field rule (CI4's
  greater_than_equal_to[field] does not resolve the field value)
- Tests: assert rejection for non-numeric/zero/negative/min>max limits
- .env.example: remove shared hard-coded encryption.key (auto-generates);
  document Docker env-var usage
- phpunit.yml: scope CREATE/DROP grant to ospos_test.* and provision a
  per-run encryption key as an env var

* feat: support ENCRYPTION_KEY env var for encryption key

Read ENCRYPTION_KEY as a fallback for the encryption key when the
config value is empty. This is a supported, reliable path for Docker /
container deploys and CI, avoiding reliance on the raw dotted
encryption.key env var.

* fix: align Summary_report temp tables with Sale temp table schema

Summary_report created sales_items_taxes_temp and sales_payments_temp with fewer columns than the canonical create_temp_table() in Sale.php. A later reader expecting those columns hit a schema-mismatch SQL error on the shared temp tables. Add internal_tax/sales_tax (sales_items_taxes_temp) and reference_code (sales_payments_temp) so all creators emit the identical column set.
2026-09-08 21:49:28 +02:00

597 lines
18 KiB
PHP

<?php
namespace App\Models;
use CodeIgniter\Database\ResultInterface;
use CodeIgniter\Session\Session;
use stdClass;
/**
* Employee class
*
* @property session session
*
*/
class Employee extends Person
{
public Session $session;
protected $table = 'Employees';
protected $primaryKey = 'person_id';
protected $useAutoIncrement = false;
protected $useSoftDeletes = false;
protected $allowedFields = [
'username',
'password',
'deleted',
'hashversion',
'language',
'language_code'
];
public function __construct()
{
parent::__construct();
$this->session = session();
}
/**
* Determines if a given person_id is an employee
*/
public function exists(int $person_id): bool
{
$builder = $this->db->table('employees');
$builder->join('people', 'people.person_id = employees.person_id');
$builder->where('employees.person_id', $person_id);
return ($builder->get()->getNumRows() == 1); // TODO: ===
}
/**
* @param int $employee_id
* @param string $username
* @return bool
*/
public function username_exists(int $employee_id, string $username): bool
{
$builder = $this->db->table('employees');
$builder->where('employees.username', $username);
$builder->where('employees.person_id <>', $employee_id);
return ($builder->get()->getNumRows() == 1); // TODO: ===
}
/**
* Gets total of rows
*/
public function get_total_rows(): int
{
$builder = $this->db->table('employees');
$builder->where('deleted', 0);
return $builder->countAllResults();
}
/**
* Returns all the employees
*/
public function get_all(int $limit = 10000, int $offset = 0): ResultInterface
{
$builder = $this->db->table('employees');
$builder->where('deleted', 0);
$builder->join('people', 'employees.person_id = people.person_id');
$builder->orderBy('last_name', 'asc');
$builder->limit($limit);
$builder->offset($offset);
return $builder->get();
}
/**
* Gets information about a particular employee
*/
public function get_info(int $person_id): object
{
$builder = $this->db->table('employees');
$builder->join('people', 'people.person_id = employees.person_id');
$builder->where('employees.person_id', $person_id);
$query = $builder->get();
if ($query->getNumRows() == 1) { // TODO: ===
return $query->getRow();
}
// Get empty base parent object, as $employee_id is NOT an employee
$person_obj = parent::get_info(NEW_ITEM);
// Get all the fields from employee table
// Append those fields to base parent object, we have a complete empty object
foreach ($this->db->getFieldNames('employees') as $field) {
$person_obj->$field = null;
}
return $person_obj;
}
/**
* Gets information about multiple employees
*/
public function get_multiple_info(array $person_ids): ResultInterface
{
$builder = $this->db->table('employees');
$builder->join('people', 'people.person_id = employees.person_id');
$builder->whereIn('employees.person_id', $person_ids);
$builder->orderBy('last_name', 'asc');
return $builder->get();
}
/**
* Inserts or updates an employee
*/
public function save_employee(array &$person_data, array &$employee_data, array &$grants_data, int $employee_id = NEW_ENTRY): bool
{
$success = true;
$isNewEmployee = ($employee_id == NEW_ENTRY || !$this->exists($employee_id));
$grantChangeDisallowed = filter_var(getenv('DISALLOW_GRANT_CHANGE'), FILTER_VALIDATE_BOOLEAN);
// Run these queries as a transaction, we want to make sure we do all or nothing
$this->db->transStart();
if ($grantChangeDisallowed && $isNewEmployee && !empty($grants_data)) {
$this->db->transComplete();
return false;
}
$personSaved = parent::save_value($person_data, $employee_id);
if ($isNewEmployee && !$personSaved) {
// A new employee must have a person record; abort if the insert failed
$this->db->transComplete();
return false;
}
if ($personSaved) {
if ($isNewEmployee) {
$employee_data['person_id'] = $employee_id = $person_data['person_id'];
$success = $this->db->table('employees')->insert($employee_data);
} else {
$success = $success && $this->db->table('employees')->where('person_id', $employee_id)->update($employee_data);
}
}
// Grants update is gated only by the DISALLOW_GRANT_CHANGE flag, not by
// whether person/employee data was actually written (a 0-row affected
// update on existing data is a no-op, not a failure).
if (!$grantChangeDisallowed && !empty($grants_data)) {
$success = $success && $this->db->table('grants')->delete(['person_id' => $employee_id]);
foreach ($grants_data as $grant) {
$data = [
'permission_id' => $grant['permission_id'],
'person_id' => $employee_id,
'menu_group' => $grant['menu_group']
];
$success = $success && $this->db->table('grants')->insert($data);
}
}
$this->db->transComplete();
$success = $success && $this->db->transStatus();
return $success;
}
/**
* Deletes one employee
*/
public function delete($employee_id = null, bool $purge = false): bool
{
$success = false;
// Don't let employees delete themselves
if ($employee_id == $this->get_logged_in_employee_info()->person_id) {
return false;
}
// Run these queries as a transaction, we want to make sure we do all or nothing
$this->db->transStart();
// Delete permissions
$builder = $this->db->table('grants');
if ($builder->delete(['person_id' => $employee_id])) {
$builder = $this->db->table('employees');
$builder->where('person_id', $employee_id);
$success = $builder->update(['deleted' => 1]);
}
$this->db->transComplete();
return $success;
}
/**
* Deletes a list of employees
*/
public function delete_list(array $person_ids): bool
{
$success = false;
// Don't let employees delete themselves
if (in_array($this->get_logged_in_employee_info()->person_id, $person_ids)) {
return false;
}
// Run these queries as a transaction, we want to make sure we do all or nothing
$this->db->transStart();
$builder = $this->db->table('grants');
$builder->whereIn('person_id', $person_ids);
// Delete permissions
if ($builder->delete()) {
// Delete from employee table
$builder = $this->db->table('employees');
$builder->whereIn('person_id', $person_ids);
$success = $builder->update(['deleted' => 1]);
}
$this->db->transComplete();
$success &= $this->db->transStatus();
return $success;
}
/**
* Get search suggestions to find employees
*/
public function get_search_suggestions(string $search, int $limit = 25, bool $unique = false): array
{
$suggestions = [];
$builder = $this->db->table('employees');
$builder->join('people', 'employees.person_id = people.person_id');
$builder->groupStart();
$builder->like('first_name', $search);
$builder->orLike('last_name', $search);
$builder->orLike('CONCAT(first_name, " ", last_name)', $search);
$builder->groupEnd();
if (!$unique) {
$builder->where('deleted', 0);
}
$builder->orderBy('last_name', 'asc');
foreach ($builder->get()->getResult() as $row) {
$suggestions[] = ['value' => $row->person_id, 'label' => $row->first_name . ' ' . $row->last_name];
}
$builder = $this->db->table('employees');
$builder->join('people', 'employees.person_id = people.person_id');
if (!$unique) {
$builder->where('deleted', 0);
}
$builder->like('email', $search);
$builder->orderBy('email', 'asc');
foreach ($builder->get()->getResult() as $row) {
$suggestions[] = ['value' => $row->person_id, 'label' => $row->email];
}
$builder = $this->db->table('employees');
$builder->join('people', 'employees.person_id = people.person_id');
if (!$unique) {
$builder->where('deleted', 0);
}
$builder->like('username', $search);
$builder->orderBy('username', 'asc');
foreach ($builder->get()->getResult() as $row) {
$suggestions[] = ['value' => $row->person_id, 'label' => $row->username];
}
$builder = $this->db->table('employees');
$builder->join('people', 'employees.person_id = people.person_id');
if (!$unique) {
$builder->where('deleted', 0);
}
$builder->like('phone_number', $search);
$builder->orderBy('phone_number', 'asc');
foreach ($builder->get()->getResult() as $row) {
$suggestions[] = ['value' => $row->person_id, 'label' => $row->phone_number];
}
// Only return $limit suggestions
if (count($suggestions) > $limit) {
$suggestions = array_slice($suggestions, 0, $limit);
}
return $suggestions;
}
/**
* Gets rows
*/
public function get_found_rows(string $search): int
{
return $this->search($search, 0, 0, 'last_name', 'asc', true);
}
/**
* Performs a search on employees
*/
public function search(string $search, ?int $rows = 0, ?int $limit_from = 0, ?string $sort = 'last_name', ?string $order = 'asc', ?bool $count_only = false)
{
// Set default values
if ($rows == null) $rows = 0;
if ($limit_from == null) $limit_from = 0;
if ($sort == null) $sort = 'last_name';
if ($order == null) $order = 'asc';
if ($count_only == null) $count_only = false;
$builder = $this->db->table('employees AS employees');
// get_found_rows case
if ($count_only) {
$builder->select('COUNT(employees.person_id) as count');
}
$builder->join('people', 'employees.person_id = people.person_id');
$builder->groupStart();
$builder->like('first_name', $search);
$builder->orLike('last_name', $search);
$builder->orLike('email', $search);
$builder->orLike('phone_number', $search);
$builder->orLike('username', $search);
$builder->orLike('CONCAT(first_name, " ", last_name)', $search);
$builder->groupEnd();
$builder->where('deleted', 0);
// get_found_rows case
if ($count_only) {
return $builder->get()->getRow()->count;
}
$builder->orderBy($sort, $order);
if ($rows > 0) {
$builder->limit($rows, $limit_from);
}
return $builder->get();
}
/**
* Attempts to log in employee and set session. Returns boolean based on outcome.
*/
public function login(string $username, string $password): bool
{
$builder = $this->db->table('employees');
$query = $builder->getWhere(['username' => $username, 'deleted' => 0], 1);
if ($query->getNumRows() === 1) {
$row = $query->getRow();
// Compare passwords depending on the hash version
if ($row->hash_version === '1' && $row->password === md5($password)) {
$builder->where('person_id', $row->person_id);
$passwordHash = password_hash($password, PASSWORD_DEFAULT);
$updated = $builder->update(['hash_version' => 2, 'password' => $passwordHash]);
if ($updated) {
if (session_status() === PHP_SESSION_ACTIVE) {
$this->session->regenerate(true);
}
$this->session->set('person_id', $row->person_id);
}
return $updated;
} elseif ($row->hash_version === '2' && password_verify($password, $row->password)) {
if (session_status() === PHP_SESSION_ACTIVE) {
$this->session->regenerate(true);
}
$this->session->set('person_id', $row->person_id);
return true;
}
}
return false;
}
/**
* Logs out a user by destroying all session data and redirect to log in
*/
public function logout(): void
{
session()->destroy();
}
/**
* Determines if an employee is logged in
*/
public function is_logged_in(): bool
{
return ($this->session->get('person_id') != false);
}
/**
* Gets information about the currently logged in employee.
*/
public function get_logged_in_employee_info(): float|false|array|int|string|stdClass|null
{
if ($this->is_logged_in()) {
return $this->get_info($this->session->get('person_id'));
}
return false;
}
/**
* Determines whether the employee has access to at least one submodule
*/
public function has_module_grant(string $permission_id, int $person_id): bool
{
$builder = $this->db->table('grants');
$builder->like('permission_id', $permission_id, 'after');
$builder->where('person_id', $person_id);
$result_count = $builder->get()->getNumRows();
if ($result_count != 1) {
return ($result_count != 0);
}
return $this->has_subpermissions($permission_id);
}
/**
* Checks permissions
*/
public function has_subpermissions(string $permission_id): bool
{
$builder = $this->db->table('permissions');
$builder->like('permission_id', $permission_id . '_', 'after');
return ($builder->get()->getNumRows() == 0); // TODO: ===
}
/**
* Determines whether the employee specified employee has access the specific module.
*/
public function has_grant(?string $permission_id, ?int $person_id): bool
{
// If no module_id is null, allow access
if ($permission_id == null) {
return true;
}
if ($person_id == null) {
return false;
}
$builder = $this->db->table('grants');
$query = $builder->getWhere(['person_id' => $person_id, 'permission_id' => $permission_id], 1);
return ($query->getNumRows() == 1); // TODO: ===
}
/**
* Returns the menu group designation that this module is to appear in
*/
public function get_menu_group(string $permission_id, ?int $person_id): string
{
$builder = $this->db->table('grants');
$builder->select('menu_group');
$builder->where('permission_id', $permission_id);
$builder->where('person_id', $person_id);
$row = $builder->get()->getRow();
// If no grants are assigned yet then set the default to 'home'
if ($row == null) {
return 'home';
} else {
return $row->menu_group;
}
}
/**
* Gets employee permission grants
*/
public function get_employee_grants(int $person_id): array
{
$builder = $this->db->table('grants');
$builder->where('person_id', $person_id);
return $builder->get()->getResultArray();
}
/**
* Attempts to log in employee and set session. Returns boolean based on outcome.
*/
public function check_password(string $username, string $password): bool
{
$builder = $this->db->table('employees');
$query = $builder->getWhere(['username' => $username, 'deleted' => 0], 1);
if ($query->getNumRows() == 1) { // TODO: ===
$row = $query->getRow();
if (password_verify($password, $row->password)) {
return true;
}
}
return false;
}
/**
* Change password for the employee
*/
public function change_password(array $employee_data, $employee_id = false): bool
{
$success = false;
if (!filter_var(getenv('DISALLOW_PASSWORD_CHANGE'), FILTER_VALIDATE_BOOLEAN)) {
$this->db->transStart();
$builder = $this->db->table('employees');
$builder->where('person_id', $employee_id);
$success = $builder->update($employee_data);
$this->db->transComplete();
$success &= $this->db->transStatus();
}
return $success;
}
/**
* Checks if the employee has admin privileges (all module permissions).
* The first employee (person_id = 1) is considered admin by default.
*/
public function isAdmin(int $person_id): bool
{
if ($person_id === 1) {
return true;
}
foreach (ADMIN_MODULES as $module) {
if (!$this->has_grant($module, $person_id)) {
return false;
}
}
return true;
}
/**
* Checks if current user can modify target employee.
* Only admins can modify other admin accounts.
* Users cannot modify their own grants unless they are admin.
*/
public function canModifyEmployee(int $target_person_id, int $current_person_id): bool
{
if ($target_person_id === $current_person_id) {
return !$this->isAdmin($target_person_id) || $this->isAdmin($current_person_id);
}
if ($this->isAdmin($target_person_id) && !$this->isAdmin($current_person_id)) {
return false;
}
return true;
}
}