mirror of
https://github.com/opensourcepos/opensourcepos.git
synced 2026-09-13 05:47:23 -04:00
* fix(tests): resolve all phpunit failures (#4626) Bring the phpunit suite from 153 failures to 0 (281 tests passing): - Employee: decouple grants block from save_value success; restructure save_employee new-employee + disallowed-grants early return - Sale: unify sales_payments_temp schema (add sale_cash_refund, reference_code) so both creators produce an identical superset table - Employees controller: provide placeholder password/hash in testing env so new-employee insert succeeds and grant logic is testable - TestDatabaseBootstrapSeeder: reset shared connection table-name cache after bootstrap reset to avoid stale listTables()/tableExists() results - Config: fix postSaveLocale validation rule syntax - Test data: use unique employee usernames to avoid UNIQUE constraint collisions latching strict-mode transStatus=false on the shared conn - Various test-file and language-string corrections * test: consolidate employee fixtures in shared trait Route test employee creation through a single EmployeeFixtureTrait that delegates to Employee::save_employee(), so fixtures exercise the same production code path instead of raw DB inserts. Removes six near-duplicate helpers across EmployeeTest, SalesControllerTest, and EmployeesControllerTest while preserving each test's specific grant set. Closes a piece of the fixture-scattering flagged in #4626. Closes #4626 * test: add global DROP/CREATE grant and commit theme fixtures * fix(ci): remove redundant symlink step, set working encryption key * fix(ci): run phpunit with --no-coverage to avoid no-driver warning * fix: address code review findings - Config: restore strict locale validation (min required|integer|>0) and fix max cross-field check with a new gte_field rule (CI4's greater_than_equal_to[field] does not resolve the field value) - Tests: assert rejection for non-numeric/zero/negative/min>max limits - .env.example: remove shared hard-coded encryption.key (auto-generates); document Docker env-var usage - phpunit.yml: scope CREATE/DROP grant to ospos_test.* and provision a per-run encryption key as an env var * feat: support ENCRYPTION_KEY env var for encryption key Read ENCRYPTION_KEY as a fallback for the encryption key when the config value is empty. This is a supported, reliable path for Docker / container deploys and CI, avoiding reliance on the raw dotted encryption.key env var. * fix: align Summary_report temp tables with Sale temp table schema Summary_report created sales_items_taxes_temp and sales_payments_temp with fewer columns than the canonical create_temp_table() in Sale.php. A later reader expecting those columns hit a schema-mismatch SQL error on the shared temp tables. Add internal_tax/sales_tax (sales_items_taxes_temp) and reference_code (sales_payments_temp) so all creators emit the identical column set.
142 lines
4.6 KiB
PHP
142 lines
4.6 KiB
PHP
<?php
|
|
|
|
namespace Tests\Support;
|
|
|
|
use App\Models\Employee;
|
|
|
|
/**
|
|
* Shared factory for creating employees in test fixtures.
|
|
*
|
|
* All employees created via this trait route through
|
|
* {@see Employee::save_employee()}, which is the same code path the
|
|
* application itself uses. That keeps fixtures exercising the real
|
|
* validation and grant-handling logic instead of raw DB inserts.
|
|
*
|
|
* Every employee gets a unique email and username by default (uniqueness
|
|
* required because tests do not always run against a freshly-reset DB —
|
|
* see opensourcepos/opensourcepos#4626 for the root-cause history).
|
|
*
|
|
* Usage:
|
|
*
|
|
* use Tests\Support\EmployeeFixtureTrait;
|
|
*
|
|
* class FooTest extends CIUnitTestCase
|
|
* {
|
|
* use EmployeeFixtureTrait;
|
|
*
|
|
* public function testSomething(): void
|
|
* {
|
|
* $personId = $this->createEmployee(
|
|
* first_name: 'Cashier',
|
|
* last_name: 'NoReports',
|
|
* email: 'cashier.' . uniqid() . '@test.com',
|
|
* username: 'cashier_' . uniqid(),
|
|
* grants: [
|
|
* ['permission_id' => 'sales', 'menu_group' => 'home'],
|
|
* ],
|
|
* );
|
|
* }
|
|
* }
|
|
*/
|
|
trait EmployeeFixtureTrait
|
|
{
|
|
/**
|
|
* Create a new employee (person + employee row + grants) via the
|
|
* application's own code path ({@see Employee::save_employee()}).
|
|
*
|
|
* @param string $first_name
|
|
* @param string $last_name
|
|
* @param null|string $email unique email (auto-generated if omitted)
|
|
* @param null|string $username unique username (auto-generated if omitted)
|
|
* @param null|string $phone_number
|
|
* @param array $grants list of ['permission_id' => ..., 'menu_group' => ...]
|
|
* @param array $employee extra ospos_employees row overrides
|
|
*
|
|
* @return int the new person_id
|
|
*/
|
|
protected function createEmployee(
|
|
string $first_name = 'Temp',
|
|
string $last_name = 'Employee',
|
|
?string $email = null,
|
|
?string $username = null,
|
|
?string $phone_number = null,
|
|
array $grants = [],
|
|
array $employee = []
|
|
): int {
|
|
if ($email === null) {
|
|
$email = 'employee.' . uniqid() . '@test.com';
|
|
}
|
|
if ($username === null) {
|
|
$username = 'employee_' . uniqid();
|
|
}
|
|
if ($phone_number === null) {
|
|
$phone_number = '';
|
|
}
|
|
|
|
$personData = [
|
|
'first_name' => $first_name,
|
|
'last_name' => $last_name,
|
|
'email' => $email,
|
|
'phone_number' => $phone_number,
|
|
];
|
|
|
|
$employeeData = array_merge([
|
|
'username' => $username,
|
|
'password' => password_hash('password123', PASSWORD_DEFAULT),
|
|
'hash_version' => 2,
|
|
'language_code' => 'en',
|
|
'language' => 'english',
|
|
], $employee);
|
|
|
|
$model = model(Employee::class);
|
|
$this->assertTrue(
|
|
$model->save_employee($personData, $employeeData, $grants, NEW_ENTRY),
|
|
'createEmployee: save_employee() failed'
|
|
);
|
|
$this->assertArrayHasKey('person_id', $personData);
|
|
|
|
return (int) $personData['person_id'];
|
|
}
|
|
|
|
/**
|
|
* Variant of {@see self::createEmployee()} for tests that expect the
|
|
* save to fail (e.g. new-employee creation when DISALLOW_GRANT_CHANGE
|
|
* is true). Returns the raw save_employee() result without asserting.
|
|
*/
|
|
protected function createEmployeeExpectingFailure(
|
|
string $first_name = 'Rejected',
|
|
string $last_name = 'Tester',
|
|
?string $email = null,
|
|
?string $username = null,
|
|
?string $phone_number = null,
|
|
array $grants = [],
|
|
array $employee = []
|
|
): bool {
|
|
if ($email === null) {
|
|
$email = 'employee.' . uniqid() . '@test.com';
|
|
}
|
|
if ($username === null) {
|
|
$username = 'employee_' . uniqid();
|
|
}
|
|
if ($phone_number === null) {
|
|
$phone_number = '';
|
|
}
|
|
|
|
$personData = [
|
|
'first_name' => $first_name,
|
|
'last_name' => $last_name,
|
|
'email' => $email,
|
|
'phone_number' => $phone_number,
|
|
];
|
|
$employeeData = array_merge([
|
|
'username' => $username,
|
|
'password' => password_hash('password123', PASSWORD_DEFAULT),
|
|
'hash_version' => 2,
|
|
'language_code' => 'en',
|
|
'language' => 'english',
|
|
], $employee);
|
|
|
|
return model(Employee::class)->save_employee($personData, $employeeData, $grants, NEW_ENTRY);
|
|
}
|
|
}
|