mirror of
https://github.com/opensourcepos/opensourcepos.git
synced 2026-05-16 20:38:32 -04:00
2f51c4ef52
Security fixes for two vulnerabilities:
1. SQL Injection in Summary Sales Taxes Report (GHSA-5j9m-2f98-cjqw)
- Fixed unsanitized user input concatenation in getData() method
- Applied proper escaping using $this->db->escape() for start_date/end_date
- Consistent with existing _where() method implementation
2. Path Traversal in Receipt Template (GHSA-h6wm-fhw2-m3q3)
- Added ALLOWED_RECEIPT_TEMPLATES whitelist constant
- Added isValidReceiptTemplate() validation method
- Validate receipt_template before saving in Config controller
- Validate receipt_template before rendering in receipt view
- Default to 'receipt_default' for invalid values
- Consistent with invoice_type fix pattern (commit 31d25e06d)
Affected files:
- app/Models/Reports/Summary_sales_taxes.php
- app/Libraries/Sale_lib.php
- app/Controllers/Config.php
- app/Views/sales/receipt.php
Co-authored-by: Ollama <ollama@steganos.dev>
70 lines
2.4 KiB
PHP
70 lines
2.4 KiB
PHP
<?php
|
|
/**
|
|
* @var int $sale_id_num
|
|
* @var bool $print_after_sale
|
|
* @var string $receipt_template_view
|
|
* @var array $config
|
|
*/
|
|
|
|
use App\Models\Employee;
|
|
|
|
$template = $receipt_template_view ?? 'receipt_default';
|
|
|
|
?>
|
|
|
|
<?= view('partial/header') ?>
|
|
|
|
<?php
|
|
if (isset($error_message)) {
|
|
echo '<div class="alert alert-dismissible alert-danger">' . $error_message . '</div>';
|
|
exit;
|
|
}
|
|
?>
|
|
|
|
<?php if (!empty($customer_email)): ?>
|
|
<script type="text/javascript">
|
|
$(document).ready(function() {
|
|
var send_email = function() {
|
|
$.get('<?= site_url() . esc("/sales/sendPdf/$sale_id_num/receipt") ?>',
|
|
function(response) {
|
|
$.notify({
|
|
message: response.message
|
|
}, {
|
|
type: response.success ? 'success' : 'danger'
|
|
})
|
|
}, 'json'
|
|
);
|
|
};
|
|
|
|
$("#show_email_button").click(send_email);
|
|
|
|
<?php if (!empty($email_receipt)): ?>
|
|
send_email();
|
|
<?php endif; ?>
|
|
});
|
|
</script>
|
|
<?php endif; ?>
|
|
|
|
<?= view('partial/print_receipt', ['print_after_sale' => $print_after_sale, 'selected_printer' => 'receipt_printer']) ?>
|
|
|
|
<div class="print_hide" id="control_buttons" style="text-align: right;">
|
|
<a href="javascript:printdoc();">
|
|
<div class="btn btn-info btn-sm" id="show_print_button"><?= '<span class="glyphicon glyphicon-print"> </span>' . lang('Common.print') ?></div>
|
|
</a>
|
|
<?php if (!empty($customer_email)): ?>
|
|
<a href="javascript:void(0);">
|
|
<div class="btn btn-info btn-sm" id="show_email_button"><?= '<span class="glyphicon glyphicon-envelope"> </span>' . lang('Sales.send_receipt') ?></div>
|
|
</a>
|
|
<?php endif; ?>
|
|
<?= anchor('sales', '<span class="glyphicon glyphicon-shopping-cart"> </span>' . lang('Sales.register'), ['class' => 'btn btn-info btn-sm', 'id' => 'show_sales_button']) ?>
|
|
<?php
|
|
$employee = model(Employee::class);
|
|
if ($employee->has_grant('reports_sales', session('person_id'))): ?>
|
|
<?= anchor('sales/manage', '<span class="glyphicon glyphicon-list-alt"> </span>' . lang('Sales.takings'), ['class' => 'btn btn-info btn-sm', 'id' => 'show_takings_button']) ?>
|
|
<?php endif; ?>
|
|
</div>
|
|
|
|
<?= view('sales/' . $template) ?>
|
|
|
|
<?= view('partial/footer') ?>
|