mirror of
https://github.com/opensourcepos/opensourcepos.git
synced 2026-03-12 12:14:22 -04:00
Complete Content-Type application/json fix for all AJAX responses - Add missing return statements to all ->response->setJSON() calls - Fix Items.php method calls from JSON() to setJSON() - Convert echo statements to proper JSON responses - Ensure consistent Content-Type headers across all controllers - Fix 46+ instances across 12 controller files - Change Config.php methods to : ResponseInterface (all return setJSON only): - postSaveRewards(), postSaveBarcode(), postSaveReceipt() - postSaveInvoice(), postRemoveLogo() - Update PHPDoc @return tags - Change Receivings.php _reload() to : string (only returns view) - Change Receivings.php methods to : string (all return _reload()): - getIndex(), postSelectSupplier(), postChangeMode(), postAdd() - postEditItem(), getDeleteItem(), getRemoveSupplier() - postComplete(), postRequisitionComplete(), getReceipt(), postCancelReceiving() - Change postSave() to : ResponseInterface (returns setJSON) - Update all PHPDoc @return tags Fix XSS vulnerabilities in sales templates, login, and config pages This commit addresses 5 XSS vulnerabilities by adding proper escaping to all user-controlled configuration values in HTML contexts. Fixed Files: - app/Views/sales/invoice.php: Escaped company_logo (URL context) and company (HTML) - app/Views/sales/work_order.php: Escaped company_logo (URL context) - app/Views/sales/receipt_email.php: Added file path validation and escaping for logo - app/Views/login.php: Escaped all config values in title, logo src, and alt - app/Views/configs/info_config.php: Escaped company_logo (URL context) Security Impact: - Prevents stored XSS attacks if configuration is compromised - Defense-in-depth principle applied to administrative interfaces - Follows OWASP best practices for output encoding Testing: - Verified no script execution with XSS payloads in config values - Confirmed proper escaping in HTML, URL, and file contexts - All templates render correctly with valid configuration Severity: High (4 files), Medium-High (1 file) CVSS Score: ~6.1 CWE: CWE-79 (Improper Neutralization of Input During Web Page Generation) Fix critical password validation bypass and add unit tests This commit addresses a critical security vulnerability where the password minimum length check was performed on the HASHED password (always 60 characters for bcrypt) instead of the actual password before hashing. Vulnerability Details: - Original code: strlen($employee_data['password']) >= 8 - This compared the hash length (always 60) instead of raw password - Impact: Users could set 1-character passwords like "a" - Severity: Critical (enables brute force attacks on weak passwords) - CVE-like issue: CWE-307 (Improper Restriction of Excessive Authentication Attempts) Fix Applied: - Validate password length BEFORE hashing - Clear error message when password is too short - Added unit tests to verify minimum length enforcement - Regression test to prevent future vulnerability re-introduction Test Coverage: - testPasswordMinLength_Rejects7Characters: Verify 7 chars rejected - testPasswordMinLength_Accepts8Characters: Verify 8 chars accepted - testPasswordMinLength_RejectsEmptyString: Verify empty rejected - testPasswordMinLength_RejectsWhitespaceOnly: Verify whitespace rejected - testPasswordMinLength_AcceptsSpecialCharacters: Verify special chars OK - testPasswordMinLength_RejectsPreviousBehavior: Regression test for bug Files Modified: - app/Controllers/Home.php: Fixed password validation logic - tests/Controllers/HomeTest.php: Added comprehensive unit tests Security Impact: - Enforces 8-character minimum password policy - Prevents extremely weak passwords that facilitate brute-force attacks - Critical for credential security and user account protection Breaking Changes: - Users with passwords < 8 characters will need to reset their password - This is the intended security improvement Severity: Critical CVSS Score: ~7.5 CWE: CWE-305 (Authentication Bypass by Primary Weakness), CWE-307 Add GitHub Actions workflow to run PHPUnit tests Move business logic from views to controllers for better separation of concerns - Move logo URL computation from info_config view to Config::getIndex() - Move image base64 encoding from receipt_email view to Sales controller - Improves separation of concerns by keeping business logic in controllers - Simplifies view templates to only handle presentation Fix XSS vulnerabilities in report views - escape user-controllable summary data and labels Fix base64 encoding URL issue in delete payment - properly URL encode base64 string Fix remaining return type declarations for Sales controller Fixed additional methods that call _reload(): - postAdd() - returns _reload($data) - postAddPayment() - returns _reload($data) - postEditItem() - returns _reload($data) - postSuspend() - returns _reload($data) - postSetPaymentType() - returns _reload() All methods now return ResponseInterface|string to match _reload() signature. This resolves PHP TypeError errors.
166 lines
6.9 KiB
PHP
166 lines
6.9 KiB
PHP
<?php
|
|
/**
|
|
* @var string $transaction_time
|
|
* @var int $sale_id
|
|
* @var string $employee
|
|
* @var array $cart
|
|
* @var float $discount
|
|
* @var float $subtotal
|
|
* @var array $taxes
|
|
* @var float $total
|
|
* @var array $payments
|
|
* @var float $amount_change
|
|
* @var string $barcode
|
|
* @var array $config
|
|
*/
|
|
?>
|
|
|
|
<div id="receipt_wrapper" style="width: 100%;">
|
|
<div id="receipt_header" style="text-align: center;">
|
|
<?php if ($config['company_logo'] != '') { ?>
|
|
<div id="company_name">
|
|
<?= $img_tag ?>
|
|
</div>
|
|
<?php } ?>
|
|
|
|
<?php if ($config['receipt_show_company_name']) { ?>
|
|
<div id="company_name" style="font-size: 150%; font-weight: bold;"><?= esc($config['company']) ?></div>
|
|
<?php } ?>
|
|
|
|
<div id="company_address"><?= nl2br(esc($config['address'])) ?></div>
|
|
<div id="company_phone"><?= esc($config['phone']) ?></div>
|
|
<br>
|
|
<div id="sale_receipt"><?= lang('Sales.receipt') ?></div>
|
|
<div id="sale_time"><?= esc($transaction_time) ?></div>
|
|
</div>
|
|
|
|
<br>
|
|
|
|
<div id="receipt_general_info" style="text-align: left;">
|
|
<?php if (isset($customer)) { ?>
|
|
<div id="customer"><?= lang('Customers.customer') . esc(": $customer") ?></div>
|
|
<?php } ?>
|
|
|
|
<div id="sale_id"><?= lang('Sales.id') . esc(": $sale_id") ?></div>
|
|
<div id="employee"><?= lang('Employees.employee') . esc(": $employee") ?></div>
|
|
</div>
|
|
|
|
<br>
|
|
|
|
<table id="receipt_items" style="text-align: left; width: 100%;">
|
|
<tr>
|
|
<th style="width: 40%;"><?= lang('Sales.description_abbrv') ?></th>
|
|
<th style="width: 20%;"><?= lang('Sales.price') ?></th>
|
|
<th style="width: 20%;"><?= lang('Sales.quantity') ?></th>
|
|
<th style="width: 20%; text-align: right;"><?= lang('Sales.total') ?></th>
|
|
</tr>
|
|
<?php
|
|
foreach ($cart as $line => $item) {
|
|
if ($item['print_option'] == PRINT_YES) {
|
|
?>
|
|
<tr>
|
|
<td><?= esc(ucfirst($item['name'] . ' ' . $item['attribute_values'])) ?></td>
|
|
<td><?= to_currency($item['price']) ?></td>
|
|
<td><?= to_quantity_decimals($item['quantity']) ?></td>
|
|
<td style="text-align: right;"><?= to_currency($item[($config['receipt_show_total_discount'] ? 'total' : 'discounted_total')]) ?></td>
|
|
</tr>
|
|
<tr>
|
|
<?php if ($config['receipt_show_description']) { ?>
|
|
<td colspan="2"><?= esc($item['description']) ?></td>
|
|
<?php } ?>
|
|
|
|
<?php if ($config['receipt_show_serialnumber']) { ?>
|
|
<td><?= esc($item['serialnumber']) ?></td>
|
|
<?php } ?>
|
|
</tr>
|
|
<?php if ($item['discount'] > 0) { ?>
|
|
<tr>
|
|
<?php if ($item['discount_type'] == FIXED) { ?>
|
|
<td colspan="3" class="discount"><?= to_currency($item['discount']) . " " . lang('Sales.discount') ?></td>
|
|
<?php } elseif ($item['discount_type'] == PERCENT) { ?>
|
|
<td colspan="3" class="discount"><?= to_decimals($item['discount']) . " " . lang('Sales.discount_included') ?></td>
|
|
<?php } ?>
|
|
<td class="total-value" style="text-align: right;"><?= to_currency($item['discounted_total']) ?></td>
|
|
</tr>
|
|
<?php
|
|
}
|
|
}
|
|
}
|
|
?>
|
|
|
|
<?php if ($config['receipt_show_total_discount'] && $discount > 0) { ?>
|
|
<tr>
|
|
<td colspan="3" style="text-align: right; border-top: 2px solid #000000;"><?= lang('Sales.sub_total') ?></td>
|
|
<td style="text-align: right; border-top: 2px solid #000000;"><?= to_currency($subtotal) ?></td>
|
|
</tr>
|
|
<tr>
|
|
<td colspan="3" style="text-align: right;"><?= lang('Sales.discount') ?>:</td>
|
|
<td style="text-align: right;"><?= to_currency($discount * -1) ?></td>
|
|
</tr>
|
|
<?php } ?>
|
|
|
|
<?php if ($config['receipt_show_taxes']) { ?>
|
|
<tr>
|
|
<td colspan="3" style="text-align: right; border-top: 2px solid #000000;"><?= lang('Sales.sub_total') ?></td>
|
|
<td style="text-align: right; border-top: 2px solid #000000;"><?= to_currency($subtotal) ?></td>
|
|
</tr>
|
|
<?php foreach ($taxes as $tax_group_index => $tax) { ?>
|
|
<tr>
|
|
<td colspan="3" style="text-align: right;"><?= (float)$tax['tax_rate'] . '% ' . $tax['tax_group'] ?>:</td>
|
|
<td style="text-align: right;"><?= to_currency_tax($tax['sale_tax_amount']) ?></td>
|
|
</tr>
|
|
<?php
|
|
}
|
|
}
|
|
?>
|
|
|
|
<tr></tr>
|
|
|
|
<?php $border = (!$config['receipt_show_taxes'] && !($config['receipt_show_total_discount'] && $discount > 0)) ?>
|
|
<tr>
|
|
<td colspan="3" style="text-align: right;<?= $border ? ' border-top: 2px solid black;' : '' ?>"><?= lang('Sales.total') ?></td>
|
|
<td style="text-align: right;<?= $border ? ' border-top: 2px solid black;' : '' ?>"><?= to_currency($total) ?></td>
|
|
</tr>
|
|
|
|
<?php
|
|
$only_sale_check = false;
|
|
$show_giftcard_remainder = false;
|
|
foreach ($payments as $payment_id => $payment) {
|
|
$only_sale_check |= $payment['payment_type'] == lang('Sales.check');
|
|
$splitpayment = explode(':', $payment['payment_type']);
|
|
$show_giftcard_remainder |= $splitpayment[0] == lang('Sales.giftcard');
|
|
?>
|
|
<tr>
|
|
<td colspan="3" style="text-align: right;"><?= esc($splitpayment[0]) ?> </td>
|
|
<td style="text-align: right;"><?= to_currency($payment['payment_amount'] * -1) ?></td>
|
|
</tr>
|
|
<?php } ?>
|
|
|
|
<?php if (isset($cur_giftcard_value) && $show_giftcard_remainder) { ?>
|
|
<tr>
|
|
<td colspan="3" style="text-align: right;"><?= lang('Sales.giftcard_balance') ?></td>
|
|
<td style="text-align: right;"><?= to_currency($cur_giftcard_value) ?></td>
|
|
</tr>
|
|
<?php } ?>
|
|
<tr>
|
|
<td colspan="3" style="text-align: right;"> <?= lang($amount_change >= 0 ? ($only_sale_check ? 'Sales.check_balance' : 'Sales.change_due') : 'Sales.amount_due') ?> </td>
|
|
<td style="text-align: right;"><?= to_currency($amount_change) ?></td>
|
|
</tr>
|
|
|
|
<tr>
|
|
<td colspan="4"> </td>
|
|
</tr>
|
|
</table>
|
|
|
|
<div id="terms">
|
|
<div id="sale_return_policy" style="text-align: center;">
|
|
<?= nl2br(esc($config['return_policy'])) ?>
|
|
</div>
|
|
|
|
<div id="barcode" style="text-align: center;">
|
|
<img alt=<?= '$sale_id' ?> src="data:image/svg+xml;base64,<?= base64_encode($barcode) ?>"><br>
|
|
<?= $sale_id ?>
|
|
</div>
|
|
</div>
|
|
</div>
|