mirror of
https://github.com/opensourcepos/opensourcepos.git
synced 2026-04-25 17:40:39 -04:00
577cf55b6a
PSR and Readability Changes - Removed unused import - Corrected PHPdoc to include the correct return type - Refactored out a function to get attribute data from the row in a CSV item import. - refactored snake_case variables and function names to camelCase - Refactored the naming of saveAttributeData() to better reflect the functions purpose. - Improved PHPdocs - Remove whitespace - Remove unneeded comment - Refactored abbreviated variable name for clarity - Removed $csvHeaders as it is unused - Corrected spacing and curly brace location - Refactored Stock Locations validation inside general validation Bugfixes - Fixed bug causing attribute_id and item_id to not be properly assigned when empty() returns true. - Fixed bug causing CSV Item import to not update barcode when changed in the import file. - Fixed saveAttributeValue() logic causing attribute_value to be updated to a value that already exists for a different attribute_id - Fixed bug preventing Category as dropdown functionality from working - Fixed bug preventing barcodes from updating. in Item CSV Imports - Corrected bug in stock_location->save_value() - Corrected incorrect helper file references. - Removed duplicate call to save attribute link - Rollback transaction on failure before returning false - Rollback transaction and return 0 on failure to save attribute link. - Account for '0' being an acceptable TEXT or DECIMAL attributeValue. - Corrected Business logic - Resolved incorrect array key - Account for 0 in column values - Correct check empty attribute check - Previously 0 would have been skipped even though that's a valid value for an attribute. - Removed unused foreach loop index variables - Corrected CodeIgniter Framework version to specific version UnitTest Seeder and tests - Created a seeder to automatically prepare the test database. - Modified the Unit Test setup to properly seed the test database. - Wrote a unit test to test deleting an attribute from an item through the CSV. - Corrected errors in unit tests preventing them from passing. save_value() returns a bool, not the itemId - Fix Unit Tests that were failing - Corrected the logic in itemUpdate test - Replaced precision test with one reflecting testing of actual value. - This test does not test cash rounding rules. That should go into a different test. - Correct expected value in test. - Update app/Database/Seeds/TestDatabaseBootstrapSeeder.php - Added check to testImportDeleteAttributeFromExistingItem - Correct mocking of dropdowns - Remove code depending on removed database.sql - Removed FQN in seeder() call - Added checks in Database seeder - Moved the function to the attribute model where it belongs which allows testability. Case Change Capability (CSV Import and Form) - CSV Import and view Case Changes of `attribute_value` - Store attribute even when just case is different. - Add getAttributeValueByAttributeId() to assist in comparing the value - Corrected Capitalization in File Handling Logic CSV Import Attribute Link Deletion Capability - Validation checks bypass magic word cells. - Delete the attribute link for an item if the CSV contains `_DELETE_` - Added calls to deleteOrphanedValues() - Items CSV Import Attribute Delete - Exclude the itemId in the check to see if the barcode number exists Error Checking and Reporting Improvements - Fail the import if an invalid stock location is found in the CSV - Return false if deleteAttributeLinks fails - Match sanitization of description field to Form submission import - Fold errors into result and return value - Populated $allowedStockLocations before sending it to the validation function - Added logic to not ignore failed saveItemAttributes calls - Add error checking to failed row insert - Reworked &= to && logic so that it short-circuits the function call after if success is already false. - Add transaction to storeCSVAttributeValue function to prevent deleting the attribute links before confirming the new value successfully saved. - Modified generate_message in Db_log.php to be defensive. Attribute Improvements - Move ATTRIBUTE_VALUE_TYPES to the helper - Normalize AttributeId in saveAttributeLink() - normalize itemId in saveAttributeLink() - Account for '0' in column values for allow_alt_description - Remove duplicate saveAttributeValue call - Correct return value of function - Like other save_value() functions, the location_data variable is passed by reference. - Unlike other save_value() functions, the location_data variable is not being updated with the primary key id. - Added updateAttributeValue() function as part of logic fix. - Added attribute_helper.php - Simplified logic to store attribute values --------- Signed-off-by: objec <objecttothis@gmail.com> Co-authored-by: coderabbitai[bot] <136622811+coderabbitai[bot]@users.noreply.github.com>
78 lines
2.3 KiB
JSON
78 lines
2.3 KiB
JSON
{
|
|
"name": "opensourcepos/opensourcepos",
|
|
"description": "Open Source Point of Sale is a web based POS system written in the PHP language. It uses MySQL as backend and has a simple user interface",
|
|
"license": "MIT",
|
|
"authors": [
|
|
{
|
|
"name": "jekkos"
|
|
},
|
|
{
|
|
"name": "FrancescoUK"
|
|
},
|
|
{
|
|
"name": "objecttothis"
|
|
},
|
|
{
|
|
"name": "steveireland"
|
|
}
|
|
],
|
|
"type": "project",
|
|
"keywords": [
|
|
"point-of-sale",
|
|
"POS"
|
|
],
|
|
"homepage": "https://opensourcepos.org",
|
|
"support": {
|
|
"issues": "https://github.com/opensourcepos/opensourcepos/issues",
|
|
"forum": "https://github.com/opensourcepos/opensourcepos/discussions",
|
|
"wiki": "https://github.com/opensourcepos/opensourcepos/wiki",
|
|
"source": "https://github.com/opensourcepos/opensourcepos",
|
|
"docs": "https://github.com/opensourcepos/opensourcepos/wiki#documentation",
|
|
"matrix": "https://matrix.to/#/#opensourcepos_Lobby:gitter.im"
|
|
},
|
|
"require": {
|
|
"ext-intl": "*",
|
|
"php": "^8.1",
|
|
"codeigniter4/framework": "4.6.3",
|
|
"dompdf/dompdf": "^2.0.3",
|
|
"ezyang/htmlpurifier": "^4.17",
|
|
"laminas/laminas-escaper": "2.17.0",
|
|
"paragonie/random_compat": "^2.0.21",
|
|
"picqer/php-barcode-generator": "^2.4.0",
|
|
"tamtamchik/namecase": "^3.0.0"
|
|
},
|
|
"require-dev": {
|
|
"codeigniter/coding-standard": "^1.8",
|
|
"fakerphp/faker": "^1.23.0",
|
|
"friendsofphp/php-cs-fixer": "^3.47.1",
|
|
"kint-php/kint": "^5.0.4",
|
|
"mikey179/vfsstream": "^1.6",
|
|
"nexusphp/cs-config": "^3.6",
|
|
"phpunit/phpunit": "^10.5.16 || ^11.2",
|
|
"predis/predis": "^1.1 || ^2.0"
|
|
},
|
|
"replace": {
|
|
"psr/log": "*"
|
|
},
|
|
"autoload": {
|
|
"psr-4": {
|
|
"App\\": "app/",
|
|
"CodeIgniter\\": "vendor/codeigniter4/framework/system/"
|
|
},
|
|
"exclude-from-classmap": [
|
|
"**/Database/Migrations/**"
|
|
]
|
|
},
|
|
"config": {
|
|
"allow-plugins": {
|
|
"phpstan/extension-installer": true
|
|
},
|
|
"optimize-autoloader": true,
|
|
"preferred-install": "dist",
|
|
"sort-packages": true
|
|
},
|
|
"scripts": {
|
|
"test": "phpunit"
|
|
}
|
|
}
|