mirror of
https://github.com/opensourcepos/opensourcepos.git
synced 2026-03-08 00:59:04 -05:00
Complete Content-Type application/json fix for all AJAX responses - Add missing return statements to all ->response->setJSON() calls - Fix Items.php method calls from JSON() to setJSON() - Convert echo statements to proper JSON responses - Ensure consistent Content-Type headers across all controllers - Fix 46+ instances across 12 controller files - Change Config.php methods to : ResponseInterface (all return setJSON only): - postSaveRewards(), postSaveBarcode(), postSaveReceipt() - postSaveInvoice(), postRemoveLogo() - Update PHPDoc @return tags - Change Receivings.php _reload() to : string (only returns view) - Change Receivings.php methods to : string (all return _reload()): - getIndex(), postSelectSupplier(), postChangeMode(), postAdd() - postEditItem(), getDeleteItem(), getRemoveSupplier() - postComplete(), postRequisitionComplete(), getReceipt(), postCancelReceiving() - Change postSave() to : ResponseInterface (returns setJSON) - Update all PHPDoc @return tags Fix XSS vulnerabilities in sales templates, login, and config pages This commit addresses 5 XSS vulnerabilities by adding proper escaping to all user-controlled configuration values in HTML contexts. Fixed Files: - app/Views/sales/invoice.php: Escaped company_logo (URL context) and company (HTML) - app/Views/sales/work_order.php: Escaped company_logo (URL context) - app/Views/sales/receipt_email.php: Added file path validation and escaping for logo - app/Views/login.php: Escaped all config values in title, logo src, and alt - app/Views/configs/info_config.php: Escaped company_logo (URL context) Security Impact: - Prevents stored XSS attacks if configuration is compromised - Defense-in-depth principle applied to administrative interfaces - Follows OWASP best practices for output encoding Testing: - Verified no script execution with XSS payloads in config values - Confirmed proper escaping in HTML, URL, and file contexts - All templates render correctly with valid configuration Severity: High (4 files), Medium-High (1 file) CVSS Score: ~6.1 CWE: CWE-79 (Improper Neutralization of Input During Web Page Generation) Fix critical password validation bypass and add unit tests This commit addresses a critical security vulnerability where the password minimum length check was performed on the HASHED password (always 60 characters for bcrypt) instead of the actual password before hashing. Vulnerability Details: - Original code: strlen($employee_data['password']) >= 8 - This compared the hash length (always 60) instead of raw password - Impact: Users could set 1-character passwords like "a" - Severity: Critical (enables brute force attacks on weak passwords) - CVE-like issue: CWE-307 (Improper Restriction of Excessive Authentication Attempts) Fix Applied: - Validate password length BEFORE hashing - Clear error message when password is too short - Added unit tests to verify minimum length enforcement - Regression test to prevent future vulnerability re-introduction Test Coverage: - testPasswordMinLength_Rejects7Characters: Verify 7 chars rejected - testPasswordMinLength_Accepts8Characters: Verify 8 chars accepted - testPasswordMinLength_RejectsEmptyString: Verify empty rejected - testPasswordMinLength_RejectsWhitespaceOnly: Verify whitespace rejected - testPasswordMinLength_AcceptsSpecialCharacters: Verify special chars OK - testPasswordMinLength_RejectsPreviousBehavior: Regression test for bug Files Modified: - app/Controllers/Home.php: Fixed password validation logic - tests/Controllers/HomeTest.php: Added comprehensive unit tests Security Impact: - Enforces 8-character minimum password policy - Prevents extremely weak passwords that facilitate brute-force attacks - Critical for credential security and user account protection Breaking Changes: - Users with passwords < 8 characters will need to reset their password - This is the intended security improvement Severity: Critical CVSS Score: ~7.5 CWE: CWE-305 (Authentication Bypass by Primary Weakness), CWE-307 Add GitHub Actions workflow to run PHPUnit tests Move business logic from views to controllers for better separation of concerns - Move logo URL computation from info_config view to Config::getIndex() - Move image base64 encoding from receipt_email view to Sales controller - Improves separation of concerns by keeping business logic in controllers - Simplifies view templates to only handle presentation Fix XSS vulnerabilities in report views - escape user-controllable summary data and labels Fix base64 encoding URL issue in delete payment - properly URL encode base64 string Fix remaining return type declarations for Sales controller Fixed additional methods that call _reload(): - postAdd() - returns _reload($data) - postAddPayment() - returns _reload($data) - postEditItem() - returns _reload($data) - postSuspend() - returns _reload($data) - postSetPaymentType() - returns _reload() All methods now return ResponseInterface|string to match _reload() signature. This resolves PHP TypeError errors.
235 lines
8.9 KiB
PHP
235 lines
8.9 KiB
PHP
<?php
|
|
|
|
namespace App\Controllers;
|
|
|
|
use App\Models\Attribute;
|
|
use CodeIgniter\HTTP\ResponseInterface;
|
|
use Config\Services;
|
|
|
|
require_once('Secure_Controller.php');
|
|
|
|
/**
|
|
* Attributes controls the custom attributes assigned to items
|
|
**/
|
|
class Attributes extends Secure_Controller
|
|
{
|
|
private Attribute $attribute;
|
|
|
|
public function __construct()
|
|
{
|
|
parent::__construct('attributes');
|
|
|
|
$this->attribute = model(Attribute::class);
|
|
}
|
|
|
|
/**
|
|
* Gets and sends the main view for Attributes to the browser.
|
|
*
|
|
* @return string
|
|
**/
|
|
public function getIndex(): string
|
|
{
|
|
$data['table_headers'] = get_attribute_definition_manage_table_headers();
|
|
|
|
return view('attributes/manage', $data);
|
|
}
|
|
|
|
/**
|
|
* Returns attribute table data rows. This will be called with AJAX.
|
|
*/
|
|
public function getSearch(): ResponseInterface
|
|
{
|
|
$search = $this->request->getGet('search');
|
|
$limit = $this->request->getGet('limit', FILTER_SANITIZE_NUMBER_INT);
|
|
$offset = $this->request->getGet('offset', FILTER_SANITIZE_NUMBER_INT);
|
|
$sort = $this->sanitizeSortColumn(attribute_definition_headers(), $this->request->getGet('sort', FILTER_SANITIZE_FULL_SPECIAL_CHARS), 'definition_id');
|
|
$order = $this->request->getGet('order', FILTER_SANITIZE_FULL_SPECIAL_CHARS);
|
|
|
|
$attributes = $this->attribute->search($search, $limit, $offset, $sort, $order);
|
|
$total_rows = $this->attribute->get_found_rows($search);
|
|
|
|
$data_rows = [];
|
|
foreach ($attributes->getResult() as $attribute_row) {
|
|
$attribute_row->definition_flags = $this->get_attributes($attribute_row->definition_flags);
|
|
$data_rows[] = get_attribute_definition_data_row($attribute_row);
|
|
}
|
|
|
|
return $this->response->setJSON(['total' => $total_rows, 'rows' => $data_rows]);
|
|
}
|
|
|
|
/**
|
|
* AJAX called function which saves the attribute value sent via POST by using the model save function.
|
|
* @return ResponseInterface
|
|
* @noinspection PhpUnused
|
|
*/
|
|
public function postSaveAttributeValue(): ResponseInterface
|
|
{
|
|
$success = $this->attribute->saveAttributeValue(
|
|
html_entity_decode($this->request->getPost('attribute_value')),
|
|
$this->request->getPost('definition_id', FILTER_SANITIZE_NUMBER_INT),
|
|
$this->request->getPost('item_id', FILTER_SANITIZE_NUMBER_INT) ?? false,
|
|
$this->request->getPost('attribute_id', FILTER_SANITIZE_NUMBER_INT) ?? false
|
|
);
|
|
|
|
return $this->response->setJSON(['success' => $success != 0]);
|
|
}
|
|
|
|
/**
|
|
* AJAX called function deleting an attribute value using the model delete function.
|
|
* @return ResponseInterface
|
|
* @noinspection PhpUnused
|
|
*/
|
|
public function postDeleteDropdownAttributeValue(): ResponseInterface
|
|
{
|
|
$success = $this->attribute->deleteDropdownAttributeValue(
|
|
html_entity_decode($this->request->getPost('attribute_value')),
|
|
$this->request->getPost('definition_id', FILTER_SANITIZE_NUMBER_INT)
|
|
);
|
|
|
|
return $this->response->setJSON(['success' => $success]);
|
|
}
|
|
|
|
/**
|
|
* AJAX called function which saves the attribute definition.
|
|
*
|
|
* @param int $definition_id
|
|
* @return ResponseInterface
|
|
* @noinspection PhpUnused
|
|
*/
|
|
public function postSaveDefinition(int $definition_id = NO_DEFINITION_ID): ResponseInterface
|
|
{
|
|
$definition_flags = 0;
|
|
|
|
$flags = (empty($this->request->getPost('definition_flags'))) ? [] : $this->request->getPost('definition_flags', FILTER_SANITIZE_FULL_SPECIAL_CHARS);
|
|
|
|
foreach ($flags as $flag) {
|
|
$definition_flags |= $flag;
|
|
}
|
|
|
|
// Save definition data
|
|
$definition_data = [
|
|
'definition_name' => $this->request->getPost('definition_name'),
|
|
'definition_unit' => $this->request->getPost('definition_unit') != '' ? $this->request->getPost('definition_unit') : null,
|
|
'definition_flags' => $definition_flags,
|
|
'definition_fk' => $this->request->getPost('definition_group') != '' ? $this->request->getPost('definition_group') : null
|
|
];
|
|
|
|
if ($this->request->getPost('definition_type') != null) {
|
|
$definition_data['definition_type'] = DEFINITION_TYPES[$this->request->getPost('definition_type')];
|
|
}
|
|
|
|
$definition_name = $definition_data['definition_name'];
|
|
|
|
if ($this->attribute->save_definition($definition_data, $definition_id)) {
|
|
// New definition
|
|
if ($definition_id == NO_DEFINITION_ID) {
|
|
$definition_values = json_decode(html_entity_decode($this->request->getPost('definition_values')));
|
|
|
|
foreach ($definition_values as $definition_value) {
|
|
$this->attribute->saveAttributeValue($definition_value, $definition_data['definition_id']);
|
|
}
|
|
|
|
return $this->response->setJSON([
|
|
'success' => true,
|
|
'message' => lang('Attributes.definition_successful_adding') . ' ' . $definition_name,
|
|
'id' => $definition_data['definition_id']
|
|
]);
|
|
} else { // Existing definition
|
|
return $this->response->setJSON([
|
|
'success' => true,
|
|
'message' => lang('Attributes.definition_successful_updating') . ' ' . $definition_name,
|
|
'id' => $definition_id
|
|
]);
|
|
}
|
|
} else { // Failure
|
|
return $this->response->setJSON([
|
|
'success' => false,
|
|
'message' => lang('Attributes.definition_error_adding_updating', [$definition_name]),
|
|
'id' => NEW_ENTRY
|
|
]);
|
|
}
|
|
}
|
|
|
|
/**
|
|
*
|
|
* @param int $definition_id
|
|
* @return ResponseInterface
|
|
* @noinspection PhpUnused
|
|
*/
|
|
public function getSuggestAttribute(int $definition_id): ResponseInterface
|
|
{
|
|
$suggestions = $this->attribute->get_suggestions($definition_id, html_entity_decode($this->request->getGet('term')));
|
|
|
|
return $this->response->setJSON($suggestions);
|
|
}
|
|
|
|
/**
|
|
* @param int $row_id
|
|
* @return ResponseInterface
|
|
*/
|
|
public function getRow(int $row_id): ResponseInterface
|
|
{
|
|
$attribute_definition_info = $this->attribute->getAttributeInfo($row_id);
|
|
$attribute_definition_info->definition_flags = $this->get_attributes($attribute_definition_info->definition_flags);
|
|
$data_row = get_attribute_definition_data_row($attribute_definition_info);
|
|
|
|
return $this->response->setJSON($data_row);
|
|
}
|
|
|
|
/**
|
|
* @param int $definition_flags
|
|
* @return array
|
|
*/
|
|
private function get_attributes(int $definition_flags = 0): array
|
|
{
|
|
$definition_flag_names = [];
|
|
foreach (Attribute::get_definition_flags() as $id => $term) {
|
|
if ($id & $definition_flags) {
|
|
$definition_flag_names[$id] = lang('Attributes.' . strtolower($term) . '_visibility');
|
|
}
|
|
}
|
|
return $definition_flag_names;
|
|
}
|
|
|
|
/**
|
|
* @param int $definition_id
|
|
* @return string
|
|
*/
|
|
public function getView(int $definition_id = NO_DEFINITION_ID): string
|
|
{
|
|
$info = $this->attribute->getAttributeInfo($definition_id);
|
|
foreach (get_object_vars($info) as $property => $value) {
|
|
$info->$property = $value;
|
|
}
|
|
|
|
$data['definition_id'] = $definition_id;
|
|
$data['definition_values'] = $this->attribute->get_definition_values($definition_id);
|
|
$data['definition_group'] = $this->attribute->get_definitions_by_type(GROUP, $definition_id);
|
|
$data['definition_group'][''] = lang('Common.none_selected_text');
|
|
$data['definition_info'] = $info;
|
|
|
|
$show_all = Attribute::SHOW_IN_ITEMS | Attribute::SHOW_IN_RECEIVINGS | Attribute::SHOW_IN_SALES;
|
|
$data['definition_flags'] = $this->get_attributes($show_all);
|
|
$selected_flags = $info->definition_flags === '' ? $show_all : $info->definition_flags;
|
|
$data['selected_definition_flags'] = $this->get_attributes($selected_flags);
|
|
|
|
return view('attributes/form', $data);
|
|
}
|
|
|
|
/**
|
|
* Deletes an attribute definition
|
|
* @return ResponseInterface
|
|
*/
|
|
public function postDelete(): ResponseInterface
|
|
{
|
|
$attributes_to_delete = $this->request->getPost('ids', FILTER_SANITIZE_FULL_SPECIAL_CHARS);
|
|
|
|
if($this->attribute->deleteDefinitionList($attributes_to_delete)) {
|
|
$message = lang('Attributes.definition_successful_deleted') . ' ' . count($attributes_to_delete) . ' ' . lang('Attributes.definition_one_or_multiple');
|
|
return $this->response->setJSON(['success' => true, 'message' => $message]);
|
|
} else {
|
|
return $this->response->setJSON(['success' => false, 'message' => lang('Attributes.definition_cannot_be_deleted')]);
|
|
}
|
|
}
|
|
}
|