Files
opensourcepos/app/Controllers
Ollama accc8c5911 Address all PR feedback for EXIF stripping
Major changes:
- Remove exif_stripping_enabled checkbox, use multiselect only
  - Feature is enabled when multiselect has selections
  - Disabled when multiselect is empty
  - Simplifies UI and logic

- Fix PHP implode() null issue
  - Coerce null to empty array before implode (Config.php:398,399)
  - Apply fix to both exif_fields_to_keep and image_allowed_types

- Fix GPS removal in Image_lib.php
  - Remove GPS via ifd0.removeEntry() instead of incorrect setIfd(null)
  - GPS INFO IFD POINTER now properly removed from IFD0

- Fix allowed_types array in Image_lib.php
  - Remove unsupported 'image/bmp' and 'image/tiff'
  - Return false instead of true for unhandled formats

- Add logging for EXIF stripping failures
  - Log warnings when stripEXIF returns false
  - Helps debugging without blocking uploads

- Fix migration consistency
  - Remove exif_stripping_enabled config (no longer needed)
  - Remove unused $forge variable
  - Make defaults consistent: Copyright,Orientation,Software

- Update language strings
  - Remove exif_stripping_enabled translations
  - Clarify exif_fields_to_keep tooltip

Addresses all actionable comments from CodeRabbit review
2026-04-08 21:12:27 +00:00
..
2025-03-28 21:24:21 +04:00