mirror of
https://github.com/opensourcepos/opensourcepos.git
synced 2026-09-21 18:25:02 -04:00
objecttothis
99b42f0800
- Simplified sort_order assignment logic to maintain dense 0..N-1 range for active locations. - Updated deleted rows to set sort_order as NULL instead of pushing to a higher value. - Adjusted tests and migrations to reflect the new behavior. Signed-off-by: objecttothis <17935339+objecttothis@users.noreply.github.com>
66 lines
2.2 KiB
PHP
66 lines
2.2 KiB
PHP
<?php
|
|
|
|
namespace App\Database\Migrations;
|
|
|
|
use CodeIgniter\Database\Migration;
|
|
|
|
class AddStockLocationDefaultAndSortOrder extends Migration
|
|
{
|
|
/**
|
|
* Perform a migration step.
|
|
*/
|
|
public function up(): void
|
|
{
|
|
$table = $this->db->prefixTable('stock_locations');
|
|
|
|
$this->forge->addColumn('stock_locations', [
|
|
'is_default' => [
|
|
'type' => 'TINYINT',
|
|
'constraint' => 1,
|
|
'null' => false,
|
|
'default' => 0,
|
|
'after' => 'deleted',
|
|
],
|
|
'sort_order' => [
|
|
'type' => 'TINYINT',
|
|
'unsigned' => true,
|
|
'null' => true,
|
|
'default' => null,
|
|
'after' => 'is_default',
|
|
],
|
|
]);
|
|
|
|
// Backfill sort_order for non-deleted rows only, ranking alphabetically so upgraded
|
|
// installs see no visible reorder. Deleted rows get NULL: they don't occupy a sort
|
|
// position, so the active range always stays a dense 0..N-1 regardless of how many
|
|
// locations have been deleted over the life of the install.
|
|
$this->db->query("
|
|
UPDATE $table AS destination
|
|
INNER JOIN (
|
|
SELECT
|
|
location_id,
|
|
ROW_NUMBER() OVER (ORDER BY location_name ASC, location_id ASC) - 1 AS new_sort_order
|
|
FROM $table
|
|
WHERE deleted = 0
|
|
) AS ranked ON ranked.location_id = destination.location_id
|
|
SET destination.sort_order = ranked.new_sort_order
|
|
");
|
|
|
|
$this->db->query("UPDATE $table SET sort_order = NULL WHERE deleted = 1");
|
|
|
|
// Default to the oldest (lowest location_id) non-deleted location so behavior is unchanged until an admin picks one explicitly.
|
|
$this->db->query("UPDATE $table SET is_default = 1 WHERE deleted = 0 ORDER BY location_id ASC LIMIT 1");
|
|
|
|
$this->forge->addUniqueKey('sort_order');
|
|
$this->forge->processIndexes('stock_locations');
|
|
}
|
|
|
|
/**
|
|
* Revert a migration step.
|
|
*/
|
|
public function down(): void
|
|
{
|
|
$this->forge->dropColumn('stock_locations', ['is_default', 'sort_order']);
|
|
}
|
|
}
|